[01:03:18] 6Multimedia, 10GlobalPreferences, 10GlobalUsage: Add possibility to use default MediaWiki URLs on all wikis - https://phabricator.wikimedia.org/T123181#1930187 (10XXN) [13:18:15] brion: Are you still working on the Popcorn Maker/MediaWiki integration? [14:07:21] From what thedj said at the summit, I think it's stalled but still a wishlist item? [14:19:32] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Upstream: Commons images with embedded color profiles shown incorrectly - https://phabricator.wikimedia.org/T44827#1931243 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur This looks resolved on the Firefox side - but T123210 just opened up with a di... [14:20:01] 6Multimedia, 6Commons, 10MediaWiki-File-management: TIFF colour profiles of thumbnails appear browser dependent - https://phabricator.wikimedia.org/T123210#1931252 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur I suspect this is indeed related to the linked Firefox bug, though also different from it. I... [14:30:12] 6Multimedia, 6Commons, 10MediaWiki-File-management: TIFF colour profiles of thumbnails appear browser dependent - https://phabricator.wikimedia.org/T123210#1931293 (10Fae) Perhaps someone could write up the situation with the most relevant links is and the prospect for getting it solved? Ideally I would like... [15:42:47] prtksxna: yeah I've actually got a demo scheduled next week, gotta tidy up my uncommitted work :) [16:25:49] 6Multimedia, 6Commons: Create a bot to automatically check Commons uploads for possible copyright violations - https://phabricator.wikimedia.org/T123517#1931482 (10MarkTraceur) [16:43:51] 6Multimedia, 10UploadWizard: UW fails with filename already existing - https://phabricator.wikimedia.org/T121360#1931525 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur I believe this works now...at least locally, entering an existing filename in the final step will cause a nearly immediate error in the i... [17:20:00] MatmaRex: Have you tried uploading, like, 50 PNGs, to compare performance with JPGs? [17:20:25] I just noticed that binReader.onload is taking a lot of time...maybe because it calls something else but might be worth trying [17:20:38] Ah, no, it's calling finishCallback, never mind [17:21:12] marktraceur: hmm, no [17:21:31] Looks like a good portion of finishCallback is calling OOUI stuff though [17:21:48] that is actyually a fair point, all that jpg metdaata parsing is surely not helping [17:22:00] (i can type) [17:22:03] Hm maybe [17:22:11] We could probably do that async, right? [17:22:21] Like, we don't need (most of) it until the details step? [17:22:26] Just as a good practices thing [17:23:21] it might kind of be async? hard to tell. :P [17:23:34] the file reading part is async at least, i think [17:23:38] Heh. [17:23:51] but, as a side note, we apparently read the whole file only to extract the metadata [17:23:53] I mean, it's "async" but the finishCallback stuff (including creating details UI stuff...wait) [17:24:00] Wait a minute [17:24:01] isn't it like, at the very end, or very beginning? [17:24:06] we could be smarter there [17:24:07] meh [17:24:18] We're making the details UI after the upload finishes, and before the user even moves to the deed step [17:24:22] That might slow things down a bit [17:27:08] OK I'm going to stop us from doing that if I can [17:27:29] I'll be back in four hours, grizzled and harried from the experience, to warn people reading that bug to never try that ever [17:39:40] Hm, seems like it just pushes the lag to the details step [17:39:53] Maybe we should do it one at a time...sigh [17:55:21] MatmaRex: Hm, I'm not sure if you caused this bug or I did [17:55:51] MatmaRex: Content language on my test wiki is en-gb and it's causing flickr uploads to not work...I can probably fix it, but if it's a pre-existing condition I'd rather leave it for a different patch [17:56:10] heh [17:56:53] that does sound like it could be something from my oouization rewrite [17:57:25] we have that thing there: [17:57:33] The language is probably wrong in many cases... [17:57:33] language: mw.config.get( 'wgContentLanguage' ), [17:57:38] MatmaRex: Basically if the content language isn't an option, the getWikitext method barfs because getSelectedItem returns null, and null doesn't have a getData method. [17:57:57] yeah. that mw.config.get should be wrapped in, hm [17:58:17] uw.DescriptionDetailsWidget.static.getClosestAllowedLanguage() [17:58:41] KK [17:59:44] I can do that as part of this patch I guess [18:02:10] OK fixed that...now to make sure flickr works otherwise [18:04:12] noooo make separate patch :( [18:05:47] (03PS1) 10MarkTraceur: Make the upload interface load faster [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/263883 (https://phabricator.wikimedia.org/T121901) [18:05:56] Oh [18:05:59] Too late now? [18:06:06] It's not a hard patch anyway [18:06:17] 3 files changed, 9 insertions(+), 10 deletions(-) [18:07:39] (03CR) 10jenkins-bot: [V: 04-1] Make the upload interface load faster [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/263883 (https://phabricator.wikimedia.org/T121901) (owner: 10MarkTraceur) [18:07:44] Damn it Jenkins [18:08:51] (03PS2) 10MarkTraceur: Make the upload interface load faster [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/263883 (https://phabricator.wikimedia.org/T121901) [19:08:33] Since when does gmail think gerritmail is a "promotion"? [19:12:21] Have you heard the good news about this patchset? [19:12:38] But wait, there's more code! [21:18:45] 6Multimedia, 6Commons: Create a bot to automatically check Commons uploads for possible copyright violations - https://phabricator.wikimedia.org/T123517#1932708 (10matmarex) [21:31:38] 6Multimedia, 6Commons, 10CopyVio-tools: Create a bot to automatically check Commons uploads for possible copyright violations - https://phabricator.wikimedia.org/T123517#1932818 (10JEumerus) [22:38:25] brion: Cool :) [22:40:10] Morning o/ [22:46:01] hi prtksxna [22:46:13] Hey MatmaRex [22:46:44] MatmaRex: Aren't you supposed to be on vacation? [22:47:22] yeah… it's complicated. i'm chillin' in the office ;) [22:48:00] :P [23:17:26] MatmaRex: Tsk. :-) [23:20:44] i just hate fun, you know. [23:20:50] can't be helped. [23:22:49] * James_F grins. [23:28:43] 6Multimedia, 10ImageTweaks, 10Security-Reviews: Security review of the ImageTweaks extension ahead of production deployment - https://phabricator.wikimedia.org/T123594#1933387 (10Jdforrester-WMF) 3NEW [23:32:23] marktraceur, prtksxna, MatmaRex: I probably lied in https://phabricator.wikimedia.org/T123594 – please fix. [23:32:39] i blame marktraceur [23:33:20] I blame Roan