[10:48:06] (03PS1) 10Phuedx: Test per-commit integration tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/267654 [10:48:22] (03CR) 10Phuedx: [C: 04-2] Test per-commit integration tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/267654 (owner: 10Phuedx) [10:54:49] (03CR) 10Phuedx: "Recheck." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/267654 (owner: 10Phuedx) [10:59:59] (03CR) 10jenkins-bot: [V: 04-1] Test per-commit integration tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/267654 (owner: 10Phuedx) [11:06:20] (03Abandoned) 10Phuedx: Test per-commit integration tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/267654 (owner: 10Phuedx) [13:07:50] MatmaRex: Just fyi I think there's a dependency between UW's license configuration and the Special:Upload gadgets on Commons, we may have broken something there accidentally [13:08:01] I will investigate in about an hour [13:08:10] huh? D: [13:09:01] If you want, head to Special:Upload?uselang=experienced and try to select a language, I haven't debugged yet either [13:09:43] And don't worry, I'll browbeat them about abusing the l10n system later [14:33:20] OK, I have had coffee and I'm looking at the code now, I was wrong about the dependency [14:36:35] And it doesn't look like it's a core or config bug [15:13:32] MatmaRex: https://edit-analysis.wmflabs.org/multimedia-health/#projects=commonswiki/metrics=Cross-Wiki Uploads FYI [15:13:38] Numbers fixed, and we have January now [15:14:56] yay [15:15:06] can that tool be changed to deal with spaces more reasonably? [15:15:11] Ugh [15:15:16] that links works for me in some browsers, and doesn't in others [15:15:23] not to mention i have to literally copy it with a space [15:15:24] Probably, it's millimetric's baby [15:15:32] so you couldn't use it in wikitext links, for example [15:16:01] Yeah [15:16:04] I'll ask him [15:16:22] But first I'm going to get the per-tool numbers running, hopefully by end of today [15:16:36] Er, per type [15:16:38] Not per tool [15:43:05] 6Multimedia, 10UploadWizard: UploadWizard broken on test2wiki - https://phabricator.wikimedia.org/T124975#1986420 (10Aklapper) p:5Triage>3High [15:43:31] Uhhh [15:45:11] eh, guess today's an uploadwizard-debugging-day? [15:45:17] I guess [15:45:24] I'm looking [15:45:32] * MatmaRex grumblegrumble [15:45:34] i need more tea [15:48:28] ( -_-)旦~ [15:50:05] MatmaRex: Infinite recursion between getDefaultLanguage and getClosestAllowedLanguage [15:56:16] whattt D: [15:56:46] Wasn't there a GCI patch in that area? [15:57:13] ugh [15:57:36] no, not GCI, but we did do something [16:02:18] prtksxna: Good morning [16:02:27] James_F: And to you sah [16:02:42] Are we moving the meeting? [16:02:49] Not until tomorrow [16:02:55] …OK. [16:03:02] I mean, we're all here anyway [16:03:42] prtksxna: You might want to disable video [16:11:16] I will just create the standup events and you can judge [16:11:43] MarkTraceur: Exactly what I was about to suggest [16:13:49] OK, created [16:14:20] So brion, lindseyanne, I just re-invited you to our New And Improved Evening Edition Stand Up Meeting [16:14:27] ® [16:15:48] MarkTraceur: Yep, I can attend all these! [16:15:56] Woot woot [16:16:42] And if I dont, it means I've overslept :( [16:23:30] Well that's OK [16:23:33] We'll forgive you [16:37:31] MatmaRex: milimetric is fixing spaces in URLs for you :) [16:38:05] :D [16:39:44] MarkTraceur: Nice. [16:45:53] MarkTraceur: so… remind me, where's uploadwizard broken? [16:46:10] since i've completely lost track of what versions of our stuff are currently in production [16:47:19] MatmaRex: Uhhh, resources/details/uw.DescriptionDetailsWidget.js [16:47:27] Oh, sorry, test2.wikipedia [16:47:30] So basically master [16:47:34] oh [16:47:37] wait, what [16:47:40] since when is test2 master [16:47:46] Basically [16:47:50] heh [16:47:53] You could try it on beta [17:08:03] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#1986686 (10matmarex) > "|" (pipe) character in any field breaks {{Information}} template and should be replaced with "{{!}}". They are sometimes found in source URL... [17:08:13] 6Multimedia, 6Commons, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#1986687 (10matmarex) [17:09:18] 6Multimedia, 10UploadWizard, 7Technical-Debt: Remove IE8 workarounds from UploadWizard - https://phabricator.wikimedia.org/T123220#1986691 (10matmarex) p:5Normal>3Low [17:12:11] 6Multimedia, 6Commons, 10UploadWizard: Add PD-ineligible as a license option - https://phabricator.wikimedia.org/T123982#1986695 (10matmarex) 5Open>3declined Per the Commons discussion, we probably do not want this. (Permanent link: https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&old... [17:13:16] 6Multimedia, 10UploadWizard: UploadWizard broken on test2wiki - https://phabricator.wikimedia.org/T124975#1986702 (10matmarex) a:3matmarex [17:15:57] 6Multimedia, 10UploadWizard: UploadWizard broken on test2wiki - https://phabricator.wikimedia.org/T124975#1986707 (10matmarex) This is somewhat of a configuration error at test2wiki (and doesn't affect production wikis, as far as I know), but UploadWizard definitely should be handling this more gracefully. The... [17:17:29] 6Multimedia, 6Commons, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#1986715 (10Jarekt) Maybe we can look for "|" (pipe) characters in URLs, like the example above and other text which is not a template or a link to wikipedia article. Another commons source... [17:29:28] (03PS1) 10Bartosz Dziewoński: Prevent infinite recursion in uw.DescriptionDetailsWidget.static.getDefaultLanguage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/267699 (https://phabricator.wikimedia.org/T124975) [19:02:03] (03CR) 10MarkTraceur: [C: 032] "Thanks!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/267699 (https://phabricator.wikimedia.org/T124975) (owner: 10Bartosz Dziewoński) [19:06:18] OK, quick sanity check queries on project_illustration and then I'm adding some reportupdater scripts [19:18:40] (03Merged) 10jenkins-bot: Prevent infinite recursion in uw.DescriptionDetailsWidget.static.getDefaultLanguage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/267699 (https://phabricator.wikimedia.org/T124975) (owner: 10Bartosz Dziewoński) [19:20:04] 6Multimedia, 10UploadWizard, 5Patch-For-Review: UploadWizard broken on test2wiki - https://phabricator.wikimedia.org/T124975#1987217 (10matmarex) 5Open>3Resolved Should be fixed on master. Since it's not affecting anything important to me, I'm not going to be backporting the patch, but please feel free t... [19:20:08] 6Multimedia, 6Commons, 10MediaWiki-File-management, 6Performance-Team: Use Chroma subsampling for image thumbnails (save 17% bandwidth and save memory on mobile) - https://phabricator.wikimedia.org/T122242#1987220 (10ori) @MarkTraceur, is this something your team could take on? The impact would be substant... [19:23:45] MatmaRex: It's definitely not going to break Commons, because we have Commons configured correctly, right? [19:24:58] MarkTraceur: well, i guess technically it could affect users who have really obscure interface languages selected. [19:25:23] might be nice to backport, but i have more than enough things to do already [19:25:34] OK then [19:25:46] and i don't feel like figuring out how to do this with the sessionmanager deployment snafu going on [19:25:52] be-tarask-old users will have to live with it for now [19:26:42] James_F: How much historical data do you want for how many illustrated pages are on enwiki, and how many pages were newly illustrated in a month [19:27:17] And also, do you want that data for other wikis [19:27:31] MarkTraceur: I want more wikis more than I want more history. [19:27:48] OK, give me a list and I'll start whacking away at it [19:28:00] MarkTraceur: Doing "top 10" but only from January would be fine. [19:28:09] January 2015? [19:28:21] I was thinking yesterday. [19:28:26] Ah [19:28:34] But January 2015–now would be awesome too. [19:28:35] :-) [19:28:36] Honestly, one year of data probably won't take much time to crunch [19:28:51] What are the "top 10" [19:29:01] enwiki, dewiki, frwiki, eswiki... [19:29:12] I'm not doing Commons, Commons is a mess [19:29:46] Sure. [19:30:07] Gah. [19:30:10] Where was that list? [19:48:41] James_F: dewiki is definitely on the list, right? I can start running that script while you search. [19:50:09] MarkTraceur: Very roughly I think it was en/ja/es/fr/de/ru/pt [19:51:42] Plus, you know, more. [19:52:20] K. [19:53:13] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-RfCs, and 9 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1987350 (10GWicke) [19:54:01] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-RfCs, and 9 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#710702 (10GWicke) The lack of a stable / simple thumb API is a serious issue for cacheable REST end points... [19:54:49] dewiki is running! [22:38:23] Morning o/ [22:47:56] prtksxna: Morning. :-) [22:51:12] i continue to be amazed by time zones. [22:52:33] MatmaRex: I agree, everyone should just run on GMT and cope. [22:54:25] There will be wars to move that line in that case :P [22:58:46] prtksxna: Did you ever submit a repository request for the ImageEditor library? Should we do so now? [23:05:10] MarkTraceur: https://phabricator.wikimedia.org/tag/imagetweaks/ [23:10:46] Or did you mean something else? [23:26:13] prtksxna: I mean your library, not the extension [23:26:32] I have ImageTweaks but I'd like ImageEditor to be a separate thing [23:30:24] thedj: This is more your area than mine, https://test2.wikipedia.org/wiki/Special:NewFiles [23:30:24] MarkTraceur: I thought we took James_F's suggestion to not do that and just move everything to the extension [23:30:29] Oh [23:30:35] I guess I forgot. [23:30:40] OK, I'll move it all in then [23:32:30] MarkTraceur: Ok. Will have to 'mw.' all the things [23:32:49] Heh, I can handle it [23:39:51] 6Multimedia, 10GlobalUsage, 7Beta-Cluster-reproducible: PHP Fatal Error: Call to undefined method ImagePage::getFile() - https://phabricator.wikimedia.org/T125468#1988133 (10thcipriani) 3NEW [23:50:52] 6Multimedia, 10GlobalUsage, 7Beta-Cluster-reproducible: PHP Fatal Error: Call to undefined method ImagePage::getFile() - https://phabricator.wikimedia.org/T125468#1988160 (10thcipriani) Stack trace available here: https://phabricator.wikimedia.org/P2554 [23:53:49] 6Multimedia, 10GlobalUsage, 7Beta-Cluster-reproducible: PHP Fatal Error: Call to undefined method ImagePage::getFile() - https://phabricator.wikimedia.org/T125468#1988169 (10matmarex) This should have been fixed by 3e329182d10b30abdf1f4e10c2b9a11409b7ef7a, [23:54:27] 6Multimedia, 10GlobalUsage, 10MediaWiki-General-or-Unknown, 7Beta-Cluster-reproducible: PHP Fatal Error: Call to undefined method ImagePage::getFile() - https://phabricator.wikimedia.org/T125468#1988176 (10matmarex)