[00:00:02] 6Multimedia, 10UploadWizard: Selection of second language for description in UW has a usability issue - https://phabricator.wikimedia.org/T121196#1996358 (10matmarex) Sorry, I had to work on other priorities for a while, but I looked into this today. > Would it be possible to left bind the typing ahead? Inst... [00:00:06] 6Multimedia, 10UploadWizard: Selection of second language for description in UW has a usability issue - https://phabricator.wikimedia.org/T121196#1996360 (10matmarex) a:3matmarex [00:12:11] eh [00:18:51] MatmaRex: Hmm. We might also have the edit icon if that is what we decide to do :/ [00:20:10] prtksxna: we can make the clickable area a bit bigger than the icon/indicator. (it already is slightly bigger) [00:20:45] MatmaRex: You're right! [00:20:51] prtksxna: if we add a separate button for editing, we could probably get rid of the one for deleting. to remove a capsule, you'd just edit it and remove the text. or focus it with the keyboard and press 'delete'. [00:21:43] not sure how applicable the comparison is, but VE doesn't have separate buttons to delete focusable nodes. [00:22:01] you just select it and 'delete' from the keyboard, or edit and remove it all. [00:23:29] That makes sense, but I was hoping that we keep the experience as close to HotCat as possible, at least in the beginning [00:56:00] bloody C-m submitting comments on gerrit [01:17:44] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design, 5OOjs-UI-next-release, 5Patch-For-Review: Show image thumbnail in both steps of mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115860#1996611 (10Prtksxna) Once the OOjs release with this patch is in core we can resolve {... [01:25:42] good night all [01:29:22] MatmaRex: o/ [07:39:11] MarkTraceur: still progressing :) these are the two tracking tasks if you want to follow: https://phabricator.wikimedia.org/T111718 https://phabricator.wikimedia.org/T121388 [07:41:48] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1996664 (10Prtksxna) [12:00:40] MatmaRex: I think I am doing something very hacky. Do you have 10 minutes to talk? [12:03:03] prtksxna: sure [12:04:18] MatmaRex: Sent you an invite [12:10:10] MatmaRex: https://gerrit.wikimedia.org/r/268375 [12:36:33] 6Multimedia, 6Commons, 10MediaWiki-File-management: InstantCommons completely broken - https://phabricator.wikimedia.org/T125799#1997552 (10Reedy) [14:12:19] Gooooood morning team [14:13:03] sup [14:18:36] 6Multimedia, 10MediaWiki-extensions-WikibaseRepository, 10Structured-Multimedia-Data, 10Wikidata: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#1997849 (10Lydia_Pintscher) [14:19:11] Just getting that first dose of caffeine in [14:19:22] I intend to work from the corner Dunn Bros. today [14:19:46] In other news, a friend invited me to "live band karaoke" which is quite possibly the most exciting thing ever [14:26:26] 6Multimedia, 6Commons, 10MediaWiki-File-management: WikiMedia Commons broken (broken backward compability in API?) - https://phabricator.wikimedia.org/T125804#1997878 (10Anomie) [14:36:54] MarkTraceur: hmm, so i decided to finally look at the eventlogging data from uploadwizard [14:37:08] MarkTraceur: and we apparently have 60 instances of someone getting "internal_api_error_Flow\Exception\FlowException" in uploadwizard. [14:37:18] how is that even possible. where does Flow come into this? [14:38:13] we also have people getting error messages from the API that are in korean, german, spanish and chinese. i would sure like to know whati's up with this too. [14:42:37] MatmaRex: On commonswiki? Weird. [14:43:16] Does Google Translate know anything about the API errors? [14:43:32] they actually seem to be custom titleblacklist ones [14:43:46] And I'd ask -collaboration about Flow stuff [14:43:58] i'm wondering why we're getting the translated text instead of error code for only this one, though. [14:44:11] it's apparently all "This looks like a file you obtained from another image host" [14:44:19] in a number of languages [14:45:08] Probably because titleblacklist localises it on the backend, at a guess [14:45:39] yeah, but why this one and not others? :D [14:45:40] hmm [14:45:47] maybe we're special-casing the others in our code. [14:45:48] anyway. [14:45:51] Might be. [14:46:12] the flow ones don't seem to be very recent. [14:46:15] so whatever. [14:52:18] Hey Mark [14:55:39] Hi prtksxna, how's it going [15:03:10] prtksxna: I have a confession, sometimes in my head I read your name like the announcer from Epic Rap Battles Of History, it never fails to amuse me [15:05:34] * prtksxna googles 'Epic Rap Battles Of History' [15:08:26] Oh man, you're one of today's lucky 20,000 [15:08:35] Er, 10,000 [15:09:19] (https://xkcd.com/1053/) [15:10:30] :D [15:10:52] Goku vs Superman! [15:11:05] * prtksxna roots for Goku [15:11:42] Heyyyy Chi Chi is off limits [15:35:00] 6Multimedia, 10UploadWizard: Flickr upload failed with 'api-error-missingparam': "Internal error: Missing parameters on request." - https://phabricator.wikimedia.org/T123922#1998106 (10matmarex) p:5Triage>3Normal [15:37:59] I'm glad I could tank prtksxna's productivity for this week. :P [15:38:48] so many [15:39:08] 6Multimedia, 10UploadWizard: First upload succeeds, second upload fails. - https://phabricator.wikimedia.org/T123878#1998120 (10matmarex) 5Open>3Resolved a:3matmarex I can't reproduce either. We haven't made any recent changes that could cause or fix this issue. I'm going to close this for now, please re... [15:40:52] I'm setting out to the coffee shop, if I don't make it in twenty minutes I'm frozen to the sidewalk near my apartment, send help [15:52:11] Success [15:53:50] 6Multimedia, 6Commons, 10MediaWiki-File-management: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998143 (10matmarex) [15:54:37] 6Multimedia, 6Commons, 10MediaWiki-File-management: InstantCommons completely broken - https://phabricator.wikimedia.org/T125799#1998146 (10matmarex) [15:54:41] 6Multimedia, 6Commons, 10MediaWiki-File-management: "Error generating thumbnail" for InstantCommons images - https://phabricator.wikimedia.org/T125781#1998148 (10matmarex) [15:54:45] 6Multimedia, 6Commons, 10MediaWiki-File-management: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1997622 (10matmarex) [15:55:24] 6Multimedia, 6Commons, 10MediaWiki-File-management: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998154 (10Aklapper) p:5Triage>3Unbreak! [15:57:23] Today: Fixing the browser tests that spam me every day [16:05:06] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998215 (10matmarex) To be honest I don't really understand the code, but fix looks reasonable and fixes the issue locally for me. [16:05:17] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998216 (10matmarex) a:3matmarex [16:05:46] tgr|away: can you review https://gerrit.wikimedia.org/r/268404 ? it fixes an UBN apparently caused by a change you merged, so hopefully you can tell if it makes sense :) [16:05:59] (oh, anomie merged it already.) [16:14:31] https://integration.wikimedia.org/ci/view/BrowserTests/view/UploadWizard/ lol. [16:38:09] God I hate browser tests [16:55:27] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998381 (10matmarex) 5Open>3Resolved This has been fixed now, and the fix is deployed to Commons. InstantCommons on my local wiki wo... [16:55:47] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998390 (10matmarex) Thanks for debugging, @Anomie and @alex-mashin :) [17:14:39] 6Multimedia, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review: InstantCommons API requests to Commons are erroring out - https://phabricator.wikimedia.org/T125804#1998506 (10matmarex) >>! In T125804#1997876, @Anomie wrote: > I note there has never been a `thumbnail` parameter for `iiprop`. https:/... [17:25:04] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design, 5OOjs-UI-next-release, 5Patch-For-Review: Show image thumbnail in both steps of mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115860#1998561 (10Esanders) We should also start the stash upload as soon as the file is sele... [17:52:18] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset does not handle well some URLs with non-alphanumeric characters - https://phabricator.wikimedia.org/T125846#1998707 (10JeanFred) 3NEW [17:54:10] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 5Patch-For-Review: Add pretty json output to the GWToolset namespace - https://phabricator.wikimedia.org/T60507#1998723 (10JeanFred) [18:21:26] 6Multimedia, 6Commons, 10MediaWiki-File-management: "Error generating thumbnail" for InstantCommons images - https://phabricator.wikimedia.org/T125781#1998959 (10Nemo_bis) All good for us too now indeed. Thanks everyone. [18:51:50] (03CR) 10Bartosz Dziewoński: "I don't think this is the right approach." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/263883 (https://phabricator.wikimedia.org/T121901) (owner: 10MarkTraceur) [18:52:05] Uh oh [18:52:53] MarkTraceur: i mean. it's still equally slow. just at a different moment. [18:52:57] Yeah [18:53:05] and generating the details interface is apparently pretty slow by itself for many files. [18:53:11] Right [18:53:26] i was just going to look into that, but figured i'll try out your patch first [18:53:29] I did say I wanted to change the workflow anyway [18:53:41] MatmaRex: I'm pretty sure it's unavoidable (from my end) OOUI lag [18:54:19] MarkTraceur: i'm pretty sure it's not. or rather, the unavoidable lag is a small part of the problem. [18:54:25] Hm. [18:54:35] I profiled it, it looked like most of the slowdown was OOUI functions [18:54:49] Or maybe just OOJS functions? [18:55:04] I know it wasn't something I could fix in UW, at least it didn't look like it [18:55:19] MarkTraceur: one thing we're doing wrong is that we're trying to start all the uploads at once. which means we're updating 50 interfaces at once, instead of like three. [18:55:37] MatmaRex: So maybe create the details interfaces on upload completion? [18:55:46] That's better anyway because then we don't create it for ones that fail [18:56:01] MarkTraceur: another thing is that we're updating DOM nodes attached to the main document and visible, which means the browser has to re-render them gazillion times instead of just once when wer're doine creating them. [18:56:12] Hmm. [18:56:14] when we're done* [18:56:23] Good point, I didn't think of that. [18:56:32] I guess because they're hidden, but still attached to the DOM [18:56:40] they're not even hidden [18:56:43] or, the details interfaces [18:56:47] oh* [18:56:54] maybe. i'm talking about the upload ones [18:56:54] Yeah [18:57:01] Hmmm [18:57:05] you can see them appear, part by part, one by one, while your browser is frozen [18:57:08] Right [18:57:29] and if anything's broken and throws an exceptions, you end up with half-created interfaces visible to the user [18:57:40] anyway. i'm looking into it today. [18:57:41] Fun. [18:57:43] OK, cool [18:57:58] Should I abandon that patch? Based on your thoughts here I don't see much value in it [18:58:31] hmm, probably [19:06:58] (03Abandoned) 10MarkTraceur: Make the upload interface load faster [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/263883 (https://phabricator.wikimedia.org/T121901) (owner: 10MarkTraceur) [19:37:30] 6Multimedia, 6Commons, 10UploadWizard: Uploading multiple images freezes the browser - https://phabricator.wikimedia.org/T125269#1999395 (10matmarex) [19:37:32] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 7Performance: UploadWizard UI performance abysmal when adding many files to upload at once - https://phabricator.wikimedia.org/T121901#1999397 (10matmarex) [19:37:34] 6Multimedia, 10UploadWizard: Long time of uploading images on Wikimedia Commons. (Opera) - https://phabricator.wikimedia.org/T122473#1999396 (10matmarex) [19:41:06] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWToolset does not handle well some URLs with non-alphanumeric characters - https://phabricator.wikimedia.org/T125846#1999422 (10Dereckson) [20:06:20] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#1999540 (10Jdforrester-WMF) >>! In T116086#1936206, @Prtksxna wrote... [20:52:23] 6Multimedia, 10UploadWizard, 7Performance: UploadWizard UI performance abysmal when adding many files to upload at once - https://phabricator.wikimedia.org/T121901#1999791 (10matmarex) Some high-level notes: * We're just doing many expensive things. Loading ten high-resolution photos to display their thumbna... [20:53:01] MarkTraceur: fun fact, if you add n files to upload, mw.UploadWizardUploadInterface.prototype.moveFileInputToCover is called 3n-1 times. [20:54:22] MarkTraceur: and you were right that some of the OOUI stuff really is slow, at least when you construct as many of the wretched things as we do. [20:54:42] soooo i guess i have a project to work on for a couple of days [20:54:51] Weird re moveFileInputToCover [20:54:55] I thought we fixed it [20:55:00] Then again, it might have been worse before [20:55:09] you did fix it a bit, then i reverted it because it broke things [20:55:19] Oh, right. [20:55:20] but i think that just killed the polling in it [20:55:39] it's still called for every UploadInterface at least. not sure why three times for each, though. [20:56:01] I think one of those calls never actually did anything [23:20:19] o/ [23:32:19] MarkTraceur: You want to reply to https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084715.html ? [23:38:23] Looks like it's up your alley, prtksxna, unless you'd prefer I do it [23:39:13] MarkTraceur: um, I was referring just to the image editing bit [23:46:44] prtksxna: Maybe my skimming of it was wrong, hold on [23:47:22] quiddity: Do you know of something like webaim.org to test font sizes? Most places just say that if the user can change the size in their browser its fine. [23:48:05] prtksxna: You know roughly as well as I do what we've done re: image editing, so I have complete faith in you if you want to represent our interests on the thread [23:48:30] :( [23:48:48] But I'm not sure if they mean "image editing" like we mean "image editing", it seems like they're talking about generating images dynamically [23:49:01] Which is also something we want, but not in the same way [23:49:11] IMO it's a yurik thread more than it's a Multimedia team thread [23:49:28] True [23:50:21] Alternatively gilles might want to get a free workforce, if he wants, they might do some of the MediaWiki API work for the Thumbor bridge. [23:50:41] I thought the thread turned into just looking for a project for their student and no longer about data viz [23:50:54] * prtksxna nods [23:52:12] Oh, sure [23:52:26] I mean, if so, the topic needs to change, but also, most of our work is going to wind up being in JS [23:52:47] Most of the API is already done (and I see now gilles responded on the Phab ticket answering my questions, so I have a solid path forward I think) [23:57:28] MarkTraceur: So there is an API? [23:58:05] James_F: There's a hacky one in ImageTweaks. [23:58:08] But it's hacky. [23:58:18] I'll spruce it up and make it work the way I want it to [23:58:19] Ah. [23:58:37] As part of api.php? [23:58:41] It also needs to be able to support arbitrarily many operations of any kind... [23:58:46] Yeah, it's a MWAPI module [23:58:57] Kk.