[00:00:22] <MarkTraceur>	 James_F: :DDD
[00:00:36] <James_F>	 Oh, hey.
[14:57:51] <MarkTraceur>	 Ooooookay good morning folks
[14:57:55] <MarkTraceur>	 prtksxna: How's it going
[15:02:08] <prtksxna>	 MarkTraceur: o/
[15:02:29] <prtksxna>	 MarkTraceur: I am almost done with the upload dialog improvements
[15:02:31] <prtksxna>	 :D
[15:05:07] <MarkTraceur>	 Woot
[15:08:02] <prtksxna>	 MarkTraceur: https://phabricator.wikimedia.org/F3333782 https://phabricator.wikimedia.org/F3333780 https://phabricator.wikimedia.org/F3333779
[15:08:26] <prtksxna>	 The icons aren't showing up for some reason :/
[15:12:46] <prtksxna>	 https://phabricator.wikimedia.org/F3333804
[15:13:12] <prtksxna>	 And need to figure out the position of the time remaining
[15:13:53] <prtksxna>	 MarkTraceur: Any ideas?
[15:15:12] <prtksxna>	 But I couldn't do any code review today, I am really behind on that :(
[15:16:59] <MarkTraceur>	 prtksxna: Where's the patch?
[15:17:12] <prtksxna>	 still here 
[15:17:20] <prtksxna>	 adding the text
[15:17:26] <MarkTraceur>	 Ah, K
[15:23:35] <prtksxna>	 MarkTraceur: https://gerrit.wikimedia.org/r/#/c/269979/
[15:24:56] <MarkTraceur>	 prtksxna: I don't see anything about icons there
[15:26:29] <prtksxna>	 MarkTraceur: Oh the icons was a separate complaint, I think it has something to do with the new OOUI release, or maybe its a local problem (cc James_F MatmaRex) 
[15:27:50] <prtksxna>	 wtf
[15:28:02] <MarkTraceur>	 Ah.
[15:28:48] <MarkTraceur>	 prtksxna: Do we need time remaining?
[15:28:50] <prtksxna>	 I messed something up with the progress bar
[15:29:02] <prtksxna>	 Maybe…
[15:29:27] <prtksxna>	 MarkTraceur: I dont think people use it to upload very large files 
[15:48:52] <James_F>	 Something broke with the OOUI icons?
[15:50:57] <prtksxna>	 James_F: Might have can you check your local instance?
[15:57:27] <prtksxna>	 James_F: Merge this? https://gerrit.wikimedia.org/r/#/c/268603/
[15:58:58] <James_F>	 Sure.
[16:00:16] <prtksxna>	 :)
[16:05:07] <prtksxna>	 I am off to bed. MarkTraceur I wont be attending tomorrow's (today's) stand-up, and I'll only be able to review the ImageTweaks code over the weekend.
[16:05:34] <MarkTraceur>	 okay.
[16:27:50] <wikibugs>	 6Multimedia, 10MediaWiki-Parser: wgAllowImageTag should also block/allow <video> tags (and be renamed? to wgAllowMediaTags - https://phabricator.wikimedia.org/T126618#2018875 (10Jdforrester-WMF) 3NEW
[16:28:51] <wikibugs>	 6Multimedia, 10MediaWiki-Parser: wgAllowImageTag should also block/allow <video> tags (and be renamed? to wgAllowMediaTags - https://phabricator.wikimedia.org/T126618#2018884 (10cscott) ...possibly also `<audio>`.
[16:29:25] <wikibugs>	 6Multimedia, 10MediaWiki-Parser: $wgAllowImageTag should also block/allow <video>/<audio> tags (and be renamed to $wgAllowMediaTags ?) - https://phabricator.wikimedia.org/T126618#2018885 (10cscott)
[17:18:12] <MarkTraceur>	 Looks like since Prateek is skipping, Trevor has backed out, and lindseyanne has missed a few standups now, if MatmaRex backs out there will be little value in me sticking around an extra hour or so
[17:18:33] <MarkTraceur>	 As much as I love talking with James_F
[17:18:48] <James_F>	 MarkTraceur: Y'all a reno fun.
[17:19:03] <MarkTraceur>	 I usually think of myself as a Tahoe fun.
[17:19:56] <MarkTraceur>	 In any case, the current update is that labs is a pain in the ass, I hate puppet, I hate vagrant, and I'm going to be fuming about that for the next few days probably
[17:20:23] * bd808 hugs MarkTraceur 
[17:20:36] <bd808>	 sysadmin work isn't fun
[17:20:39] <MarkTraceur>	 Yeah
[17:20:45] <MarkTraceur>	 But it'll make things easier later, which is good
[17:20:59] <MarkTraceur>	 I'm going to try enabling my roles now and see how many errors I need to wade through
[17:21:53] <bd808>	 If you end up with strange Puppet ordering issues I'd be glad to try and help sort them out
[17:22:26] <bd808>	 Using PUPPET_DEBUG=1 vagrant ... can be very helpful
[17:23:21] <MarkTraceur>	 I'm currently just not able to turn on my role
[17:24:11] <MarkTraceur>	 Isn't there a good documentation page on how to write roles?
[17:24:29] <MarkTraceur>	 Aha.
[17:32:03] <bd808>	 There is some info buried in the presentation and slides from the tech talk that Dan and I did
[17:35:19] <James_F>	 MarkTraceur: [are no]
[17:35:21] <James_F>	 Sorry.
[18:07:27] <MatmaRex>	 MarkTraceur: James_F: i just napped for a bit instead of working ;) so we might not have much to talk about
[18:07:43] <MatmaRex>	 i want to work on UW performance issues, if i manage to wake up today properly
[18:08:04] <MarkTraceur>	 Hrm
[18:30:56] <wikibugs>	 6Multimedia, 6Commons, 10DBA, 10MediaWiki-Recent-changes, and 2 others: Allow filtering based on tag on Special:NewFIles - https://phabricator.wikimedia.org/T124214#2019568 (10jcrespo) matmarex: Welcome to the club: T118186. As a general comment, I think we fall into the trap of giving too many options to...
[18:44:52] <MarkTraceur>	 James_F: I'm going to say we shouldn't meet.
[19:00:54] <James_F>	 MarkTraceur: Kk.
[19:00:54] * James_F sniffs.
[19:03:56] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 7Voice & Tone: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#2019745 (10matmarex)
[20:07:18] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: Have mediawiki-codesniffer linting on GWToolset - https://phabricator.wikimedia.org/T125554#2019927 (10JeanFred) First pass:  > A TOTAL OF 113 ERRORS AND 118 WARNINGS WERE FOUND IN 33 FILES > PHPCBF CAN FIX 180 OF THESE SNIFF VIOLATIONS AUTOMATICALLY...
[20:10:23] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: Have mediawiki-codesniffer linting on GWToolset - https://phabricator.wikimedia.org/T125554#2019940 (10Legoktm) \o/  I would suggest doing something like {a49a8e7f096995e7a3d512e17fad5a4921e5861f}, so you can begin enforcing the ones that do pass, and...
[20:12:40] <legoktm>	 [11:00:54] -*- James_F sniffs. <-- I first read that as "James_F started running phpcs"
[20:15:51] * James_F grins at legoktm.
[20:16:07] <James_F>	 Speaking of, where the's new version of mediawiki-codersniffer, hmm? ;-)
[20:18:23] <legoktm>	 soon!
[20:43:04] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: Have mediawiki-codesniffer linting on GWToolset - https://phabricator.wikimedia.org/T125554#2020103 (10JeanFred) Thanks for chiming in :)  A pass of `egrep '\s+\|\s+\|\s+\((.*)\)' old-report.txt | cut -d'(' -f2 | sort | uniq` (could not quickly get php...
[21:03:02] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: Have mediawiki-codesniffer linting on GWToolset - https://phabricator.wikimedia.org/T125554#2020242 (10JeanFred) #Patch-For-Review at https://gerrit.wikimedia.org/r/#/c/270095/ (Gerrit-bot in holiday or I’m doing something wrong? o_O)
[21:03:16] <wikibugs>	 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 5Patch-For-Review: Have mediawiki-codesniffer linting on GWToolset - https://phabricator.wikimedia.org/T125554#2020243 (10JeanFred)
[21:39:36] * thedj bangs head against wall over TMH
[21:39:49] <thedj>	 also why does it keep surprising me
[22:05:21] <James_F>	 thedj: Because it hates you it lulls you into a sense of happiness.
[22:51:46] <grrrit-wm>	 (03PS1) 10TheDJ: Use CanonicalNamespaces hook instead of SetupAfterCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270127 (https://phabricator.wikimedia.org/T90282) 
[22:57:20] <thedj>	 weee
[22:57:21] <thedj>	 OK (12 tests, 23 assertions)
[22:57:41] <thedj>	 finally !!!!
[22:59:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use CanonicalNamespaces hook instead of SetupAfterCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270127 (https://phabricator.wikimedia.org/T90282) (owner: 10TheDJ)
[23:02:46] <grrrit-wm>	 (03PS2) 10TheDJ: Use CanonicalNamespaces hook instead of SetupAfterCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/270127 (https://phabricator.wikimedia.org/T90282) 
[23:12:51] <thedj>	 i can't believe it. it's actually working
[23:13:35] <thedj>	 now to cleanup the crap i had to do to make the parsertests run, but that be details
[23:18:09] <James_F>	 thedj: Hurrah.
[23:19:26] <thedj>	 with parser tests, we finally will be able to start making dom changes
[23:19:52] <thedj>	 which be awesome