[00:19:19] MarkTraceur: Should I just submit a PR for https://github.com/meltingice/CamanJS/issues/158? [00:22:42] hrm, never mind [01:05:24] Go for it if you like [01:57:39] 06Multimedia, 06Commons, 10MediaWiki-File-management: Image page should list places that image redirects are used - https://phabricator.wikimedia.org/T20017#2197867 (10Elvey) Hmm. Now, a few hours later, the page looks fine. I guess it just takes a while (half hour? 2 hours? what?) for a bot somewhere to d... [10:26:33] 06Multimedia, 10MediaWiki-extensions-3d, 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: Make Media Viewer pluggable for the 3d extension - https://phabricator.wikimedia.org/T132064#2198322 (10Gilles) >>! In T132064#2195952, @Jdlrobson wrote: > Can we also explore getting this on mobile web?... [10:56:27] 06Multimedia, 10MediaWiki-extensions-3d, 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: Make Media Viewer pluggable for the 3d extension - https://phabricator.wikimedia.org/T132064#2198373 (10Jdlrobson) Right now I was just curious if it was theoretically possible. I'm gonna take a dive int... [11:02:00] 06Multimedia, 10MediaWiki-extensions-3d, 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: Make Media Viewer pluggable for the 3d extension - https://phabricator.wikimedia.org/T132064#2198389 (10Gilles) I think it is, many mobile browsers seem to support WebGL. I don't know about rendering perfo... [13:10:59] 06Multimedia, 06Commons, 10MediaWiki-File-management: Image page should list places that image redirects are used - https://phabricator.wikimedia.org/T20017#2198687 (10Anomie) 05Open>03Resolved a:03Anomie >>! In T20017#2197867, @Elvey wrote: > Hmm. Now, a few hours later, the page looks fine. I guess... [13:11:06] 06Multimedia, 06Commons, 10MediaWiki-File-management: Image page should list places that image redirects are used - https://phabricator.wikimedia.org/T20017#2198690 (10Anomie) a:05Anomie>03None [14:13:37] (03PS16) 10Zfilipin: WIP Simplify creating Jenkins jobs for running browser tests daily [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/279601 (https://phabricator.wikimedia.org/T128190) [14:21:57] (03CR) 10jenkins-bot: [V: 04-1] WIP Simplify creating Jenkins jobs for running browser tests daily [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/279601 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [14:29:44] Morning all [14:29:55] I'm going to walk over to the library for work today. [14:52:21] (03PS17) 10Zfilipin: WIP Simplify creating Jenkins jobs for running browser tests daily [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/279601 (https://phabricator.wikimedia.org/T128190) [15:27:15] Are my quit and join messages flooding the channel? [15:28:57] prtksxna: No? [15:29:03] You aren't quitting and joining [15:29:46] Good to know, I thought my bouncer was misbehaving, but I guess its just my client. Thanks! [15:32:29] :-) [16:02:58] Did I mention that I have no idea what I am doing here https://gerrit.wikimedia.org/r/#/c/282641/ [16:13:19] Evidently. :) [16:13:45] prtksxna: Two more patches and hashar will give you root on the ci box [16:13:56] :( [16:14:13] prtksxna: Want to /join #wikimedia-releng and ask there for help? [16:14:41] MarkTraceur: Yep, I should do that, but tomorrow morning. [16:14:49] Sounds good :) [17:12:37] 06Multimedia, 06Commons, 10MediaWiki-File-management: Nice UI for image annotations - https://phabricator.wikimedia.org/T108887#2199671 (10Ricordisamoa) [17:13:40] 06Multimedia, 06Commons, 10MediaWiki-File-management: Redirect file page of foreign files directly to commons - https://phabricator.wikimedia.org/T46471#2199679 (10Ricordisamoa) [17:18:51] 06Multimedia, 10UploadWizard, 07user-notice: Adding watch option or watch by default using upload wizard - https://phabricator.wikimedia.org/T33313#2199714 (10Jdforrester-WMF) 05Open>03Resolved [17:52:08] 06Multimedia, 10UploadWizard: No "Next" button and no error when trying to upload a file with duplicative name - https://phabricator.wikimedia.org/T130242#2199819 (10matmarex) 05Open>03Resolved p:05Triage>03High Thanks to T132356 I was able to reproduce this – turns out this only happens when the exten... [17:52:23] 06Multimedia, 06Commons, 10UploadWizard: UploadWizard does and does not handle duplicate file names with different capitalization of file extension at the same time - https://phabricator.wikimedia.org/T132356#2195484 (10matmarex) p:05Triage>03High a:03matmarex This is actually a duplicate of T130242, b... [17:53:33] Thanks for the merge James_F [17:54:07] * James_F bows. [17:54:26] There was another patch I said I'd merge after the cut and I can't remember which. [17:54:29] * James_F shrugs. [17:54:46] Probably wasn't important [17:55:03] * James_F grins. [17:55:59] James_F: Are you announcing the upload watchlist preference or do you want me to? [17:56:57] MarkTraceur: I was going to wait 'til next week's Tech/news. [17:57:20] Fair enough [18:27:24] (03CR) 10Brion VIBBER: [C: 032] "Ok I'm going over related patches & tweaks, let's land this. :)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231788 (https://phabricator.wikimedia.org/T109184) (owner: 10Paladox) [18:34:58] Whoa. [18:35:46] 06Multimedia, 10MediaWiki-Gallery, 07Design: Provide an auto-rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T128429#2200008 (10Pginer-WMF) Based on the stated goals, I think there are three design principles we may want to follow: - **Anticipate hidden content.** When... [18:37:59] (03CR) 10Brion VIBBER: [C: 04-1] "I think there's a bug in the fractional seconds, but otherwise good. Needs a fix & one or two additional tests to confirm." (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/282809 (owner: 10TheDJ) [18:40:38] 06Multimedia, 06Commons, 06Community-Advocacy, 10Wikimedia-General-or-Unknown, 06Zero: Commons and testwiki used as video hoster by Wikipedia Zero - https://phabricator.wikimedia.org/T129845#2200041 (10Gunnex) Reposting here my comment from today in another, related task, which may be relevant also for t... [18:43:32] (03Merged) 10jenkins-bot: Change videoQuality to videoBitrate [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231788 (https://phabricator.wikimedia.org/T109184) (owner: 10Paladox) [18:45:05] (03CR) 10Paladox: "Thanks." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231788 (https://phabricator.wikimedia.org/T109184) (owner: 10Paladox) [18:47:25] (03PS3) 10TheDJ: Repair start/end times for videos. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/282809 [18:49:57] (03PS17) 10Brion VIBBER: Support low quality videos in webm and mp4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [18:50:19] (03PS18) 10Brion VIBBER: Support low quality videos in webm and mp4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [18:50:51] (03CR) 10Brion VIBBER: "Rebased and adjusted the bitrates." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [18:52:12] (03CR) 10jenkins-bot: [V: 04-1] Repair start/end times for videos. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/282809 (owner: 10TheDJ) [18:54:12] oh duh. that's why i used round... [18:55:24] (03PS4) 10TheDJ: Repair start/end times for videos. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/282809 [18:55:37] "PHP Warning: fork failed - Cannot allocate memory" [18:55:39] well that's a new one [18:55:46] hmm, though you could argue that floor is better... [18:56:10] (03CR) 10Paladox: "Thanks." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [18:56:11] heh my vagrant vm has no swap [18:56:15] how .... helpful [18:56:17] hmm, let's fix the parser test instead. flooring down, seems better than potentially rouding up. [18:57:30] ffmpeg is using a gig of memory on this 2160p transcode. heh [18:58:04] (03PS5) 10TheDJ: Repair start/end times for videos. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/282809 [18:59:09] not surprised. it takes what it can get, since larger in memory buffer is better for the encoding speed [19:00:46] (03CR) 10Brion VIBBER: [C: 032] "Ok let's merge this!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [19:01:10] yeah, especially when doing the fancier temporal stuff in vp9 [19:01:31] it's not the space that worries me about UHD, it's the CPU time and memory :) [19:03:30] (03CR) 10Brion VIBBER: [C: 032] "Forgot to merge this earlier." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/258359 (https://phabricator.wikimedia.org/T119049) (owner: 10TheDJ) [19:09:55] (03CR) 10Brion VIBBER: [C: 032] "\o/ woohoo" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/273140 (https://phabricator.wikimedia.org/T127597) (owner: 10TheDJ) [19:10:13] now i gotta wait until this transcode finishes before i can test anything else :P [19:10:15] * brion wanders off [19:33:56] brion: Is "waiting for it to transcode" your version of https://xkcd.com/303/ ? :) [19:35:29] 06Multimedia, 10MediaWiki-Uploading, 10TimedMediaHandler, 10TimedMediaHandler-Transcode, and 2 others: Video transcoding not started after server-side uploads - https://phabricator.wikimedia.org/T127597#2200491 (10TheDJ) 05Open>03Resolved a:03TheDJ [19:35:41] 06Multimedia, 10MediaWiki-Uploading, 10TimedMediaHandler, 10TimedMediaHandler-Transcode, 10Wikimedia-Video: Video transcoding not started after server-side uploads - https://phabricator.wikimedia.org/T127597#2047939 (10TheDJ) p:05Triage>03Low [19:39:30] Hehe [19:44:38] wtf my gate-and-submit jobs are ~40 minutes behind in queue [19:47:07] (03Merged) 10jenkins-bot: Support low quality videos in webm and mp4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 (owner: 10Paladox) [19:47:14] (03Merged) 10jenkins-bot: Make controlbar layout depend on the player width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/258359 (https://phabricator.wikimedia.org/T119049) (owner: 10TheDJ) [19:50:33] woot [19:51:25] something in my git workflow has started printing "Killed by signal 1" to console all the time [19:51:27] that's worrrying [19:53:06] ah it's from the ProxyCommand for the labs setup [19:53:33] *tweak tweak* ~/.ssh/config [20:02:06] (03Merged) 10jenkins-bot: Trigger transcode jobs from FileUpload hook [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/273140 (https://phabricator.wikimedia.org/T127597) (owner: 10TheDJ) [20:02:14] (03PS1) 10Bartosz Dziewoński: mw.DestinationChecker: Check for non-exact extension matches too [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/283005 (https://phabricator.wikimedia.org/T132356) [20:04:33] 06Multimedia, 06Commons, 10UploadWizard, 13Patch-For-Review: UploadWizard does and does not handle duplicate file names with different capitalization of file extension at the same time - https://phabricator.wikimedia.org/T132356#2200671 (10matmarex) p:05High>03Normal [20:09:34] brion: Do we want to enable WebP images this week too, as part of a tumult of format support? :-) [20:09:52] James_F: for upload or for output? :) [20:10:00] upload is easy, output is more work [20:10:14] brion: Just render it natively and let the users complain. ;-) [20:10:23] lol [20:10:36] There's a paladox patch to do it somewhere, I think. [20:12:17] this is the patch for enabling uploads: https://gerrit.wikimedia.org/r/#/c/281973/ [20:13:56] (03PS1) 10Brion VIBBER: Add defs for 1440p and clean up transcode format labels [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/283007 [20:16:58] James_F, thedj: ok taking a quick peek at the WebP handler in core, looks like it will unconditionally render thumbnails as PNG [20:17:10] so that ought to work fine for handling uploaded .webps without breaking browser support [20:17:17] fancier rendering _to_ webp can come some other time :D [20:17:24] indeed. [20:17:57] Or never. ;-) [20:18:17] * James_F declares that it's Performance's concern (shipping fewer bytes). [20:18:48] yeps [20:19:00] Which means our concern, but not our priority. ;-) [20:20:51] i wish i knew why VBoxHeadless sits around eating 175% CPU all the time [20:21:38] because Vagrant + VB has a bug that eats your cpu [20:21:58] usually shows after your system has slept. [20:22:08] only solution is to fully stop VB and start it fresh. [20:22:22] it's a mac only bug. [20:22:49] \o/ [20:22:52] thanks virtualbox+mac [20:27:38] reminds me i'll have to try fedora 24 + wayland on my mac + double uhd monitors setup [20:40:01] (03CR) 10Paladox: [C: 031] "Looks good too me and plus this adds the missing Webm 240p resolution that is defined but was never added." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/283007 (owner: 10Brion VIBBER) [20:40:35] :) [20:41:09] (03CR) 10Jforrester: [C: 032] Add defs for 1440p and clean up transcode format labels [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/283007 (owner: 10Brion VIBBER) [20:42:53] brion: https://gerrit.wikimedia.org/r/#/c/248540/ – does that just need a tweak to the parser tests to be merged? [20:43:55] James_F: i don't think it needs any parser test changes, does it? [20:44:06] there was a test failure but it looks like an OOM bug on the test runner box [20:44:09] brion: The test failures were for the … [20:44:10] Hmm. [20:44:11] failure to fork [20:44:13] * James_F reads it again. [20:44:26] isn't that a matthew mccoughnehey movie? [20:44:36] ParserTest_Tests__parserTests::testParserTest with data set #2 ('Simple thumbed video', '[[File:Video.ogv|thumb]]', '
\n', ' tidy', '') [20:44:47] Simple thumbed video. [20:44:49] Failed asserting that two strings are equal [20:46:01] what report are you looking at? i don't see any of that [20:46:50] https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/56735/consoleFull from the last V-1 on https://gerrit.wikimedia.org/r/#/c/248540/ [20:46:55] ugh my vagrant's all messed up now, bbiab [20:47:11] Sorry. :-) [20:50:20] why is parsoid running on this vagrant box? i don't have visualeditor enabled... BAH [20:52:03] brion: Flow. CX. VE. RESTbase. Other things. [20:52:28] the shitfuck is this? mwscript maintenance/runJobs.php --wiki='wiki-parsertest_' --type='recentChangesUpdate' [20:52:46] Umm. [20:52:50] … interesting. [20:52:51] is there a way to get al ist of roles that have been implicitly enabled by something? [20:52:55] cause i don't have a lot of roles on [20:54:34] eventlogging, geshi, mobilefrontend, svg, timedmediahandler, uploadwizard. [20:55:39] * brion re-provisions ftw [20:56:22] if that doesn't do it i'll just recreate the damn vm [20:56:23] sighhhh [20:59:08] you think the inline-block change is a good idea ? [20:59:39] i think it is, but i'm a little bit concerned with existing uses. [21:04:25] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2193963 (10Bawolff) I guess ideally canRender() returning false would cause a tracking category. [21:10:21] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2193963 (10brion) I think canRender just returns true all the time because the media handlers report themselves as capable of rendering. Are you suggesti... [21:11:53] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2193963 (10TheDJ) canRender only means: "is there a thumbnail engine for this filetype" if I remember correctly. The files that we are talking about here... [21:16:57] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2201056 (10brion) It does take a $file parameter, so we could have it determine renderability based on an individual file I guess but indeed, returning f... [21:17:28] (03Merged) 10jenkins-bot: Add defs for 1440p and clean up transcode format labels [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/283007 (owner: 10Brion VIBBER) [21:18:06] bah! i give up i'm creating a new vm [21:18:34] and just as a fuck-you to virtualbox i'm rebooting [21:18:35] brb [21:19:54] thedj: inline block should be OK but it's worth double checking [21:23:37] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2201073 (10Bawolff) Pdfs do adjust canRender() depending on if the file is corrupt. >>! In T132304#2201056, @brion wrote: > It does take a $file param... [21:28:07] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2201093 (10brion) The thing to do may be to add a new handler method explicitly for checking correctness, and check that on page parse to add the trackin... [21:29:04] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2201094 (10brion) Do we have a good pluggable interface for testing validity on upload as well? Might want to use the same one, or might want to test dif... [21:29:41] if only i could script irccloud to not beep me on mentions of me from wikibugs that are my own bug updates, but still beep me on mentions of me from wikibugs that are someone else's reply mentioning me [21:31:33] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2201105 (10TheDJ) Since our thumbnailing is 'on demand' (404 handling), and not upon parse, I doubt if this is even doable at all. [21:34:49] brion: Yeah, my main issue with IRC Cloud. I pinged them on Twitter about it, no reply. [21:35:20] brion: Also, I'm trying to rebase https://gerrit.wikimedia.org/r/#/c/225284/ of yours onto master, but https://gerrit.wikimedia.org/r/#/c/259604/ is really not helping. :-) [21:35:37] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Automated tracking of broken files - https://phabricator.wikimedia.org/T132304#2201124 (10brion) Well there's two separate issues there: * if we try to thumbnail, and cannot, can we record that? * if we look at the file beforehand,... [21:36:39] heh [21:36:55] * James_F just makes a bad fist of it. [21:37:40] sounds like a punk band [21:37:42] "Bad Fist" [21:37:48] * James_F grins. [21:38:10] or possible a spa town in Germany [21:38:25] * James_F grins. [21:38:37] Surely, Austria, and Bad Fistïng [21:38:54] +2 start gate-and-submit jobs [21:39:22] * brion wanders off to coffee up while vagrant rebuilds [23:03:08] prtksxna: Yo, coming? [23:03:24] (Or brion for that matter. :-)) [23:05:22] Sorry afk -- quick update, going through TMH patches and fixing little things up to prep for VP9/opus webm which win10 should support in the summer update [23:05:52] James_F: I also sent you a summary on the IIIF meeting the other day, I'll write up more public notes in a bit [23:07:09] brion: Cool. Yay. [23:07:12] brion: Oh, yeah. [23:54:42] (03PS1) 10Darenwelsh: add DS_Store to gitignore [extensions/UploadWizard] (REL1_25) - 10https://gerrit.wikimedia.org/r/283109 [23:54:44] (03PS1) 10Darenwelsh: add optional config for enterprise use case [extensions/UploadWizard] (REL1_25) - 10https://gerrit.wikimedia.org/r/283110 (https://phabricator.wikimedia.org/T46682)