[10:56:05] 06Multimedia, 10UploadWizard, 07Upstream: Firefogg fails explosively for files with non-ASCII characters in the name - https://phabricator.wikimedia.org/T136879#2352644 (10Aklapper) [11:57:23] 06Multimedia, 06Commons, 10MediaWiki-Uploading: wrong username in file history for cross-wiki upload - https://phabricator.wikimedia.org/T136935#2352791 (10FDMS) [13:41:20] 06Multimedia, 06Commons, 10MediaWiki-Uploading: wrong username in file history for cross-wiki upload - https://phabricator.wikimedia.org/T136935#2352945 (10Aklapper) "File history" table on https://commons.wikimedia.org/wiki/File:Orsip.png says user is Magdalenacicha ; https://commons.wikimedia.org/w/index... [13:45:38] 06Multimedia, 06Commons, 10MediaWiki-Uploading: wrong username in file history for cross-wiki upload - https://phabricator.wikimedia.org/T136935#2352966 (10FDMS) It does now … strange, at the time I filed the bug it said (and linked to) "Śląskie Centrum Społeczeństwa Informacyjnego". The infobox still does t... [14:22:18] 06Multimedia, 06Commons, 10MediaWiki-Uploading: wrong username in file history for cross-wiki upload - https://phabricator.wikimedia.org/T136935#2353033 (10Steinsplitter) >>! In T136935#2352966, @FDMS wrote: > It does now … strange, at the time I filed the bug it said (and linked to) "Śląskie Centrum Społecz... [14:25:20] 06Multimedia, 06Commons, 10MediaWiki-Uploading: Wrong username in file history for cross-wiki upload (caching issue due to user rename?) - https://phabricator.wikimedia.org/T136935#2353043 (10Aklapper) [14:50:29] How's it going in here? [14:53:55] another friday, another revert [14:54:08] (not our code, but i'm getting it reverted :P) [14:57:17] Fair enough [15:06:42] (03CR) 10MarkTraceur: [C: 032] mw.DestinationChecker: Avoid exception when a file page without extension is returned [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292336 (https://phabricator.wikimedia.org/T136237) (owner: 10Bartosz Dziewoński) [15:08:16] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Avoid exceptions when a chunked upload is aborted [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292329 (https://phabricator.wikimedia.org/T136236) (owner: 10Bartosz Dziewoński) [15:12:53] (03Merged) 10jenkins-bot: mw.DestinationChecker: Avoid exception when a file page without extension is returned [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292336 (https://phabricator.wikimedia.org/T136237) (owner: 10Bartosz Dziewoński) [15:12:56] (03Merged) 10jenkins-bot: mw.FormDataTransport: Avoid exceptions when a chunked upload is aborted [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292329 (https://phabricator.wikimedia.org/T136236) (owner: 10Bartosz Dziewoński) [15:13:02] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Don't attempt to retry aborted uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292330 (https://phabricator.wikimedia.org/T136236) (owner: 10Bartosz Dziewoński) [15:14:49] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardDetails: Don't assume that a description is required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292334 (https://phabricator.wikimedia.org/T136234) (owner: 10Bartosz Dziewoński) [15:16:23] :o [15:17:19] (03Merged) 10jenkins-bot: mw.FormDataTransport: Don't attempt to retry aborted uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292330 (https://phabricator.wikimedia.org/T136236) (owner: 10Bartosz Dziewoński) [15:22:20] MatmaRex: Ugh the change tags API documentation makes me sad [15:22:28] But not much we can do about it I guess [15:22:49] marktraceur: what about it? [15:23:06] MatmaRex: The fact that there's a parameter to a public API that the documentation marks as "Internal, do not use" [15:23:11] maybe we can. it's like crazy conf- [15:23:14] yeah, that's not configurable [15:23:20] :P [15:23:25] (03Merged) 10jenkins-bot: mw.UploadWizardDetails: Don't assume that a description is required [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292334 (https://phabricator.wikimedia.org/T136234) (owner: 10Bartosz Dziewoński) [15:23:36] i wonder if it's possible to hide it entirely, but that'd probably be worse [15:23:44] I mean my issue stems from the fact that we're trying to track a client on the server-side, which is an unsolved problem without, like...DRM or something [15:23:56] i guess i could just not register it, but then we'll be getting warnings from the API about unknown parameter [15:24:16] Somewhere in Boston, an FSF employee's head lifted at the sound of a WMFer saying "DRM" [15:24:17] yeah, no, that probably is pretty much unsolvable [15:24:38] i'm just assuming no one will care to abuse this, because what for? [15:24:41] I'm fine with it, it's just frustrating that that problem has no solution [15:25:07] Yeah I think the only people who might have any interest in boosting the numbers of UW uploads would be us, and we don't care enough [15:25:43] marktraceur: i guess we could also subclass the action=upload API module, and mark our one as 'internal' [15:25:44] MatmaRex: I guess if you marked it as a UW upload, the file might receive slightly less scrutiny because UW as a tool has a lot of ways to weed out bad uploads [15:25:53] Ugh that's definitely worse [15:25:54] (which does nothing, it's just a marker in the documentation) [15:26:18] I think overall this is a perfectly elegant solution [15:26:21] Well [15:26:28] It's as elegant a solution as is practicable [15:26:35] we could also just not do it, if it's problematic and we're not sure about the usefulness [15:26:57] Honestly I'm just over the moon we can do the API configuration you pulled off, I never thought about doing that with hooks [15:27:34] Just goes to show you that whatever stupid thing you want to do with MediaWiki, there's a hook for it somewhere if you look hard enough [15:27:45] i kind of cheater with the recentchangesave hook [15:27:49] cheated* [15:28:02] but tags are just a pain in the arse, and doubly so for uploads [15:28:42] hmm, come to think of it, i'm not sure if i tested that with async uploads [15:28:48] i probably should [15:28:51] marktraceur: ^ [15:29:44] i think it remembers the request details somewhere for the async part… but i'm not sure [15:30:12] Ooh, that's a good point [15:41:17] I'm running through some testing too. [15:43:01] Looks fine with local uploads and Flickr [15:43:26] MatmaRex: Let me know if you run into issues with your testing? [15:43:52] (03CR) 10MarkTraceur: [C: 031] "I like it. Bartosz is running through some more testing quick but I think this can be merged." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292284 (https://phabricator.wikimedia.org/T121872) (owner: 10Bartosz Dziewoński) [15:44:55] James_F: Looks like Krinkle wants the new gallery mode to be in MMV? See prtksxna's patch https://gerrit.wikimedia.org/r/#/c/289632/ [15:45:21] marktraceur: yeah, gimme a minute, i was concerned that it didn't work but turns out that i tested it without the patch… [15:45:29] Hah [15:48:48] marktraceur: actually, i think my wiki is messed up, since async uploads apparently don't work at all… the upload succeeds, but the file doesn't exist afterwards… [15:48:55] do you have them set up and working? [15:58:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This doesn't actually work for async uploads :(" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/292284 (https://phabricator.wikimedia.org/T121872) (owner: 10Bartosz Dziewoński) [15:59:33] Uh oh. [16:42:50] marktraceur: I think James_F and Timo already spoke about this [16:42:58] Oh, good. [16:50:16] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2353492 (10matmarex) [16:50:18] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'description' of undefined - https://phabricator.wikimedia.org/T136234#2353490 (10matmarex) 05Open>03Resolved [16:51:51] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'code' of undefined - https://phabricator.wikimedia.org/T136236#2353508 (10matmarex) 05Open>03Resolved [16:51:52] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2327598 (10matmarex) [16:52:33] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2353529 (10matmarex) [17:04:10] 06Multimedia, 10UploadWizard, 07Upstream: Firefogg returns invalid metadata for files with non-ASCII characters in the name - https://phabricator.wikimedia.org/T136879#2353595 (10matmarex) [17:25:58] Yup. My vague plan is to put it in core for now, improve the code a bunch (K.rinkle in particular said the existing PHP is terrible), and then eventually move the code entirely into an extension, not in core. [17:26:10] (cc prtksxna marktraceur.) [17:26:31] Right. [19:01:51] 06Multimedia, 06Commons, 10MediaWiki-Uploading, 07JavaScript, and 3 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#2353998 (10Whatamidoing-WMF) > the "cross-wiki upload" feat... [19:50:58] 06Multimedia, 10UploadWizard, 07Upstream: Firefogg returns invalid metadata for files with non-ASCII characters in the name - https://phabricator.wikimedia.org/T136879#2354225 (10matmarex) So… we can't actually work around it. My initial description of "fails explosively" was actually correct. It was just th...