[06:46:06] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard: Error fails indicating "undesirable characters" but does not indicate which characters this might be - https://phabricator.wikimedia.org/T140222#2473986 (10Jan_Dittrich) [06:49:44] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard: Error fails indicating "undesirable characters" but does not indicate which characters this might be - https://phabricator.wikimedia.org/T140222#2474003 (10Jan_Dittrich) > So the question is, why do we have a different one for invalid titles detected se... [06:49:52] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2474005 (10Osnard) Thanks. Something like this could solve the issue. But I am not sure if FileBackend is meant to perform such c... [10:03:06] 06Multimedia, 10UploadWizard, 07Browser-Support-Internet-Explorer, 07Browser-Support-Microsoft-Edge: Typed array constructor argument is invalid - https://phabricator.wikimedia.org/T136235#2474674 (10matmarex) And the results are in! ``` mysql:research@dbstore1002.eqiad.wmnet [log]> select event_message,... [10:27:02] 06Multimedia, 10MediaWiki-Uploading, 07Crosswiki: Crosswiki SVG upload: seams bypass the blacklist check on Commons - https://phabricator.wikimedia.org/T140750#2474707 (10Perhelion) [10:29:12] 06Multimedia, 10MediaWiki-Uploading, 07Crosswiki: Crosswiki SVG upload: seams bypass the blacklist check on Commons - https://phabricator.wikimedia.org/T140750#2474719 (10Perhelion) [10:51:03] 06Multimedia, 10UploadWizard: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#2474763 (10matthiasmullie) 05Open>03Resolved a:03matthiasmullie [11:02:00] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardUpload: Improve error handling in #extractMetadataFromJpegMeta [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299734 (https://phabricator.wikimedia.org/T136235) [11:54:22] MatmaRex: How do you pinpoint failures is the output generated by karma? [11:56:45] prtksxna: i run the tests with Special:JavaScriptTest on the wiki usually, the karma output is horrible [11:57:12] and then you can set up breakpoints and stuff and debug normally [11:59:12] MatmaRex: I see, can you do that with ooui tests too? [12:01:01] prtksxna: it has a "standalone" test suite, view tests/index.php with your browser [12:01:57] (i hope it still works, i haven't tried it in a while :D) [12:02:23] it should run the same tests as the karma version [12:02:33] MatmaRex: arg! I'll need to setup php for this [12:03:13] argh. yeah [12:03:34] prtksxna: if you have JS-only tests, you could probably comment out all the PHP stuff in that file [12:03:56] and the "JSPHP" tests. [12:04:00] and everything else should just run [12:04:24] MatmaRex: iirc, those were the tests that were failing when I was doing the textinputwidget break out work [12:06:28] yeah. then you'll need PHP, i'm afraid :/ [12:27:09] Froze my computer for a bit, but it worked. https://phabricator.wikimedia.org/F4288353 Thanks MatmaRex <3 [12:28:09] MatmaRex: I am on master, and I get 9591 assertions of 11075 passed, 1484 failed. [12:28:26] Did I not set this up correctly? [12:29:36] prtksxna: huh… let me try [12:35:04] prtksxna: everything passes for me. which tests do you see failing? [12:39:14] (afk) [12:39:16] MatmaRex: JSPHP: ApexTheme: TextInputWidget and Mediawiki theme [12:39:27] MatmaRex: I think I know what the problem is [12:40:04] MatmaRex: Woo! 11075 assertions of 11075 passed, 0 failed. [12:41:10] Need to 'composer update && php bin/generate-JSPHP-for-karma.php > tests/JSPHP.test.js' before loading the page? [12:52:23] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2460989 (10matthiasmullie) Another possible solution: ``` class MyBackend extends FileBackend { /** * @var FileBackendSt... [13:15:05] 06Multimedia, 06Commons, 10GLAM-Tech, 10Structured-Multimedia-Data, and 2 others: [Epic] Store media information for files on Wikimedia Commons as structured data - https://phabricator.wikimedia.org/T68108#2474993 (10Tobi_WMDE_SW) [13:16:42] prtksxna: hmm, yeah, but there's a grunt task for that. exec:phpGenerateJSPHPForKarma [13:17:24] prtksxna: i'm guessing you were just running `grunt build` rather than `grunt test`? i also ran into this just now when testing [13:17:39] but i got an error message from index.php about this [13:17:40] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2475004 (10Osnard) Thanks @matthiasmullie. This looks like a nice solution. I will give it a try! [13:18:04] prtksxna: you might want to merge https://gerrit.wikimedia.org/r/299745 to correct it, btw :) [13:20:01] MatmaRex: Right that is where I copied it from :P [13:21:39] prtksxna: oh. hmm. so that was your problem, old version of that file? [13:21:44] MatmaRex: grunt exec/build-tests runs both, but that didn't fix it for me [13:22:24] Trying to get the tests to fail again. I think I have to grunt test, run the karma tests and then open that interface to see the failures [13:22:45] MatmaRex: https://gerrit.wikimedia.org/r/#/c/283652/ if you're looking for something that fails tests :P [13:24:57] MatmaRex: Confirmed, I have to run 'grunt test' first and then open that page to see the errors. [13:28:56] MatmaRex: Right, so if I run git-build and build-tests and open that page its enough. I don't have to run karma separately. [13:29:46] That is a long wait to run the tests :( [13:30:38] yeah. :/ [13:31:44] MatmaRex: quick-build works. Mind if I add a pre-test task that runs the two? [13:33:17] prtksxna: no, go ahead. [13:34:05] prtksxna: it's really more of volker's and james's decision than mine, they're more active in ooui than me now ;) [13:39:15] MatmaRex: (y) [13:52:16] 06Multimedia, 10UploadWizard, 07Browser-Support-Internet-Explorer, 07Browser-Support-Microsoft-Edge, 13Patch-For-Review: Typed array constructor argument is invalid - https://phabricator.wikimedia.org/T136235#2475123 (10matmarex) Something conked out when I was pushing the commit for review. https://ger... [14:10:18] I was punished for not paying attention with overcooked eggs. [14:10:22] Karma is a bitch [14:11:10] Yeah! Niether MatmaRex nor I can understand its output! :P [14:11:21] Heh [14:20:55] prtksxna: I couldn't figure out how to uninvite you for some reason [14:21:34] Ah. I needed to click save. [14:21:39] It's really a banner day for me today [14:22:11] the "save" in google calendar is in the stupidest location possible, though [14:31:37] (03PS2) 10Bartosz Dziewoński: Unbreak audio thumbnail width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/299616 (https://phabricator.wikimedia.org/T137632) [14:31:44] (03PS4) 10Bartosz Dziewoński: Revert "TimedMediaHandler: Don't try to calculate width and height for audio files" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/298872 (https://phabricator.wikimedia.org/T137632) (owner: 10TheDJ) [14:34:23] 06Multimedia, 06Commons, 10MediaWiki-API, 10MediaWiki-File-management, and 2 others: misleading error about thumbnails for OGG audio files - https://phabricator.wikimedia.org/T137632#2475357 (10matmarex) [14:36:50] 06Multimedia, 06Commons, 10MediaWiki-API, 10MediaWiki-File-management, and 2 others: misleading error about thumbnails for OGG audio files - https://phabricator.wikimedia.org/T137632#2475368 (10matmarex) Wikitext to reproduce the problem: ``` [[File:Example.ogg|500px|thumb]] [[File:Example.ogg|thumb]] [[F... [14:57:28] (03CR) 10MarkTraceur: [C: 032] Unbreak audio thumbnail width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/299616 (https://phabricator.wikimedia.org/T137632) (owner: 10Bartosz Dziewoński) [15:03:52] (03Merged) 10jenkins-bot: Unbreak audio thumbnail width [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/299616 (https://phabricator.wikimedia.org/T137632) (owner: 10Bartosz Dziewoński) [15:29:34] (03CR) 10Bartosz Dziewoński: "I feel like if we wanted to do that, MobileFrontend would be a better place." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [15:34:43] (03CR) 10Jdlrobson: "Usually what we do in these situations is have a kill switch but only enable it on the mobile site in config. So essentially you just need" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [16:39:45] (03CR) 10Bartosz Dziewoński: "No config variable should ever live in UploadWizard for the purpose of MobileFrontend, either…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [16:57:08] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'parseDom' of undefined - https://phabricator.wikimedia.org/T139132#2476054 (10matmarex) No hits for the debug logging, and the last instance of the original exception is on 2016-06-28… [17:00:02] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2476077 (10matmarex) [17:00:03] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'parseDom' of undefined - https://phabricator.wikimedia.org/T139132#2476074 (10matmarex) 05Open>03Resolved I am pretty sure this was fixed with d9604e759a3d8a8d39d13511ee12e9f450049bf8. [17:00:37] (03PS1) 10Bartosz Dziewoński: uw.FieldLayout: Remove debugging code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299788 (https://phabricator.wikimedia.org/T139132) [17:09:00] (03CR) 10jenkins-bot: [V: 04-1] uw.FieldLayout: Remove debugging code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299788 (https://phabricator.wikimedia.org/T139132) (owner: 10Bartosz Dziewoński) [17:10:11] (03CR) 10Jdlrobson: "> No config variable should ever live in UploadWizard for the purpose of MobileFrontend, either…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [18:04:07] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2476413 (10matmarex) [18:05:51] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2327598 (10matmarex) Commit 046cbe84a29d1e4a3473d7497415f94889ca6182 (https://gerrit.wikimedia.org/r/297120) allows us to finally filter out non-UW exceptions, as all... [19:00:05] 06Multimedia, 06Commons, 10MediaWiki-API, 10MediaWiki-File-management, and 2 others: misleading error about thumbnails for OGG audio files - https://phabricator.wikimedia.org/T137632#2476646 (10matmarex) [19:01:04] (03Abandoned) 10Bartosz Dziewoński: Revert "TimedMediaHandler: Don't try to calculate width and height for audio files" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/298872 (https://phabricator.wikimedia.org/T137632) (owner: 10TheDJ) [19:02:41] 06Multimedia, 06Commons, 10MediaWiki-API, 10MediaWiki-File-management, and 2 others: misleading error about thumbnails for OGG audio files - https://phabricator.wikimedia.org/T137632#2476661 (10matmarex) 05Open>03Resolved Issue with thumbnails should get fixed with this week's WMF deployment, between T... [19:38:08] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2476884 (10matmarex) [19:38:10] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'resolve' of undefined - https://phabricator.wikimedia.org/T139130#2476880 (10matmarex) 05Open>03Invalid Like with T136237, none of the remaining errors seem to be coming from UploadWizard. [19:53:24] 06Multimedia, 10UploadWizard: UploadWizard should not suggest categories that do not exist - https://phabricator.wikimedia.org/T32718#2476970 (10Anomie) [20:09:55] 06Multimedia: Epic saga: immersive hypermedia (Myst for Wikipedia) - https://phabricator.wikimedia.org/T133526#2477125 (10Tgr) [20:21:38] (03PS2) 10MarkTraceur: Consistently pass api in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297848 (owner: 10Bartosz Dziewoński) [20:21:46] (03CR) 10MarkTraceur: [C: 032] Consistently pass api in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297848 (owner: 10Bartosz Dziewoński) [20:22:00] That has always bothered me. Thanks, MatmaRex [20:22:21] (03PS2) 10MarkTraceur: Various small code cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297849 (owner: 10Bartosz Dziewoński) [20:23:23] :o [20:24:55] MatmaRex: So this next patch removes the check for total size, right? So if we have a batch of files that's over xGB, we now don't throw an error? [20:25:46] i don't think it does? i wrote that a couple days ago though. which file? [20:25:49] marktraceur: ^ [20:25:56] (03Merged) 10jenkins-bot: Consistently pass api in uw.controller.Step subclasses [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297848 (owner: 10Bartosz Dziewoński) [20:26:01] UploadWizard.js [20:27:22] marktraceur: no, that it just dead code. it was calculating the totalSize and never using it anywhere [20:27:29] Oh, huh. [20:27:41] I thought we were supposed to not upload files if the size exceeded something [20:27:43] Oh well [20:27:52] marktraceur: that was just for thumbnails stuff, and i removed the code that checked this in https://gerrit.wikimedia.org/r/#/c/271809/ [20:28:01] we do check that, somewhere else [20:28:19] i'm not sure where, but i got that error this morning when testing unrelated stuff, so it's still there :P [20:28:40] OK, I believe in you [20:29:43] i had a browser tab with UW which would consistently crash if i had the debugger open and tried uploading a file over 2 GB or so [20:29:51] (03CR) 10MarkTraceur: [C: 032] Various small code cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297849 (owner: 10Bartosz Dziewoński) [20:29:52] but then i restarted the browser and it stopped :( [20:38:42] (03Merged) 10jenkins-bot: Various small code cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297849 (owner: 10Bartosz Dziewoński) [21:03:00] (03PS6) 10Jdlrobson: Parse annotations [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/173627 (https://phabricator.wikimedia.org/T58666) (owner: 10Gergő Tisza) [21:03:49] (03CR) 10Jdlrobson: "Would be good to update the commit message with some more information about what you are actually doing here and how you expect it to help" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/173627 (https://phabricator.wikimedia.org/T58666) (owner: 10Gergő Tisza) [21:07:42] (03CR) 10MarkTraceur: "It's worth noting that we have a prototype extension, FileAnnotations, that could replace the need for this (and add features, e.g. video " [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/173627 (https://phabricator.wikimedia.org/T58666) (owner: 10Gergő Tisza) [21:57:09] aw yeah, i reproduced https://phabricator.wikimedia.org/T136831 [22:13:01] 06Multimedia, 10UploadWizard: NS_ERROR_NOT_AVAILABLE - https://phabricator.wikimedia.org/T136831#2477706 (10matmarex) I was able to reproduce this. So it seems that Firefox doesn't like when we draw many