[00:37:26] 06Multimedia, 10UploadWizard, 13Patch-For-Review: NS_ERROR_NOT_AVAILABLE - https://phabricator.wikimedia.org/T136831#2478250 (10matmarex) I attempted to make a reduced test case, but it doesn't seem to be resulting in errors like the real UploadWizard :/ I'm not going to pursue this further, and I won't both... [00:38:05] 06Multimedia, 10UploadWizard, 13Patch-For-Review: NS_ERROR_NOT_AVAILABLE - https://phabricator.wikimedia.org/T136831#2478258 (10matmarex) Impact: ``` lines=10 mysql:research@dbstore1002.eqiad.wmnet [log]> select left(timestamp, 8), count(*) from UploadWizardExceptionFlowEvent_11772722 where event_message... [00:38:16] 06Multimedia, 10UploadWizard, 07Browser-Support-Firefox, 13Patch-For-Review: NS_ERROR_NOT_AVAILABLE - https://phabricator.wikimedia.org/T136831#2478259 (10matmarex) p:05Triage>03Normal [00:52:09] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2478276 (10matmarex) Status update: {F4290031,width=800} {F4290030} {F4290029} This chart excludes errors related to T136237 and T139130 (which I'm pretty sure are... [08:27:50] (03PS4) 10Matthias Mullie: Normalize all coordinate input to decimal degrees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298277 (https://phabricator.wikimedia.org/T123127) [08:27:56] (03CR) 10Matthias Mullie: Normalize all coordinate input to decimal degrees (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298277 (https://phabricator.wikimedia.org/T123127) (owner: 10Matthias Mullie) [10:56:34] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299788 (https://phabricator.wikimedia.org/T139132) (owner: 10Bartosz Dziewoński) [11:04:07] (03CR) 10Matthias Mullie: [C: 032] uw.FieldLayout: Remove debugging code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299788 (https://phabricator.wikimedia.org/T139132) (owner: 10Bartosz Dziewoński) [11:05:47] (03Merged) 10jenkins-bot: uw.FieldLayout: Remove debugging code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299788 (https://phabricator.wikimedia.org/T139132) (owner: 10Bartosz Dziewoński) [14:31:26] marktraceur: Do let me know if you need me to attend any meetings, I usually skip the ones that are late at night. [14:31:41] prtksxna: Yeah, no problem! [14:53:58] (03CR) 10Bartosz Dziewoński: [C: 032] Normalize all coordinate input to decimal degrees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298277 (https://phabricator.wikimedia.org/T123127) (owner: 10Matthias Mullie) [15:01:34] (03Merged) 10jenkins-bot: Normalize all coordinate input to decimal degrees [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/298277 (https://phabricator.wikimedia.org/T123127) (owner: 10Matthias Mullie) [15:03:22] 06Multimedia, 10UploadWizard: Accept degrees-minutes-seconds (DMS) coordinates in the Location field, not just decimal coordinates - https://phabricator.wikimedia.org/T135599#2480269 (10matmarex) 05Open>03Resolved [15:03:24] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#2480271 (10matmarex) That should resolve most problems with coordinates. Other issues mentioned in this task still stand. We should split off some subtasks to track the progress better. [15:03:27] (03PS1) 10Matthias Mullie: Fix indentation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300036 [15:03:30] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#2480274 (10matmarex) [15:03:33] 06Multimedia, 10UploadWizard: Accept degrees-minutes-seconds (DMS) coordinates in the Location field, not just decimal coordinates - https://phabricator.wikimedia.org/T135599#2304248 (10matmarex) [15:04:07] (03PS2) 10Matthias Mullie: Fix indentation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300036 [15:04:35] (03CR) 10Matthias Mullie: [C: 032] "trivial enough for self-merge" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300036 (owner: 10Matthias Mullie) [15:06:22] 06Multimedia, 06Commons, 10UploadWizard: "|" (pipe) character in any field breaks {{Information}} template and should be replaced with "{{!}}" - https://phabricator.wikimedia.org/T140901#2480287 (10matmarex) [15:07:07] 06Multimedia, 06Commons, 10UploadWizard: Warn when using recent dates for historical images (PD-old etc.) - https://phabricator.wikimedia.org/T140902#2480304 (10matmarex) [15:07:47] 06Multimedia, 06Commons, 10UploadWizard: Verify licenes tags for custom licenses ("Another reason not mentioned above") - https://phabricator.wikimedia.org/T140903#2480321 (10matmarex) [15:10:25] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard field input validation - https://phabricator.wikimedia.org/T123127#2480352 (10matmarex) Subtasks: # {T140901} # {T135599} # {T140902} # {T140903} Let's discuss each problem separately :) [15:12:37] 06Multimedia, 06Commons, 10UploadWizard: Verify license tags for custom licenses ("Another reason not mentioned above") - https://phabricator.wikimedia.org/T140903#2480363 (10matmarex) [15:12:40] (03Merged) 10jenkins-bot: Fix indentation [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300036 (owner: 10Matthias Mullie) [15:14:12] 06Multimedia, 06Commons, 10UploadWizard: Verify license tags for custom licenses ("Another reason not mentioned above") - https://phabricator.wikimedia.org/T140903#2480321 (10matmarex) We used to have some form of this, but IIRC it was broken in some way and eventually removed. I can't find when it was added... [15:17:30] 06Multimedia, 06Commons, 10UploadWizard: "|" (pipe) character in any field breaks {{Information}} template and should be replaced with "{{!}}" - https://phabricator.wikimedia.org/T140901#2480381 (10matmarex) This is going to be tricky – we should escape pipes in URLs and in plain text, but not in wikitext li... [15:18:19] 06Multimedia, 06Commons, 10UploadWizard: "|" (pipe) character in any field breaks {{Information}} template and should be replaced with "{{!}}" - https://phabricator.wikimedia.org/T140901#2480287 (10Jarekt) The only time "|" is ok is if it is inside a link [[...|...]] or template {{...|...}}. Otherwise it bre... [15:24:24] (03PS1) 10Reedy: Convert ImageMetrics to extension registration [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/300041 (https://phabricator.wikimedia.org/T87930) [15:25:47] (03CR) 10jenkins-bot: [V: 04-1] Convert ImageMetrics to extension registration [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/300041 (https://phabricator.wikimedia.org/T87930) (owner: 10Reedy) [15:27:25] lol [15:27:26] hoooooks [15:28:04] 06Multimedia, 06Commons, 10UploadWizard: Verify license tags for custom licenses ("Another reason not mentioned above") - https://phabricator.wikimedia.org/T140903#2480321 (10Jarekt) We do have about 50 files per day in https://commons.wikimedia.org/wiki/Category:New_uploads_without_a_license , which are upl... [15:29:48] (03PS2) 10Reedy: Convert ImageMetrics to extension registration [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/300041 (https://phabricator.wikimedia.org/T87930) [15:31:44] 06Multimedia, 10Analytics, 10Analytics-EventLogging, 10UploadWizard: Move efSchemaValidate out of global scope - https://phabricator.wikimedia.org/T140908#2480452 (10Reedy) [15:33:12] (03CR) 10Reedy: [C: 04-1] "Need to fix indenting" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/300041 (https://phabricator.wikimedia.org/T87930) (owner: 10Reedy) [15:33:17] what exactly is ImageMetrics? :o [15:33:37] is grrrit-wm implying that we maintain it? [15:33:40] :> [15:34:19] looks like it was written by the previous Multimedia team, and we should pawn it off to Reading [15:35:58] (03CR) 10jenkins-bot: [V: 04-1] Convert ImageMetrics to extension registration [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/300041 (https://phabricator.wikimedia.org/T87930) (owner: 10Reedy) [15:36:49] gah [15:36:50] on [15:38:00] Hmm Reedy does efSchemaValidate have a reasonable alternative in core yet? Last I checked it was lackluster. [15:38:12] Not sure, I'd presume not [15:38:26] I was gonna just move it to the "EventLogging" class for now [15:38:33] UW seems to be the only other consumer [15:39:47] (03PS3) 10Reedy: Convert ImageMetrics to extension registration [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/300041 (https://phabricator.wikimedia.org/T87930) [15:39:50] marktraceur: Unless someone says just move it to core [15:39:57] Reedy: UW and now FileAnnotations :) [15:40:06] orly? [15:40:18] I used the code from UW as a template, and when legoktm suggested the alternative, I found it to be lacking entirely [15:40:23] 06Multimedia, 10Analytics, 10Analytics-EventLogging, 10FileAnnotations, 10UploadWizard: Move efSchemaValidate out of global scope - https://phabricator.wikimedia.org/T140908#2480482 (10Reedy) [15:40:38] Reedy: We use efSchemaValidate to lay out the schema for the File Annotations namespace [15:40:47] marktraceur: You're the worst [15:40:49] But that's in prototype [15:40:51] Yes I am! [15:41:07] Is the extension in our repos now? [15:41:40] I've tagged that bug for it too [15:41:40] Reedy: Yeah, but the patch adding the schema is still in review (but now passing phpcs and jscs/jslint) [15:42:27] Ok, so if I get this done first, you'll have to amend/depend [15:46:23] lolol [15:47:58] something something programming in the heat something something [15:48:15] (03PS1) 10Reedy: Update call to efSchemaValidate [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300047 (https://phabricator.wikimedia.org/T140908) [15:52:14] Gosh. [15:53:39] marktraceur: efSchemaValidate() -> EventLogging::schemaValidate() [15:53:45] easy fixed if you add Depends-On [15:53:47] (03CR) 10jenkins-bot: [V: 04-1] Update call to efSchemaValidate [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300047 (https://phabricator.wikimedia.org/T140908) (owner: 10Reedy) [15:53:50] Easy enough, yeah [15:54:23] (03PS2) 10Reedy: Update call to efSchemaValidate [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300047 (https://phabricator.wikimedia.org/T140908) [15:54:38] * Reedy slaps jenkins [15:54:45] rebase in gerrit worked! [15:54:53] He deserves the slap for sure [16:13:28] James_F: Is jquery.ui enough of a problem that I should spend time finding an alternative? [16:13:43] * Reedy eyes marktraceur [16:13:52] Hush Reedy [16:13:54] marktraceur: Eurgh. No. [16:13:59] James_F: OK then! [16:14:13] marktraceur: But eww tech-debt. [16:14:25] James_F: I may wind up replacing it anyway since there's a bug in containment [16:14:32] Good. [16:25:22] 06Multimedia, 10TimedMediaHandler: Thumbnail missing on upload of video - https://phabricator.wikimedia.org/T39036#2480834 (10matmarex) [16:25:24] 06Multimedia, 10UploadWizard: UW does not display thumbs for OGV files in some browsers - https://phabricator.wikimedia.org/T43403#2480836 (10matmarex) [16:25:50] 06Multimedia, 10UploadWizard: Thumbnail missing on upload of video - https://phabricator.wikimedia.org/T39036#420041 (10matmarex) [16:25:51] yay old tasks [16:29:48] Reedy: Updated to not use global. [16:32:48] ty [16:32:52] Just need to get the other stuff merged now :D [16:36:49] 06Multimedia, 10UploadWizard, 10Wikimedia-General-or-Unknown: Cannot upload 12MB JPG file with Upload Wizard: "The upload succeeded, but the server could not get a preview thumbnail." - https://phabricator.wikimedia.org/T126293#2480920 (10matmarex) 05Open>03Resolved I'm sorry that this report went so far... [16:39:16] Indeed! [16:44:15] marktraceur: FWIW there is resizable and draggable things in OOUI; not sure if they could be used for this, though. [16:54:32] James_F: Hm, I'll look at it [16:55:18] James_F: Maybe, but I'd need to create a whole new class which I'm not sure is a sane amount of overhead [17:16:26] * James_F nods. [17:38:04] (03CR) 10Bartosz Dziewoński: "Hmm, that makes more sense. Ideally you would be able to just not load the extension at all, but we have Campaigns stuff in here too and y" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/296832 (https://phabricator.wikimedia.org/T97169) (owner: 10Bartosz Dziewoński) [17:39:59] 06Multimedia, 10MediaWiki-Parser: Exclude redundant srcset attribute values (e.g. same url) - https://phabricator.wikimedia.org/T135550#2481128 (10matmarex) 05Open>03Resolved [18:44:00] 06Multimedia, 06Services: Explore moving the Panoviewer gadget/Tool Labs tool into production - https://phabricator.wikimedia.org/T138933#2414341 (10Jdforrester-WMF) p:05Triage>03High [18:55:15] marktraceur: T138933, T5593, T3790, T55167 [19:17:56] (cc mlitn but marktraceur will discuss. :-)) [19:20:31] James_F, what's the status of the panoviewer? Have you built any backend tech for it? Also, do you know who is working on it? i would love to collab on it :) [19:20:46] CC from #mediawiki-visualeditor :D [19:20:53] yurik: None. None. No-one yet. [19:21:00] yurik: Phabricator is the source of truth. [19:21:29] James_F, yeah, i saw you added it to the board, hence wanted to sync up. Who is working on the backend for it? [19:21:40] (or will be) [19:26:28] yurik: We're still looking at it, but I'm going to ask tomorrow [19:27:00] marktraceur, ask who/what? [19:28:42] yurik: Ask a few people on the team if they want to work on it [19:30:44] marktraceur, ah, gotcha. I have spoken with Daniel Schwen about it - it might make sense to re-use Kartotherian tile serving ability for the backend, but I am not yet sure that mapnik engine is able to do the graphical re-projection, so it might need to shell-out for that [19:46:45] James_F: Can you take notes at the meeting tonight? [19:48:32] marktraceur: Sure. Is there a standard format? [19:48:55] James_F: The etherpad (PM incoming) has historical data [19:49:17] Ooh, interesting. [19:58:11] (03PS2) 10Bartosz Dziewoński: uw.EventFlowLogger: Unbreak UploadWizardTutorialActions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/299494 [19:59:54] marktraceur: Also, merge https://gerrit.wikimedia.org/r/#/c/299588/ already. :-) [20:00:33] Oh, pfft, fail [20:04:08] James_F: You put the wrong module name in, else okay [20:04:30] marktraceur: Fixed. [20:52:31] marktraceur: How would you feel if I created a "current desired epics" column on the workboard for those tasks? [21:07:35] James_F: I'd be delighted [21:08:12] marktraceur: Good, 'cos I did it whilst waiting for your response. :-D [21:08:37] 06Multimedia, 10PronunciationRecording, 10UploadWizard: PronunciationRecording uses UploadWizard in a very unsupported way - https://phabricator.wikimedia.org/T130170#2482007 (10Jdforrester-WMF) p:05Triage>03Normal [21:08:53] 06Multimedia, 06Commons, 10MediaWiki-extensions-GWToolset: Harmonize the format expected for templates in the various GWToolset fields - https://phabricator.wikimedia.org/T125203#2482010 (10Jdforrester-WMF) p:05Triage>03Normal [21:08:59] 06Multimedia, 10UploadWizard: Suggest nearby categories based on EXIF latitude/longitude - https://phabricator.wikimedia.org/T130120#2482014 (10Jdforrester-WMF) p:05Triage>03Low [21:09:14] 06Multimedia: Epic saga: immersive hypermedia (Myst for Wikipedia) - https://phabricator.wikimedia.org/T133526#2482017 (10Jdforrester-WMF) p:05Triage>03Low [21:09:25] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10Wikimedia-SVG-rendering, and 2 others: Beta feature for opt-in client side SVG rendering - https://phabricator.wikimedia.org/T134482#2482020 (10Jdforrester-WMF) p:05Triage>03Low [21:10:36] Eurgh. I hate how Phabricator's JS keeps crashing on me. [21:10:57] 06Multimedia, 10MediaWiki-Uploading: Use GPS location to deliver locally relevant messages about copyright (for people uploading pictures) - https://phabricator.wikimedia.org/T70770#2482028 (10Jdforrester-WMF) p:05Triage>03Normal [21:15:15] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown, 07Crosswiki: Use site-specific tags for cross-wiki-upload - https://phabricator.wikimedia.org/T127889#2482048 (10Jdforrester-WMF) 05Open>03declined I agree with @MatmaRex. There isn't a problem statement, and this is a bad solution in search of a... [21:18:27] marktraceur: We now allow restart-from-stash, right? So https://phabricator.wikimedia.org/T113043 can be closed as Resolved? [21:18:47] 06Multimedia, 06Commons, 10Wikimedia-General-or-Unknown, 07Crosswiki: Use site-specific tags for cross-wiki-upload - https://phabricator.wikimedia.org/T127889#2482063 (10matmarex) I'll note that with T139848 resolved, you can create an AbuseFilter for this. It would match `action='upload'` and the `summary... [21:22:53] James_F: not yet :( there's a UW patch for it [21:23:21] Ah, OK. [21:23:27] James_F: the patch is fine, but it would be rather terribly annoying right now, since files are never deleted from stash [21:23:31] even when you finish uploading them [21:23:32] James_F: I don't know if MatmaRex got the UW patch merged [21:23:36] or manually remove them from upload [21:23:37] * James_F nods. [21:23:37] Oh. [21:24:11] marktraceur: i rebased it only [21:24:22] https://gerrit.wikimedia.org/r/#/c/259320/ [21:37:53] James_F: why do we own ImageMetrics and can we pawn it off to Reading? [21:38:47] MatmaRex: Because they said they owned nothing when they got created, and we didn't push it. If you can convince Adam B. to take it on, be my guest. [21:39:30] James_F: the old Multimedia team that wrote it was folded into Reading. they sure do own it. [21:39:57] MatmaRex: And the people that break CentralAuth moved to Reading too, but they also disclaim ownership of that. :-) [21:40:05] (except for mark whom we love in the new Multimedia team) [21:40:27] We love Mark! [21:42:39] James_F: hmm, or to look at this from the other side. if we own it, can we decide to undeploy it? [21:43:04] MatmaRex: Is that the one used for MediaViewer? [21:43:24] i have no idea what it's used for. i think it just logs data. it's probably not used for anything. [21:43:36] In that case we should probably de-deploy it, yes. [21:43:37] prehaps someone looks at the data, but it definitely isn't us [21:43:45] ask gilles maybe, for MV it's not needed [21:43:54] Kk. Thanks, tgr. [21:44:03] I suspect it was something we used to find stats so we could make a decision in MMV [21:44:09] But I don't think we need it anymore? [21:44:15] Yeah, and now it's needed. [21:44:15] I don't know. [22:01:15] 06Multimedia, 10Analytics, 10Analytics-EventLogging, 10FileAnnotations, and 2 others: Move efSchemaValidate out of global scope - https://phabricator.wikimedia.org/T140908#2480452 (10matmarex) Hold on… is efSchemaValidate() a generic function to validate some JSON data against some JSON schema? Why is it i... [22:04:06] 06Multimedia, 10Analytics, 10Analytics-EventLogging, 10FileAnnotations, and 2 others: Move efSchemaValidate out of global scope - https://phabricator.wikimedia.org/T140908#2482213 (10Reedy) >>! In T140908#2482208, @matmarex wrote: > Hold on… is efSchemaValidate() a generic function to validate some JSON da... [23:01:09] Anyone else coming to KIT? [23:05:39] OK, we've finished it.