[00:06:51] <James_F>	 MatmaRex: So… T97202 and T97169 can both be closed? Or keep open?
[00:08:18] <MatmaRex>	 James_F: those are UW-mobile bugs? yes, i'll close them, i want to post a notice on commons' VP first. but i'm in the middle of something else now
[00:08:35] <James_F>	 MatmaRex: Of course. Congrats, BTW. :-)
[00:10:06] <MatmaRex>	 :)
[13:48:42] <marktraceur>	 MatmaRex: Make sure to mention Jon like five times, he'll love that :P
[13:49:11] <MatmaRex>	 heh
[13:49:37] <MatmaRex>	 right, i still need to write that. i'm fighting with backend stuff today
[13:49:47] <MatmaRex>	 https://phabricator.wikimedia.org/T140521
[13:50:12] <MatmaRex>	 trying to pay off some tech debt i added with my recent abusefilter work
[13:50:15] <MatmaRex>	 it's going… slowly
[13:50:33] <MatmaRex>	 (https://phabricator.wikimedia.org/T140522 is a better link, actually)
[13:52:55] <marktraceur>	 Mmkay
[13:53:12] <marktraceur>	 MatmaRex: My evil plan today is to do CR for you, so hopefully that will take some of the stuff off your backlog
[13:53:52] <marktraceur>	 MatmaRex: I could also take a step off of FA for a bit and work on UW bugs if you have some you'd like me to take, I haven't been looking at that backlog recently and I remember you saying you felt underwater on it
[13:54:15] <MatmaRex>	 marktraceur: oh, that'd be great, i have a bunch of boring easy UW and core patches waiting for review
[13:54:19] <marktraceur>	 Or I could just ramble through the backlog
[13:55:32] <MatmaRex>	 marktraceur: i'm mostly staying on top of new UW bug reports, at least responding to them, but not always fixing. there are a few new ones that are probably easy-ish, i just didn't have time yet
[13:55:52] <marktraceur>	 OK
[13:56:02] <marktraceur>	 Then I probably won't worry about them if they're easy
[13:56:08] <marktraceur>	 Depending on what it'd take you away from
[13:57:13] <MatmaRex>	 https://phabricator.wikimedia.org/maniphest/query/jtpJ8kC6_5du/#R feel free to take anything that is not fixed, stalled or patch-for-review ;)
[13:58:38] <marktraceur>	 Mmmmkay
[15:59:12] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Move mw.UploadWizardDetails.makeTitleInFileNS to uw.TitleDetailsWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300793 (owner: 10Bartosz Dziewoński)
[15:59:46] <grrrit-wm>	 (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300794 (owner: 10Bartosz Dziewoński)
[16:00:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move mw.UploadWizardDetails.makeTitleInFileNS to uw.TitleDetailsWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300793 (owner: 10Bartosz Dziewoński)
[16:05:57] <grrrit-wm>	 (03PS2) 10MarkTraceur: Do not set 'wgSiteName' JS config var [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300794 (owner: 10Bartosz Dziewoński)
[16:08:49] <marktraceur>	 Come on Jenkins don't be a dick
[16:12:56] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Do not set 'wgSiteName' JS config var [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300794 (owner: 10Bartosz Dziewoński)
[16:13:06] <grrrit-wm>	 (03PS2) 10MarkTraceur: Various minor cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300795 (owner: 10Bartosz Dziewoński)
[16:14:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Do not set 'wgSiteName' JS config var [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300794 (owner: 10Bartosz Dziewoński)
[16:41:48] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Various minor cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300795 (owner: 10Bartosz Dziewoński)
[16:45:35] <wikibugs>	 06Multimedia, 06Commons, 10MediaWiki-File-management: Missing skins/common/images/icons/fileicon.png causes fatal PHP error when viewing file pages for files that can't be thumbnailed - https://phabricator.wikimedia.org/T69422#2519613 (10Krinkle)
[16:48:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Various minor cleanups [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300795 (owner: 10Bartosz Dziewoński)
[16:55:26] <grrrit-wm>	 (03PS2) 10MarkTraceur: uw.TitleDetailsWidget: Check for $wgIllegalFileChars client-side [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[16:57:17] <MatmaRex>	 marktraceur: i've just remembered about one more thing for mobile uploadwizard - https://gerrit.wikimedia.org/r/302740
[16:57:33] <marktraceur>	 Ugh
[16:58:04] <marktraceur>	 Done
[16:58:09] <MatmaRex>	 thankee
[17:02:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] uw.TitleDetailsWidget: Check for $wgIllegalFileChars client-side [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[17:02:59] <MatmaRex>	 yeah, James_F and i just broke CI, disregard that
[17:03:09] <marktraceur>	 Hah
[17:03:12] <marktraceur>	 Fantastic
[17:11:55] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This failed to merge due to a delay in merging https://gerrit.wikimedia.org/r/#/c/302736/ . The PHP tests should pass now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[17:12:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[17:14:10] <MatmaRex>	 marktraceur: should be fine now
[17:14:47] <marktraceur>	 MatmaRex: qunit fail
[17:15:25] <wikibugs>	 06Multimedia, 06Editing-Department, 10UploadWizard, 07Epic, and 2 others: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#2519761 (10matmarex)
[17:15:27] <wikibugs>	 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Enable various core modules for mobile to make UploadWizard work - https://phabricator.wikimedia.org/T97202#2519759 (10matmarex) 05Open>03Resolved
[17:20:19] <wikibugs>	 06Multimedia, 10UploadWizard, 07Technical-Debt: Refactor UploadWizard to be maintainable - https://phabricator.wikimedia.org/T96906#2519770 (10matmarex)
[17:20:21] <wikibugs>	 06Multimedia, 10UploadWizard, 13Patch-For-Review: Rewrite UploadWizard with mustache templates - https://phabricator.wikimedia.org/T96520#2519771 (10matmarex)
[17:20:24] <wikibugs>	 06Multimedia, 06Editing-Department, 10UploadWizard, 07Epic, and 2 others: [EPIC] Enable UploadWizard on mobile - https://phabricator.wikimedia.org/T97169#2519766 (10matmarex) 05Open>03Resolved a:03matmarex This change will be deployed to Wikimedia wikis next week, 09-11 August 2016, with MediaWiki ve...
[17:22:30] <MatmaRex>	 marktraceur: hmm. weird.
[17:27:34] <MatmaRex>	 marktraceur: ha, i think the code is correct and the tests were wrong all this time. 'File:MediaWiki:foo bar.jpg' sure is not a valid title
[17:32:09] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: uw.TitleDetailsWidget: Check for $wgIllegalFileChars client-side [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) 
[17:32:09] <marktraceur>	 Not MediaWiki, Media
[17:32:12] <MatmaRex>	 that should be better
[17:32:15] <MatmaRex>	 marktraceur: both
[17:32:18] <marktraceur>	 Oh.
[17:32:33] <marktraceur>	 I thought : was a valid character
[17:32:37] <MatmaRex>	 (unless i missed something silly, that is, because i didn't run the tests to check)
[17:32:48] <MatmaRex>	 marktraceur: it's valid in titles, but not in file names
[17:32:58] <marktraceur>	 Ugh, computers are terrible
[17:33:05] <MatmaRex>	 i can't really tell you why, but that's how it is
[17:33:30] <MatmaRex>	 (it's invalid in filenames on Windows, but then so is e.g. '?', and we allow it)
[17:33:42] <marktraceur>	 We allow ? but not :
[17:33:44] <marktraceur>	 Ugh
[17:33:54] <MatmaRex>	 there are some comments which mention filesystems from the mac os 9 era
[17:33:54] <marktraceur>	 It's not like we're a website and ? is special in URLs
[17:34:02] <marktraceur>	 MatmaRex: Dude I believe that
[17:34:05] <MatmaRex>	 that used ':' as path separator
[17:34:16] <MatmaRex>	 so i dunno. whatever.
[17:35:52] <MatmaRex>	 lindseyanne_: i take it we have nothing to talk about in the 1:1 meeting? i have nothing, but i'm around if we have something to discuss
[18:14:09] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] uw.TitleDetailsWidget: Check for $wgIllegalFileChars client-side [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[18:14:32] <grrrit-wm>	 (03PS2) 10MarkTraceur: Stop using and remove mw.UploadWizard.sanitizeFilename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300797 (owner: 10Bartosz Dziewoński)
[18:15:40] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Stop using and remove mw.UploadWizard.sanitizeFilename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300797 (owner: 10Bartosz Dziewoński)
[18:15:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: uw.TitleDetailsWidget: Check for $wgIllegalFileChars client-side [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300796 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[18:15:49] <MatmaRex>	 marktraceur: thanks for all the reviews today <3
[18:15:55] <marktraceur>	 My pleasure!
[18:15:59] <grrrit-wm>	 (03PS2) 10MarkTraceur: Remove unused localisation messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300798 (owner: 10Bartosz Dziewoński)
[18:16:44] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Remove unused localisation messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300798 (owner: 10Bartosz Dziewoński)
[18:16:52] <grrrit-wm>	 (03PS2) 10MarkTraceur: Improve errors about invalid filenames [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300799 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[18:17:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop using and remove mw.UploadWizard.sanitizeFilename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300797 (owner: 10Bartosz Dziewoński)
[18:18:24] <marktraceur>	 James_F: Your +1 on 300799 says we're waiting on TWN, is that still accurate?
[18:18:44] <marktraceur>	 And if so who do we bother
[18:22:43] <MatmaRex>	 marktraceur: raimond or siebrand. i added them as reviewers now
[18:26:34] <wikibugs>	 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2519981 (10matmarex)
[18:26:36] <wikibugs>	 06Multimedia, 10UploadWizard, 07Regression, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): TypeError: undefined is not an object (evaluating 'uploadObj.ui.div') - https://phabricator.wikimedia.org/T141529#2519977 (10matmarex) 05Open>03Resolved This should be resolved with {46708622dda32ec31e4d4409d0f0f815fa5...
[18:29:33] <James_F>	 MatmaRex: Ta. Sorry, marktraceur, I should have done that.
[18:29:38] <marktraceur>	 That's okay
[18:31:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused localisation messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300798 (owner: 10Bartosz Dziewoński)
[19:01:10] <James_F>	 Woah, we have https://phabricator.wikimedia.org/T291 from the dawn of time.
[19:01:22] <James_F>	 (i.e., before we moved from BZ to Phab)
[19:04:26] <grrrit-wm>	 (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300799 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[19:06:04] <marktraceur>	 Yeah it's a giant pain in the ass spaghetti code thing James_F 
[19:07:44] <James_F>	 Fun.
[20:07:08] <wikibugs>	 06Multimedia, 10UploadWizard: Sort files in UploadWizard - https://phabricator.wikimedia.org/T140480#2466339 (10MarkTraceur) Could we just decouple the software's sorting of the files and the sorting in the interface? Currently it's sorted by "when was this upload added to the wizard" which we could do simply...
[20:07:13] <wikibugs>	 06Multimedia, 10UploadWizard: Sort files in UploadWizard - https://phabricator.wikimedia.org/T140480#2520456 (10MarkTraceur) a:03MarkTraceur
[22:59:38] <MatmaRex>	 marktraceur: raimond +1'd https://gerrit.wikimedia.org/r/#/c/300799/ , that probably means you can merge it whenever and he'll take care of the translatewiki part
[23:00:07] <marktraceur>	 Probably! I like it.
[23:00:17] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Improve errors about invalid filenames [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300799 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[23:00:28] <MatmaRex>	 yay
[23:01:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve errors about invalid filenames [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/300799 (https://phabricator.wikimedia.org/T140222) (owner: 10Bartosz Dziewoński)
[23:05:06] <marktraceur>	 lindseyanne_: You missed Penny!
[23:09:58] <wikibugs>	 06Multimedia, 06Commons, 10UploadWizard, 05MW-1.28-release-notes, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Upload Wizard: Error fails indicating "undesirable characters" but does not indicate which characters this might be - https://phabricator.wikimedia.org/T140222#2521094 (10matmarex) 05Open>03Resol...