[05:11:18] o/ [08:24:15] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2556348 (10Osnard) Unfortunately the approach to wrap a "FileBackendStore" object with my class does not work. This is how inhert... [08:47:34] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2556373 (10c.holtermann) Sorry for my inactivity. I can't help with this specific question either. I have been pondering over the... [08:54:47] 06Multimedia, 06Commons, 10MediaWiki-File-management, 07Wikimedia-log-errors: Fix "Error generating thumbnail" for svg thumb lang=en - https://phabricator.wikimedia.org/T106246#2556392 (10Gilles) a:05Gilles>03None [09:59:29] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team: Investigate PNG metadata in thumbnails - https://phabricator.wikimedia.org/T114518#2556533 (10Gilles) As @Bawolff pointed out, we strip most metadata from PNG thumbnails but not "thumbnail metadata". Which manifests itself as these f... [10:21:16] 06Multimedia, 10Wikimedia-SVG-rendering: SVG thumbnailing: radialGradient on circle element get ruined - https://phabricator.wikimedia.org/T143086#2556585 (10Perhelion) [10:26:29] 06Multimedia, 10Wikimedia-SVG-rendering: SVG thumbnailing: radialGradient on circle element get ruined (striped) - https://phabricator.wikimedia.org/T143086#2556600 (10Perhelion) [10:30:49] 06Multimedia, 10Wikimedia-SVG-rendering: SVG thumbnailing: radialGradient get ruined (striped) - https://phabricator.wikimedia.org/T143086#2556615 (10Perhelion) [12:07:46] (03CR) 10Addshore: [C: 032] Use "::class" when overriding TextContent::getContentClass() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/304601 (owner: 10Legoktm) [12:10:37] (03Merged) 10jenkins-bot: Use "::class" when overriding TextContent::getContentClass() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/304601 (owner: 10Legoktm) [12:50:44] 06Multimedia, 06Commons, 10MediaWiki-File-management, 06Performance-Team: ThumbnailRender job spam due to HTTP 500s - https://phabricator.wikimedia.org/T106740#2556924 (10Gilles) [13:53:06] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2557130 (10Osnard) Thanks for your commtent. I think keeping the wikis separated is a good idea, but I also believe that NSFileRep... [14:00:02] 06Multimedia, 06Commons, 10MediaWiki-File-management: img_auth.php: How to implement access checks using a custom file backend / repo? - https://phabricator.wikimedia.org/T140334#2557137 (10Osnard) It looks like I can do the trick by having my `NSFileRepoFSFileBackend` class inherit from `FSFileBackend` and... [14:02:26] Anybody coming? [14:02:32] marktraceur: I am [14:02:45] marktraceur: I thought I was in the hangout [14:02:54] I don't think so, but I could be wrong [14:03:01] AOh [14:11:00] James_F: Stand-up is rescheduled for one hour later tomorrow and following. [14:11:35] Kk. [14:12:34] prtksxna: I like the designs in principle, I guess. Some of them are a little out there compared to the current state of the software but we can work towards it [14:37:56] Ugh, now MediaWiki is broken like always [14:38:08] * marktraceur did not want to spend the day in a rabbit hole [15:11:00] 06Multimedia, 10MediaWiki-Gallery, 13Patch-For-Review: Slideshow mode gallery with redlinked image throws JS excpetion - https://phabricator.wikimedia.org/T142799#2557295 (10MarkTraceur) 05Open>03Resolved a:03MarkTraceur [15:24:04] (03CR) 10MarkTraceur: [C: 032] mw.FlickrChecker: Code style tweaks [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297850 (https://phabricator.wikimedia.org/T142481) (owner: 10Bartosz Dziewoński) [15:24:40] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Thumbnails are never shown when adding single Flickr uploads - https://phabricator.wikimedia.org/T142481#2557347 (10MarkTraceur) 05Open>03Resolved I'm going to add a separate bug for thumbnails when the upload fails. [15:26:03] 06Multimedia, 10UploadWizard: Thumbnails not shown when Flickr upload fails - https://phabricator.wikimedia.org/T143114#2557349 (10MarkTraceur) [15:28:57] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizard: Separate adding uploads and `` handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303834 (owner: 10Bartosz Dziewoński) [15:34:22] (03Merged) 10jenkins-bot: mw.UploadWizard: Separate adding uploads and `` handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303834 (owner: 10Bartosz Dziewoński) [15:34:24] (03Merged) 10jenkins-bot: mw.FlickrChecker: Code style tweaks [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/297850 (https://phabricator.wikimedia.org/T142481) (owner: 10Bartosz Dziewoński) [15:35:33] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Thumbnails are never shown when adding single Flickr uploads - https://phabricator.wikimedia.org/T142481#2557399 (10matmarex) [15:38:09] (03CR) 10MarkTraceur: [C: 032] mw.FlickrChecker: Set up lazy-loading after showing the placeholders [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303835 (https://phabricator.wikimedia.org/T142480) (owner: 10Bartosz Dziewoński) [15:41:01] (03Merged) 10jenkins-bot: mw.FlickrChecker: Set up lazy-loading after showing the placeholders [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303835 (https://phabricator.wikimedia.org/T142480) (owner: 10Bartosz Dziewoński) [16:00:26] (03CR) 10MarkTraceur: [C: 032] mw.FlickrChecker: Display a spinner while loading metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303836 (owner: 10Bartosz Dziewoński) [16:00:40] 06Multimedia, 10UploadWizard, 13Patch-For-Review, 07Regression: Lazy-loading of thumbnails in FlickrChecker no longer works - https://phabricator.wikimedia.org/T142480#2557499 (10MarkTraceur) 05Open>03Resolved [16:04:51] (03Merged) 10jenkins-bot: mw.FlickrChecker: Display a spinner while loading metadata [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/303836 (owner: 10Bartosz Dziewoński) [17:29:41] 06Multimedia, 10MediaWiki-Uploading: Allow &preload= and &editintro= parameters for templates on Special:Upload - https://phabricator.wikimedia.org/T13698#2557749 (10Slowking4) i'm not using upload wizard, and until the feature enabled, not using special:upload either [17:34:41] 06Multimedia, 10MediaWiki-Uploading: Allow &preload= and &editintro= parameters for templates on Special:Upload - https://phabricator.wikimedia.org/T13698#160063 (10Ciencia_Al_Poder) You can pass `wpUploadDescription` parameter to the URL to prefill the upload description, and `wpLicense` to prefill the licens... [18:00:35] 06Multimedia, 10UploadWizard: Unknown error: "badparams" - https://phabricator.wikimedia.org/T143134#2557929 (10matmarex) [18:46:05] 06Multimedia, 10Wikimedia-SVG-rendering: SVG thumbnailing: radialGradient get ruined (striped) - https://phabricator.wikimedia.org/T143086#2558169 (10Menner) The bug seems already present in 2.40.2. Commons SVG Checker shows the same and runs on older tool servers. https://commons.wikimedia.org/wiki/Commons:C... [19:11:19] 06Multimedia, 10VisualEditor: Surface images used in other languages when inserting media - https://phabricator.wikimedia.org/T142996#2558240 (10Jdforrester-WMF) [20:26:12] 06Multimedia, 06Commons, 06Operations, 10media-storage: Storage backend errors on commons when deleting/restoring pages - https://phabricator.wikimedia.org/T141704#2558555 (10Revent) As an update, the first file I mentioned being unable to restore worked just now. The second still gives the error. [21:11:48] 06Multimedia, 06Commons, 06Operations, 10media-storage: Storage backend errors on commons when deleting/restoring pages - https://phabricator.wikimedia.org/T141704#2558846 (10aaron) >>! In T141704#2558555, @Revent wrote: > As an update, the first file I mentioned being unable to restore worked just now. Th... [21:13:58] 06Multimedia, 06Commons, 06Operations, 10media-storage: Storage backend errors on commons when deleting/restoring pages - https://phabricator.wikimedia.org/T141704#2558851 (10Revent) Yes, nothing until I actually hit 'restore'. This is apparently quite uncommon, but a bit catastrophic when it does occur. [21:15:11] 06Multimedia, 06Commons, 06Operations, 10media-storage: Storage backend errors on commons when deleting/restoring pages - https://phabricator.wikimedia.org/T141704#2558859 (10Revent) As a further note, the deleted file, and page revisions, are visible from the history (when, of course, looking at deleted r... [21:52:00] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading: Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php on line 730 - https://phabricator.wikimedia.org/T143161#2559066 (10matmar... [21:54:02] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading: Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php on line 730 - https://phabricator.wikimedia.org/T143161#2559087 (10matmar... [21:55:47] ^ i made a mess again, eh [21:57:41] :-( [21:58:51] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading: Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php on line 730 - https://phabricator.wikimedia.org/T143161#2559123 (10Jdforr... [22:02:54] Wuh oh [22:02:58] MatmaRex: Urgent? [22:03:57] marktraceur: yes, must be fixed before tomorrow's deployment of wmf.15 to Commons (or the patches i linked reverted). but should be easy. [22:04:02] easy-ish. [22:04:08] Ping me if you need CR [22:04:18] (i'm working on it) [22:04:27] right, thanks [23:03:15] Are MatmaRex and I the only ones attending the standup? [23:07:16] Oh! [23:07:24] "No-one is here at the moment." [23:07:28] Is Google wrong? [23:08:01] James_F: oh, we left D: [23:08:16] Nothing much to say anyway. [23:09:58] MatmaRex: Do you have a fix for https://phabricator.wikimedia.org/T143161 in the works? [23:17:51] James_F: yes [23:18:27] James_F: it's not urgent enough for me to drop everything else, and i keep getting distracted. but it's pretty much done, i need to verify one more case, and write a commit message [23:23:13] Kk. [23:23:29] MatmaRex: I marked it as blocking the train; should it not? [23:24:19] James_F: it should. but the train's next run is in ~19 hours? [23:24:34] MatmaRex: Yes, just checking. [23:24:53] we can live with not being able to chunked-upload files on mw.org for a couple hours [23:25:10] Yeah. [23:40:28] James_F: https://gerrit.wikimedia.org/r/305155 is the fix [23:40:57] MatmaRex: Thank you!