[08:54:43] 06Multimedia, 06Community-Liaisons, 10MediaWiki-Gallery: Talk to communities about the new slideshow mode for galleries - https://phabricator.wikimedia.org/T143192#2560090 (10Whatamidoing-WMF) [09:56:48] (03PS1) 10Matthias Mullie: Localize SpamBlacklist errors & make then recoverable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305209 (https://phabricator.wikimedia.org/T141491) [09:57:58] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Add support for SpamBlacklist in UploadWizard - https://phabricator.wikimedia.org/T141491#2560165 (10matthiasmullie) a:03matthiasmullie [09:58:25] 06Multimedia, 10MediaWiki-Uploading, 10SpamBlacklist, 13Patch-For-Review: Add support for SpamBlacklist in cross-wiki upload dialog - https://phabricator.wikimedia.org/T141492#2560166 (10matthiasmullie) a:03matthiasmullie [10:05:54] 06Multimedia, 06Commons, 06Editing-Department, 10MediaWiki-File-management, and 4 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#2560200 (10Mrjohncummings) @Gilles thanks for the update. The reason why .amf is included is that .stl isn't an open format s... [10:31:24] 06Multimedia, 10UploadWizard: Unknown error: "badparams" - https://phabricator.wikimedia.org/T143134#2560297 (10matmarex) p:05Triage>03Normal a:03matmarex There is a slow but constant trickle of people hitting this issue in our logs. ```lines=8 mysql:research@dbstore1002.eqiad.wmnet [log]> select left(t... [10:34:02] 06Multimedia, 10UploadWizard: Unknown error: "badparams" - https://phabricator.wikimedia.org/T143134#2560307 (10matmarex) (The API error message is always "Cannot supply a filekey when offset is 0".) [10:52:07] (03PS1) 10Bartosz Dziewoński: mw.FormDataTransport: Don't set filekey with offset=0 when retrying [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305218 (https://phabricator.wikimedia.org/T143134) [11:06:57] 06Multimedia, 06Commons, 06Editing-Department, 10MediaWiki-File-management, and 4 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#2560339 (10Gilles) That's unfortunate. AMF made a terrible decision using XML for a format that simple. The fact that security... [11:20:01] 06Multimedia, 06Commons, 06Editing-Department, 10MediaWiki-File-management, and 4 others: Investigate copyright status of STL format - https://phabricator.wikimedia.org/T143201#2560368 (10Gilles) [14:54:02] writing javascript really fucks with your mind [14:54:06] mw.UploadWizardUpload.prototype.setTransported = function ( result ) { [14:54:06] ... [14:54:06] result.upload = result.upload || {}; [14:54:06] ... [14:54:06] } [14:54:31] how could 'result.upload' be undefined after running this code? i'll give y'all a couple minutes to answer [14:56:22] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'warnings' of undefined - https://phabricator.wikimedia.org/T143213#2560800 (10matmarex) [14:59:17] MatmaRex: Errors or warnings, but in theory we deal with that elsewhere [14:59:22] It might have been a carryover from a refactor [15:00:03] right, but i set it to an object right there [15:00:06] yet it's still undefined [15:00:13] Oh, I see [15:00:49] MatmaRex: Where is the undefined reference error, in that same thread or in a promise callback? [15:01:05] There might be a side effect happening in some other thread between calls, but seems unlikely [15:01:18] 06Multimedia, 10UploadWizard: Uncaught TypeError: Cannot read property 'warnings' of undefined - https://phabricator.wikimedia.org/T143213#2560819 (10matmarex) I ran into this when working on unrelated things. It happens when an async upload assembling fails, when UW tried to display the error. [15:01:36] marktraceur: the answer is: when 'result' is a string [15:01:53] Oh wow. [15:11:02] MatmaRex: OK, that's super weird. My first reaction was "but strings are objects, too", and it does let you set a property on a string, but it won't let you read it for some reason [15:11:16] Maybe the JS implementation just throws away the data you set on the property? [15:12:40] JS strings are actually primitives, but they're autoboxed when you try to treat them like objects [15:13:00] so i'm guessing it autoboxes that string into a String object, sets the property, then unboxes it back, losing any properties [15:13:43] Sounds reasonable, but a little unexpected [15:17:29] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Don't set filekey with offset=0 when retrying [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305218 (https://phabricator.wikimedia.org/T143134) (owner: 10Bartosz Dziewoński) [15:19:23] (03Merged) 10jenkins-bot: mw.FormDataTransport: Don't set filekey with offset=0 when retrying [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305218 (https://phabricator.wikimedia.org/T143134) (owner: 10Bartosz Dziewoński) [15:20:18] (03CR) 10MarkTraceur: [C: 032] Localize SpamBlacklist errors & make then recoverable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305209 (https://phabricator.wikimedia.org/T141491) (owner: 10Matthias Mullie) [15:25:09] (03CR) 10jenkins-bot: [V: 04-1] Localize SpamBlacklist errors & make then recoverable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305209 (https://phabricator.wikimedia.org/T141491) (owner: 10Matthias Mullie) [15:25:39] 06Multimedia, 10MobileFrontend, 06Reading-Web-Backlog, 10TimedMediaHandler-Player, 07Browser-Support-Apple-Safari: webm not playing on iOS Safari - https://phabricator.wikimedia.org/T142856#2560932 (10dr0ptp4kt) p:05Triage>03Normal [15:25:48] 06Multimedia, 10MobileFrontend, 06Reading-Web-Backlog, 10TimedMediaHandler-Player, 07Browser-Support-Apple-Safari: webm not playing on iOS Safari - https://phabricator.wikimedia.org/T142856#2548631 (10dr0ptp4kt) @brion, any insight on this? [15:26:03] mlitn: Looks like our crack CI infrastructure is borked again [15:30:48] (03PS1) 10Bartosz Dziewoński: mw.ApiUploadFormDataHandler: Unbreak error handling for async uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305272 (https://phabricator.wikimedia.org/T143213) [15:30:50] (03PS1) 10Bartosz Dziewoński: mw.FormDataTransport: Handle hopeless cases [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305273 [15:37:33] (03Merged) 10jenkins-bot: Localize SpamBlacklist errors & make then recoverable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305209 (https://phabricator.wikimedia.org/T141491) (owner: 10Matthias Mullie) [15:37:44] There we go. [15:38:24] 06Multimedia, 10UploadWizard, 13Patch-For-Review: Add support for SpamBlacklist in UploadWizard - https://phabricator.wikimedia.org/T141491#2561015 (10MarkTraceur) 05Open>03Resolved Thanks, Matthias! [15:49:21] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardUpload: Don't try to get API thumbnails for error uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305280 [15:49:30] everything is horrible [15:56:39] Everything is awesome!!!! [15:57:13] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardUpload: Don't try to get API thumbnails for error uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305280 (owner: 10Bartosz Dziewoński) [16:05:18] (03CR) 10MarkTraceur: "I don't understand how we get three arguments out of FormDataTransport.prototype.upload's promise rejections...and this would just mean th" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305272 (https://phabricator.wikimedia.org/T143213) (owner: 10Bartosz Dziewoński) [16:06:47] 06Multimedia, 10MediaWiki-Uploading, 13Patch-For-Review: No duplicate warnings are ever produced for chunked uploads to stash - https://phabricator.wikimedia.org/T130564#2561125 (10matmarex) [16:09:31] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Handle hopeless cases [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305273 (owner: 10Bartosz Dziewoński) [16:09:56] MatmaRex: How is changing the handler but not the calls going to work? [16:10:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Aw, poop. The three arguments are mw.Api's stupid rejection format, I thought they're supposed to be like this. But it looks like the bug " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305272 (https://phabricator.wikimedia.org/T143213) (owner: 10Bartosz Dziewoński) [16:10:16] Oh, got it [16:10:28] marktraceur: it's apparently inconsistent, i thought it was always wrong. thanks for noticing [16:10:37] That's why we do CR :) [16:10:53] On the bright side that might have meant a lot fewer people getting error messages [16:15:46] (03PS2) 10Bartosz Dziewoński: mw.FormDataTransport: Unbreak error handling for async uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305272 (https://phabricator.wikimedia.org/T143213) [16:16:46] marktraceur: that should be right ^ [16:16:54] Yeah that seems more better [16:17:06] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Unbreak error handling for async uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305272 (https://phabricator.wikimedia.org/T143213) (owner: 10Bartosz Dziewoński) [16:17:26] (03CR) 10jenkins-bot: [V: 04-1] mw.FormDataTransport: Unbreak error handling for async uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/305272 (https://phabricator.wikimedia.org/T143213) (owner: 10Bartosz Dziewoński) [16:18:05] grr [16:18:42] Probably poorly written tests as usual. [16:57:14] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 13Patch-For-Review: Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php ... - https://phabricator.wikimedia.org/T143161#2561311 [17:19:26] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 13Patch-For-Review: Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php ... - https://phabricator.wikimedia.org/T143161#2561373 [17:23:02] 06Multimedia, 10AbuseFilter, 10MediaWiki-Uploading, 13Patch-For-Review: Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php ... - https://phabricator.wikimedia.org/T143161#2561380 [18:02:17] 06Multimedia, 10MobileFrontend, 06Reading-Web-Backlog, 10TimedMediaHandler-Player, 07Browser-Support-Apple-Safari: webm not playing on iOS Safari - https://phabricator.wikimedia.org/T142856#2561516 (10brion) The mobile interface doesn't yet interact with TimedMediaHandler and the Ogg compatibility shim -... [18:03:00] 06Multimedia, 10MobileFrontend, 06Reading-Web-Backlog, 10TimedMediaHandler-Player, 07Browser-Support-Apple-Safari: webm not playing on iOS Safari - https://phabricator.wikimedia.org/T142856#2561517 (10brion) (fixing things on the TimedMediaHandler end). I'll reprioritize that on my end higher since it's... [19:17:10] 06Multimedia, 10UploadWizard: Thumbnails not shown when Flickr upload fails - https://phabricator.wikimedia.org/T143114#2561878 (10matmarex) p:05Triage>03Low I think Flickr thumbnails are always loaded from the API, and we assume that we can't load from the API if the upload is in the 'error' state (even t... [19:24:45] James_F: marktraceur: FYI, Commons now has a bunch of new filters https://commons.wikimedia.org/wiki/Commons:Abuse_filter/Automated_copyvio_detection . they're mostly targetted at cross-wiki uploads, some of them affect uploads from UploadWizard too. [19:25:15] MatmaRex: OK, cool. Hopefully it will help some. [19:25:37] around 1000 UW uploads prevented in the last 4 days, according to our EventLogging logs. (we have no logging at all for cross-wiki uploads, you could probably look at Special:AbuseLog to estimate for them.) [19:26:12] (compared to ~20 UW uploads prevented a day prior to recent filter changes) [19:26:49] MatmaRex: Usefully prevented? [19:27:09] James_F: usefully? [19:27:53] MatmaRex: As in, does it look like the filters are ultra-broad or are they useful in preventing bad stuff and allowing good stuff? [19:28:09] probably mostly yes. i didn't look at them in detail. [19:28:35] you could probably debate about some of them. i think at one point all PNG cross-wiki uploads were being prevented at one point, i didn't check now to see if that's still the case. [19:29:28] Steinsplitter has been tweaking the filters busily and i'm not trying to keep up, i'll just complain if the graphs spike too bad ;) [19:34:48] James_F: marktraceur: http://i.imgur.com/ugWCLko.png [19:35:06] Not bad [19:36:07] * James_F nods. [19:44:02] 06Multimedia, 06Commons, 10MediaWiki-File-management: Exception with thumb.php?w=xxxx: No width specified to ImageHandler::makeParamString - https://phabricator.wikimedia.org/T58924#2561984 (10mmodell) @aklapper: seems like it's still happening in #wmf-deploy-2016-08-16_1.28.0-wmf.15: ```lang=json { "fil... [20:32:31] James_F: I am helpfully not attending either evening standup tonight or tomorrow, because of prior engagements. Can you keep notes? [20:32:42] I have tomorrow's morning one for sure, of course [20:41:51] 06Multimedia, 06Commons, 10MediaWiki-File-management: Exception with thumb.php?w=xxxx: No width specified to ImageHandler::makeParamString - https://phabricator.wikimedia.org/T58924#2562234 (10Tgr) That's not a `thumb.php` stacktrace though. Seems like a TimedMediaHandler bug. [20:49:27] marktraceur: Umm. Maybe? [20:50:18] James_F: OK then. [20:51:52] 06Multimedia, 06Commons, 10MediaWiki-File-management: Exception with thumb.php?w=xxxx: No width specified to ImageHandler::makeParamString - https://phabricator.wikimedia.org/T58924#2562265 (10Tgr) It also seems very rare (18 instances in the last 30 days). Most of those are `thumb.php`, actually: a missing... [22:33:34] 06Multimedia, 06Commons, 10MediaWiki-Categories: Filenames are truncated on category pages - https://phabricator.wikimedia.org/T143281#2562715 (10Josve05a) [22:33:57] 06Multimedia, 06Commons, 10MediaWiki-Categories: Filenames are truncated on category pages - https://phabricator.wikimedia.org/T143281#2562728 (10Josve05a) [22:35:02] 06Multimedia, 06Commons, 10MediaWiki-Categories: Filenames are truncated on category pages - https://phabricator.wikimedia.org/T143281#2562715 (10Josve05a) [22:43:16] 06Multimedia, 06Commons, 10MediaWiki-Categories, 07Browser-Support-Google-Chrome: Filenames are truncated on category pages - https://phabricator.wikimedia.org/T143281#2562745 (10matmarex) I can reproduce this only using Chrome. All other browsers display the filenames correctly. I think it was fine until... [23:02:33] Anyone else meeting? [23:07:44] * James_F takes that as a 'no', hangs up. [23:44:57] 06Multimedia, 06Commons, 10MediaWiki-Categories, 07Browser-Support-Google-Chrome: Filenames are truncated on category pages - https://phabricator.wikimedia.org/T143281#2563031 (10Quiddity) Oh, I'm only seeing this problem with my staff account... testing... Gah, it's a gadget: "Long Image Names in Categori...