[14:36:35] 06Multimedia, 10UploadWizard: Get UploadWizard's uncaught exceptions on Commons to fewer than 50/day - https://phabricator.wikimedia.org/T136230#2594597 (10matmarex) [14:36:37] 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15), and 2 others: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined - https://phabricator.wikimedia.org/T139130#2594592 (10matmarex) 05Open>03Resolved That patch was the... [14:36:40] 06Multimedia, 06Commons, 10MediaWiki-File-management, 13Patch-For-Review: Embed TinyRGB color profile when JPG EXIF Color Space = sRGB but no profile embedded - https://phabricator.wikimedia.org/T134498#2594598 (10matthiasmullie) a:03matthiasmullie [14:49:51] 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15), and 2 others: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined - https://phabricator.wikimedia.org/T139130#2594628 (10matmarex) [16:15:43] 06Multimedia, 10MediaWiki-Uploading, 10UploadWizard: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2594899 (10matmarex) [16:51:53] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardDetails, mw.UploadWizardUpload: Use 'amenableparser' to handle templates in error messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307531 (https://phabricator.wikimedia.org/T144237) [17:01:40] 06Multimedia, 10MediaWiki-Uploading, 10UploadWizard, 13Patch-For-Review: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2595084 (10matmarex) Example results when attempting to upload a file ({F4416895,l... [17:03:48] marktraceur: James_F: could you both find time today to review https://phabricator.wikimedia.org/T144237 and the patches there? this is one more chapter in the cross-wiki upload abuse filter saga [17:04:15] and now i'm going to do what i planned for today, that is, lots of code review of my own. [17:09:20] 06Multimedia, 10MediaWiki-Uploading, 10UploadWizard, 13Patch-For-Review: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2595098 (10matmarex) p:05Triage>03High [17:14:20] 06Multimedia, 10UploadWizard, 07Browser-Support-Firefox, 13Patch-For-Review, and 3 others: NS_ERROR_NOT_AVAILABLE - https://phabricator.wikimedia.org/T136831#2595122 (10matmarex) (As if to spite me, it seems that not a single user ran into this exception since the detailed logging was deployed. I'm waiting... [17:15:55] 06Multimedia, 10MediaWiki-Uploading, 10UploadWizard, 13Patch-For-Review: Error messages from AbuseFilter shown in UploadWizard and upload dialog are not fully parsed (no templates) - https://phabricator.wikimedia.org/T144237#2595127 (10Steinsplitter) >>! In T144237#2595084, @matmarex wrote: > @Steinsplitte... [17:17:30] I've been looking for an option called "amenable parser" and just realized it's "a(ll)m(essages) enable parser" [17:17:42] I was like I didn't realize our parser was so distasteful [17:19:43] oh, haha [17:24:59] (03CR) 10MarkTraceur: [C: 031] "I'll let James sign off on this because Bartosz requested it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/307531 (https://phabricator.wikimedia.org/T144237) (owner: 10Bartosz Dziewoński) [19:55:24] hi, who is the best person to ask about ios and android feature test? [19:57:52] yurik: I don't think any one of our team members has had much experience with mobile things, I imagine jdlrobson would at least know who to ask [20:01:03] marktraceur, thanks! will do :) [20:01:30] * yurik just realized it was multimedia rather than mobile... :) [20:01:37] Heh [20:05:05] 06Multimedia, 10UploadWizard, 05MW-1.28-release-notes, 05WMF-deploy-2016-08-16_(1.28.0-wmf.15), and 2 others: Uncaught TypeError: Cannot read property 'resolve' of undefined / queue[title] is undefined - https://phabricator.wikimedia.org/T139130#2595750 (10Jdforrester-WMF) Nice! [20:35:29] marktraceur: Could you review my documentation changes to MatmaRex's https://gerrit.wikimedia.org/r/#/c/306493/ and if so merge it? [20:38:42] Oh, hmm, apparently I can't put those characters in our PHP without phpcs getting upset. [20:38:45] * James_F sighs. [20:39:19] Hey, MatmaRex; I added some further documentation on the PHP and JS sides to https://gerrit.wikimedia.org/r/#/c/306493/ but now both jscs and phpcs hate me. Oh well. [20:40:22] James_F: Ping again when you need another +2 [20:40:23] some of them are pretty magical. [20:47:08] Sorry m.arktraceur, will do. [23:01:49] marktraceur: Worth meeting? [23:01:53] I mean [23:02:02] I have nothing additional to say. [23:02:04] I enjoy talking [23:02:06] But whatever [23:02:15] I could also just carry on watching youtube videos [23:02:16] Speak to you in the morning then. :-) [23:02:20] Right-o [23:02:59] I will probably float the idea of axing the evening standup, but we should wait a week to see if LA agrees (she is on vacation this week) [23:03:10] * James_F nods. [23:03:43] Also, I think I've broken jscs. [23:03:50] RIP [23:05:06] It's telling me about bugs on lines I've not touched. [23:05:40] It crashed before you hit those lines, before? [23:05:53] No, it's reporting errors, but: [23:06:13] 1 |/*! [23:06:13] --------^ [23:06:13] Mixed spaces and tabs found at ./resources/src/mediawiki/mediawiki.Title.js : [23:06:27] Given that there's neither a space nor a tab on line 1, this is hard to agree with. [23:06:30] Pfft [23:07:10] Also getting js fatals inside jscs, to be fair. [23:07:16] Maybe it forgot where it found spaces and tabs, and fell back to 1 [23:07:17] "Error running rule validateIndentation: This is an issue with JSCS and not your codebase." [23:07:23] Possibly.