[00:46:50] 06Multimedia, 10Librarization, 10MediaWiki-Uploading: Make SVG sanitization into a library - https://phabricator.wikimedia.org/T86874#978461 (10Legoktm) All of the code for this is in UploadBase::detectScriptInSvg() and UploadBase::detectScript() correct? [08:55:03] 06Multimedia, 10UploadWizard: Location with NaN - https://phabricator.wikimedia.org/T146353#2658392 (10Aschroet) [08:55:32] 06Multimedia, 10UploadWizard: Location with NaN in uploads of UploadWizard - https://phabricator.wikimedia.org/T146353#2658405 (10Aschroet) [09:05:33] 06Multimedia, 10UploadWizard: Location with NaN in uploads of UploadWizard - https://phabricator.wikimedia.org/T146353#2658416 (10matthiasmullie) a:03matthiasmullie [10:09:37] (03PS1) 10Matthias Mullie: Fix NaN location input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/312220 (https://phabricator.wikimedia.org/T146353) [13:56:26] Morning folks [14:14:22] marktraceur: o/ [14:19:22] 06Multimedia, 10MediaWiki-Uploading, 10VisualEditor, 10VisualEditor-MediaWiki-Media, and 2 others: Provide a way during the upload stage for the user to change their mind about what file to upload once they've started it uploading - https://phabricator.wikimedia.org/T114938#2658904 (10matthiasmullie) a:03... [14:19:49] I see prtksxna invited marktraceur[NOTWMF] to a meeting today :P [14:24:52] marktraceur: Oops! Hate marktraceur[NOTWMF] :P [14:26:24] Right, what a dick [14:53:37] I'll miss the KIT, sorry. [15:18:52] (03PS1) 10Brion VIBBER: Update ogv.js to 1.2.0 [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/312263 (https://phabricator.wikimedia.org/T145983) [15:19:56] (03PS1) 10Brion VIBBER: Update ogv.js to 1.2.0 [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/312264 (https://phabricator.wikimedia.org/T145983) [15:21:57] (03CR) 10jenkins-bot: [V: 04-1] Update ogv.js to 1.2.0 [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/312263 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [15:24:32] (03CR) 10jenkins-bot: [V: 04-1] Update ogv.js to 1.2.0 [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/312264 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [15:25:19] (03CR) 10Hashar: "recheck" [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/312263 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [15:25:29] (03CR) 10Hashar: "recheck" [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/312264 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [15:37:04] prtksxna: https://phabricator.wikimedia.org/T145455 [15:37:29] prtksxna: You'll probably want to base it on https://gerrit.wikimedia.org/r/311616 [16:15:17] marktraceur MatmaRex: How do I reproduce https://phabricator.wikimedia.org/T145455? [16:15:34] Sorry, I am not familar with spam/abuse filter. [16:29:03] prtksxna: I just made an abusefilter that caught all text [16:29:36] prtksxna: SpamBlacklist is pretty easy, you add a blacklist for example.com like on the extension page [16:30:12] marktraceur: Like on http://localhost:8080/wiki/MediaWiki:Spam-blacklist add example.com, and add that text as an annotation? [16:30:40] I think you have to put in \b*example.com*\b or something....the extension page has it [16:45:43] (03Abandoned) 10MarkTraceur: Move towards a more consistent display [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/311740 (owner: 10MarkTraceur) [16:46:51] prtksxna: OK, one thing if you're still around...what if the screen is too small to fit the annotation into the content? The sidebar has some zindex shit that causes weirdness [16:48:01] I can force it to stay in the content body, which prevents the weirdness [16:48:23] But then the annotation overlaps with the annotation box, which I assume we should avoid? Should I just push it to the right in that case? [16:50:11] Ugh, no, that won't help anything. [16:51:31] I guess I might not care that the annotation box is overlapped by the annotation itself [16:51:38] I will just roll with the punches and fix it later [16:53:24] (03PS1) 10MarkTraceur: Make annotations popups, move them around [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/312281 (https://phabricator.wikimedia.org/T145458) [17:09:28] (03CR) 10Bartosz Dziewoński: [C: 032] Move bulk of code to single-class file [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/311445 (https://phabricator.wikimedia.org/T145450) (owner: 10MarkTraceur) [17:10:34] (03Merged) 10jenkins-bot: Move bulk of code to single-class file [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/311445 (https://phabricator.wikimedia.org/T145450) (owner: 10MarkTraceur) [17:10:56] (03CR) 10Bartosz Dziewoński: [C: 032] Pull a bunch of code into separate classes [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/311616 (owner: 10MarkTraceur) [17:11:16] Yay MatmaRex [17:12:12] :o [17:12:16] (03Merged) 10jenkins-bot: Pull a bunch of code into separate classes [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/311616 (owner: 10MarkTraceur) [17:15:34] MatmaRex: I might have something useful for you :D [17:15:37] ...or not :( [17:18:06] https://prtksxna.github.io/upload-stats/ [17:19:31] Whoaaaaa [17:19:59] click things [17:20:11] neeeat [17:22:24] gwtoolset is the least exciting dataset ever [17:22:40] But wow this is cool [17:23:15] that is actually very cool. i really should figure out one of those graphing libraries some day. [17:23:37] marktraceur: I should change the order of the pie charts so that it says - 'good', 'old', 'gwtoolset' :P [17:42:23] 06Multimedia, 10WikiEditor, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2659622 (10Nemo_bis) > figure it out pretty quickly: "Ooops, that dialog says "select a file" and then tries to search my hard drive for images... Yeah, t... [17:48:21] 06Multimedia, 06Commons, 10MediaWiki-Uploading, 07JavaScript, and 2 others: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#2659641 (10Nemo_bis) IMHO this task can be closed; the main... [17:49:13] 06Multimedia, 10FileAnnotations (Beta Cluster Release): Separate FileAnnotator class from code in fileannotations.js that should run on page load - https://phabricator.wikimedia.org/T145450#2659644 (10matmarex) 05Open>03Resolved a:03MarkTraceur [18:05:31] (03CR) 10Paladox: "Thanks." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/304021 (owner: 10Paladox) [18:05:39] (03CR) 10Paladox: "Thanks." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/288716 (owner: 10Paladox) [18:09:07] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/312263 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [18:09:24] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/312264 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [18:15:54] (03Merged) 10jenkins-bot: Update ogv.js to 1.2.0 [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/312263 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [18:15:58] (03Merged) 10jenkins-bot: Update ogv.js to 1.2.0 [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.19) - 10https://gerrit.wikimedia.org/r/312264 (https://phabricator.wikimedia.org/T145983) (owner: 10Brion VIBBER) [18:52:08] MatmaRex: But I very recently upgraded from a trial-and-error automaton to a software engineer :( [18:52:32] browsers have no hearts :( [19:10:17] (03CR) 10Bartosz Dziewoński: [C: 032] Fix NaN location input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/312220 (https://phabricator.wikimedia.org/T146353) (owner: 10Matthias Mullie) [19:11:45] 06Multimedia, 10UploadWizard: Location with NaN in uploads of UploadWizard - https://phabricator.wikimedia.org/T146353#2660038 (10matmarex) 05Open>03Resolved The fix has been merged and will probably be deployed to Commons on Thursday next week, with MediaWiki version 1.28.0-wmf.21. [19:12:34] (03Merged) 10jenkins-bot: Fix NaN location input [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/312220 (https://phabricator.wikimedia.org/T146353) (owner: 10Matthias Mullie) [19:18:16] (03CR) 10Bartosz Dziewoński: [C: 031] Do useful things for other image types [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/311737 (https://phabricator.wikimedia.org/T146118) (owner: 10MarkTraceur) [19:18:16] marktraceur: So I copied http://mediawiki.org/wiki/MediaWiki:Spam-blacklist over to my local wiki but I am still able to add those links [19:20:09] Even when I am logged out [19:20:40] prtksxna: Did you update the database after installing the extension, and add the requisite permissions to LS.php? [19:21:59] marktraceur: hmm, i think your refactors in FileAnnotations broke a few things :/ i didn't test them very carefully when merging, but i was trying out the other patches now and notices [19:22:15] Oh [19:22:16] marktraceur: empty annotations are no longer displayed, and the "Add annotation" button is nowhere to be found [19:22:22] MatmaRex: They worked for me... [19:22:34] Let me try pulling them again [19:22:46] Baka! Baka prtksxna! [19:24:49] Shoot, broken for me too [19:24:52] I wonder what happened there [19:26:36] * prtksxna makes note of installin extensions before trying to use them [19:27:01] * prtksxna sticks note on forehead and goes to bed [19:29:17] prtksxna: Heh, have a good night [19:31:22] (03PS1) 10MarkTraceur: Fix silly mistakes in refactors [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/312319 [19:31:25] MatmaRex: There ye be [19:33:18] (03CR) 10Bartosz Dziewoński: [C: 032] Fix silly mistakes in refactors [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/312319 (owner: 10MarkTraceur) [19:33:25] aha, that fixes it. thanks [19:34:56] yw [19:35:22] (03Merged) 10jenkins-bot: Fix silly mistakes in refactors [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/312319 (owner: 10MarkTraceur) [19:46:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Neat." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/311982 (https://phabricator.wikimedia.org/T146155) (owner: 10Matthias Mullie) [19:50:02] 06Multimedia, 10UploadWizard, 13Patch-For-Review: UploadWizard warns of properly filling gin all the fields; isn't clear which fields it wants - https://phabricator.wikimedia.org/T146155#2652342 (10matmarex) We have a task about the design of error/warning notices, I added your screenshot there: {T145674}. [20:09:17] (03PS1) 10Paladox: Test [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [20:14:04] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (owner: 10Paladox) [20:17:47] Could that have a less descriptive commit message [20:26:07] 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Location with NaN in uploads of UploadWizard - https://phabricator.wikimedia.org/T146353#2660303 (10Aschroet) Thank you for the quick fix. [20:48:32] 06Multimedia, 06Commons, 10Wikimedia-Site-requests: Set $wgUploadWizardConfig['blacklistIssuesPage'] = ''; for commonswiki - https://phabricator.wikimedia.org/T146417#2660363 (10matmarex) [20:49:07] (03PS2) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [20:54:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I still get the same exception when selecting "Provide copyright information for each file individually on the next page"." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/308177 (https://phabricator.wikimedia.org/T140902) (owner: 10Matthias Mullie) [20:59:35] (03PS3) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [21:06:18] (03CR) 10jenkins-bot: [V: 04-1] Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (owner: 10Paladox) [21:28:28] (03PS4) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [21:29:57] (03CR) 10jenkins-bot: [V: 04-1] Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (owner: 10Paladox) [21:31:03] (03PS5) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [21:32:36] (03CR) 10jenkins-bot: [V: 04-1] Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (owner: 10Paladox) [21:44:34] (03PS6) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [21:46:35] prtksxna: you really should link your visualization on https://phabricator.wikimedia.org/T144992 :) [21:47:05] (03PS7) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [21:53:19] (03CR) 10jenkins-bot: [V: 04-1] Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (owner: 10Paladox) [21:56:09] (03PS8) 10Paladox: Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 [22:00:35] (03CR) 10jenkins-bot: [V: 04-1] Add a new beta feature to enable Videojs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (owner: 10Paladox) [22:07:35] 06Multimedia, 10UploadWizard, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Location with NaN in uploads of UploadWizard - https://phabricator.wikimedia.org/T146353#2660714 (10matmarex) Actually, it will be the next next week (so Thursday, 7 October 2016), as there are no deployments planned next week due to Ope... [22:31:48] Bloody netsplits man