[09:10:10] brion: sigh.. i think i've given up on trying to understand foreigndb :( [09:11:04] It's funky and hard to set up yeah :( [09:51:54] (03CR) 10Matthias Mullie: [C: 032] uw.controller.Details: Correct conditions for metadata copier and upload removal [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314309 (owner: 10Bartosz Dziewoński) [09:54:07] (03Merged) 10jenkins-bot: uw.controller.Details: Correct conditions for metadata copier and upload removal [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314309 (owner: 10Bartosz Dziewoński) [10:14:10] (03PS39) 10Brion VIBBER: Optional BetaFeatures integration for video.js mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [10:14:13] (03PS1) 10Brion VIBBER: Regression fix: don't load TMH JS modules when not needed [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314528 [10:17:28] (03CR) 10Brion VIBBER: [C: 032] "I'm pretty happy with the latest rev; the fix for the cache hash seems to have resolved the audio issue I was seeing after switching. Upda" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [10:18:26] (03CR) 10Brion VIBBER: [C: 032] "self-merging quick fix" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314528 (owner: 10Brion VIBBER) [10:25:47] (03Merged) 10jenkins-bot: Optional BetaFeatures integration for video.js mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [10:28:14] (03Merged) 10jenkins-bot: Regression fix: don't load TMH JS modules when not needed [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314528 (owner: 10Brion VIBBER) [11:28:03] (03PS2) 10Brion VIBBER: WIP: optional integration of TMH video.js into MMV [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314313 [11:32:05] (03CR) 10jenkins-bot: [V: 04-1] WIP: optional integration of TMH video.js into MMV [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314313 (owner: 10Brion VIBBER) [13:14:20] (03PS3) 10Brion VIBBER: WIP: optional integration of TMH video.js into MMV [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314313 (https://phabricator.wikimedia.org/T77147) [13:18:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: optional integration of TMH video.js into MMV [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314313 (https://phabricator.wikimedia.org/T77147) (owner: 10Brion VIBBER) [13:21:21] and with that... bedtime :D [13:38:58] 06Multimedia, 06Commons, 10UploadWizard, 10Wikimedia-Site-requests, 13Patch-For-Review: Set $wgUploadWizardConfig['blacklistIssuesPage'] = ''; for commonswiki - https://phabricator.wikimedia.org/T146417#2696421 (10Dereckson) Deployed and live. To test with a unprivileged account (with confirmed right bu... [14:07:00] 06Multimedia, 10UploadWizard, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2696701 (10Reedy) [15:02:29] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [15:57:17] 06Multimedia, 10UploadWizard, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2696986 (10matmarex) Why do we even need this… we apparently do some namespace-specific validation in it. Isn't ContentHandler supposed to call the validation functio... [16:35:13] 06Multimedia, 10UploadWizard, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2697128 (10Reedy) >>! In T147566#2696984, @matmarex wrote: > Why do we even need this… we apparently do some namespace-specific validation in it. Isn't ContentHandler... [16:50:27] (03PS1) 10Bartosz Dziewoński: Fix volume resetting to 100% when starting playback [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314584 (https://phabricator.wikimedia.org/T147449) [17:23:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Good idea, some comments." (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314020 (owner: 10Matthias Mullie) [17:31:29] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks like a no-op." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314021 (owner: 10Matthias Mullie) [19:20:25] 06Multimedia, 10UploadWizard, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2697542 (10daniel) [19:23:16] 06Multimedia, 10UploadWizard, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2697543 (10daniel) It would indeed be nice if ContentHandler had a validate() methods that returns a Status object (or would return a meaningful message in some other... [21:16:58] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [21:19:29] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [21:22:02] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [21:23:02] (03CR) 10Paladox: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [21:27:15] (03CR) 10Brion VIBBER: [C: 032] Fix volume resetting to 100% when starting playback [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314584 (https://phabricator.wikimedia.org/T147449) (owner: 10Bartosz Dziewoński) [21:29:32] (03PS1) 10Bartosz Dziewoński: jquery.morphCrossfade: Remove 'overflow' fiddling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314598 [21:29:45] (03CR) 10Bartosz Dziewoński: [C: 031] Only paint the elements once we move into a step, instead of on construct (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314022 (owner: 10Matthias Mullie) [21:30:26] (03CR) 10Bartosz Dziewoński: "I'm not sure what is the purpose of this change? Perhaps it becomes clear when I review the rest of the stack :D" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314023 (owner: 10Matthias Mullie) [21:34:43] (03Merged) 10jenkins-bot: Fix volume resetting to 100% when starting playback [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314584 (https://phabricator.wikimedia.org/T147449) (owner: 10Bartosz Dziewoński) [22:07:38] 06Multimedia, 10UploadWizard, 07Technical-Debt: UploadWizard uses deprecated EditFilterMerged hook - https://phabricator.wikimedia.org/T147566#2696701 (10Legoktm) >>! In T147566#2697543, @daniel wrote: > It would indeed be nice if ContentHandler had a validate() methods that returns a Status object (or would... [23:03:31] (03PS1) 10Reedy: Replace EditFilterMerged hook usage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) [23:29:43] (03CR) 10Legoktm: [C: 04-1] Replace EditFilterMerged hook usage (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) (owner: 10Reedy) [23:35:33] (03PS2) 10Reedy: Replace EditFilterMerged hook usage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) [23:37:25] (03CR) 10Reedy: Replace EditFilterMerged hook usage (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) (owner: 10Reedy) [23:38:01] (03CR) 10jenkins-bot: [V: 04-1] Replace EditFilterMerged hook usage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) (owner: 10Reedy) [23:38:37] damn it gerrit [23:39:02] (03PS3) 10Reedy: Replace EditFilterMerged hook usage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) [23:39:41] Reedy: It does that. [23:39:51] What, be shit? [23:42:30] also, yes [23:54:09] 06Multimedia, 06Commons, 10Librarization, 10MediaWiki-File-management, and 3 others: Create separate XMP parsing library - https://phabricator.wikimedia.org/T100922#2698336 (10Bawolff) Woo! XMPReader kind of sounds nice. [23:58:04] (03CR) 10Legoktm: [C: 032] Replace EditFilterMerged hook usage [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314625 (https://phabricator.wikimedia.org/T147566) (owner: 10Reedy)