[00:47:19] (03CR) 10Brion VIBBER: "Looks ok offhand but I'm not sure what to do to actually invoke it. Eg, I can upload and purge metadata on Ogg, WebM, and MP4 files withou" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy) [04:32:56] 06Multimedia, 06Discovery, 10UploadWizard, 13Patch-For-Review: Add map widget for coordinate selection - https://phabricator.wikimedia.org/T58612#2724470 (10jeremyb) a:05Inchikutty>03jeremyb [05:26:03] (03PS1) 10Brian Wolff: Fix typo in comment [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/316520 [05:58:25] 06Multimedia, 06Discovery, 10UploadWizard, 13Patch-For-Review: Add map widget for coordinate selection - https://phabricator.wikimedia.org/T58612#2724526 (10Yurik) The patch should be implemented using [[ https://www.mediawiki.org/wiki/Help:Extension:Kartographer/Developer_guide#Creating_a_map_frame | Kart... [10:07:11] 06Multimedia, 10Commons-App-Android-Upload, 10UploadWizard: Make UploadWizard locally configurable - https://phabricator.wikimedia.org/T148447#2724720 (10Aklapper) @Whatamidoing-WMF : Could you explain how this task is related to #Commons-App-Android-Upload ? Adding #UploadWizard. [11:21:20] 06Multimedia, 10ArchCom-RfC, 10MediaWiki-extensions-CollaborationKit, 07ArchCom-Has-shepherd: RFC: JSON validation - https://phabricator.wikimedia.org/T147137#2724891 (10mobrovac) Just to be clear, this discussion is not about JSON vs YAML. JSON-schema is a schema standard and does not depend on it being w... [11:38:04] 06Multimedia, 10ArchCom-RfC, 10MediaWiki-extensions-CollaborationKit, 07ArchCom-Has-shepherd: RFC: JSON validation - https://phabricator.wikimedia.org/T147137#2724905 (10Florian) >>! In T147137#2724891, @mobrovac wrote: > ```lang=json, name=JSON > { > "type": "object", > "properties": [ > } >... [12:06:45] 06Multimedia, 10Commons-App-Android-Upload, 10UploadWizard: Make UploadWizard locally configurable - https://phabricator.wikimedia.org/T148447#2723263 (10josephine_l) Hi @Whatamidoing-WMF , Just to clarify, are you requesting this feature for the web-based Upload Wizard? #commons-app-android-upload is for t... [12:16:30] (03Abandoned) 10Paladox: Remove erroneous break [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316250 (https://phabricator.wikimedia.org/T148284) (owner: 10Paladox) [12:17:50] (03CR) 10Paladox: [C: 031] Bring in getid3 from composer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy) [13:00:20] 06Multimedia, 10ArchCom-RfC, 10MediaWiki-extensions-CollaborationKit, 07ArchCom-Has-shepherd: RFC: JSON validation - https://phabricator.wikimedia.org/T147137#2725038 (10mobrovac) >>! In T147137#2724905, @Florian wrote: > And, the JSOn is invalid... line 3 should be: ... which just proves my point about m... [14:14:33] 06Multimedia, 06Commons, 10MediaWiki-File-management, 07Easy, 13Patch-For-Review: thumb.php should output docs if no file specified - https://phabricator.wikimedia.org/T56749#2725226 (10Aklapper) Two patches in Gerrit, both need reworking (see comments there). [14:21:00] 06Multimedia, 10MediaWiki-Uploading, 07Easy, 13Patch-For-Review: Special:Upload should remove whitespace before file extension - https://phabricator.wikimedia.org/T67811#2725261 (10Aklapper) * Client-side T66922 is resolved now. * https://gerrit.wikimedia.org/r/#/c/192773/ has a CR+1. * https://gerrit.wiki... [15:00:59] 06Multimedia, 06Commons, 10UploadWizard: Upload Wizard FAQ links - https://phabricator.wikimedia.org/T77538#2725354 (10Aklapper) Not simple, hence removing #easy tag. [15:15:42] (03CR) 10Reedy: "That's kinda worrying brion... lol" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy) [15:41:10] (03CR) 10Paladox: "@Brion VIBBER https://gerrit.wikimedia.org/r/#/c/316067/ needs c+2 please?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy) [15:43:21] oh, ffs paladox... [15:43:40] when will you learn :) [15:43:48] * thedj still has hopes [15:48:50] I don't [15:48:57] It's obvious he doesn't understand OOPs [15:48:59] * brion just pushes buttons \o/ [15:49:01] The P alone is questionable [15:49:41] I spent 4-5 hours helping get a patch into a decent state... Would've taken well under 30 minutes to write from scratch [15:49:52] "can you review this patch" [15:50:00] *makes multiple more PS in the time* [15:52:12] well he tries, but i had hoped he had grasped a better understanding of what reviewing means by now... [15:52:34] it's been like 3 years or something now... [15:53:23] Has it really? [15:54:47] Wonder how we easily find that out [15:54:51] Hmm [15:54:58] He was definitely around before Lyon... [15:55:05] So that's vaguely 18 months ago [15:57:34] (03Merged) 10jenkins-bot: Bring in getid3 from composer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316066 (https://phabricator.wikimedia.org/T148285) (owner: 10Reedy) [16:37:46] 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2725870 (10MothsART) I've generated this illustration with a custom tool. This tool (a wysiwyg and an offline web app) can im... [16:58:16] (03Abandoned) 10Brion VIBBER: Update getid3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145575 (owner: 10Paladox) [16:59:24] thedj: does that update I made on https://gerrit.wikimedia.org/r/#/c/316485/ look good to you? [16:59:35] i merged the check/conditional-load into mw.OgvJsSupport [17:17:14] (03CR) 10Brion VIBBER: [C: 032] "self-merging this fix :D" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316000 (https://phabricator.wikimedia.org/T144483) (owner: 10Brion VIBBER) [17:26:38] (03Merged) 10jenkins-bot: Add check to File_Ogg for cut-off page headers [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316000 (https://phabricator.wikimedia.org/T144483) (owner: 10Brion VIBBER) [17:29:56] brion: looks good, but did not have time to fully review yet. [17:30:02] will do in a minute [17:49:36] sigh [17:49:50] vagrant: [17:49:51] ==> default: Error: /Stage[main]/Npm/Package[nodejs]/ensure: change from 4.4.5-1nodesource1~trusty1 to 0.10.25~dfsg2-2ubuntu1+wmf1 failed: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install nodejs' returned 100: Reading package lists... [17:50:01] thedj: ah you ofund that bug too [17:50:18] thedj: workaround: run the apt-get command as root inside the vm with -y option, then re-provision [17:51:15] like /usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install nodejs ? [17:51:35] yeah [17:53:06] thedj: supposedly they just merged a proper pin for the nodejs package, may or may not be happier after an update on the vagrant git [18:00:49] (03CR) 10Dereckson: [C: 032] "SWAT" [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/316069 (https://phabricator.wikimedia.org/T122737) (owner: 10Brion VIBBER) [18:12:18] (03Merged) 10jenkins-bot: Repair text track attributes [extensions/TimedMediaHandler] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/316069 (https://phabricator.wikimedia.org/T122737) (owner: 10Brion VIBBER) [18:13:06] (03PS3) 10TheDJ: Made the dependency on videojs-ogvjs conditional [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316485 (https://phabricator.wikimedia.org/T133228) [18:15:30] brion: i think i'm OK with the patch yes [18:15:36] woohoo [18:20:58] oh great, now root and vagrant user are fighting with eachother over permissions in the npm cache... [18:21:12] sigh. [18:26:02] (03CR) 10TheDJ: [C: 031] Made the dependency on videojs-ogvjs conditional [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316485 (https://phabricator.wikimedia.org/T133228) (owner: 10TheDJ) [18:35:46] (03CR) 10Brion VIBBER: [C: 032] Made the dependency on videojs-ogvjs conditional [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316485 (https://phabricator.wikimedia.org/T133228) (owner: 10TheDJ) [18:43:01] right, well i guess i'll try git updating vagrant then [18:44:41] (03Merged) 10jenkins-bot: Made the dependency on videojs-ogvjs conditional [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316485 (https://phabricator.wikimedia.org/T133228) (owner: 10TheDJ) [18:50:00] (03CR) 10Bartosz Dziewoński: [C: 032] Fix typo in comment [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/316520 (owner: 10Brian Wolff) [18:51:00] (03Merged) 10jenkins-bot: Fix typo in comment [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/316520 (owner: 10Brian Wolff) [18:55:24] 06Multimedia, 10MediaWiki-General-or-Unknown, 10UploadWizard, 10VisualEditor, and 3 others: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget - https://phabricator.wikimedia.org/T147811#2726578 (10Prtksxna) I spoke with @Esanders and @matmarex about this and we feel that it'll be better to get m... [18:56:47] 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2726583 (10matmarex) We have a HTML validation library (the Sanitizer class) and it could probably be hooked up to validating... [19:10:38] (03PS1) 10Brion VIBBER: Fix videojs mode control bar in RTL [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316612 (https://phabricator.wikimedia.org/T148565) [19:26:49] 06Multimedia, 10ArchCom-RfC, 10MediaWiki-extensions-CollaborationKit, 07ArchCom-Has-shepherd: RFC: JSON validation - https://phabricator.wikimedia.org/T147137#2726680 (10Bawolff) I was just looking at the FileAnnotations extension, which also depends on EventLogging solely for json schema validation. It s... [19:48:52] 06Multimedia, 06Commons, 10MediaWiki-Uploading, 10Possible-Tech-Projects, 07Community-Wishlist-Survey: Add support for KML/KMZ filetype - https://phabricator.wikimedia.org/T28059#300455 (10Yurik) I think we should consider a few things when implementing (or not implementing) this task. There are several... [19:56:33] 06Multimedia, 10MediaWiki-Uploading: Support for GPS eXchange Format (GPX) - https://phabricator.wikimedia.org/T55023#563624 (10Yurik) Copying from T28059#2726773 - identical reasoning: I think we should consider a few things when implementing (or not implementing) this task. There are several reasons to stor... [20:22:34] 06Multimedia, 06Commons, 10MediaWiki-File-management: Gallery perrow width is overestimated - https://phabricator.wikimedia.org/T29577#2726933 (10matmarex) [20:46:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "If tutorial step is skipped, you get tons of weird exceptions." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [20:51:59] (03CR) 10Bartosz Dziewoński: "…and when it's not skipped, going back to it after selecting files and then forward results in inconsistent UI." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/314024 (https://phabricator.wikimedia.org/T122923) (owner: 10Matthias Mullie) [22:18:18] 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2727251 (10RobLa-WMF) >>! In T138783#2725870, @MothsART wrote: > I've generated this illustration with a custom tool. > This... [22:18:31] head desk... [23:00:29] 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2727342 (10matmarex) No, we don't want to parse wikitext in SVG images, that's far too crazy :) But I think Sanitizer can jus... [23:03:31] 10FileAnnotations, 06Multimedia, 10MediaWiki-Vagrant: MediaWiki-Vagrant role for FileAnnotations extension - https://phabricator.wikimedia.org/T148597#2727348 (10brion) [23:18:46] brion: sorry, got dragged into 5 hours of vagrant mess :( [23:19:10] at least we got a bit further again today. [23:30:35] 06Multimedia, 10MediaWiki-Uploading, 06Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783#2727413 (10RobLa-WMF) >>! In T138783#2727342, @matmarex wrote: > No, we don't want to parse wikitext in SVG images, that's fa... [23:42:52] (03PS2) 10Paladox: Update videojs to 5.12.4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/314731 [23:53:58] (03CR) 10Paladox: [C: 031] Fix videojs mode control bar in RTL [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/316612 (https://phabricator.wikimedia.org/T148565) (owner: 10Brion VIBBER)