[00:25:50] 06Multimedia, 10Commons-Datasets, 10GlobalUsage, 03Interactive-Sprint, 07Technical-Debt: Refactor GlobalUsage to support Commons Datasets - https://phabricator.wikimedia.org/T154047#2947837 (10MaxSem) [07:50:17] > They haven’t seen the cake, as it were. They don’t even know it exists. [07:50:22] THE CAKE IS A LIE [08:50:30] hello prtksxna :o [08:55:17] 06Multimedia, 10MediaWiki-Gallery, 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140595#2948711 (10Prtksxna) [09:07:30] Hey MatmaRex [09:07:54] MatmaRex: That is from the grant, in case you were wondering :P [10:23:29] 06Multimedia, 10MediaWiki-Gallery, 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140595#2469881 (10matmarex) The big thumbnail shou... [10:24:07] MatmaRex: I might have bulldozed some of your changes on https://gerrit.wikimedia.org/r/#/c/332745/3 [10:25:56] oh, mid-air collision? no problem [10:26:08] 06Multimedia, 10MediaWiki-Gallery, 10MediaWiki-extensions-MultimediaViewer, 13Patch-For-Review: Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140595#2948833 (10Prtksxna) >>! In T140595#2948831... [10:29:47] MatmaRex: I actually am not sure which comment belongs here [10:30:29] The 'template' is obviously part of the previous line. Is the fixme for #siteNotice. I think PS4 gets it completely wrong [10:30:56] prtksxna: hmm. i though the entire "we are on an error page for a non-existing article, the image is part of some template // FIXME this should be handled by .metadata" is about .noarticletext [10:31:11] we could probably find out from git history [10:31:30] I see that from your changes. But the way the comment was initially formatted was confusing. [10:31:55] MatmaRex: Also, https://gerrit.wikimedia.org/r/#/c/332387/ [10:32:10] (hmm, we won't actually find out from history, the whole confusing block was added in 92ea8edbc50aae3104f35215c4ce9e87c0b4a0d0) [10:32:57] prtksxna: yeah, i just saw that comment. you're right, that's broken [10:33:09] i really had no good reason to change that. i'll submit a change to undo it [10:34:15] MatmaRex: #siteNotice is like an 'informational template' so it would make sense that that is what the fixme is referring to. but who knows [10:42:35] prtksxna: hmm, do you know what makes MMV not trigger when clicking the big slideshow thumbnail? [10:43:15] MatmaRex: I think the fact that we might be adding that image in the DOM after the MMV bootstrap has already run. [10:43:43] ooh. [10:43:50] * prtksxna gets dizzy looking at the related changes on https://gerrit.wikimedia.org/r/#/c/332387/ [10:44:59] hmm. i guess we could do mw.hook( 'wikipage.content' ).fire(…) on it after we insert it, in core code? [10:45:18] * prtksxna nods [10:48:55] MatmaRex: https://gerrit.wikimedia.org/r/#/c/332755/ is good to +2, wont mess up some dependency somewhere? [10:49:53] prtksxna: no. i rebased https://gerrit.wikimedia.org/r/#/c/331583/ on top of it, because i needed to fix the tests there to account for the new id format, and it would conflict [10:50:08] prtksxna: i mean, yes, it's good to go, no, it won't mess up anything :) [10:51:03] I have a bad habit of forming questions that are impossible to answer with a single boolean :( [13:33:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "* The link to the non-existent file (for 'duplicate-archive') should be a redlink, as in the previous code." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/331230 (owner: 10Matthias Mullie) [13:47:58] (03PS7) 10Bartosz Dziewoński: uw.LocationDetailsWidget: Display map with a pin inside a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/286906 (https://phabricator.wikimedia.org/T133905) [13:49:33] (03CR) 10Bartosz Dziewoński: "Now, if Kartographer is not installed (or the modules fail to load), the button just never appears. If it's installed, it appears as disab" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/286906 (https://phabricator.wikimedia.org/T133905) (owner: 10Bartosz Dziewoński) [17:23:25] 06Multimedia, 06Commons, 10MediaWiki-File-management, 10TimedMediaHandler, 07Upstream: Ogg audio file on Commons not listed with correct duration metadata - https://phabricator.wikimedia.org/T87619#2949484 (10brion) This appears to be an issue with File_Ogg. Tagging upstream... https://pear.php.net/bugs/... [22:40:07] (03PS3) 10Matthias Mullie: Treat duplicate & duplicate-archive warnings differently [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/331230 [22:41:34] (03CR) 10Matthias Mullie: "The previous code printed a
    with a link to the (archived) file." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/331230 (owner: 10Matthias Mullie) [23:18:48] prtksxna: It's been 2017 for nearly three weeks man [23:26:15] 06Multimedia, 10MediaWiki-Gallery, 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 13Patch-For-Review: Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode - https://phabricator.wikimedia.org/T140595#2951026 (10phuedx)