[01:02:49] <James_F>	 marktraceur: Well… having just installed and uploaded an STL file, I get "Error creating thumbnail: module.js:327 throw err; ^ Error: Cannot find module 'canvas' at Function.Module._resolveFilename (module.js:325:15) at …", so that's not perfect. :-)
[01:08:05] <marktraceur>	 James_F: No kidding. With the vagrant role?
[01:08:14] <James_F>	 marktraceur: Yup.
[01:08:27] <James_F>	 marktraceur: Fresh git-master update.
[01:08:42] <marktraceur>	 Current mw too?
[01:08:46] <James_F>	 Yup.
[01:08:56] <James_F>	 Though it's the node process that's died.
[01:09:08] <James_F>	 Also breaks MV's initial load, sadly.
[01:09:38] <marktraceur>	 Well that sucks.
[01:09:48] <marktraceur>	 I'll look at 'er tomorrow
[01:10:30] <James_F>	 Ta.
[01:10:40] <James_F>	 Probably something I'm doing wrong, of course.
[02:09:01] <marktraceur>	 James_F: Reasonable assumption
[17:15:26] <James_F>	 So… I've been poking around the vagrant role, and there doesn't seem to be a service created (nothing in /vagrant/srv), just run inside the extension directory?
[17:15:32] <James_F>	 Err. marktraceur ^
[17:15:51] <marktraceur>	 James_F: Yeah, it's just a command line thing
[17:16:31] <James_F>	 And on install it's meant to execute `npm install` to provide the code dependencies?
[17:16:37] <marktraceur>	 I believe so
[17:17:12] <marktraceur>	 James_F: You enabled the three_d role, right?
[17:17:19] <James_F>	 Yes yes yes.
[17:17:35] <James_F>	 I just rm -rf'ed the node_modules directory and re-installed.
[17:18:24] <James_F>	 Oh, wait.
[17:18:39] <James_F>	 What's $three_d_2png_dir meant to be?
[17:19:39] <marktraceur>	 Probably the directory for 3d2png
[17:19:44] <marktraceur>	 At a guess.
[17:19:54] <marktraceur>	 But I'd imagine the puppet role would set that
[17:19:55] <James_F>	 Yeah, I mean, what value should it have? :-)
[17:20:02] <marktraceur>	 Uhh
[17:20:52] <marktraceur>	 That is a fantastic question!
[17:21:08] <James_F>	 The manifest says it's a parameter.
[17:21:19] <James_F>	 But I don't know vagrant/puppet well enough to know where that'd be set, or how.
[17:22:40] <marktraceur>	 James_F: /var/3d2png
[17:24:36] <James_F>	 It should probably be moved to srv/
[17:24:39] <James_F>	 But that's by the by.
[17:25:39] <James_F>	 Aha.
[17:25:45] <James_F>	 Now I'm getting somewhere.
[17:25:58] <James_F>	 ../src/Image.h:19:21: fatal error: gif_lib.h: No such file or directory
[17:26:15] <marktraceur>	 It sounds like some of the dependencies are seriously missing
[17:26:23] <James_F>	 Yeah.
[17:26:26] <marktraceur>	 But that shouldn't have happened...
[17:26:37] <marktraceur>	 I mean, on my clean vagrant install it worked perfectly
[17:26:46] <James_F>	 Indeed. In particular, vagrant shouldn't have been under the impression that the install had worked if it didn't.
[17:26:47] <marktraceur>	 So something to do with the state of your VM maybe
[17:27:07] <James_F>	 I can vagrant destroy/up if you think it'd help?
[17:27:11] <marktraceur>	 James_F: I asked you about MW and the extension, but is your mw-vagrant up to date?
[17:27:26] <James_F>	 Yup, everything's bleeding-edge git master.
[17:27:35] <marktraceur>	 Yeah, try destroy/up and we'll see what happens
[18:41:02] <wikibugs>	 06Multimedia, 06Discovery, 06Maps, 10UploadWizard, 13Patch-For-Review: Add map widget for coordinate selection - https://phabricator.wikimedia.org/T58612#2997190 (10Deskana)
[19:29:47] <James_F>	 marktraceur: So! Bad news/worse news: On vagrant re-install it fails with "Failed at the canvas@1.6.2 install script 'node-gyp rebuild'."
[19:31:53] <James_F>	 Looks like it needs libgif-dev installed. Re-trying with that…
[19:32:25] <James_F>	 Success!
[19:32:35] <James_F>	 OK, need to add that to the vagrant manifest I guess.
[19:34:31] <marktraceur>	 Doesn't totally explain why this worked for me...
[19:34:53] <James_F>	 Did you already have libgif-dev installed for something else?
[19:34:59] <marktraceur>	 On my vagrant instance?
[19:35:03] <marktraceur>	 Not that I know of
[19:35:27] <marktraceur>	 It's mentioned in graphoid's role, but I don't think that's enabled
[19:35:41] <marktraceur>	 Negative.
[19:36:35] <James_F>	 Is it installed?
[19:38:14] <marktraceur>	 Well, it must be right
[19:38:45] <James_F>	 Anyway. Issues from playing around with it:
[19:38:52] <James_F>	 1) First go at creating any thumbnail fails with "Error generating thumbnail\n\nCould not stream the file" but then it's generated – not sure there's anything we can do to fix that?
[19:39:29] <marktraceur>	 Doesn't look like it...
[19:39:44] <marktraceur>	 James_F: I don't have libgif-dev installed on my Vagrant instance.
[19:39:53] <marktraceur>	 Gonna double check
[19:40:12] <James_F>	 2) (This is with DavidStatue.stl) The item pictured is vertical, so the thumbnails should be portrait, but they're 4:3 landscapes, which is a bit irritating.
[19:40:55] <James_F>	 3) In Special:Version the i18n isn't being picked up (odd), and perhaps we should list 3d2png in the "Installed software" section?
[19:41:28] <James_F>	 Other than that, this looks like MVP to me.
[19:41:52] <James_F>	 Would we need to add something to the ElasticSearch indexes to recognise it as a new kind of media file?
[19:44:28] <marktraceur>	 I'm not sure! I suppose it would just show up as multimedia.
[19:46:14] <James_F>	 'Cos it now has "magic" things like filetype:video.
[19:46:32] <marktraceur>	 Hm, nope, it's currently "UNKNOWN"
[19:46:44] <marktraceur>	 I suppose I should do something like add "3d" to the media types
[19:46:49] <James_F>	 OK, want me to make tasks?
[19:47:02] <James_F>	 marktraceur: I created https://gerrit.wikimedia.org/r/#/c/335853/ to add a dependency on libgif but if you think it's not needed please C-1.
[19:53:26] <James_F>	 5) Cursor in MediaViewer should change to the four-way-drag interactive thing at least.
[20:50:06] <wikibugs>	 06Multimedia, 10Wikimedia-Site-requests, 13Patch-For-Review, 15User-Urbanecm: Increase default thumb size to 250px at nowiki - https://phabricator.wikimedia.org/T155892#2958050 (10Quiddity) This is a very complex topic, that was last addressed as a whole (AFAIK) in ~2014.  IIUC (I am not a developer), the...
[20:57:46] <wikibugs>	 06Multimedia, 10Wikimedia-Site-requests, 13Patch-For-Review, 15User-Urbanecm: Increase default thumb size to 250px at nowiki - https://phabricator.wikimedia.org/T155892#2997526 (10Quiddity) >>! In T155892#2985807, @Gilles wrote: > 250px is more common than 220px, this would actually increase performance....
[20:58:57] <wikibugs>	 06Multimedia, 10Wikimedia-Site-requests, 07Community-consensus-needed, 05Goal: Increase WMF cluster default image thumb size - https://phabricator.wikimedia.org/T51357#574131 (10Volker_E) In T155892#2997519, @Quiddity gave an insightful, comprehensive statement of the connected challenges: > This is a very...
[20:59:04] <wikibugs>	 06Multimedia, 10Wikimedia-Site-requests, 13Patch-For-Review, 15User-Urbanecm: Increase default thumb size to 250px at nowiki - https://phabricator.wikimedia.org/T155892#2958050 (10Volker_E) Thanks for the comprehensive summary, @Quiddity. I've pasted your comment into T51357 and we should continue there as...
[21:04:40] <wikibugs>	 06Multimedia, 06Operations, 10Wikimedia-Site-requests, 07Performance: Choose a sensible set of thumbnail sizes for Special:Preferences - https://phabricator.wikimedia.org/T106640#2997545 (10Quiddity)
[21:04:44] <wikibugs>	 06Multimedia, 10Wikimedia-Site-requests, 07Community-consensus-needed, 05Goal: Increase WMF cluster default image thumb size - https://phabricator.wikimedia.org/T51357#2997544 (10Quiddity)
[21:46:58] <wikibugs>	 06Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1039076 (10Shonagon) Something seems  broken since today. With the [[https://www.wikidata.org/...
[23:31:33] <wikibugs>	 06Multimedia, 10MediaWiki-General-or-Unknown, 10Developer-Wishlist (2017): Make it easier to manage/deliver files created by extensions - https://phabricator.wikimedia.org/T156233#2968206 (10srishakatux) This proposal is selected for the #developer-wishlist voting round and will be added to a MediaWiki page...