[14:43:44] (03PS1) 10Matthias Mullie: jQuery 3 support: stop using .bind [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/364217 [15:05:47] 10Multimedia, 10Commons, 10MediaWiki-File-management: Don't show in file history (upload log) files uploaded after the date of a selected revision - https://phabricator.wikimedia.org/T170051#3421038 (10MarkTraceur) p:05Triage>03Low [15:06:10] 10Multimedia, 10Commons, 10MediaWiki-File-management: New versions of files appear to retain same aspect ratio as parent - https://phabricator.wikimedia.org/T170031#3421042 (10MarkTraceur) 05Open>03Resolved a:03MarkTraceur Since this doesn't seem to be an issue, I'm closing it - if there is further nec... [15:07:10] 10Multimedia, 10Commons, 10TimedMediaHandler, 10Wikimedia-Video: Thumbtime parameter for videos is broken - https://phabricator.wikimedia.org/T169445#3421048 (10MarkTraceur) p:05Triage>03Normal [15:07:55] 10Multimedia, 10MediaWiki-Core-Tests, 10TimedMediaHandler: Core tests depend on TimedMediaHandler - https://phabricator.wikimedia.org/T169258#3421050 (10MarkTraceur) p:05Triage>03Normal [15:11:18] 10Multimedia, 10Commons, 10UploadWizard: File uploads need to recognise urls on blacklist early in the process - https://phabricator.wikimedia.org/T157436#3421066 (10MarkTraceur) 05Open>03stalled Waiting for more information on tool used. [15:12:05] 10Multimedia, 10UploadWizard: upload wizard hangs up when provided URL for flicker "tag" - https://phabricator.wikimedia.org/T156255#3421072 (10MarkTraceur) p:05Triage>03Low [15:13:39] 10Multimedia, 10MediaWiki-General-or-Unknown, 10Developer-Wishlist (2017): Make it easier to manage/deliver files created by extensions - https://phabricator.wikimedia.org/T156233#3421081 (10MarkTraceur) p:05Triage>03Low [15:14:58] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Audio WebM file marked as MEDIATYPE_VIDEO - https://phabricator.wikimedia.org/T156135#2965232 (10MarkTraceur) I'll run a query to check if there's other files like this, or if some webm files have been correctly labelled as audio. [15:19:06] 10Multimedia, 10UploadWizard: UploadWizard fails with Invalid CSRF token - https://phabricator.wikimedia.org/T159005#3421108 (10MarkTraceur) 05Open>03stalled Thanks for the report, sadly without more information it's hard for us to know how to proceed - if more issues like this crop up, we will take anothe... [15:21:50] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Schema-change, and 2 others: Add img_sha256, related columns with SHA-256 hash of file - https://phabricator.wikimedia.org/T158989#3421130 (10MarkTraceur) p:05Triage>03Low [15:22:02] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Page-deletion, and 4 others: Migrate filearchive's fa_storage_key from SHA-1 to SHA-256 - https://phabricator.wikimedia.org/T158988#3421132 (10MarkTraceur) p:05Triage>03Low [15:22:58] 10Multimedia, 10GLAM-Tech, 10GlobalUsage: Include Wikidata image transclusions in GlobalUsage - https://phabricator.wikimedia.org/T158803#3421134 (10MarkTraceur) p:05Triage>03Normal [15:30:47] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10TimedMediaHandler: Audio WebM file marked as MEDIATYPE_VIDEO - https://phabricator.wikimedia.org/T156135#3421197 (10MarkTraceur) p:05Triage>03High a:03MarkTraceur I'll take a look at this, it seems like we're mislabelling some files and should f... [15:40:31] 10Multimedia, 10UploadWizard: upload wizard adds {{location}} instead of {{object location}} templates - https://phabricator.wikimedia.org/T158605#3421248 (10MarkTraceur) p:05Triage>03Low Hello all, just wanted to hop in and offer a quick thought about how to accomplish the goal of the original reporter, p... [16:54:29] brion: If you have a second, can you confirm something for me? I'm looking at https://phabricator.wikimedia.org/T156135 and as far as I can tell, there isn't really any way to distinguish between audio and video WEBM files except checking the tracks... [16:55:00] (which seems like it might be a Bad Idea somehow, and probably not very robust, and anyway I wouldn't know where to start) [17:03:55] That sounds correct, yeah [17:04:51] That's pretty much what we have to do for ogg too, though I think there's currently an awful hack for the track type check instead of a proper one [17:06:15] brion: OK, do you think it's worthwhile to check the tracks for webm the same way, or is introducing another awful hack not worthwhile [17:06:40] If doing a full header read is too tricky right now because the mime analyzer isn't easily pluggable, a hack is probably possible... [17:07:24] There should be recognizable patterns for the track type element and it's content, can check for them in the first N bytes... [17:07:32] Whether it's worth it I can't say ;) [17:07:48] Probably mainly affects the search classification [17:08:12] Which is a usability issue yeah [17:11:05] Hm okay [17:12:31] brion: If I were to look for those patterns, how would I do that? All of my googling for "webm header format" and "webm track format" has been basically fruitless, they all have kind of high-level explanations of the format but nothing about the implementation that I can use [17:13:35] Lemme do a quick doc check :) [17:14:11] OK [17:16:02] marktraceur: ok good news: the actual track type identifiers are strings \o/ [17:16:17] Yeah, I can see them, but it's not clear to me how they're denoted [17:17:18] here's a hexdump of a header of a webm with both audio and video: https://gist.github.com/brion/325386239930e4504c1d668b26e7786f the actual elements should be the strings eg A_VORBIS or V_VP8 and I believe the two bytes preceding them are the encoded element ID for the track type, as an additional guard against random comments including those strings [17:18:23] so as a rough approximation, check for (hexbyte hexbyte whatever)/A_(VORBIS|OPUS)/ or (hexbyte hexbyte)/V_(VP8|VP9)/ [17:18:36] kinda dirty but should do :D [17:19:17] OK, sounds fine... [17:21:10] brion: Looks like there are two different bytes...but the 75 6e 64 86 is the same, I think [17:24:29] Ah maybe that was the string length encoding marker [17:24:35] * brion double checks [17:27:23] yes, it's id then size then data [17:27:50] ok so should be a consistent size marker per string then, so still fairly straightforward hack >:D [17:30:56] brion: So if I'm looking for tracks...will the 75 6e 64 86 be sufficient or am I missing something in what you've said [17:31:48] * marktraceur is brand new to this binary stuff [17:35:29] marktraceur: so .... looks like the 86 is the actual marker for CodecID (the bit before is ... another element i think?). the next two bytes are the marker for string length, and then there's the string itself [17:36:02] so if you know the length marker bytes for all possible values, then just check for them :) otherwise.... try to figure out how ebml stores the length in some weird variable length integer scheme :P [17:36:10] Ah, OK [17:36:16] frickin' binary markup languages amirite [17:36:36] So I can just look for 86 85 because both of the video options are going to be the same length [17:36:44] heh that works [17:36:47] HACK [17:36:50] Hack hack hack [17:36:50] :DDD [17:36:59] #dontevenneedaloop [17:37:42] fwiw i've got some cleanup of the mime analyzer slated for later this quarter, hopefully we can make this not suck soon enough :D [17:38:37] Cool beans [17:41:27] brion: Added you to the patch, so if you're feeling brave... [17:41:47] The other thing I guess I should do is figure out how to retroactively change the MIME types [17:50:58] marktraceur: I'd recommend including the V_VP string prefix in that check, just in case of false positives on that two byte binary prefix [17:51:28] Otherwise, should work :) [17:56:47] OK [17:59:35] Done [18:00:03] Video formats...never again [18:01:39] Lol [18:01:55] * brion bane speech [21:04:21] 10Multimedia, 103d, 10Community-Liaisons (Jul-Sep 2017): Reach out to 3D communities about 3D file support on Commons - https://phabricator.wikimedia.org/T163480#3422769 (10CKoerner_WMF) [22:22:02] 10Multimedia, 10Commons, 10UploadWizard: File uploads need to recognise urls on blacklist early in the process - https://phabricator.wikimedia.org/T157436#3423035 (10Pigsonthewing) > Waiting for more information on tool used. As I said above, "I was one of the affected users, using Flickr2Commons" As I als...