[11:46:58] 10Multimedia, 10TimedMediaHandler: Transcode logging should also log the server on which the transcode process ran - https://phabricator.wikimedia.org/T185997#3930471 (10MoritzMuehlenhoff) [15:08:56] matthiasmullie: [15:08:57] * cormacparle waves [15:09:06] see this https://phabricator.wikimedia.org/T184380 [15:09:31] the js code being served via load.php doesn't seem to be the same as the code if I inspect it directly [15:09:38] any idea how that might happen? [15:10:18] 10Multimedia, 10Commons, 10UploadWizard, 10Wiki-Loves-Monuments, and 3 others: Upload Wizard ignores the description= field when using the upload campaign - https://phabricator.wikimedia.org/T184380#3930843 (10Cparle) @kaldari any idea how that might happen? [15:13:17] ehm - let me check [15:15:58] seems like load.php is serving old code, without this patch [15:16:09] yeah [15:17:30] did you ever see that happening before? [15:17:41] let's see where deployment is at right now [15:18:05] oh [15:18:47] looks like regular deployment train did not run last week, because of dev summit & all hands probably [15:19:22] and it won't be this week because of releng offsite [15:20:01] and there won't be SWAT windows either [15:21:04] 10Multimedia, 10Commons, 10UploadWizard, 10Wiki-Loves-Monuments, and 3 others: Upload Wizard ignores the description= field when using the upload campaign - https://phabricator.wikimedia.org/T184380#3881489 (10matthiasmullie) Due to last week's dev summit & this week's releng offsite, MW deployment train h... [15:21:13] so we should either ignore this for another week [15:21:37] huh [15:22:27] oh [15:22:57] reading the history in the ticket; I see that MatmaRex had scheduled it for swat last week [15:23:07] so it should've been deployed [15:23:36] yeah. i'm also looking into it now [15:23:43] it appears to have been carefully undeployed [15:25:25] weird [15:27:49] 10Multimedia, 10Commons, 10UploadWizard, 10Wiki-Loves-Monuments, and 3 others: Upload Wizard ignores the description= field when using the upload campaign - https://phabricator.wikimedia.org/T184380#3930859 (10matmarex) I don't think it's just a caching issue, it appears the patch I've gotten deployed has... [15:28:57] cormacparle: matthiasmullie: i am pretty sure i verified this after the deployment on 22 january and it was working correctly. i think someone must have accidentally rolled back UploadWizard since then. if you have deployment access, you could probably find out what version is actually running for certain [15:29:12] but it sure looks like it's the previous version [15:29:18] it does indeed [15:29:32] I don't have deployment access afaik - matthiasmullie ? [15:29:44] checking [15:32:28] looks like it was indeed deployed on 22/01: https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:32:46] "19:34 catrope@tin: Synchronized php-1.31.0-wmf.17/extensions/UploadWizard/resources/details/uw.DescriptionDetailsWidget.js: T184380 (duration: 00m 56s)" [15:35:24] puzzling [15:36:19] looks like /srv/mediawiki-staging has the correct code, but /srv/mediawiki doesn't [15:37:09] ugh [15:37:32] looks like the wrong file got synced :p [15:37:52] during the swat? [15:38:08] resources/details/uw.DescriptionsDetailsWidget.js (plural "descriptions") is the one that contains the changes [15:38:23] aha! [15:38:30] but SAL recorded a sync of resources/details/uw.DescriptionDetailsWidget.js (singular) [15:39:30] huh. whoops [15:40:06] i guess that's mostly my fault then [15:41:00] i definitely verified the deployment on mwdebug1002, but apparently not after it was deployed everywhere. or i had the files cached, or something [15:41:42] oh, that happens :) [15:42:27] sorry about this, folks [15:42:43] 10Multimedia, 10Commons, 10UploadWizard, 10Wiki-Loves-Monuments, and 3 others: Upload Wizard ignores the description= field when using the upload campaign - https://phabricator.wikimedia.org/T184380#3930871 (10matthiasmullie) It appears that the change got in, but the wrong file ended up being synced (uw.D... [15:42:55] no worries! :) [15:47:44] not at all dude! [15:47:57] so what happens next? we wait for the next swat? [15:52:30] that would be most convenient, but won't be before Monday I think [15:53:01] I could do so myself, but would have to check if ok with releng [15:53:22] I assume they wouldn't have an issue with that [15:53:39] let's discuss in standup [16:26:48] Do we have many campaigns running right now? [16:26:54] Sorry for slow response [18:48:01] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Accessibility, 10Easy, 10JavaScript: Buttons in MMV are not really buttons and are thus not semantic - https://phabricator.wikimedia.org/T161612#3137133 (10JHunterH) Hey, I'm Hunter, and I'm one of five senior CS students that are on a team wanting... [19:38:06] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Accessibility, 10Easy, 10JavaScript: Buttons in MMV are not really buttons and are thus not semantic - https://phabricator.wikimedia.org/T161612#3931884 (10Tgr) >>! In T161612#3931604, @JHunterH wrote: > Any guidance or suggestions on how to go abo... [21:32:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/406937 (owner: 10L10n-bot)