[00:20:48] (03CR) 10Brion VIBBER: [C: 04-1] "In mwembed mode, short resolution names like 'VP9 480P' are replaced in this rev with long resolution names like 'SD VP9 (480P)' which ove" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [00:28:02] Hmmm. [00:31:02] Definitely broken by that change. [00:31:54] (03CR) 10Brion VIBBER: [C: 04-1] Move all ResourceLoader vars into the TMH namespace (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [00:39:19] (03CR) 10Jforrester: Move all ResourceLoader vars into the TMH namespace (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [00:39:22] (03PS8) 10Jforrester: Move all ResourceLoader vars into the TMH namespace [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 [00:47:19] (03CR) 10Brion VIBBER: [C: 04-1] "found the bug" (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 (owner: 10Jforrester) [00:52:43] brion: Ha. [00:53:20] Yup, that fixes it. [00:53:33] (03PS9) 10Jforrester: Move all ResourceLoader vars into the TMH namespace [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454344 [00:53:59] * James_F sobs at the insanity of this code. [00:54:26] brion: The "wgTimedMediaHander" (not wgTimedMediaHand*l*er) was particularly unfortunate. :-) [00:54:40] Lol [00:54:58] Reminded of the lonely whale, destined to never be heard by anyone else. [00:55:17] Awww [00:55:38] (03PS3) 10Jforrester: Kill mw.load pointless accessor [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454893 [00:55:48] (03PS8) 10Jforrester: Drop or inline some pointless config options [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454345 (https://phabricator.wikimedia.org/T60082) [00:55:56] (03PS8) 10Jforrester: Scrap last remnants of NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 [00:55:59] (03CR) 10jerkins-bot: [V: 04-1] Drop or inline some pointless config options [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454345 (https://phabricator.wikimedia.org/T60082) (owner: 10Jforrester) [00:56:04] (03PS3) 10Jforrester: ext.tmh.transcodetable: Fix deprecated dependency on mediawiki.api.edit [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454921 [00:56:08] (03CR) 10jerkins-bot: [V: 04-1] Scrap last remnants of NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [00:56:12] (03PS3) 10Jforrester: Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 [00:56:18] (03CR) 10jerkins-bot: [V: 04-1] ext.tmh.transcodetable: Fix deprecated dependency on mediawiki.api.edit [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454921 (owner: 10Jforrester) [00:56:28] (03CR) 10jerkins-bot: [V: 04-1] Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [00:56:31] Meh. [00:57:30] It's Friday dude [00:57:46] Why are we still tilting at windmills :) [01:00:16] Fair question. I should go get some food. [01:00:20] See you later. :-) [01:05:36] * brion off to play video games :) [04:49:36] (03CR) 10Krinkle: [C: 032] Add @covers to unit tests [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455131 (owner: 10Umherirrender) [04:57:59] (03PS41) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [05:05:59] (03Merged) 10jenkins-bot: Add @covers to unit tests [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455131 (owner: 10Umherirrender) [05:58:41] (03CR) 10Legoktm: [C: 032] Use LinkRenderer to build links (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454207 (owner: 10Umherirrender) [06:17:25] (03Merged) 10jenkins-bot: Use LinkRenderer to build links [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454207 (owner: 10Umherirrender) [09:33:38] (03PS9) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [13:04:06] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10Epic, and 2 others: Deploy Structured Data on Commons baseline - https://phabricator.wikimedia.org/T194750 (10CCicalese_WMF) [13:41:13] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Page-deletion, 10Wikimedia-log-errors: Fatal error when submitting edit and deletion/undeletion on Commons from "Error: 1205 Lock wait timeout exceeded" (WikiPage::lockAndGetLatest) - https://phabricator.wikimedia.org/T197464 (10Srittau) I... [22:22:30] (03PS42) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [22:25:55] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ)