[00:12:23] (03CR) 10Catrope: [C: 032] Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [00:33:39] (03Merged) 10jenkins-bot: Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [07:17:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Use Parser::stripOuterParagraph [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/452421 (owner: 10Umherirrender) [07:24:18] (03Merged) 10jenkins-bot: Use Parser::stripOuterParagraph [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/452421 (owner: 10Umherirrender) [07:28:02] (03CR) 10jenkins-bot: Use Parser::stripOuterParagraph [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/452421 (owner: 10Umherirrender) [07:31:43] (03PS1) 10Legoktm: SpecialOrphanedTimedText: Remove some dead code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456556 [07:31:45] (03PS1) 10Legoktm: Suppress phan-taint-check warnings in job debugging [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 [07:31:48] (03PS1) 10Legoktm: Add a FIXME for double escaping [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 [07:31:51] (03PS1) 10Legoktm: Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 [07:32:16] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10WMF-Legal: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871 (10Gilles) Ah, indeed, but that's probably just an accident that an XMP field has that name. The original task description mentions ImageDesc... [07:47:29] (03CR) 10Brian Wolff: "I'm unsure if this is safe if $wgRunJobsAsync = false; $wgJobRunRate > 0 and register_postsend_function() is not available and fastcgi_fin" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [08:29:15] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Gilles can the everyday Wikipedia user such as myself help in the process of purging these PNGs? The us... [08:30:41] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Gilles) That's action=purge yes. After you've done that, you need to make sure that you clear your browser cache or to shif... [08:33:16] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Gilles I should also clarify, just as I had already said earlier, the opaque backgrounds still appear e... [08:41:53] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10WMF-Legal: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871 (10Gilles) [08:42:17] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Aklapper) >>! In T198370#4547673, @PhilipTerryGraham wrote: > @Gilles I should also clarify, just as I had already said ear... [08:48:28] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Aklapper Firefox Nightly 63.0, Windows 10 version 1803, Ctrl+F5 doesn't work either; I've been trying o... [08:50:11] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Gilles) Ah, you need to purge the file itself, not the article it appears in. I.e. https://en.wikipedia.org/wiki/File:Micro... [08:53:34] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Gilles This works! Thanks for the tip; I'll go ahead and purge as many PNGs as I can! [10:04:41] (03CR) 10Brian Wolff: [C: 032] Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 (owner: 10Legoktm) [10:06:49] (03CR) 10Brian Wolff: "I think the double escaping is correct here, so maybe it shouldn't be marked as FIXME (TMH is putting a blob of html in an attribute for l" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 (owner: 10Legoktm) [10:07:32] (03CR) 10Brian Wolff: [C: 032] SpecialOrphanedTimedText: Remove some dead code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456556 (owner: 10Legoktm) [10:08:29] 10Multimedia, 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki-Media: "Slideshow" mode for gallery doesn't look like a slideshow when editing - https://phabricator.wikimedia.org/T151471 (10Deskana) p:05Normal>03Low [10:10:49] 10Multimedia, 10VisualEditor, 10Design: Make it clear in VE (hover state?) when a media file is being dragged in that shows it will do something - https://phabricator.wikimedia.org/T115859 (10Deskana) p:05Normal>03Low [10:12:48] 10Multimedia, 10MediaWiki-Gallery, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Images in galleries are scaled up, instead of being re-fetched at the correct size - https://phabricator.wikimedia.org/T151551 (10Deskana) p:05Normal>03Low [10:12:52] 10Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10Design: Insert image in content immediately after it's uploaded, skipping the "General settings" step - https://phabricator.wikimedia.org/T115865 (10Deskana) p:05Normal>03Low [10:22:35] (03Merged) 10jenkins-bot: SpecialOrphanedTimedText: Remove some dead code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456556 (owner: 10Legoktm) [11:16:51] (03PS15) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [11:16:56] (03PS16) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [11:17:30] (03CR) 10Zoranzoki21: Fix typos in code (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:43:06] 10Multimedia, 10Thumbor, 10WMF-Blog-Social-Team, 10Patch-For-Review, 10Services (later): ThumbnailRender job fails with 429 errors - https://phabricator.wikimedia.org/T203135 (10Gilles) Indeed, I've also cross-referenced job failures that hit POOLCOUNTER_CONFIG_PER_ORIGINAL In the case I saw, the thumbn... [11:45:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix typos in code (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [12:03:11] (03Merged) 10jenkins-bot: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [12:05:06] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: Sorry, this file cannot be displayed - Error Message when clicking on image with MediaViewer enabled - https://phabricator.wikimedia.org/T203189 (10Stevensi1018) No, should I ? And how can I do it in MediaWiki to make it works? [12:08:00] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) - https://phabricator.wikimedia.org/T203189 (10Aklapper) [12:11:35] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) - https://phabricator.wikimedia.org/T203189 (10Tgr) Yeah, either [[https://enable-cors.org/server.html|enable CORS]] on your upload domain or make sur... [12:19:58] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10IKhitron) >>! In T198370#4547738, @PhilipTerryGraham wrote: > @Gilles This works! Thanks for the tip; I'll go ahead and pur... [12:34:34] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) - https://phabricator.wikimedia.org/T203189 (10Stevensi1018) I added : Header set Access-Control-Allow-Origin "*" in my apache2.conf under in the (03PS1) 10Zoranzoki21: Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) [13:55:29] (03PS2) 10Zoranzoki21: Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) [13:57:10] (03CR) 10Zoranzoki21: Fix typos in code (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:31:32] 10Multimedia, 10Thumbor, 10WMF-Blog-Social-Team, 10Patch-For-Review, 10Services (later): ThumbnailRender job fails with 429 errors - https://phabricator.wikimedia.org/T203135 (10fgiunchedi) I grepped the logs on webproxy.eqiad.wmnet and found only a single ip requesting thumbs from `upload.wikimedia.org`... [15:18:13] (03PS3) 10Thiemo Kreuz (WMDE): Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [15:18:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [15:37:39] (03Merged) 10jenkins-bot: Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [16:13:43] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) due to missing CORS - https://phabricator.wikimedia.org/T203189 (10Aklapper) 05Open>03Invalid [19:46:30] (03PS1) 10Fomafix: Start showing warning for deprecated PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456679 [20:03:06] (03PS2) 10Legoktm: Send WebVideoTranscodeJob debugging through the normal logger [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 [20:03:09] (03PS2) 10Legoktm: Suppress warning for legitimate case of double escaping [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 [20:03:12] (03PS2) 10Legoktm: Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 [20:05:10] (03CR) 10Legoktm: "OK, I'm now having it send the logs through the debug logger (totally safe), which people can manually configure to go to stdout if they w" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:06:15] (03CR) 10Jforrester: [C: 031] Send WebVideoTranscodeJob debugging through the normal logger (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:07:44] (03CR) 10Umherirrender: [C: 032] Start showing warning for deprecated PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456679 (owner: 10Fomafix) [20:17:58] (03PS18) 10Jforrester: Drop ResourceLoaderRegisterModules, scrap NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 [20:18:00] (03PS7) 10Jforrester: Move MwEmbed static resources into the static resources directory [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454922 [20:18:16] (03PS4) 10Jforrester: build: Pin stylelint to 9.2.0 as required by stylelint-config-wikimedia 0.4.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455906 [20:18:27] (03PS4) 10Jforrester: Drop duplicate NewMwEmbedSupport i18n registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455907 [20:24:31] (03CR) 10Jforrester: "PS18: Manual rebase over interceding patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [20:24:42] (03CR) 10Jforrester: "PS7: Manual rebase over interceding patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454922 (owner: 10Jforrester) [20:24:45] (03PS4) 10Jforrester: Move MwEmbed- and EmbedPlayer-related i18n to i18n/ [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455908 [20:25:07] (03CR) 10Jforrester: "PS4: Manual rebase over interceding patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455908 (owner: 10Jforrester) [20:25:15] (03PS2) 10Jforrester: .phpcs.xml: Drop exemption for now-deleted MwEmbedModules dir [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456018 [20:29:31] (03Merged) 10jenkins-bot: Start showing warning for deprecated PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456679 (owner: 10Fomafix) [20:29:47] (03CR) 10Legoktm: Send WebVideoTranscodeJob debugging through the normal logger (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:30:45] (03CR) 10Jforrester: [C: 032] Send WebVideoTranscodeJob debugging through the normal logger [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:31:42] (03CR) 10jerkins-bot: [V: 04-1] build: Pin stylelint to 9.2.0 as required by stylelint-config-wikimedia 0.4.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455906 (owner: 10Jforrester) [20:36:58] 10Multimedia, 10ContentTranslation, 10Growth-Team, 10Notifications, and 4 others: Regex DoS vulnerability in moment.js - https://phabricator.wikimedia.org/T181547 (10Petar.petkovic) [20:37:07] (03CR) 10Krinkle: [C: 031] "Untested. Code LGTM." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [20:44:36] (03CR) 10Jforrester: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455906 (owner: 10Jforrester) [20:50:01] (03Merged) 10jenkins-bot: Send WebVideoTranscodeJob debugging through the normal logger [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [21:54:06] 10Multimedia, 10Structured-Data-Commons, 10Wikidata, 10CommRel-Specialists-Support (Jul-Sep-2018), 10Multimedia-Team-Working-Board: Create a list of properties needed on Wikidata for Commons - https://phabricator.wikimedia.org/T199565 (10Keegan) 05Open>03Resolved https://commons.wikimedia.org/wiki/Co... [21:54:27] 10Multimedia, 10CommRel-Specialists-Support (Jul-Sep-2018), 10Multimedia-Team-Working-Board: Discuss first draft of Depicts with Commons - https://phabricator.wikimedia.org/T193666 (10Keegan) 05Open>03Resolved We're all done here.