[00:03:10] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/488790 (owner: 10Libraryupgrader)
[00:16:41] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Wikidata, 10Epic, and 2 others: "Depicts crawling": Add displaying/editing statements to File page - https://phabricator.wikimedia.org/T204264 (10Jdforrester-WMF)
[00:16:44] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Wikidata, 10Core Platform Team (MCR), and 3 others: Deploy Structured Data on Commons with arbitrary Statements - https://phabricator.wikimedia.org/T199352 (10Jdforrester-WMF)
[00:16:47] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Wikidata, 10Patch-For-Review: Enable federated access to entities and properties from Wikidata to Commons - https://phabricator.wikimedia.org/T214075 (10Jdforrester-WMF)
[00:17:16] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Wikidata, 10Epic, and 2 others: "Depicts crawling": Add displaying/editing statements to File page - https://phabricator.wikimedia.org/T204264 (10Jdforrester-WMF) p:05Triage→03High
[00:26:26] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/488790 (owner: 10Libraryupgrader)
[13:19:33] <wikibugs>	 10Multimedia, 10SDC General, 10Wikidata, 10CommRel-Specialists-Support (Jan-Mar-2019): Document Multilingual captions release plan - https://phabricator.wikimedia.org/T207049 (10Elitre)
[13:20:17] <wikibugs>	 10Multimedia, 10SDC General, 10Wikidata, 10CommRel-Specialists-Support (Jan-Mar-2019): Communicate multilingual captions release - https://phabricator.wikimedia.org/T205468 (10Elitre)
[14:50:00] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-FlaggedRevs, and 4 others: FlaggedRevs causes query error in LocalFile::getHistory - https://phabricator.wikimedia.org/T198687 (10CCicalese_WMF)
[15:01:59] <matthiasmullie>	 James_F: I had force-merged https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/488981 (thought there was an issue preventing jenkins from kicking off)
[15:02:21] <matthiasmullie>	 only later realized it probably wasn't kicking off because the Depends-On in wikibase hasn't been merged yet
[15:02:39] <matthiasmullie>	 so I reverted that again
[15:02:54] <matthiasmullie>	 and (revert-revert-) patch is now again up for review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/489225
[15:12:21] <James_F>	 Right. :-)
[15:14:37] <wikibugs>	 10Multimedia, 10SDC Engineering: File captions sometimes do not display - https://phabricator.wikimedia.org/T213991 (10matthiasmullie) I don't think this is a matter of parser cache getting corrupted.  Right now, I'm getting a JS notice that's essentially caused by node `.wbmi-entityview-content` not being fou...
[15:24:31] <wikibugs>	 10Multimedia, 10Analytics, 10Discovery-Search, 10Reading-Admin, and 3 others: Image Classification Working Group - https://phabricator.wikimedia.org/T215413 (10dr0ptp4kt)
[16:00:57] <wikibugs>	 10Multimedia, 10Analytics, 10Discovery-Search, 10Reading-Admin, and 3 others: Image Classification Working Group - https://phabricator.wikimedia.org/T215413 (10Miriam) @Gilles thanks for this! Images and graphics have very different underlying image statistics: it is therefore fairly easy for a classifier...
[16:03:45] <matthiasmullie>	 James_F: around?
[16:06:21] <matthiasmullie>	 not sure if you've read https://phabricator.wikimedia.org/T213991#4938361 yet
[16:06:58] <matthiasmullie>	 TL;DR: we have javascript live that expects .wbmi-entityview-content, but in parses caches of over a couple of days old, those are .filepage-mediainfo-entityview
[16:09:22] <matthiasmullie>	 I'd like to purge those caches to fix the immediate issue
[16:09:49] <matthiasmullie>	 only... that's a list of ~120k pages (that have a mediainfo slot)
[16:10:21] <matthiasmullie>	 and it's Friday night... I'm not sure how I'm supposed to feel about that
[16:11:40] <matthiasmullie>	 I'm pretty confident that purging ~120k file pages isn't really an issue (most likely aren't even cached, and won't be accessed any time soon), but still... :)
[16:13:00] <matthiasmullie>	 what's your take on this? :p
[16:30:42] <wikibugs>	 10Multimedia, 10SDC Engineering: Load depicts data into javascript on File page load - https://phabricator.wikimedia.org/T215310 (10Cparle) a:03Cparle
[17:03:36] <wikibugs>	 10Multimedia, 10Wikimedia-maintenance-script-run: Run refreshImageMetadata.php for new media type of DjVu files - https://phabricator.wikimedia.org/T215635 (10Umherirrender) p:05Triage→03Normal
[17:04:35] <wikibugs>	 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05): Index DjVu files as OFFICE instead of BITMAP? - https://phabricator.wikimedia.org/T212852 (10Umherirrender) >>! In T212852#4936669, @Ramsey-WMF wrote: > Confirmed that newly uploaded DjVu files are indexed as office. Will keep this...
[17:17:16] <James_F>	 matthiasmullie: Looking now.
[17:24:19] <matthiasmullie>	 James_F: `mwscript purgeList.php --wiki=commonswiki --purge --delay=0.05 --verbose < /home/mlitn/purge.txt` should purge all (including a ton of mediainfo pages that don't even have cache)
[17:24:29] <matthiasmullie>	 it's a ~120k page list
[17:25:10] <matthiasmullie>	 I'm happy to run it, just not sure about potential risk
[17:27:19] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/488790 (owner: 10Libraryupgrader)
[17:28:34] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/488700 (owner: 10Libraryupgrader)
[17:30:15] <wikibugs>	 10Multimedia, 10SDC Engineering: File captions sometimes do not display - https://phabricator.wikimedia.org/T213991 (10Jdforrester-WMF) We changed the name in d1738c877111e273c2c6e33b4223c640fb66a82a which just missed wmf.13; wmf.14 was deployed to Commons on Wednesday, 23 January so the Varnish cache should t...
[17:30:39] <James_F>	 matthiasmullie: Let's do it.
[17:31:03] <cormacparle_>	 birds do it, bees do it - even monkeys in the trees do it
[17:33:10] <matthiasmullie>	 James_F: who's running it - you or me?
[17:34:26] <James_F>	 matthiasmullie: What server is that file on? I can't see it on mwmaint1002, so I guess it should be you.
[17:34:53] <matthiasmullie>	 oh, that's on deploy1001
[17:35:00] <matthiasmullie>	 should probably fo to maint ^^
[17:35:02] <James_F>	 cormacparle_: How did we merge the repo into a state where extension.json refers to a file that isn't there? There are explicit tests to avoid that happening…
[17:35:24] <cormacparle_>	 oh - I think that patch is no longer necessary
[17:35:30] <James_F>	 matthiasmullie: Cool. Go ahead. Do a !log in #wikimedia-operations for awareness.
[17:35:48] <James_F>	 cormacparle_: If nothing else, we should probably disable MediaInfoEnableFilePageDepicts in master. :-)
[17:35:58] <James_F>	 But really they should be separate patches.
[17:36:09] <cormacparle_>	 ok, will abandon that one, hang on
[17:36:34] <cormacparle_>	 the answer to your question is - a forced merge, cos we thought CI was stuck
[17:36:36] <wikibugs>	 (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/488790 (owner: 10Libraryupgrader)
[17:36:37] <cormacparle_>	 but it wasn't 
[17:36:41] <cormacparle_>	 and things got screwed up
[17:36:45] <cormacparle_>	 since fixed
[17:36:49] <James_F>	 Oh.
[17:37:06] <James_F>	 CI is still broken, BTW, because Wikibase looks to have merged some breaking changes.
[17:37:26] <James_F>	 You should never ever ever force-merge a patch because now I'm going to spend most of the day fixing things. ;-)
[17:38:03] * cormacparle_ waits for Matthias to take the blame :p
[17:38:06] <James_F>	 (But https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/485183 got a real V+2 from jenkins even though it shouldn't have, so I have no idea what's going on.)
[17:38:54] <matthiasmullie>	 James_F: I believe Cormac's patch (missing JS file) was just confusion over https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/485183, which (I think) Cormac assumed to be merged (when it was not yet) when he found the file was still in there
[17:39:09] <cormacparle_>	 that's exactly it
[17:39:14] <matthiasmullie>	 the force-merge was definitely me, but unrelated to that Cormac's patch
[17:39:35] <James_F>	 Oh, just the once for the Wikibase mobile dependency?
[17:39:50] <matthiasmullie>	 I thought jenkins got stuck, but it was waiting got the dependency in wikibase (I hadn't noticed that one)
[17:39:51] <matthiasmullie>	 yeah
[17:40:20] <James_F>	 I see, it wasn't on master.
[17:40:28] <James_F>	 Sorry, gerrit sucks for answering the obvious question.
[17:41:03] <matthiasmullie>	 so basic timeline: force-merge mediainfo mobile patch; revert mediainfo mobile patch, get wikibase mbile patch merged, jenkins-merge revert-revert mediainfo mobile patch, jenkins-merge mediainfo filepage depicts patch
[17:41:34] <matthiasmullie>	 that extension.json patch is mostly unrelated - born out of the confusion of above timeline, not an actual issue
[17:41:53] <James_F>	 Yeah, all looks good from that POV. But I still think that Wikibase's patches around EntitySource are breaking us. 
[17:41:57] <James_F>	 (Yay.)
[17:42:11] <matthiasmullie>	 I know nothing about EntitySource, I promise! :p
[17:42:22] <matthiasmullie>	 (apologies for the rest of the confusion, though :))
[17:42:29] <James_F>	 No no, it's the magic stuff addshore etc. are doing to allow us to access entities properly.
[17:42:40] <James_F>	 Not our fault. Just our problem.™ ;-)
[17:42:48] <cormacparle_>	 was just talking to him about that earlier
[17:43:03] <cormacparle_>	 what's broken?
[17:43:14] <James_F>	 Yeah, he suggested we'd go live on Beta Cluster on Monday, which sounds reasonable.
[17:43:35] <James_F>	 cormacparle_: See the bottom of https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/34237/console – that looks not-good.
[17:43:54] * James_F is waiting the 20 minutes for CI to get back to him.
[17:44:16] <cormacparle_>	 ah 
[17:44:19] <cormacparle_>	 those are my tests
[17:44:22] * cormacparle_ takes a look
[17:44:55] <cormacparle_>	 hmm all passing here with the latest wikibase
[17:45:10] <James_F>	 Maybe it's a false alarm
[17:45:43] <matthiasmullie>	 James_F: /home/mlitn/purge.txt is now on mwmaint1002
[17:45:45] <matthiasmullie>	 I'm now off for dinner
[17:45:50] <matthiasmullie>	 I can run it in 20-30min
[17:45:55] <matthiasmullie>	 or you can go ahead in the meantime
[17:46:01] <James_F>	 I'll do it
[17:46:30] <cormacparle_>	 ah! that test is failing because MediaInfoEnableFilePageDepicts is false
[17:46:37] <cormacparle_>	 will put in a check
[17:46:40] <cormacparle_>	 for it
[17:46:57] <matthiasmullie>	 random page that is now broken and should be fixed after purging: https://commons.wikimedia.org/wiki/File:Lippendorf_power_station_04.jpg
[17:48:30] <wikibugs>	 10Multimedia, 10Wikimedia-maintenance-script-run: Run refreshImageMetadata.php for new media type of DjVu files - https://phabricator.wikimedia.org/T215635 (10Umherirrender) a:05Jdforrester-WMF→03None
[17:49:02] <James_F>	 cormacparle_: Ha. That explains.
[18:01:18] <cormacparle_>	 fix in for that now https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/489274
[18:01:27] <cormacparle_>	 going for dinner shortly, hope it passes CI
[18:02:35] <matthiasmullie>	 James_F: I'm back back - if you haven't already started running purge, I can now
[18:02:57] <James_F>	 matthiasmullie: It's running. Seems to be working fine.
[18:03:12] <matthiasmullie>	 ok thanks! :)
[18:03:42] <cormacparle_>	 dinner bell is ringing in my house, talk to you all Monday (waves)
[18:03:47] <James_F>	 See you!
[18:04:01] <matthiasmullie>	 ciao!
[18:04:05] <James_F>	 matthiasmullie: We can merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/489219 right? Can I remove your C-2?
[18:05:14] <matthiasmullie>	 yep, should be fine
[18:05:23] <James_F>	 We should also probably steal the no-wikitext warning from VisualEditor to avoid things like https://commons.wikimedia.org/wiki/File:Degnan%27s_Restaurant_NRHP_100001558_Mariposa_County,_CA.jpg
[18:05:51] <matthiasmullie>	 haha
[18:10:47] <matthiasmullie>	 btw, we've got ~120k files with captions so far
[18:11:25] <James_F>	 Yeah, not bad.
[18:11:30] <matthiasmullie>	 IIRC, commons gets around 500k monthly uploads? so that's about ~1/4 files
[18:11:48] <James_F>	 Do we have a task for "show the interface with tabs on file page"?
[18:11:53] <matthiasmullie>	 (that's assuming only new uploads get the captions, though...)
[18:11:57] <James_F>	 And isn't it a blocker to releasing depicts?
[18:12:05] <matthiasmullie>	 don't remember such task
[18:12:15] <matthiasmullie>	 idk if it's a blocker or not
[18:12:17] <James_F>	 Yeah, I imagine a few are edits to old images, but the majority are probably via UW.
[18:12:21] <matthiasmullie>	 and for what version it would be
[18:12:32] <James_F>	 I'll ask in chat.
[18:13:16] <matthiasmullie>	 I can imagine we might now want a separate tab until we add qualifiers as well, or it would end up having relatively little content
[18:13:20] <matthiasmullie>	 not*
[18:13:22] <matthiasmullie>	 idk
[18:13:54] <James_F>	 Hmm. Maybe? It's going to push the wikitext block even further down.
[18:14:58] <matthiasmullie>	 I imagine tabbed navigation would take up about as much space as a simple depicts without qualifiers
[18:15:03] <James_F>	 I'm just thinking about PHP-side DOM changes.
[18:15:09] <matthiasmullie>	 yeah...
[18:15:26] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10Krinkle)
[18:15:30] <James_F>	 Nah, it'll be about 30px high for just the tabs.
[18:15:30] <matthiasmullie>	 we're going to need to be more careful with that :)
[18:15:33] <James_F>	 (From the design.)
[18:16:11] <matthiasmullie>	 ok, depicts title + input field is going to be 60 or so at least
[18:16:16] <matthiasmullie>	 I retract that statement
[18:16:32] <matthiasmullie>	 but it's still not a lot of content to fill a tab with :p
[18:16:39] <James_F>	 Indeed.
[18:16:46] <matthiasmullie>	 anyway, not my decision to make!
[18:17:09] <matthiasmullie>	 ramsey and pam will have better opinions about this
[18:17:23] <James_F>	 Yup.
[18:20:36] <wikibugs>	 10Multimedia, 10SDC Engineering: Change file pages to display content in tabs, with captions and the wikitext block in the first and statements in the second - https://phabricator.wikimedia.org/T215642 (10Jdforrester-WMF) p:05Triage→03High
[18:22:59] <wikibugs>	 10Multimedia, 10SDC Engineering: Change file pages to display content in tabs, with captions and the wikitext block in the first and statements in the second - https://phabricator.wikimedia.org/T215642 (10Jdforrester-WMF)
[18:24:09] <wikibugs>	 10Multimedia, 10OOUI, 10SDC Engineering: Add a frameless design for OOUI's TabLayout, suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Jdforrester-WMF) p:05Triage→03High
[18:25:00] <wikibugs>	 10Multimedia, 10SDC Engineering: Factor out the magic for knitting together the PHP and JS side of TabLayout as built for Special:Preferences so others can use it - https://phabricator.wikimedia.org/T215645 (10Jdforrester-WMF) p:05Triage→03High
[18:34:58] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10Krinkle)
[18:35:23] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10Krinkle)
[18:39:13] <wikibugs>	 10Multimedia, 10SDC Engineering: Factor out the magic for knitting together the PHP and JS side of TabLayout as built for Special:Preferences so others can use it - https://phabricator.wikimedia.org/T215645 (10matmarex) There is no magic, just a bunch of hardcoded HTML in PreferencesFormOOUI::getBody().  I thi...
[18:39:20] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10Jdforrester-WMF) As an alternative, I proposed (to Timo...
[18:39:49] <wikibugs>	 10Multimedia, 10SDC Engineering: Factor out the hard-coded magic for knitting together the PHP and JS side of TabLayout as built for Special:Preferences so others can use it - https://phabricator.wikimedia.org/T215645 (10Jdforrester-WMF)
[18:40:30] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10jcrespo) One comment, Re: "add primary keys"- image alr...
[18:42:08] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10Krinkle) @Jdforrester-WMF Yeah, just note though, that...
[18:44:01] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10jcrespo) I am also fearful of extreme normalization, as...
[19:14:17] <wikibugs>	 10Multimedia, 10SDC Engineering: Change file pages to display content in tabs, with captions and the wikitext block in the first and statements in the second - https://phabricator.wikimedia.org/T215642 (10Jdforrester-WMF)
[19:14:48] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Wikidata, 10Epic, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22): "Depicts crawling": Add displaying/editing statements to File page - https://phabricator.wikimedia.org/T204264 (10Jdforrester-WMF)
[20:08:32] <wikibugs>	 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05): Let file captions be edited on Mobile Frontend - https://phabricator.wikimedia.org/T208993 (10PDrouin-WMF) @Jdforrester-WMF @Ramsey-WMF   I have some feedback I'd like you to consider that will make the Captions mobile experience b...
[20:29:35] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10daniel) If feasible, I'm in favor of porting the primar...
[20:43:46] <wikibugs>	 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05): Let file captions be edited on Mobile Frontend - https://phabricator.wikimedia.org/T208993 (10Ramsey-WMF) I agree with these recommendations.
[21:14:25] <wikibugs>	 10Multimedia, 10SDC General, 10Wikidata: Users may add so-called descriptions to MediaInfo entities - https://phabricator.wikimedia.org/T214692 (10daniel) The MediaInfoContent class can just override the isValid() method, call $this->getMediaInfo()->getDescriptions(), and return false of that is not empty. T...
[21:23:55] <wikibugs>	 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Code Health (TEC13)), and 2 others: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys) - https://phabricator.wikimedia.org/T28741 (10Tgr) We need the file metadata for the current version...
[21:33:42] <wikibugs>	 10Multimedia, 10SDC General, 10Wikidata, 10Patch-For-Review: Users may add so-called descriptions to MediaInfo entities - https://phabricator.wikimedia.org/T214692 (10Jdforrester-WMF) >>! In T214692#4939551, @daniel wrote: > The MediaInfoContent class can just override the isValid() method, call $this->get...