[00:30:42] (03PS1) 10Eric Gardner: Add a visual indicator to Captions/Depicts panels when in edit mode [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493344 (https://phabricator.wikimedia.org/T217256) [00:36:36] 10Multimedia, 10OOUI, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling): Add a frameless design for OOUI's TabLayout, suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10egardner) [00:47:00] (03PS2) 10Eric Gardner: Add a visual indicator to Captions/Depicts panels when in edit mode [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493344 (https://phabricator.wikimedia.org/T217256) [13:07:56] (03PS1) 10Hashar: Move up checks to test if we should construct depicts widgets [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) [13:54:53] (03CR) 10Hashar: [C: 03+2] Move up checks to test if we should construct depicts widgets [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) (owner: 10Hashar) [14:03:23] (03CR) 10jerkins-bot: [V: 04-1] Move up checks to test if we should construct depicts widgets [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) (owner: 10Hashar) [14:04:01] (03CR) 10Hashar: [C: 03+2] Move up checks to test if we should construct depicts widgets [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) (owner: 10Hashar) [14:17:59] (03PS54) 10Matthias Mullie: [WIP] Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T216536) [14:21:50] (03PS1) 10Matthias Mullie: Move message to correct module [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493414 [14:21:52] (03CR) 10jerkins-bot: [V: 04-1] Move up checks to test if we should construct depicts widgets [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) (owner: 10Hashar) [14:22:34] (03CR) 10Matthias Mullie: Display a "no results found" message in Depicts autocomplete widget (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493131 (https://phabricator.wikimedia.org/T217164) (owner: 10Eric Gardner) [14:24:15] (03CR) 10Hashar: [V: 03+2 C: 03+2] Move up checks to test if we should construct depicts widgets [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) (owner: 10Hashar) [14:24:30] (03CR) 10Hashar: [V: 03+2 C: 03+2] "Broken due to some issue with hhvm / luasandbox" [extensions/WikibaseMediaInfo] (wmf/1.33.0-wmf.19) - 10https://gerrit.wikimedia.org/r/493402 (https://phabricator.wikimedia.org/T217285) (owner: 10Hashar) [14:27:58] (03PS1) 10Matthias Mullie: Remove unused i18n messages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493416 [14:33:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Search prototype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/441040 (https://phabricator.wikimedia.org/T216536) (owner: 10Matthias Mullie) [14:41:02] (03CR) 10Matthias Mullie: [C: 03+1] "LGTM. Just need to address that styleling issue (https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/82781/console)" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [14:53:03] (03CR) 10Matthias Mullie: [C: 03+2] Add a visual indicator to Captions/Depicts panels when in edit mode [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493344 (https://phabricator.wikimedia.org/T217256) (owner: 10Eric Gardner) [15:08:50] (03Merged) 10jenkins-bot: Add a visual indicator to Captions/Depicts panels when in edit mode [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493344 (https://phabricator.wikimedia.org/T217256) (owner: 10Eric Gardner) [15:44:39] (03PS1) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) [15:48:31] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) (owner: 10Cparle) [15:50:39] (03PS2) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) [15:50:47] (03PS2) 10Ha78na: Add overflow:auto to contain css floats [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) [15:53:14] (03CR) 10Matthias Mullie: [C: 03+2] Add overflow:auto to contain css floats [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [15:54:54] (03CR) 10jerkins-bot: [V: 04-1] Add overflow:auto to contain css floats [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [15:55:13] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) (owner: 10Cparle) [16:00:39] (03CR) 10Matthias Mullie: [C: 03+2] "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [16:04:51] (03CR) 10jerkins-bot: [V: 04-1] Add overflow:auto to contain css floats [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [16:05:22] (03PS3) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) [16:06:14] (03CR) 10Ha78na: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [16:21:19] (03CR) 10jerkins-bot: [V: 04-1] Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) (owner: 10Cparle) [16:28:39] (03Merged) 10jenkins-bot: Add overflow:auto to contain css floats [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493336 (https://phabricator.wikimedia.org/T216593) (owner: 10Ha78na) [16:49:26] (03PS4) 10Cparle: Tabify file information and structured data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493432 (https://phabricator.wikimedia.org/T215645) [17:31:09] 10Multimedia: Date incompatible with the chosen license? - https://phabricator.wikimedia.org/T214426 (10Abzeronow) Yeah, Upload Wizard should definitely fix the 1923 bug since works published in the United States in 1923 are now definitely public domain. [17:44:02] (03PS1) 10Matthias Mullie: Fix errors when submitting depicts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493461 (https://phabricator.wikimedia.org/T217354) [17:58:38] (03CR) 10jerkins-bot: [V: 04-1] Fix errors when submitting depicts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493461 (https://phabricator.wikimedia.org/T217354) (owner: 10Matthias Mullie) [18:01:04] (03PS2) 10Matthias Mullie: Fix errors when submitting depicts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493461 (https://phabricator.wikimedia.org/T217354) [18:05:07] (03CR) 10jerkins-bot: [V: 04-1] Fix errors when submitting depicts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493461 (https://phabricator.wikimedia.org/T217354) (owner: 10Matthias Mullie) [18:39:14] 10Multimedia, 10GLAM, 10SDC General, 10Wiki-Loves-Monuments, and 3 others: Make UploadWizard suitable for customized 'Wiki Loves' style campaigns powered by Structured Data on Commons - https://phabricator.wikimedia.org/T215894 (10Ramsey-WMF) [18:55:40] 10Multimedia, 10SDC Engineering, 10Patch-For-Review: Adding subsections to the Licensing section causes Summary header to disappear - https://phabricator.wikimedia.org/T216593 (10Ramsey-WMF) @matthiasmullie when is this expected to hit Beta? [19:01:13] 10Multimedia, 10SDC Engineering, 10Patch-For-Review: Adding subsections to the Licensing section causes Summary header to disappear - https://phabricator.wikimedia.org/T216593 (10matthiasmullie) It already is on beta. And will hit production next Wed. [19:01:37] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/493461 (https://phabricator.wikimedia.org/T217354) (owner: 10Matthias Mullie) [20:21:14] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10Reedy) Looks to have been there since 1.16 :) https://github.com/wikimedia/mediawiki/commit/3e4467422987e4214e563... [20:23:26] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10BPirkle) a:05BPirkle→03Hknust [20:24:12] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Phase out deprecated Title::isValidMoveTarget - https://phabricator.wikimedia.org/T214317 (10BPirkle) a:05BPirkle→03Hknust [20:24:52] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Phase out deprecated Title::isValidMoveTarget - https://phabricator.wikimedia.org/T214317 (10Reedy) [20:48:32] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10Tgr) > More specifically, the stable part of the PHP API is comprised of all code that is explicitly marked public... [21:44:19] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10holger.knust) I removed Title::validateFileMoveOperation and also removed the test comment saying the method was c... [21:48:12] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10Reedy) >>! In T214316#4992560, @holger.knust wrote: > I removed Title::validateFileMoveOperation and also removed... [21:52:37] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 3 others: Remove unused method Title::validateFileMoveOperation - https://phabricator.wikimedia.org/T214316 (10holger.knust) Looks like it. :) I removed the comment but left the actual test case since that should be covered b... [21:55:13] 10Multimedia, 10SDC Engineering, 10Patch-For-Review: Adding subsections to the Licensing section causes Summary header to disappear - https://phabricator.wikimedia.org/T216593 (10Ramsey-WMF) Tested on Beta. Seems to work. Will test again on production. [22:46:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/493594 (owner: 10L10n-bot) [23:07:32] (03CR) 10Ha78na: Only enable submit button when there have been changes (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/492976 (https://phabricator.wikimedia.org/T216454) (owner: 10Matthias Mullie)