[12:41:32] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Thumbor: PNG thumbnail looks significantly blurrier than JPG thumbnail - https://phabricator.wikimedia.org/T192744 (10Jeff_G) [12:54:58] 10Multimedia: Depicts form incorrect state - https://phabricator.wikimedia.org/T219151 (10Cparle) [12:58:11] (03CR) 10Cparle: "Code looks ok to me, but noticed this:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) (owner: 10Matthias Mullie) [12:58:22] (03CR) 10Cparle: [C: 04-1] Add new metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) (owner: 10Matthias Mullie) [13:38:21] (03CR) 10Matthias Mullie: "This change is ready for review." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [13:57:44] (03PS1) 10Matthias Mullie: Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) [13:59:39] 10Multimedia, 10Patch-For-Review: Depicts form incorrect state - https://phabricator.wikimedia.org/T219151 (10matthiasmullie) a:03matthiasmullie [14:00:21] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review: Depicts form incorrect state - https://phabricator.wikimedia.org/T219151 (10matthiasmullie) [14:07:49] (03CR) 10jerkins-bot: [V: 04-1] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [14:16:23] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [14:24:59] (03PS6) 10Ha78na: WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [14:25:47] (03CR) 10jerkins-bot: [V: 04-1] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [14:31:56] (03CR) 10Matthias Mullie: "* If I upload 2 images at once, "own work", no captions, no categories - the metadata page comes up blank" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) (owner: 10Matthias Mullie) [14:34:51] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [14:40:00] 10Multimedia, 10SDC-Depicts (Depicts-Walking): Add 'metadata' step to UploadWizard EventLogging schemas - https://phabricator.wikimedia.org/T219166 (10matthiasmullie) [14:41:33] (03CR) 10Cparle: [C: 04-1] "> Patch Set 21:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) (owner: 10Matthias Mullie) [14:48:11] (03CR) 10Matthias Mullie: "* Shouldn't there be a temporary feature flag for the new step?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/471919 (https://phabricator.wikimedia.org/T215304) (owner: 10Matthias Mullie) [15:18:04] 10Multimedia, 10SDC Design: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10PDrouin-WMF) [15:18:08] 10Multimedia, 10SDC Design: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10PDrouin-WMF) [15:36:54] 10Multimedia, 10UploadWizard: UploadWizard Flickr on Wikimedia Commons should use HTTPS in the Source URL - https://phabricator.wikimedia.org/T219168 (10JeanFred) [15:40:50] (03PS1) 10Jean-Frédéric: Use HTTPS in Flickr source URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498918 (https://phabricator.wikimedia.org/T219168) [15:58:34] (03CR) 10Cparle: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [15:59:20] (03CR) 10Cparle: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [16:08:50] (03CR) 10jerkins-bot: [V: 04-1] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [16:10:27] (03CR) 10jerkins-bot: [V: 04-1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [16:13:47] 10Multimedia, 10SDC Design: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10PDrouin-WMF) [16:14:25] 10Multimedia, 10SDC Design: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10PDrouin-WMF) [16:14:57] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, and 2 others: Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10Ha78na) [16:19:08] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Cparle) [16:22:33] (03PS1) 10Cparle: Remove blank translations [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498935 [16:24:12] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Cparle) a:03Cparle [16:24:39] (03CR) 10Matthias Mullie: "also need to remove in qqq" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498935 (owner: 10Cparle) [16:25:55] (03PS2) 10Cparle: Remove blank translations [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498935 [16:30:28] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10PDrouin-WMF) [16:34:52] (03CR) 10jerkins-bot: [V: 04-1] Remove blank translations [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498935 (owner: 10Cparle) [16:35:26] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 3 others: Match the spacings and paddings with the design spec - https://phabricator.wikimedia.org/T216773 (10Ramsey-WMF) p:05Triage→03High [16:39:28] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review: Depicts form incorrect state - https://phabricator.wikimedia.org/T219151 (10Ramsey-WMF) p:05Triage→03High [16:39:56] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Depicts (Depicts-Crawling): Depicts form incorrect state - https://phabricator.wikimedia.org/T219151 (10Ramsey-WMF) [16:46:21] (03CR) 10Matthias Mullie: [V: 03+2 C: 03+2] Remove blank translations [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498935 (owner: 10Cparle) [16:47:03] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Core Platform Team (MCR), and 4 others: MCR: Include all slots in XML dumps - https://phabricator.wikimedia.org/T174031 (10ArielGlenn) Page content dumps are broken on beta; all new page content (anything not prefetched out of the previosu dump file, but reque... [16:47:22] 10Multimedia, 10SDC Engineering, 10SDC-Depicts (Depicts-and-Other-Statements-on-a-Bicycle): Configure beta commons properties for 'bicycle' release (with qualifiers) - https://phabricator.wikimedia.org/T219181 (10Cparle) [16:47:41] 10Multimedia, 10SDC Engineering, 10SDC-Depicts (Depicts-and-Other-Statements-on-a-Bicycle): Configure beta commons properties for 'bicycle' release (with qualifiers) - https://phabricator.wikimedia.org/T219181 (10Cparle) [16:48:29] (03PS7) 10Ha78na: WIP: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [16:49:36] (03PS1) 10Matthias Mullie: Remove use of removed messages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498939 [16:49:47] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Depicts (Depicts-Crawling): Configure beta commons properties - https://phabricator.wikimedia.org/T217153 (10Cparle) 05Open→03Resolved Closing - separate ticket T219181 raised for $wgDepictsQualif... [16:50:24] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Cparle) a:05Cparle→03None [16:53:28] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Ramsey-WMF) p:05Triage→03High a:03egardner [16:54:02] (03CR) 10Cparle: [C: 03+2] Remove use of removed messages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498939 (owner: 10Matthias Mullie) [16:54:33] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Multilingual Captions: When user updates their babel settings, change is not reflected on pages until logout - https://phabricator.wikimedia.org/T210874 (10egardner) a:05egardner→03None [16:56:09] (03CR) 10Eric Gardner: WIP: Refactor panel styles to use LESS features, Flexbox (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [16:57:46] Moving discussion here for missing SD on beta-commons - CC cormacparle_ et al. [16:58:10] (03CR) 10Jdlrobson: [C: 04-1] "There is some eslint issues and some issues with the old style tests in jquery.wikibase.grammaticalfeatureview and wikibase.lexeme.widgets" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [16:58:17] * cormacparle_ waves [16:58:53] (03CR) 10jerkins-bot: [V: 04-1] Remove use of removed messages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498939 (owner: 10Matthias Mullie) [16:59:41] (03CR) 10Matthias Mullie: [V: 03+2] Remove use of removed messages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498939 (owner: 10Matthias Mullie) [16:59:45] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 4 others: Phase out deprecated Title::isValidMoveTarget - https://phabricator.wikimedia.org/T214317 (10greg) Just to check, what I gathered from the Scrum of Scrums notice last week is that this is blocked on the removal of t... [17:00:00] I'm getting 2 js errors in the console [17:00:11] Error: "Unknown dependency: wikibase.experts.Lexeme" [17:00:20] ReferenceError: injectSpinner is not defined [17:00:45] logged out I can see the SD on this page https://commons.wikimedia.beta.wmflabs.org/wiki/File:Virtual_dog_2.jpg ... but the js errors are preventing the tabs from working [17:00:50] (I'm guessing) [17:06:36] I think addshore loaded that page logged-in so the cache may have it still? [17:06:42] Sigh interlocking dependencies [17:08:18] (03CR) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [17:12:29] (03CR) 10Jdlrobson: Refactor Filepage module with require() statements and headless testing (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [17:20:25] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use HTTPS in Flickr source URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498918 (https://phabricator.wikimedia.org/T219168) (owner: 10Jean-Frédéric) [17:22:48] sorry marktraceur [17:22:50] got distracted [17:22:54] No problem [17:22:54] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: The panels should use column width (60%) instead of spanning across the entire screen - https://phabricator.wikimedia.org/T216772 (10Ha78na) Updates screenshots including work from T216773 (and in person design-dev pai... [17:22:58] which cache do you mean? [17:23:16] parser cachce? [17:23:19] cormacparle_: Parser cache maybe? Honestly I'm a little confused as to how this could be happening [17:23:20] Yeah [17:23:33] Parsing works logged in, parser cache saves it for logged-out users too [17:23:58] Which points to a problem we have in our hooks or a problem with MCR stuff [17:24:19] can you give me an example page with SD missing entirely? [17:24:39] https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test-1438714531.892466.png [17:26:10] (03PS8) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [17:29:39] (03Merged) 10jenkins-bot: Use HTTPS in Flickr source URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498918 (https://phabricator.wikimedia.org/T219168) (owner: 10Jean-Frédéric) [17:31:21] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Make button placement for Captions consistent with Depicts/statements - https://phabricator.wikimedia.org/T218951 (10egardner) Happy to work on this once the patch for [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/4982... [17:32:21] who, it's even when I purge it [17:32:29] wtf [17:32:39] cormacparle_: Logged in or out? [17:32:45] out [17:32:48] Hm [17:33:02] So yeah, not just random cache problems, something's wrong with logged out parsing [17:33:55] 10Multimedia, 10UploadWizard, 10Patch-For-Review: UploadWizard Flickr on Wikimedia Commons should use HTTPS in the Source URL - https://phabricator.wikimedia.org/T219168 (10matmarex) 05Open→03Resolved [17:35:57] (03CR) 10jerkins-bot: [V: 04-1] Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [17:36:07] (03CR) 10jenkins-bot: Use HTTPS in Flickr source URLs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498918 (https://phabricator.wikimedia.org/T219168) (owner: 10Jean-Frédéric) [17:41:04] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Make button placement for Captions consistent with Depicts/statements - https://phabricator.wikimedia.org/T218951 (10Ha78na) ^ simply blocked till CSS refactor merges [17:42:40] yeah, there might be something up with some of the regexes we introduced recently into the hooks [17:42:49] digging [17:53:12] (03CR) 10Jean-Frédéric: "Thanks for reviewing and merging this! :-)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/498918 (https://phabricator.wikimedia.org/T219168) (owner: 10Jean-Frédéric) [17:53:17] cormacparle_: Cool, let me know if you find anything or if you need to hand off [17:55:33] (03PS9) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [18:03:53] (03PS10) 10Ha78na: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [18:04:00] (03CR) 10Eric Gardner: "> Patch Set 12: Code-Review-1" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [18:13:50] ok, dinner's on the table now so gotta go ... [18:14:03] (03CR) 10jerkins-bot: [V: 04-1] Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [18:14:15] I can't see how the source of this doesn't have a tag in it https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test-1438714531.892466.png [18:14:18] even after purging [18:14:36] unless the page is a redirect, which doesn't make any sense [18:15:32] marktraceur: you may wish to note the above ^ :) [18:15:41] cormacparle_: Would tidy tear that out since it's not a valid HTML tag? [18:15:53] And/or it means the MCR stuff is borked [18:16:14] yeah [18:17:03] but the tag IS here view-source:https://commons.wikimedia.beta.wmflabs.org/wiki/File:Virtual_dog_2.jpg [18:17:39] so I don't see how it could be either tidy OR MCR :/ [18:17:54] I don't see a mediaInfoView tag there [18:18:06] sorry, it's lowercase - mediainfoview [18:18:13] regexes are all /i [18:18:35] Still don't see that - maybe it got re-parsed somewhere [18:18:59] really?? [18:19:07] Yeah not in the view-source [18:19:10] I'm logged out [18:19:12] I see the tabs on the page now [18:19:17] Oh, I'll try logged out [18:19:19] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-Decoupling, and 4 others: Phase out deprecated Title::isValidMoveTarget - https://phabricator.wikimedia.org/T214317 (10holger.knust) Yes, currently on hold until T216089 is merged. [18:19:24] wtf [18:19:30] There we go [18:19:32] could we be connecting to different servers? [18:19:42] Cache servers? I don't think that's how that works [18:19:43] ah ok cool [18:19:49] But could be, on the beta cluster [18:19:57] This is so weird. Like, from all angles. [18:20:07] (03CR) 10Jdlrobson: [C: 04-1] "The unit tests that are failing are running in http://localhost:8888/w/index.php/Special:JavaScriptTest/qunit/plain" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [18:20:13] 10Multimedia: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10Ramsey-WMF) [18:20:19] yeah [18:20:25] But if the mediainfoview tag is still there then the regex must not be doing its business [18:20:35] yes! [18:20:50] Which brings me back to WTF, but okay, at least it's a hint [18:21:16] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10Ramsey-WMF) p:05Triage→03Normal [18:21:42] anyway, look - gotta go eat and do the evening's chores [18:21:53] if it's not been solved overnight I'll be back on it in the morn [18:21:54] Yeah, no problem, I'll dig a little more [18:21:59] 👍 [18:44:16] James_F: I don't know if you're on SDC mode today but if you have a minute to look at beta today it would be a help...I'm having trouble figuring out what might be causing it [18:46:05] marktraceur: OK, was just about to change config for federation anyway. :-) [18:46:11] Cool cool [18:46:39] James_F: There's a bit of chat above but basically logged-out parsing doesn't seem to include structured data stuff - mediainfoview tags are present in the view-source [18:47:23] Hmm. Bad sign. [18:47:28] I'd say so [18:47:33] Hopefully it doesn't affect the train [18:48:00] Best case is it's a beta config issue [18:54:36] (03PS13) 10Eric Gardner: Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) [19:01:23] Hmm, well, I found one issue but it wasn't that one. [19:01:29] Meeting now, more checking afterwards. [19:01:36] Cool [19:03:46] (03CR) 10jerkins-bot: [V: 04-1] Refactor Filepage module with require() statements and headless testing [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/495167 (https://phabricator.wikimedia.org/T216229) (owner: 10Eric Gardner) [19:07:52] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10egardner) Some questions about the behavior of this element: - Should the user be able to dismiss this notice by clickin... [19:37:00] OK, so this is interesting. It's definitely broken server-side, not client side. [19:38:30] James_F: Yeah, certainly [19:45:22] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo: SDC file page rendering is broken for logged-out users on beta cluster (possible train blocker) - https://phabricator.wikimedia.org/T219221 (10Jdforrester-WMF) [19:47:27] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo: SDC file page rendering is broken for logged-out users on beta cluster (possible train blocker) - https://phabricator.wikimedia.org/T219221 (10Jdforrester-WMF) Possible train-blocker if this breaks non-statement display too. [20:04:20] (03CR) 10Jforrester: [C: 03+2] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [20:13:13] 10Multimedia, 10SDC Engineering, 10SDC-Depicts (Depicts-Walking): Add feature flag to enable/disable metadata step - https://phabricator.wikimedia.org/T217024 (10Jdforrester-WMF) [20:14:05] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10egardner) This ended up being pretty straightforward, since we can rely on existing functionality. Here's a screenshot:... [20:19:14] (03PS1) 10Eric Gardner: Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) [20:23:28] (03CR) 10jerkins-bot: [V: 04-1] Disable adding new statements while they're being submitted [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498868 (https://phabricator.wikimedia.org/T219151) (owner: 10Matthias Mullie) [20:29:14] (03CR) 10jerkins-bot: [V: 04-1] Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [21:18:15] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Wikidata-Campsite, and 2 others: Federated remote entities in diffs show as deleted - https://phabricator.wikimedia.org/T218921 (10Jdforrester-WMF) Update: I tried disabling "old style" federation, and it immediately and totally broke (PHP fatal, "No entity so... [21:38:17] (03CR) 10Ha78na: [C: 03+1] Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [22:07:26] (03CR) 10Jforrester: [C: 04-1] "We should probably re-use the standard Legal-approved text from MediaWiki, `anoneditwarning`, rather than adding our own duplicate, which " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [22:13:09] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10Ha78na) So that warning is the browser default when you unload a window - actual implementation will just use a simple alert.... [22:18:41] (03PS1) 10Ha78na: Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) [22:28:20] (03CR) 10jerkins-bot: [V: 04-1] Add close confirm alert when canceling un-saved SDC content [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499004 (https://phabricator.wikimedia.org/T219197) (owner: 10Ha78na) [22:32:43] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10Ramsey-WMF) gonna ping @PDrouin-WMF for opinion on whether the wording for our stuff needs to be different... [22:33:26] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Patch-For-Review: SDC file page rendering is broken for logged-out users on beta cluster (possible train blocker) - https://phabricator.wikimedia.org/T219221 (10Jdforrester-WMF) Confirmed that this isn't a train blocker; it'll break on TestCommons but... [22:33:35] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo: SDC file page rendering is broken for logged-out users on beta cluster - https://phabricator.wikimedia.org/T219221 (10Jdforrester-WMF) [22:49:57] (03PS2) 10Eric Gardner: Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) [22:57:13] (03CR) 10jerkins-bot: [V: 04-1] Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [23:04:33] (03CR) 10Jforrester: [C: 03+2] Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [23:14:23] (03CR) 10jerkins-bot: [V: 04-1] Warn anonymous editing users that their IP will be logged [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498986 (https://phabricator.wikimedia.org/T218628) (owner: 10Eric Gardner) [23:16:23] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Show "changes you made may not be saved" alert for structured data fields - https://phabricator.wikimedia.org/T219197 (10PDrouin-WMF) I agree with @Ha78na - "Discard changes?" is more clear. [23:34:09] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): [Insert issue here] - https://phabricator.wikimedia.org/T219244 (10Ramsey-WMF) [23:37:37] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Change "Make primary" to "Mark as prominent" - https://phabricator.wikimedia.org/T219244 (10Ramsey-WMF) p:05Triage→03High [23:38:53] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Depicts (Depicts-Crawling): Change "Make primary" to "Mark as prominent" - https://phabricator.wikimedia.org/T219244 (10Ramsey-WMF) Pinging @Cparle or @matthiasmullie to do this one quickly before we start opening up beta testing to a larger... [23:41:32] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Change "Office" in the new Commons search bar drop down to "Documents" - https://phabricator.wikimedia.org/T219245 (10Ramsey-WMF) [23:42:24] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Change "Office" in the new Commons search bar drop down to "Documents" - https://phabricator.wikimedia.org/T219245 (10Ramsey-WMF) p:05Triage→03Low [23:49:23] (03PS1) 10Jforrester: i18n: Change "Make primary" to "Mark as prominent" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) [23:49:26] (03PS1) 10Jforrester: Rename CSS classes to match new primary->prominent nomenclature [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499021 [23:49:29] (03PS1) 10Jforrester: i18n: Drop old 'primary' i18n, no longer used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499022 [23:49:32] (03PS1) 10Jforrester: Drop B/C 'primary' CSS classes, cache will have expired [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499023 [23:54:23] (03PS1) 10Jforrester: i18n: Change "Office" to "Documents" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499027 (https://phabricator.wikimedia.org/T219245) [23:58:46] (03CR) 10jerkins-bot: [V: 04-1] i18n: Drop old 'primary' i18n, no longer used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499022 (owner: 10Jforrester) [23:59:17] (03CR) 10jerkins-bot: [V: 04-1] i18n: Change "Make primary" to "Mark as prominent" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499020 (https://phabricator.wikimedia.org/T219244) (owner: 10Jforrester) [23:59:41] (03CR) 10jerkins-bot: [V: 04-1] Rename CSS classes to match new primary->prominent nomenclature [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499021 (owner: 10Jforrester)