[01:14:07] (03PS21) 10Eric Gardner: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) [07:30:03] 10Multimedia, 10StructuredDataOnCommons, 10UploadWizard, 10Multimedia-Current-Work: During UploadWizard process, issue with Captions blocked the process - https://phabricator.wikimedia.org/T219677 (10matthiasmullie) [07:30:26] 10Multimedia, 10UploadWizard, 10Multimedia-Current-Work: Flickr UploadWizard fails to fetch thumbnails - https://phabricator.wikimedia.org/T219679 (10matthiasmullie) [07:38:01] (03PS1) 10Matthias Mullie: Don't attempt to iterate on non-existing key [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 [07:41:29] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10matthiasmullie) Confirmed, same issue as T219540. I'll move this back to QA once https://gerrit.wikimedia.org/r/c/mediawiki/ex... [07:52:45] (03PS1) 10Matthias Mullie: Don't error on copyrighted works from 1923 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) [07:52:47] (03PS2) 10Matthias Mullie: Don't error on copyrighted works from 1923 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) [07:53:18] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review: Date incompatible with the chosen license? - https://phabricator.wikimedia.org/T214426 (10matthiasmullie) a:03matthiasmullie [08:00:51] (03PS3) 10Matthias Mullie: Don't error on copyrighted works from 1923 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) [08:01:35] 10Multimedia, 10Commons, 10UploadWizard, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 2 others: Need to change year to 1924 for public domain images in Wikimedia Commons Upload Wizard? - https://phabricator.wikimedia.org/T217845 (10matthiasmullie) [08:01:51] 10Multimedia, 10Commons, 10UploadWizard, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), and 2 others: Need to change year to 1924 for public domain images in Wikimedia Commons Upload Wizard? - https://phabricator.wikimedia.org/T217845 (10matthiasmullie) [08:18:54] (03PS3) 10Matthias Mullie: Do not toggle 'primary' onclick while form is submitting [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500476 (https://phabricator.wikimedia.org/T219515) (owner: 10Cparle) [08:20:00] (03CR) 10Matthias Mullie: [C: 03+2] "Just updated to use OOUI's built-in setDisabled rather than containingFormIsSubmitting" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500476 (https://phabricator.wikimedia.org/T219515) (owner: 10Cparle) [08:22:44] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Clicking 'make prominent' while depicts form is submitting gets the form into a weird state - https://phabricator.wikimedia.org/T219515 (10matthiasmullie) a:05Cparle→03Edtadros [08:33:41] (03CR) 10Matthias Mullie: "recheck" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [08:39:17] (03CR) 10Matthias Mullie: "(The only *actual* thing that needs fixing is the one in DepictsWidget.js - the others are just random feedback)" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [08:50:20] (03Merged) 10jenkins-bot: Do not toggle 'primary' onclick while form is submitting [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500476 (https://phabricator.wikimedia.org/T219515) (owner: 10Cparle) [08:51:32] (03CR) 10jenkins-bot: Do not toggle 'primary' onclick while form is submitting [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500476 (https://phabricator.wikimedia.org/T219515) (owner: 10Cparle) [10:06:10] (03CR) 10Matthias Mullie: [C: 03+1] "(Updated an earlier comment that was invalid; as far as I'm concerned, this is good to go once rebased)" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [10:36:56] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-PdfHandler: Make mw-filepage-resolutioninfo link to both .png and .jpg thumbnails - https://phabricator.wikimedia.org/T219863 (10Incnis_Mrsi) [13:03:19] (03CR) 10Thiemo Kreuz (WMDE): Don't attempt to iterate on non-existing key (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 (owner: 10Matthias Mullie) [13:26:09] (03PS1) 10Matthias Mullie: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 [13:26:12] (03PS1) 10Matthias Mullie: Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) [13:26:26] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) Added a patch that simply adds a little whitespace between multiple statement groups. {F28560975} Do we need to do a... [13:29:54] (03PS2) 10Matthias Mullie: Don't attempt to iterate on non-existing key [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 [13:30:11] (03CR) 10Matthias Mullie: Don't attempt to iterate on non-existing key (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 (owner: 10Matthias Mullie) [13:47:55] (03CR) 10jerkins-bot: [V: 04-1] Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [13:48:34] (03CR) 10jerkins-bot: [V: 04-1] Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) (owner: 10Matthias Mullie) [13:55:09] (03PS2) 10Matthias Mullie: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 [13:55:48] (03CR) 10Matthias Mullie: [C: 03+1] "Will merge later today, after branch cut." (0311 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [13:56:02] (03PS22) 10Matthias Mullie: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [13:58:12] (03CR) 10Ha78na: [C: 03+1] "Good catch, I didn't realize there was more to this." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) (owner: 10Matthias Mullie) [13:58:32] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: API call in new search bar not working - https://phabricator.wikimedia.org/T219540 (10matthiasmullie) a:05matthiasmullie→03Edtadros [14:03:34] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review: Date incompatible with the chosen license? - https://phabricator.wikimedia.org/T214426 (10matthiasmullie) [14:09:01] 10Multimedia, 10SDC Engineering: P and Q links don't display wikidata icon - https://phabricator.wikimedia.org/T219872 (10matthiasmullie) [14:09:23] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): P and Q links don't display wikidata icon - https://phabricator.wikimedia.org/T219872 (10matthiasmullie) [14:17:01] (03CR) 10jerkins-bot: [V: 04-1] Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [14:18:29] (03PS1) 10Ladsgroup: Cahnge MediaInfoHandler to use EntityTermStoreWriter [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500749 (https://phabricator.wikimedia.org/T219296) [14:19:30] (03PS2) 10Ladsgroup: Change MediaInfoHandler to use EntityTermStoreWriter [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500749 (https://phabricator.wikimedia.org/T219296) [14:26:10] (03PS2) 10Ha78na: Order of depicts statements sorted by prominence on publish [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) [14:26:23] (03CR) 10jerkins-bot: [V: 04-1] Order of depicts statements sorted by prominence on publish [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [14:29:27] (03CR) 10jerkins-bot: [V: 04-1] Change MediaInfoHandler to use EntityTermStoreWriter [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500749 (https://phabricator.wikimedia.org/T219296) (owner: 10Ladsgroup) [14:36:20] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10PDrouin-WMF) Adding a little whitespace between multiple statement groups (until they're fully supported) works for me. I believe @R... [14:36:37] (03PS3) 10Matthias Mullie: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 [14:40:53] (03PS3) 10Ha78na: Order of depicts statements sorted by prominence on publish [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) [14:41:58] (03CR) 10Ha78na: Order of depicts statements sorted by prominence on publish (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [14:50:05] 10Multimedia: [Spike] Explore the customization options for Advanced Search extension - https://phabricator.wikimedia.org/T219878 (10PDrouin-WMF) [14:55:18] (03CR) 10Ha78na: Refactor panel styles to use LESS features, Flexbox (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [15:04:12] (03PS4) 10Matthias Mullie: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 [15:07:05] (03PS2) 10Matthias Mullie: Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) [15:07:46] (03CR) 10Jforrester: [C: 03+2] Don't attempt to iterate on non-existing key [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 (owner: 10Matthias Mullie) [15:24:20] (03CR) 10jerkins-bot: [V: 04-1] Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [15:25:08] (03CR) 10Matthias Mullie: Order of depicts statements sorted by prominence on publish (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [15:25:50] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [15:28:11] (03CR) 10Jforrester: [C: 03+2] "Let's hope we don't get "reform" that means we need to lengthen this further." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) (owner: 10Matthias Mullie) [15:48:57] (03PS4) 10Ha78na: Order of depicts statements sorted by prominence on publish [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) [15:49:59] (03Merged) 10jenkins-bot: Don't attempt to iterate on non-existing key [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 (owner: 10Matthias Mullie) [15:50:47] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Ramsey-WMF) Yes. Pam and I chatted about this recently and threw around a few ideas. We could: # Hide the unsupported elements in... [15:51:07] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Ramsey-WMF) [15:52:27] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-on-training-wheels): [Spike] Explore the customization options for Advanced Search extension - https://phabricator.wikimedia.org/T219878 (10Ramsey-WMF) p:05Triage→03Normal [15:53:40] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-on-training-wheels): [Spike] Explore the customization options for Advanced Search extension - https://phabricator.wikimedia.org/T219878 (10Ramsey-WMF) Thoughts on this one, @Cparle ? [15:53:58] (03CR) 10Ha78na: Order of depicts statements sorted by prominence on publish (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [15:54:46] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): P and Q links don't display wikidata icon - https://phabricator.wikimedia.org/T219872 (10Ramsey-WMF) p:05Triage→03Normal [15:56:28] (03CR) 10jenkins-bot: Don't attempt to iterate on non-existing key [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500662 (owner: 10Matthias Mullie) [15:57:24] 10Multimedia, 10Multimedia-Current-Work: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10Ramsey-WMF) p:05Triage→03Normal [15:57:33] (03PS1) 10Cparle: Put panel initialisation inside hooks [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500772 (https://phabricator.wikimedia.org/T218922) [16:05:29] (03PS1) 10Matthias Mullie: Change input example [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500774 [16:06:57] (03CR) 10MarkTraceur: [C: 03+2] Change input example [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500774 (owner: 10Matthias Mullie) [16:07:58] (03CR) 10Matthias Mullie: [C: 03+2] Order of depicts statements sorted by prominence on publish (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [16:18:40] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Multimedia-Current-Work, and 2 others: SDC: The tabs end up in the wrong place in "view" non-view pages like diffs - https://phabricator.wikimedia.org/T218922 (10Cparle) @Edtadros >> compare versions, and on the diff page th... [16:25:47] (03Merged) 10jenkins-bot: Don't error on copyrighted works from 1923 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) (owner: 10Matthias Mullie) [16:29:13] (03CR) 10jerkins-bot: [V: 04-1] Put panel initialisation inside hooks [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500772 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [16:32:32] (03CR) 10jenkins-bot: Don't error on copyrighted works from 1923 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500664 (https://phabricator.wikimedia.org/T214426) (owner: 10Matthias Mullie) [16:33:29] 10Multimedia, 10Commons, 10GLAM-Tech, 10SDC General, and 2 others: [Epic] Store media information for files on Wikimedia Commons as structured data - https://phabricator.wikimedia.org/T68108 (10jcrespo) I've been told wikibase tables have been created on s4. We would like to have been notified of this- we... [16:45:43] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: API call in new search bar & UploadWizard not working - https://phabricator.wikimedia.org/T219540 (10matthiasmullie) [16:46:16] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 4 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10matthiasmullie) [16:47:34] (03Merged) 10jenkins-bot: Change input example [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500774 (owner: 10Matthias Mullie) [16:48:03] (03Merged) 10jenkins-bot: Order of depicts statements sorted by prominence on publish [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [16:48:34] (03CR) 10jenkins-bot: Change input example [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500774 (owner: 10Matthias Mullie) [16:49:43] (03CR) 10jenkins-bot: Order of depicts statements sorted by prominence on publish [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500512 (https://phabricator.wikimedia.org/T219292) (owner: 10Ha78na) [16:52:35] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): [DO THIS FIRST] Auto-suggest widget that returns P-items limited to 1 or more data types - https://phabricator.wikimedia.org/T219378 (10Cparle) [16:59:34] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) a:05Ramsey-WMF→03matthiasmullie [17:06:18] (03CR) 10Cparle: [C: 03+2] Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [17:12:57] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10Jdforrester-WMF) >>! In T218628#5075311, @PDrouin-WMF wrote: > @Jdforreste... [17:16:25] 10Multimedia, 10Multimedia-Current-Work: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10MarkTraceur) p:05Normal→03High [17:17:56] 10Multimedia, 10Analytics, 10Discovery-Search, 10Reading-Admin, and 3 others: Image Classification Working Group - https://phabricator.wikimedia.org/T215413 (10elukey) [17:44:31] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review: Date incompatible with the chosen license? - https://phabricator.wikimedia.org/T214426 (10Ramsey-WMF) [17:48:26] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review: Date incompatible with the chosen license? - https://phabricator.wikimedia.org/T214426 (10Ramsey-WMF) p:05Triage→03Normal [18:00:54] 10Multimedia, 10MediaWiki-Gallery, 10MinervaNeue (Tracking), 10Mobile: Mode slideshow of gallery tag is not working in phone screens - https://phabricator.wikimedia.org/T194887 (10Yuriy_kosygin) @Jdlrobson That's right, but when reading on the mobile version, the image show is vertical (even if the picture... [18:01:22] (03PS53) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:02:14] (03CR) 10Brion VIBBER: "Rebased, moved dieUsage to dieWithError, removed the unused tracktype param. Will make some more tweaks before ready for review." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:03:46] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:06:53] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10Ramsey-WMF) [18:25:55] (03PS54) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:30:10] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:31:40] (03CR) 10Jforrester: [C: 03+2] Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [18:31:49] (03PS5) 10Jforrester: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [18:31:53] (03CR) 10Jforrester: [C: 03+2] Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [18:31:59] (03PS3) 10Jforrester: Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) (owner: 10Matthias Mullie) [18:32:04] (03CR) 10Jforrester: [C: 03+2] Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) (owner: 10Matthias Mullie) [18:32:59] (03CR) 10Jforrester: [C: 03+1] Expose repo API url everywhere [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500006 (owner: 10Matthias Mullie) [18:45:03] (03PS55) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:53:39] (03CR) 10jerkins-bot: [V: 04-1] Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [18:53:42] (03CR) 10jerkins-bot: [V: 04-1] Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [18:53:45] (03CR) 10jerkins-bot: [V: 04-1] Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) (owner: 10Matthias Mullie) [18:58:51] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:59:37] (03CR) 10Jforrester: [C: 03+2] "*sighs*" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [19:00:14] (03CR) 10Brion VIBBER: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [19:10:58] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [19:11:38] 10Multimedia, 10Commons, 10Thumbor: PNG thumbnail of SVG file not rendered correctly, mostly black - https://phabricator.wikimedia.org/T212081 (10Gilles) Looks like an upstream librsvg issue. [19:14:44] (03PS56) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [19:18:39] brion: Aha, you're getting caught by my i18n linting. :-) [19:19:08] yeah i just found the relevant lines of output :D [19:24:31] * James_F cackles evilly. (Or… positively? Supporting translators is important.) [19:27:26] Gosh, it passes. [19:27:37] Does it also work? :-) [19:56:44] (03CR) 10Jforrester: [C: 03+2] Update EventLogging schemas [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499989 (https://phabricator.wikimedia.org/T219166) (owner: 10Matthias Mullie) [19:57:20] (03CR) 10Jforrester: [C: 03+2] Update depicts title copy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500004 (owner: 10Matthias Mullie) [19:59:00] (03Merged) 10jenkins-bot: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [19:59:03] (03Merged) 10jenkins-bot: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [19:59:05] (03CR) 10Jforrester: [C: 03+1] Add metadata config to campaigns schema (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500008 (https://phabricator.wikimedia.org/T219368) (owner: 10Matthias Mullie) [19:59:08] (03Merged) 10jenkins-bot: Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) (owner: 10Matthias Mullie) [20:00:32] (03CR) 10jenkins-bot: Refactor panel styles to use LESS features, Flexbox [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498261 (https://phabricator.wikimedia.org/T216773) (owner: 10Eric Gardner) [20:00:51] (03PS2) 10Jforrester: i18n: Drop old 'primary' i18n, no longer used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499022 [20:01:14] (03CR) 10Jforrester: "Now that we know we're keeping it." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/499022 (owner: 10Jforrester) [20:01:18] (03CR) 10jenkins-bot: Follow-up on panel style refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500735 (owner: 10Matthias Mullie) [20:02:43] (03CR) 10jenkins-bot: Separate multiple statement groups [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500736 (https://phabricator.wikimedia.org/T219381) (owner: 10Matthias Mullie) [20:06:48] (03Merged) 10jenkins-bot: Update EventLogging schemas [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499989 (https://phabricator.wikimedia.org/T219166) (owner: 10Matthias Mullie) [20:10:14] (03CR) 10jenkins-bot: Update EventLogging schemas [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499989 (https://phabricator.wikimedia.org/T219166) (owner: 10Matthias Mullie) [20:14:25] (03CR) 10Matthias Mullie: Add metadata config to campaigns schema (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500008 (https://phabricator.wikimedia.org/T219368) (owner: 10Matthias Mullie) [20:17:14] James_F: more or less works! ;) need to confirm on multi-site, which might have some bugs still. which means setting up a local commons-like config. yay \o/ [20:17:14] (03Merged) 10jenkins-bot: Update depicts title copy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500004 (owner: 10Matthias Mullie) [20:17:27] i think vagrant can do that though? [20:17:40] brion: Yup, working great locally with ~20 wikis. [20:17:49] excellent, i'll set that up in a bit [20:19:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10egardner) I was able to get the basic Ruby/Cucumber setup for integration... [20:21:21] (03CR) 10jenkins-bot: Update depicts title copy [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500004 (owner: 10Matthias Mullie) [20:24:59] (03CR) 10Jforrester: "This change is ready for review." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:30:22] (03PS2) 10Jforrester: Put panel initialisation inside hooks [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500772 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [20:48:08] (03CR) 10Jforrester: [C: 03+2] Add metadata config to campaigns schema (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500008 (https://phabricator.wikimedia.org/T219368) (owner: 10Matthias Mullie) [20:58:58] (03Merged) 10jenkins-bot: Add metadata config to campaigns schema [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500008 (https://phabricator.wikimedia.org/T219368) (owner: 10Matthias Mullie) [21:09:51] (03CR) 10jenkins-bot: Add metadata config to campaigns schema [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/500008 (https://phabricator.wikimedia.org/T219368) (owner: 10Matthias Mullie) [21:41:17] (03CR) 10Jforrester: [C: 03+2] Put panel initialisation inside hooks [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500772 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [22:04:25] (03Merged) 10jenkins-bot: Put panel initialisation inside hooks [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500772 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [22:05:39] (03CR) 10jenkins-bot: Put panel initialisation inside hooks [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500772 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [22:18:27] 10Multimedia: [Insert design/front-end thing] - https://phabricator.wikimedia.org/T219944 (10PDrouin-WMF) [22:20:24] 10Multimedia: Upload Wizard depicts heading/label should match what's been updated for File Page - https://phabricator.wikimedia.org/T219944 (10PDrouin-WMF) [22:38:10] 10Multimedia: Change Upload Wizard step name from "Metadata" to "Add data" - https://phabricator.wikimedia.org/T219945 (10PDrouin-WMF) [23:07:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Change Upload Wizard step name from "Metadata" to "Add data" - https://phabricator.wikimedia.org/T219945 (10Ramsey-WMF) p:05Triage→03Normal a:03matthiasmullie [23:07:31] 10Multimedia: Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10PDrouin-WMF) [23:07:59] 10Multimedia: Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10PDrouin-WMF) [23:08:09] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 4 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10PDrouin-WMF) [23:08:16] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Change Upload Wizard step name from "Metadata" to "Add data" - https://phabricator.wikimedia.org/T219945 (10PDrouin-WMF) [23:08:22] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 4 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10PDrouin-WMF) [23:08:24] 10Multimedia: Upload Wizard depicts heading/label should match what's been updated for File Page - https://phabricator.wikimedia.org/T219944 (10PDrouin-WMF) [23:08:32] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 4 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10PDrouin-WMF) [23:17:13] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): [MUST BE DONE BEFORE DEPICTS LAUNCH] Add config for searching statements on commons - https://phabricator.wikimedia.org/T219649 (10Jdforrester-WMF) Does it need to go out beforehand? Or just as part of [[https:... [23:20:24] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Upload Wizard depicts heading/label should match what's been updated for File Page - https://phabricator.wikimedia.org/T219944 (10Ramsey-WMF) p:05Triage→03Normal a:03matthiasmullie [23:28:21] 10Multimedia: Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10PDrouin-WMF) [23:31:42] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10Ramsey-WMF) a:03matthiasmullie [23:34:37] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10Ramsey-WMF) p:05Triage→03Normal [23:44:56] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10Ramsey-WMF) Extending the length of the top gray bar a bit may help as an "easy" fix. Nudging the image and the depict...