[07:57:49] 10Multimedia, 10UploadWizard, 10Design, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: UploadWizard Flickr image selection interface is no longer awesome - https://phabricator.wikimedia.org/T208825 (10kaldari) I dug through the old code and looks like it was using [[ https://jqueryui.com... [10:08:22] 10Multimedia, 10UploadWizard: Update UploadWizard describe step with text explaining what "publish" actually does - https://phabricator.wikimedia.org/T220429 (10matthiasmullie) Do we really need to clutter the upload interface even more? There's so much information, help text, legal text, ... on this step alre... [10:33:43] (03PS1) 10Matthias Mullie: Remove redundant margin-right [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/503956 [10:50:51] 10Multimedia, 10Commons, 10Wikimedia-SVG-rendering, 10Upstream: SVG style element ignored if no type attribute is specified - https://phabricator.wikimedia.org/T68672 (10jijiki) @JoKalliauer Since last week all servers are using librsvg 2.40.20-3 which fixes some svg rendering issues (and possibly introduc... [11:00:23] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, 10Patch-For-Review: Protected image captions can't be edited, API query points at null - https://phabricator.wikimedia.org/T220660 (10matthiasmullie) Tried it on beta (with link provided by @Ramsey - t... [11:14:10] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Allow editing of non-depicts statement block on File page - https://phabricator.wikimedia.org/T219382 (10matthiasmullie) [11:22:45] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) [11:25:13] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10matthiasmullie) a:05matthiasmullie→03Ramsey-WMF @Ramsey: this one wasn't r... [11:29:53] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Allow editing of non-depicts statement block on File page - https://phabricator.wikimedia.org/T219382 (10matthiasmullie) @Ramsey-WMF: this ticket was pulled in from a later milestone to improve how we d... [11:30:14] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Allow editing of non-depicts statement block on File page - https://phabricator.wikimedia.org/T219382 (10matthiasmullie) a:05matthiasmullie→03Ramsey-WMF [11:44:05] (03PS2) 10Matthias Mullie: Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 [12:23:11] (03CR) 10Cparle: "I can still see 'mark as prominent'." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502516 (https://phabricator.wikimedia.org/T220613) (owner: 10Matthias Mullie) [12:48:18] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Replace usage of Title with usage of LinkTarget in Linker - https://phabricator.wikimedia.org/T214318 (10Simetrical) a:03Simetrical [12:52:08] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Create a value-only interface alternative to the File class - https://phabricator.wikimedia.org/T214321 (10Simetrical) It doesn't look like Linker could make any use of a FileIdent... [12:54:33] (03CR) 10Matthias Mullie: "Oh damn. I thing the "mark prominent" being there is not a real issue (since that's actually supported), but I didn't even think about tha" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502516 (https://phabricator.wikimedia.org/T220613) (owner: 10Matthias Mullie) [12:55:55] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Other-statements-running): Allow deletion of statement blocks with unsupported data types - https://phabricator.wikimedia.org/T220614 (10matthiasmullie) [14:02:10] (03CR) 10Cparle: [C: 03+2] Handle statements with unsupported data types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502516 (https://phabricator.wikimedia.org/T220613) (owner: 10Matthias Mullie) [14:26:07] (03Merged) 10jenkins-bot: Handle statements with unsupported data types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502516 (https://phabricator.wikimedia.org/T220613) (owner: 10Matthias Mullie) [14:26:52] (03CR) 10jenkins-bot: Handle statements with unsupported data types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502516 (https://phabricator.wikimedia.org/T220613) (owner: 10Matthias Mullie) [14:31:22] (03CR) 10Cparle: [C: 03+2] Remove redundant margin-right [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/503956 (owner: 10Matthias Mullie) [14:57:52] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)), and 2 others: Replace usage of Title with usage of LinkTarget in File - https://phabricator.wikimedia.org/T214319 (10daniel) [14:57:56] (03Merged) 10jenkins-bot: Remove redundant margin-right [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/503956 (owner: 10Matthias Mullie) [14:58:01] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)), and 2 others: Replace usage of Title with usage of LinkTarget in Linker - https://phabricator.wikimedia.org/T214318 (10daniel) [14:58:51] (03CR) 10jenkins-bot: Remove redundant margin-right [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/503956 (owner: 10Matthias Mullie) [17:16:18] 10Multimedia, 10SDC Engineering: 'Items depicts in this File' text sometimes in German - https://phabricator.wikimedia.org/T221017 (10Jdforrester-WMF) Fixed by doing an `action=purge` on the file with an English locale. Might just be an old page cache issue from the roll out of testing code, or might be more s... [17:29:08] 10Multimedia, 10Multimedia-Current-Work: Depicts heading text is cut off on right - https://phabricator.wikimedia.org/T221021 (10Ha78na) [17:31:31] (03PS1) 10Ha78na: Add overflow:visible to keep depicts label from being cut off [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) [17:35:57] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes - https://phabricator.wikimedia.org/T219500 (10Ha78na) [17:36:01] 10Multimedia, 10Multimedia-Current-Work: Add JS Unit tests to safeguard Filepage UI happy-paths - https://phabricator.wikimedia.org/T220774 (10Ha78na) [17:43:18] (03CR) 10Jforrester: [C: 04-1] "Syntax nit, otherwise good." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) (owner: 10Ha78na) [17:47:51] (03CR) 10Ha78na: Add overflow:visible to keep depicts label from being cut off (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) (owner: 10Ha78na) [18:14:52] (03CR) 10jerkins-bot: [V: 04-1] Add overflow:visible to keep depicts label from being cut off [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) (owner: 10Ha78na) [18:55:39] 10Multimedia, 10UploadWizard: Update UploadWizard describe step with text explaining what "publish" actually does - https://phabricator.wikimedia.org/T220429 (10Ramsey-WMF) Thanks for the useful notes @matthiasmullie . Pam and I share a lot of these sentiments. We're just trying to address some external concer... [19:04:55] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Depicts heading text is cut off on right - https://phabricator.wikimedia.org/T221021 (10Ramsey-WMF) p:05Triage→03Lowest [19:10:37] 10Multimedia, 10SDC Engineering: 'Items depicts in this File' text sometimes in German - https://phabricator.wikimedia.org/T221017 (10Ramsey-WMF) Hmm. I'm gonna test this one a bit more in multiple languages. Tagging the rest of the team for additional eyes on it/insight [19:35:32] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 2 others: Allow deletion of qualifiers with unsupported data types - https://phabricator.wikimedia.org/T220617 (10Ramsey-WMF) p:05Triage→03Normal [19:36:20] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Add JS Unit tests to safeguard Filepage UI happy-paths - https://phabricator.wikimedia.org/T220774 (10Ramsey-WMF) [19:38:07] (03PS2) 10Ha78na: Add overflow:visible to keep depicts label from being cut off [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) [20:11:21] 10Multimedia, 10Commons, 10MediaWiki-Database, 10MediaWiki-File-management, 10Performance-Team: filearchive mysql queries are not replication safe - https://phabricator.wikimedia.org/T48134 (10Krinkle) 05Open→03Resolved a:03Krinkle The rdbms layer now does an explicit SELECT first and an insert bas... [20:55:18] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Create a value-only interface alternative to the File class - https://phabricator.wikimedia.org/T214321 (10daniel) >>! In T214321#5111160, @Simetrical wrote: > It doesn't look like... [21:00:38] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501967 (owner: 10Jforrester) [21:05:56] (03CR) 10Jforrester: [C: 03+2] Restore backward compatibility when initialised without property id [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504030 (owner: 10Matthias Mullie) [21:16:27] (03CR) 10Jforrester: [C: 03+2] Add overflow:visible to keep depicts label from being cut off [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) (owner: 10Ha78na) [21:38:23] (03Merged) 10jenkins-bot: WikibaseMediaInfoHooksTest: Assert that we drop tags [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501967 (owner: 10Jforrester) [21:38:34] (03Merged) 10jenkins-bot: Restore backward compatibility when initialised without property id [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504030 (owner: 10Matthias Mullie) [21:38:41] (03Merged) 10jenkins-bot: Add overflow:visible to keep depicts label from being cut off [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) (owner: 10Ha78na) [21:39:36] (03CR) 10jenkins-bot: WikibaseMediaInfoHooksTest: Assert that we drop tags [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501967 (owner: 10Jforrester) [21:40:26] 10Multimedia, 10Commons, 10Core Platform Team Kanban, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)): Create a value-only interface alternative to the File class - https://phabricator.wikimedia.org/T214321 (10Tgr) `exists()` seems reasonable for a FileIdentity class (although remot... [21:41:13] (03CR) 10jenkins-bot: Restore backward compatibility when initialised without property id [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504030 (owner: 10Matthias Mullie) [21:42:10] (03CR) 10jenkins-bot: Add overflow:visible to keep depicts label from being cut off [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504069 (https://phabricator.wikimedia.org/T221021) (owner: 10Ha78na) [22:12:29] (03PS3) 10Jforrester: WikibaseMediaInfoHooksTest: Use a more representative page content test string [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501968 [22:12:40] (03PS3) 10Jforrester: WikibaseMediaInfoHooksTest: Test for existing captions tags invariantly, like real code [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501969 [22:12:46] (03PS3) 10Jforrester: WikibaseMediaInfoHooksTest: Make the captions dummy content we check more like reality [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501970 [22:12:52] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501968 (owner: 10Jforrester) [22:48:37] (03Merged) 10jenkins-bot: WikibaseMediaInfoHooksTest: Use a more representative page content test string [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501968 (owner: 10Jforrester) [22:48:39] (03Merged) 10jenkins-bot: WikibaseMediaInfoHooksTest: Test for existing captions tags invariantly, like real code [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501969 (owner: 10Jforrester) [22:49:45] (03CR) 10jenkins-bot: WikibaseMediaInfoHooksTest: Use a more representative page content test string [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501968 (owner: 10Jforrester) [22:50:16] (03CR) 10jenkins-bot: WikibaseMediaInfoHooksTest: Test for existing captions tags invariantly, like real code [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501969 (owner: 10Jforrester)