[08:07:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508271 (owner: 10L10n-bot) [09:01:29] (03CR) 10Matthias Mullie: [C: 03+2] UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [09:09:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508265 (owner: 10L10n-bot) [09:12:54] (03CR) 10jerkins-bot: [V: 04-1] UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [09:30:27] (03PS4) 10Matthias Mullie: Require statement exports from other modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507567 [09:45:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] tests: Use getNewTempDirectory() without modification [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508098 (owner: 10Krinkle) [11:56:25] (03CR) 10Matthias Mullie: [C: 03+2] "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [12:51:52] (03CR) 10jerkins-bot: [V: 04-1] UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [13:43:07] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Nikerabbit) >>! In T222309#5156677, @Jdforrester-WMF wrote: > oh, wow, yes, ExtraLanguageNames is not an appropriate disposition for this stuff (as it only works on one wi... [14:51:36] (03PS5) 10Matthias Mullie: UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [14:53:53] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Raymond) >>! In T222309#5159912, @Nikerabbit wrote: >>>! In T222309#5156677, @Jdforrester-WMF wrote: >> oh, wow, yes, ExtraLanguageNames is not an appropriate disposition... [15:02:46] (03PS66) 10Jforrester: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [15:07:12] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Nikerabbit) Then that something probably should be changed to use codes coming from the CLDR extension. It might be as easy as changing one parameter to fetchLanguageNames. [15:44:39] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508098 (owner: 10Krinkle) [15:58:59] (03CR) 10jerkins-bot: [V: 04-1] UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [16:11:38] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work: There's no way to go forward to Add Data if there's an error/warning of any sort - https://phabricator.wikimedia.org/T222481 (10Ramsey-WMF) p:05Triage→03Normal a:03matthiasmullie [16:17:53] (03CR) 10jerkins-bot: [V: 04-1] tests: Use getNewTempDirectory() without modification [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508098 (owner: 10Krinkle) [16:19:55] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508098 (owner: 10Krinkle) [16:30:16] 10Multimedia, 10SDC Design, 10SDC Engineering, 10UploadWizard, 10SDC-Statements (Other-statements-running): Increase padding between statement blocks on UW - https://phabricator.wikimedia.org/T222485 (10Ramsey-WMF) p:05Triage→03Low [16:46:30] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Captions on UW doesn't warn you more than once if your input is over 250 - https://phabricator.wikimedia.org/T222483 (10Ramsey-WMF) p:05Triage→03Normal [16:46:56] (03PS1) 10Matthias Mullie: Add padding between statement blocks on UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) [16:46:58] (03PS1) 10Matthias Mullie: Disable publish button until statements have been added [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508364 (https://phabricator.wikimedia.org/T222482) [16:48:19] (03Merged) 10jenkins-bot: tests: Use getNewTempDirectory() without modification [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508098 (owner: 10Krinkle) [16:49:15] (03CR) 10jenkins-bot: tests: Use getNewTempDirectory() without modification [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508098 (owner: 10Krinkle) [16:51:52] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, and 2 others: Publish data button should be disabled if nothing has been added yet - https://phabricator.wikimedia.org/T222482 (10Ramsey-WMF) p:05Triage→03Normal a:03matthiasmullie [16:59:02] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T222361 (10Ramsey-WMF) p:05Triage→03Normal a:03PDrouin-WMF Thoughts on the best way to d... [16:59:54] (03CR) 10jerkins-bot: [V: 04-1] Add padding between statement blocks on UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [17:00:16] (03CR) 10jerkins-bot: [V: 04-1] Disable publish button until statements have been added [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508364 (https://phabricator.wikimedia.org/T222482) (owner: 10Matthias Mullie) [18:15:08] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [18:17:45] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 3 others: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php - https://phabricator.wikimedia.org/T221812 (10Krinkle) [18:24:37] 10Multimedia, 10Commons, 10StructuredDataOnCommons, 10I18n, 10Multimedia-Current-Work: Structured Data table overflows when wikidata label is too long - https://phabricator.wikimedia.org/T221861 (10Ramsey-WMF) a:03Cparle ^ looks like word wrap it shall be :) [18:27:59] (03CR) 10jerkins-bot: [V: 04-1] Add padding between statement blocks on UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [20:42:44] (03CR) 10Krinkle: Subtitles served through API, with WebVTT conversion (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:43:42] (03CR) 10Krinkle: [C: 04-1] "Confirmed all CR and changes since PS 57 (my last review). LGTM, except for the "exception instead of fatal" which I don't quite understan" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:50:37] (03PS1) 10Krinkle: Only load wikibase.mediainfo.search with wgMediaInfoEnableSearch [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508406 [20:50:56] (03CR) 10Krinkle: "Caution - untested :)" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508406 (owner: 10Krinkle) [20:52:01] (03CR) 10Krinkle: Only load wikibase.mediainfo.search with wgMediaInfoEnableSearch (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508406 (owner: 10Krinkle) [20:58:19] (03CR) 10Brion VIBBER: "Ah indeed, an exception will also log won't it. I'll change to just forbid this for now." (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:09:24] (03PS67) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:10:50] (03CR) 10Brion VIBBER: "Oh PS67 will gracefully error out instead of throwing an exception if asked for a subtitle with a source page that only existed in vtt sou" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:22:25] (03CR) 10Brion VIBBER: "Note there's also an oddity I noticed where if you provide a page in TimedText namespace with a non-supported extension it'll still get tr" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ)