[00:29:25] (03PS1) 10Eric Gardner: Allow user to set qualifier properties with an autocomplete widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513538 (https://phabricator.wikimedia.org/T224040) [00:56:20] (03CR) 10jerkins-bot: [V: 04-1] Allow user to set qualifier properties with an autocomplete widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513538 (https://phabricator.wikimedia.org/T224040) (owner: 10Eric Gardner) [01:02:04] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field - https://phabricator.wikimedia.org/T218620 (10Edtadros) a:05Edtadros→03Cparle === Test Result **Sta... [01:03:09] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field - https://phabricator.wikimedia.org/T218620 (10Edtadros) [02:02:35] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Multimedia-Current-Work, and 2 others: Should not be able to interact with statements in UploadWizard while submitting - https://phabricator.wikimedia.org/T221076 (10Edtadros) a:05Edtadros→03Ramsey-WMF @Ramsey-WMF I'm unable... [03:37:41] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Multimedia-Current-Work, and 2 others: Should not be able to interact with statements in UploadWizard while submitting - https://phabricator.wikimedia.org/T221076 (10Ramsey-WMF) Yeah, there seems to be some weirdness on Beta. Tr... [08:45:07] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes - https://phabricator.wikimedia.org/T219500 (10Cparle) a:05Cparle→03None [09:46:03] 10Multimedia, 10Commons, 10MediaWiki-extension-requests: Feature request, Simple gallery feature extension for Commons - https://phabricator.wikimedia.org/T224660 (10RTG) I'm not sure I can present it as a problem solver. Commons already uses an app called "slideshow". Yes it would be a timed cycling of the... [09:48:10] 10Multimedia, 10Commons, 10MediaWiki-extension-requests: Feature request, Simple gallery feature extension for Commons - https://phabricator.wikimedia.org/T224660 (10RTG) I'm sure it could be very complex I've little idea really [13:11:26] (03CR) 10Umherirrender: Fix vendor versions [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 (owner: 10Matthias Mullie) [13:11:34] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 (owner: 10Matthias Mullie) [13:17:32] 10Multimedia, 10Commons, 10MediaWiki-extension-requests: Feature request, Simple gallery feature extension for Commons - https://phabricator.wikimedia.org/T224660 (10Aklapper) > Commons already uses an app called "slideshow". Where to see that? Please provide clear steps which allow seeing that. [13:40:51] (03Merged) 10jenkins-bot: Fix vendor versions [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 (owner: 10Matthias Mullie) [13:43:22] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [13:46:24] (03CR) 10jenkins-bot: Fix vendor versions [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 (owner: 10Matthias Mullie) [14:06:35] (03CR) 10jerkins-bot: [V: 04-1] Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [15:50:24] (03PS1) 10Cparle: Other statements in UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513631 (https://phabricator.wikimedia.org/T219407) [15:51:40] (03PS1) 10Tchanders: Use MediaWiki\Block\DatabaseBlock instead of Block [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 [15:51:42] (03Abandoned) 10Cparle: Test commit [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513288 (owner: 10Cparle) [16:01:51] (03CR) 10jerkins-bot: [V: 04-1] Other statements in UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513631 (https://phabricator.wikimedia.org/T219407) (owner: 10Cparle) [16:02:03] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Other-statements-running): UI for adding statements in UploadWizard (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219407 (10Cparle) a:03Cparle [16:04:44] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field - https://phabricator.wikimedia.org/T218620 (10Cparle) I think we can just put this one on hold for now,... [16:08:53] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWiki\Block\DatabaseBlock instead of Block [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [16:54:16] (03CR) 10Jforrester: [C: 03+2] "Test failure is due to Wikibase issues and unrelated. Land this whenever." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [16:55:16] 10Multimedia, 10MediaViewer, 10Patch-For-Review, 10good first bug: Download button frequently unresponsive - https://phabricator.wikimedia.org/T186461 (10Jdforrester-WMF) 05Open→03Resolved a:03simon04 [16:55:32] 10Multimedia, 10MediaViewer, 10TCB-Team, 10Wikimedia-Hackathon-2019, and 2 others: Show more image sizes in download panel - https://phabricator.wikimedia.org/T77642 (10Jdforrester-WMF) 05Open→03Resolved a:03simon04 [17:04:58] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513480 (owner: 10L10n-bot) [17:05:05] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [17:13:40] (03CR) 10Jforrester: [C: 03+2] "This will fail due to test issues from Wikibase, which are going to be fixed by I6fa4fc3d0 which is behind it in the merge queue, so I'll " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [17:20:26] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWiki\Block\DatabaseBlock instead of Block [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [17:27:51] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [17:40:06] (03Merged) 10jenkins-bot: Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [17:47:49] (03CR) 10jenkins-bot: Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [17:48:58] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [17:52:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513480 (owner: 10L10n-bot) [18:02:22] (03Merged) 10jenkins-bot: Use MediaWiki\Block\DatabaseBlock instead of Block [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [18:08:04] (03CR) 10jenkins-bot: Use MediaWiki\Block\DatabaseBlock instead of Block [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/513632 (owner: 10Tchanders) [18:13:05] 10Multimedia, 10SDC Engineering, 10SDC-Statements, 10Multimedia-Current-Work: Newly added depicted items don’t show Wikidata logo - https://phabricator.wikimedia.org/T224703 (10Ramsey-WMF) p:05Triage→03Normal [18:17:57] 10Multimedia: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Ramsey-WMF) [18:18:18] 10Multimedia: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Ramsey-WMF) p:05Triage→03High [18:18:51] 10Multimedia: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Ramsey-WMF) Any thoughts on this one, @Jdforrester-WMF 😃 [18:28:36] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Jdforrester-WMF) API response is an internal fatal: ` Argument 1 passed to AbuseFilterCachingParser::evalNode() must be an instance of AFPTreeNode, null... [18:28:49] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Jdforrester-WMF) p:05High→03Unbreak! I'm declaring this a train blocker for next week. [18:29:14] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Jdforrester-WMF) [18:45:53] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Daimona) I'll check it. Anyway, AbuseFilterCachingParser is only used in test wikis, whereas production uses AbuseFilterParser. Thus, it's a beta-only issue... [18:46:08] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Daimona) [18:46:16] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Daimona) p:05Unbreak!→03High [18:46:30] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Jdforrester-WMF) Aha, interesting. Why is Beta Cluster using CachingParser if it doesn't work yet? [18:50:38] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Daimona) I think it was enabled to test it and see what errors (like this one) could come out. The config patch is https://gerrit.wikimedia.org/r/#/c/operat... [18:55:11] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Jdforrester-WMF) No trace (Beta Cluster is prod-like) or fatal hash (API is unhelpful), sorry. [18:56:59] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Daimona) I could actually find it on beta logstash, we have `name=message PHP Fatal Error: Argument 1 passed to AbuseFilterCachingParser::evalNode() must... [18:57:05] (03PS1) 10Umherirrender: Fix whitespace after @var [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/513671 [18:57:37] (03CR) 10Jforrester: [C: 03+2] Fix whitespace after @var [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/513671 (owner: 10Umherirrender) [19:02:00] (03PS5) 10Umherirrender: Add phan [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/512473 [19:32:12] (03CR) 10jerkins-bot: [V: 04-1] Add phan [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/512473 (owner: 10Umherirrender) [19:41:59] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Krinkle) Re-voicing from Daimona, I agree it'd be useful to keep the caching parser enabled in Beta so as to keep finding new issues and work on them. But,... [19:56:24] (03Merged) 10jenkins-bot: Fix whitespace after @var [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/513671 (owner: 10Umherirrender) [20:16:08] (03CR) 10jenkins-bot: Fix whitespace after @var [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/513671 (owner: 10Umherirrender) [20:30:19] 10Multimedia, 10AbuseFilter, 10UploadWizard: [Beta Commons] All attempts to upload with UploadWizard fail - https://phabricator.wikimedia.org/T224746 (10Daimona) I forgot to say that I took a quick look at the issue. Unfortunately, we don't know what's the faulty filter (the parser is unaware), and the trigg... [21:17:06] 10Multimedia, 10MediaViewer, 10I18n, 10Patch-For-Review, 10Performance: MultimediaViewer should not use moment.js for a single line - https://phabricator.wikimedia.org/T224626 (10Jdforrester-WMF) 05Open→03Resolved Thank you! [21:37:11] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-production-error: Undefined index error after unpack() from MimeAnalyzer.php - https://phabricator.wikimedia.org/T223728 (10Mholloway) It looks like the indices of the array returned by unpack here actually begin at 1: https://www.php.net/ma... [22:10:19] (03CR) 10Jforrester: [C: 03+2] Use ::class for class name resolution [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513408 (owner: 10Umherirrender) [22:17:15] (03PS6) 10Umherirrender: Add phan [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/512473 [22:36:47] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513408 (owner: 10Umherirrender) [22:50:53] 10Multimedia, 10Commons, 10MediaWiki-File-management: LocalFile isMissing always returns true regardless of file stat - https://phabricator.wikimedia.org/T220244 (10Reedy) Is this still open because of the tests not having yet been written? [23:10:03] (03PS1) 10Eric Gardner: Use templates instead of imperative DOM construction when possible [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513706 [23:15:03] (03CR) 10Eric Gardner: "Hey all – in the process of working through some statements & qualifiers patches, something occurred to me and I thought I would submit a " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513706 (owner: 10Eric Gardner) [23:17:38] (03CR) 10Gergő Tisza: Add phan (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/512473 (owner: 10Umherirrender) [23:23:14] (03CR) 10jerkins-bot: [V: 04-1] Use templates instead of imperative DOM construction when possible [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513706 (owner: 10Eric Gardner) [23:51:41] (03CR) 10Niedzielski: "Thanks for sharing this patch! It's neat to see your interest and work in this area." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513706 (owner: 10Eric Gardner)