[00:31:22] 10Multimedia, 10SDC Engineering: Add UI support for time Wikibase datatype - https://phabricator.wikimedia.org/T227112 (10Volker_E) @PDrouin-WMF There's currently two date pickers in MW core, that are close to the template. Forward thinking, we're recommending DateInputWidget as long as date is the main input... [05:31:15] (03PS1) 10Fomafix: Simplify by using mw.util.getUrl [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520362 [09:42:08] (03PS1) 10Reedy: Call rather than [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520395 [09:43:04] (03PS2) 10Reedy: Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520395 [09:44:05] (03PS3) 10Reedy: Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520395 (https://phabricator.wikimedia.org/T226840) [09:58:12] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10PHP 7.2 support, 10Wikimedia-production-error: PHP error "non well formed numeric value encountered" from FormatMetadata->formatCoords - https://phabricator.wikimedia.org/T226751 (10Daimona) The obvious thing to notice is that formatCoords' docblock... [11:38:25] (03PS1) 10Reedy: Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.11) - 10https://gerrit.wikimedia.org/r/520414 (https://phabricator.wikimedia.org/T226840) [11:38:34] (03CR) 10Reedy: [C: 03+2] Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.11) - 10https://gerrit.wikimedia.org/r/520414 (https://phabricator.wikimedia.org/T226840) (owner: 10Reedy) [11:43:29] (03PS2) 10Cparle: Only show 'remove all' if property is non-default [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) [11:49:46] (03Merged) 10jenkins-bot: Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.11) - 10https://gerrit.wikimedia.org/r/520414 (https://phabricator.wikimedia.org/T226840) (owner: 10Reedy) [12:03:25] (03CR) 10Gergő Tisza: [C: 03+2] Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520395 (https://phabricator.wikimedia.org/T226840) (owner: 10Reedy) [12:04:27] (03CR) 10jerkins-bot: [V: 04-1] Only show 'remove all' if property is non-default [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [12:14:06] (03Merged) 10jenkins-bot: Call `RequestContext::getMain()` rather than `new RequestContext()` [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520395 (https://phabricator.wikimedia.org/T226840) (owner: 10Reedy) [12:48:50] 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 4 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10Aklapper) [13:45:00] James_F: there used to be some problems with the RL modules inside the frame.php loader and indeed with Aspect ratio of some videos. It does indeed seem like those have been fixed with various updates along the way [13:46:17] (03CR) 10TheDJ: [C: 04-1] "The module then needs to depend on mediawiki.util" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520362 (owner: 10Fomafix) [13:49:44] (03CR) 10Cparle: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [14:01:28] (03CR) 10Cparle: Convert ItemWidget.js's rendering to Mustache templates (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520229 (owner: 10Matthias Mullie) [14:17:11] (03CR) 10Fomafix: "I didn't check the dependencies, because the module already used mw.util.wikiUrlencode." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520362 (owner: 10Fomafix) [14:18:16] (03PS1) 10Cparle: Remove clear() method as it's not used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520453 (https://phabricator.wikimedia.org/T204488) [14:18:59] 10Multimedia, 10MediaWiki-Vendor, 10Wikidata, 10wikidata-tech-focus, and 2 others: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear` - https://phabricator.wikimedia.org/T204488 (10Cparle) a:03Cparle [14:29:25] (03PS1) 10D3r1ck01: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 [14:36:10] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [14:43:04] (03PS2) 10Fomafix: Simplify by using mw.util.getUrl [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520362 [14:45:14] (03CR) 10D3r1ck01: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [14:45:20] (03CR) 10Matthias Mullie: [C: 03+2] Remove clear() method as it's not used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520453 (https://phabricator.wikimedia.org/T204488) (owner: 10Cparle) [14:51:41] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [14:52:43] (03PS1) 10Eric Gardner: Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 [15:00:00] (03CR) 10D3r1ck01: "How come this is failing when I clearly see: https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/extension.json#L63" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [15:00:08] (03CR) 10D3r1ck01: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [15:07:18] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [15:13:20] (03Merged) 10jenkins-bot: Remove clear() method as it's not used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520453 (https://phabricator.wikimedia.org/T204488) (owner: 10Cparle) [15:13:49] (03CR) 10jerkins-bot: [V: 04-1] Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [15:13:53] (03CR) 10D3r1ck01: "@Krinkle, I see a comment" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [15:14:01] (03CR) 10D3r1ck01: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [15:19:34] (03CR) 10jenkins-bot: Remove clear() method as it's not used [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520453 (https://phabricator.wikimedia.org/T204488) (owner: 10Cparle) [15:20:07] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [15:24:01] thedj: Nice. Thanks for the confirmation. [15:38:22] (03CR) 10Eric Gardner: "This is going to need some adjustments to how things are tested before it is ready to merge." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [15:43:57] (03PS1) 10DannyS712: Add help links to special pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520472 (https://phabricator.wikimedia.org/T226938) [15:49:44] (03CR) 10Jforrester: Optional BetaFeatures integration for video.js mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/312327 (https://phabricator.wikimedia.org/T100106) (owner: 10Paladox) [15:50:50] brion: ^ Whoops. :-) [15:53:13] (03PS2) 10DannyS712: Add help links to special pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520472 (https://phabricator.wikimedia.org/T226938) [16:05:43] (03Abandoned) 10D3r1ck01: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [16:22:42] d'oh [16:42:12] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] Limit which predicates are used for mediainfo labels [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) (owner: 10Smalyshev) [16:44:52] (03PS2) 10Eric Gardner: Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 [17:06:07] (03CR) 10jerkins-bot: [V: 04-1] Limit which predicates are used for mediainfo labels [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) (owner: 10Smalyshev) [17:17:04] (03CR) 10Smalyshev: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) (owner: 10Smalyshev) [17:48:27] (03CR) 10jerkins-bot: [V: 04-1] Update for namespace moves [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/515095 (owner: 10Lucas Werkmeister (WMDE)) [17:57:33] (03PS4) 10Smalyshev: Limit which predicates are used for mediainfo labels [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) [18:26:44] (03CR) 10Smalyshev: [C: 03+2] "re-apply +2" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) (owner: 10Smalyshev) [18:32:38] (03CR) 10Eric Gardner: "Basic "templatization" patch ready for review." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [18:33:36] 10Multimedia: [Test Commons] Some statement panels default to 'edit' mode - https://phabricator.wikimedia.org/T227220 (10Ramsey-WMF) [18:34:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): [Test Commons] Some statement panels default to 'edit' mode - https://phabricator.wikimedia.org/T227220 (10Ramsey-WMF) p:05Triage→03High [18:49:44] (03Merged) 10jenkins-bot: Limit which predicates are used for mediainfo labels [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) (owner: 10Smalyshev) [18:50:51] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): UploadWizard: property panel added via "Add statement" persists when you upload another image - https://phabricator.wikimedia.org/T227106 (10Ramsey-WMF) p:05Triage→03Normal [18:58:00] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): UploadWizard: property panel added via "Add statement" persists when you upload another image - https://phabricator.wikimedia.org/T227106 (10Ramsey-WMF) [19:01:07] (03CR) 10jenkins-bot: Limit which predicates are used for mediainfo labels [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520131 (https://phabricator.wikimedia.org/T222302) (owner: 10Smalyshev) [19:07:49] (03CR) 10Eric Gardner: Add template and render method to QualifierWidget (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [19:09:40] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): [stub] Add "click here to see more" functionality to statement panels - https://phabricator.wikimedia.org/T220459 (10Ramsey-WMF) I'd vote for a default number (5). Simplest, most consist... [19:14:41] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): [stub] Add "click here to see more" functionality to statement panels - https://phabricator.wikimedia.org/T220459 (10PDrouin-WMF) 5 sounds reasonable. I do think we still need an "Expand... [19:15:58] 10Multimedia, 10SDC Engineering, 10I18n, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10Aklapper) @egardner: Could you reply to the previous comment, please? Thanks! [19:16:36] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): [stub] Add "click here to see more" functionality to statement panels - https://phabricator.wikimedia.org/T220459 (10Ramsey-WMF) Just clarify, I meant an "Expand all" that would expand a... [20:24:36] 10Multimedia, 10SDC Engineering, 10I18n, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10egardner) @Aklapper part of this issue has been resolved with the merger of this patch: https://... [20:52:00] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Only Depicts statement panels should have Learn More links (for now) - https://phabricator.wikimedia.org/T227226 (10Ramsey-WMF) [20:52:10] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Only Depicts statement panels should have Learn More links (for now) - https://phabricator.wikimedia.org/T227226 (10Ramsey-WMF) p:05Triage→03High [20:59:31] 10Multimedia, 10SDC Engineering: UploadWizard: "learn more" link not removed when all statements are removed - https://phabricator.wikimedia.org/T227103 (10Ramsey-WMF) FYI, this is related to T224249, and actually if that ticket is fully implemented, this one may no longer be relevant anyway :) Key points:... [21:04:33] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Ramsey-WMF) We may need to add a confirmation model that asks something like: "This action will delete all existing values for this proper... [21:28:12] 10Multimedia, 10Commons, 10MediaWiki-DjVu, 10ProofreadPage, 10Wikisource: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10ShakespeareFan00) Seeing a related concern with some pages in : https://en.wikisource.org/... [21:29:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520627 (owner: 10L10n-bot) [21:35:03] 10Multimedia, 10Commons, 10MediaWiki-DjVu, 10ProofreadPage, 10Wikisource: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Peteforsyth) What @Xover said makes sense -- it's not a problem with ProofreadPage, but a... [21:42:16] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): Add UI support for time Wikibase datatype - https://phabricator.wikimedia.org/T227112 (10Ramsey-WMF) [21:44:37] 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 4 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10Jdforrester-WMF) [21:45:45] 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 4 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10Jdforrester-WMF) [21:48:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520617 (owner: 10L10n-bot) [21:48:25] 10Multimedia: Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10PDrouin-WMF) [21:56:08] 10Multimedia, 10Commons, 10MediaWiki-DjVu, 10ProofreadPage, 10Wikisource: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Aklapper) [21:57:12] 10Multimedia, 10Commons, 10MediaWiki-DjVu, 10ProofreadPage, and 2 others: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Aklapper) I'm not sure if this is also handled by #Thumbor - someone please correct me if I'... [22:06:21] (03CR) 10Jforrester: "I guess this isn't a blocker for releasing videojs by default, but it'd be nice to finish this part of the task tree. ;-)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/518128 (https://phabricator.wikimedia.org/T116154) (owner: 10TheDJ) [22:08:49] 10Multimedia, 10Commons, 10MediaWiki-DjVu, 10ProofreadPage, and 2 others: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Peteforsyth) Thank you @Aklapper ! I did not realize it was possible to create private image...