[08:08:40] (03PS1) 10Matthias Mullie: Fix 'add qualifier' button position when no existing qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521222 [09:43:24] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 3 others: Jenkins job to run core tests against commons.wikimedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T220621 (10zeljkofilipin) a:03zeljkofilipin [10:14:16] (03PS12) 10Cparle: Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) [10:27:27] (03CR) 10D3r1ck01: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [10:33:05] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [10:38:34] (03CR) 10jerkins-bot: [V: 04-1] Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [10:42:17] (03PS1) 10Matthias Mullie: Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) [10:42:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: File page: qualifiers not displayed just after they've been added - https://phabricator.wikimedia.org/T227274 (10matthiasmullie) a:05Cparle→03matthiasmullie [11:02:16] (03CR) 10jerkins-bot: [V: 04-1] Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [11:09:57] (03PS2) 10Matthias Mullie: Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) [11:17:01] 10Multimedia, 10Commons, 10MediaWiki-File-management: Moving a File: page without a file onto a deleted file is not possible in Commons - https://phabricator.wikimedia.org/T226922 (10Wargo) You can only merge revisions from "older" page to "newer". "Newer" is based on first revision (I suppose). So, you need... [11:19:18] (03CR) 10Cparle: [C: 03+2] Fix 'add qualifier' button position when no existing qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521222 (owner: 10Matthias Mullie) [11:24:51] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Cparle) @PDrouin-WMF any thoughts? [11:26:23] (03PS13) 10Cparle: Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) [11:40:46] (03PS3) 10Matthias Mullie: Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) [11:40:55] (03Merged) 10jenkins-bot: Fix 'add qualifier' button position when no existing qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521222 (owner: 10Matthias Mullie) [11:46:33] (03CR) 10jenkins-bot: Fix 'add qualifier' button position when no existing qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521222 (owner: 10Matthias Mullie) [12:01:21] (03CR) 10jerkins-bot: [V: 04-1] Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [12:34:00] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10PDrouin-WMF) @Cparle - Agree with Ramsey here that there needs to be a confirmation model. I'm assuming this kind of action won't be taken... [12:43:43] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Cparle) I guess it is, but that'd effectively mean there'd be no 'publish' step for 'remove all' - it'd just warn you when you clicked it... [12:48:43] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 3 others: Jenkins job to run core tests against commons.wikimedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T220621 (10zeljkofilipin) [12:49:20] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 3 others: Jenkins job to run core tests against commons.wikimedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T220621 (10zeljkofilipin) [12:50:14] (03CR) 10TheDJ: Tests: Fixup the testcases a bit (036 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521029 (owner: 10TheDJ) [12:58:26] (03CR) 10Matthias Mullie: Only show 'remove all' if property is non-default (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [12:59:15] (03PS3) 10Matthias Mullie: Only show 'remove all' if property is non-default [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [13:01:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 3 others: Jenkins job to run core tests against commons.wikimedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T220621 (10zeljkofilipin) 05Open→03Resolved [13:01:10] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 3 others: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10zeljkofilipin) [13:01:17] (03CR) 10Matthias Mullie: [C: 03+1] "PS3 addresses the feedback on PS2:" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [13:03:46] (03PS4) 10Matthias Mullie: Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) [13:20:26] (03CR) 10TheDJ: Tests: Fixup the testcases a bit (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521029 (owner: 10TheDJ) [13:32:21] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10PDrouin-WMF) Okay, thanks @cparle - never mind then. Ramsey's solution would work best. I think the text does a good job of explaining wha... [14:51:00] (03CR) 10Matthias Mullie: Unit tests for CaptionPanel.js (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [14:51:10] (03PS14) 10Matthias Mullie: Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [14:51:44] (03CR) 10Matthias Mullie: "PS14 = stick with sha512 hashes." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [14:59:16] (03PS1) 10Cparle: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) [15:05:46] (03PS2) 10Cparle: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) [15:06:37] (03CR) 10Matthias Mullie: [C: 04-1] "LGTM (except for whitespace issues), but will hold off merging until we deploy config patch for the new global." (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [15:07:43] (03PS3) 10Cparle: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) [15:11:04] (03CR) 10Matthias Mullie: [C: 04-1] "LGTM - will merge after updated config has been deployed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [15:18:06] (03CR) 10jerkins-bot: [V: 04-1] Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [15:29:04] (03CR) 10jerkins-bot: [V: 04-1] Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [16:09:13] 10Multimedia, 10SDC Design, 10SDC-Statements (Depicts-Crawling): Tab-navigation when adding depicts statements on Wikimedia Commons is counter-intuitive - https://phabricator.wikimedia.org/T221687 (10PDrouin-WMF) After I last checked in on it, we changed the placement of “Publish changes” to the lower right... [17:19:16] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10kaldari) [17:21:29] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10kaldari) [17:23:34] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10kaldari) [18:13:16] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: MSCompoundFileReaderTest fails on macOS - https://phabricator.wikimedia.org/T225019 (10Jdforrester-WMF) 05Open→03Resolved a:03TK-999 [18:24:45] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata, 10Wikidata-Campsite: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10Ladsgroup) It's very likely to be because of federation, something in Wikibase repo injects all... [18:31:49] 10Multimedia: Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10PDrouin-WMF) [18:32:43] 10Multimedia: Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10PDrouin-WMF) [18:44:11] (03CR) 10Eric Gardner: [C: 03+2] "Looks good to me – I look forward to removing more CSS trickery as we roll out templates." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521222 (owner: 10Matthias Mullie) [19:01:46] (03CR) 10Eric Gardner: [C: 03+2] "This looks good to me, and actually seems like a step in the direction we want to go generally. I feel like GroupWidget does a little too " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [19:24:29] (03CR) 10jerkins-bot: [V: 04-1] Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [19:25:32] (03CR) 10Eric Gardner: [C: 03+2] "Recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [19:30:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10Ramsey-WMF) p:05Triage→03High a:03egardner Assigning this to Eric for now so he doesn't fee... [19:43:26] (03Merged) 10jenkins-bot: Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [19:46:50] (03CR) 10Aaron Schulz: [C: 03+2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/521045 (owner: 10D3r1ck01) [19:48:11] (03CR) 10Aaron Schulz: [C: 03+2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [19:48:14] (03CR) 10jenkins-bot: Don't let OO.ui.mixin.GroupElement detach nodes from template [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521247 (https://phabricator.wikimedia.org/T227274) (owner: 10Matthias Mullie) [19:50:40] (03Merged) 10jenkins-bot: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/521045 (owner: 10D3r1ck01) [19:50:46] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [19:58:55] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata, 10Wikidata-Campsite: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10MarkTraceur) @Ladsgroup I believe SDC won't require lexeme entity rendering, so perhaps you cou... [20:00:25] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): Add UI support for time Wikibase datatype - https://phabricator.wikimedia.org/T227112 (10Ramsey-WMF) p:05Triage→03Normal [20:03:07] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata, 10Wikidata-Campsite: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10Lydia_Pintscher) It is theoretically possible for someone to make a statement on Commons that l... [20:08:47] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10egardner) There are two tasks here, and it may be good to separate them. 1. Add links to each Wi... [21:13:16] 10Multimedia, 10MediaViewer, 10Wikimedia-Hackathon-2019, 10Design, and 3 others: Clicking the black frame should close Multimediaviewer - https://phabricator.wikimedia.org/T133900 (10Jdlrobson) @alexhollender would you be able to weigh in on this question about the DESKTOP version of mediaviewer? [21:18:55] (03PS4) 10Eric Gardner: Only show 'remove all' if property is non-default [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [21:44:17] (03CR) 10Eric Gardner: [C: 03+2] "Looks good to me. The Filepage init.js file is getting pretty complex though – I think that this would be a good target for some future re" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [22:07:21] (03Merged) 10jenkins-bot: Only show 'remove all' if property is non-default [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [22:15:08] (03CR) 10jenkins-bot: Only show 'remove all' if property is non-default [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520035 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle)