[07:30:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/523081 (owner: 10L10n-bot) [07:43:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523077 (owner: 10L10n-bot) [07:50:50] (03CR) 10DCausse: [C: 03+1] Index captions as description field rather than label [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522473 (https://phabricator.wikimedia.org/T226722) (owner: 10Cparle) [09:31:10] (03CR) 10Matthias Mullie: [C: 03+1] "LGTM" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522473 (https://phabricator.wikimedia.org/T226722) (owner: 10Cparle) [10:21:03] (03PS2) 10Cparle: Confirmation msg for 'remove all' on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521461 (https://phabricator.wikimedia.org/T224249) [10:22:27] (03PS4) 10Cparle: Index captions as description field rather than label [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522473 (https://phabricator.wikimedia.org/T226722) [10:23:30] (03CR) 10Matthias Mullie: [C: 03+2] Confirmation msg for 'remove all' on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521461 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [10:34:58] (03CR) 10Zfilipin: [C: 03+2] selenium: Remove test for Special:Version [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522515 (owner: 10Krinkle) [10:47:15] (03Merged) 10jenkins-bot: Confirmation msg for 'remove all' on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521461 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [10:52:09] (03CR) 10jenkins-bot: Confirmation msg for 'remove all' on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521461 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [10:58:21] (03Merged) 10jenkins-bot: selenium: Remove test for Special:Version [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522515 (owner: 10Krinkle) [11:06:08] (03CR) 10jenkins-bot: selenium: Remove test for Special:Version [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522515 (owner: 10Krinkle) [11:22:23] (03CR) 10Matthias Mullie: [C: 03+2] Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [11:26:19] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), and 2 others: Increase curl timeout for importImages.php - https://phabricator.wikimedia.org/T226979 (10Urbanecm) 05Open→03Resolved [11:42:29] (03CR) 10jerkins-bot: [V: 04-1] Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [12:21:17] 10Multimedia, 10SDC General, 10Wikidata, 10CommRel-Specialists-Support (Apr-Jun-2019): Abuse filter support for depicts and statements - https://phabricator.wikimedia.org/T218149 (10Elitre) 05Open→03Declined See https://phabricator.wikimedia.org/T213764#5328893 . [12:21:20] 10Multimedia, 10SDC General, 10CommRel-Specialists-Support (Apr-Jun-2019): Community Relations support for the depicts statement SDC release - https://phabricator.wikimedia.org/T213764 (10Elitre) [13:06:09] (03CR) 10Matthias Mullie: "Some feedback after testing." (035 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [13:07:02] (03PS8) 10Matthias Mullie: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [13:07:51] (03CR) 10Matthias Mullie: [C: 03+1] "LGTM, but won't merge myself because I made some small changes in last patchset." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [13:26:23] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [13:30:36] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [14:48:33] 10Multimedia, 10UploadWizard: Align Special:UploadWizard warning message appearance to Style Guide - https://phabricator.wikimedia.org/T228064 (10Volker_E) [15:31:13] (03PS9) 10Matthias Mullie: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [15:48:51] 10Multimedia, 10UploadWizard: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Urbanecm) [15:49:26] 10Multimedia, 10UploadWizard: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Urbanecm) [15:52:42] (03PS1) 10Urbanecm: Remove Image-reviewer group from extension.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) [15:52:57] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10MarcoAurelio) Agreed. This `Image-reviewers` group seems very Wikimedia-specific to be defined in the extension's code. I suggest to drop it from the extension code... [15:56:23] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Urbanecm) Do you think this needs to be announced somewhere, as a (potentionally) breaking change? [15:57:03] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10MarcoAurelio) I'll also note that this was added in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/UploadWizard/+/bfdb1ab697fecf2a1b184128c387b... [15:59:42] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Urbanecm) >>! In T228073#5333768, @MarcoAurelio wrote: > This is not a user right that the extension needs apparently, and the `mass-upload` permission can simply b... [16:03:49] (03CR) 10Matthias Mullie: [C: 04-1] "Patch LGTM, but need to wait for follow-up where popover thingy is added." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [16:04:32] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Steinsplitter) >>! In T228073#5333767, @Urbanecm wrote: > Do you think this needs to be announced somewhere, as a (potentionally) breaking change? This is for http... [16:05:39] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Multimedia-Current-Work: "Add a caption" is broken - https://phabricator.wikimedia.org/T227798 (10matthiasmullie) a:05matthiasmullie→03Edtadros [16:05:45] (03PS5) 10Matthias Mullie: Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [16:07:00] (03CR) 10jerkins-bot: [V: 04-1] Remove Image-reviewer group from extension.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [16:08:22] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Urbanecm) @Steinsplitter This task isn't about _deleting_ this group from our wikis. This is just about removing the group from extension.json (=stuff defined there... [16:09:09] 10Multimedia, 10UploadWizard, 10Patch-For-Review: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10Steinsplitter) >>! In T228073#5333799, @Urbanecm wrote: > @Steinsplitter This task isn't about _deleting_ this group from our wikis. This is just about removing the... [16:13:57] (03PS1) 10Urbanecm: [DNM] Test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 [16:14:03] (03CR) 10Urbanecm: "This change is ready for review." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:15:59] (03CR) 10MarkTraceur: [C: 04-2] "Please don't upload test commits to real repositories, at least not without explaining what you're testing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:16:35] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:18:24] (03CR) 10Urbanecm: "> Patch Set 1: Code-Review-2" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:18:28] (03Abandoned) 10Urbanecm: [DNM] Test [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:18:40] (03CR) 10MarcoAurelio: "Urbanecm is a Wikimedia deployer and I think he's testing the jenkins-bot failures on a previous patch he's submitted :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:20:00] (03CR) 10MarkTraceur: "> Patch Set 1:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523221 (owner: 10Urbanecm) [16:21:28] (03CR) 10MarcoAurelio: "Looks like it's `ObjectCache::getMainWANInstance`; a deprecated function. No idea how to fix PHPUnit tests though." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [16:25:58] (03CR) 10Urbanecm: "> Patch Set 1:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [16:29:53] (03CR) 10jerkins-bot: [V: 04-1] Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [16:34:07] (03CR) 10jerkins-bot: [V: 04-1] Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner) [16:35:56] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Only Depicts statement panels should have Learn More links (for now) - https://phabricator.wikimedia.org/T227226 (10matthiasmullie) a:05Cparle→03Edtadros [16:37:24] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Only Depicts statement panels should have Learn More links (for now) - https://phabricator.wikimedia.org/T227226 (10matthiasmullie) [17:43:16] (03PS1) 10Jforrester: UploadWizardCampaign: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523242 [17:44:53] (03PS1) 10Jforrester: ApiFileAnnotations: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/523243 [17:45:11] (03PS2) 10Jforrester: Remove Image-reviewer group from extension.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [17:49:11] (03CR) 10Jforrester: [C: 03+2] Remove Image-reviewer group from extension.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [17:50:27] (03CR) 10Aaron Schulz: [C: 03+2] UploadWizardCampaign: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523242 (owner: 10Jforrester) [17:50:47] (03CR) 10Aaron Schulz: [C: 03+2] ApiFileAnnotations: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/523243 (owner: 10Jforrester) [17:56:03] (03Merged) 10jenkins-bot: UploadWizardCampaign: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523242 (owner: 10Jforrester) [17:56:05] (03Merged) 10jenkins-bot: Remove Image-reviewer group from extension.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [17:56:07] (03Merged) 10jenkins-bot: ApiFileAnnotations: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/523243 (owner: 10Jforrester) [17:58:49] (03CR) 10jenkins-bot: UploadWizardCampaign: Stop using deprecated ObjectCache::getMainWANInstance() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523242 (owner: 10Jforrester) [18:00:59] (03CR) 10jenkins-bot: Remove Image-reviewer group from extension.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523208 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [19:06:53] 10Multimedia, 10UploadWizard, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Patch-For-Review, 10User-Urbanecm: Remove Image-reviewer group from extension.json - https://phabricator.wikimedia.org/T228073 (10matmarex) 05Open→03Resolved a:03Urbanecm [19:09:26] 10Multimedia, 10UploadWizard: Align Special:UploadWizard warning message appearance to Style Guide - https://phabricator.wikimedia.org/T228064 (10matmarex) The message is not part of the source code, it's defined in https://commons.wikimedia.org/wiki/MediaWiki:Uploadwizard-summary (https://commons.wikimedia.or... [19:12:30] 10Multimedia, 10UploadWizard: UploadWizard tests failing due to "Use of ObjectCache::getMainWANInstance was deprecated in MediaWiki 1.28" - https://phabricator.wikimedia.org/T227990 (10matmarex) 05Open→03Resolved a:03Jdforrester-WMF Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWiz... [19:17:52] (03PS1) 10Urbanecm: Remove Image-reviewer group from extension.json [extensions/UploadWizard] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/523289 (https://phabricator.wikimedia.org/T228073) [19:20:01] (03CR) 10jerkins-bot: [V: 04-1] Remove Image-reviewer group from extension.json [extensions/UploadWizard] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/523289 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [19:24:22] (03CR) 10Legoktm: [C: 03+2] "Should be fixed now." [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/522976 (owner: 10Libraryupgrader) [19:38:34] (03Abandoned) 10Urbanecm: Remove Image-reviewer group from extension.json [extensions/UploadWizard] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/523289 (https://phabricator.wikimedia.org/T228073) (owner: 10Urbanecm) [19:41:13] 10Multimedia, 10UploadWizard: UploadWizard tests failing due to "Use of ObjectCache::getMainWANInstance was deprecated in MediaWiki 1.28" - https://phabricator.wikimedia.org/T227990 (10Jdforrester-WMF) Oh, hah, didn't know this had been filed yet. [20:24:34] (03CR) 10Smalyshev: "> Patch Set 3: Code-Review+1" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522473 (https://phabricator.wikimedia.org/T226722) (owner: 10Cparle) [20:27:22] (03CR) 10D3r1ck01: "@James_F, I rechecked this: Ib3f29188c6b5bdf5a9397 until I got tired, same patch but it kept failing :( but thanks for handling this. I'll" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/523242 (owner: 10Jforrester) [20:28:00] (03Abandoned) 10D3r1ck01: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/520454 (owner: 10D3r1ck01) [21:39:01] (03PS2) 10Eric Gardner: Add LinkNoticeWidget above Statements Panel [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522563 (https://phabricator.wikimedia.org/T227230) [21:39:32] (03PS3) 10Eric Gardner: Add LinkNoticeWidget above Statements Panel [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522563 (https://phabricator.wikimedia.org/T227230)