[00:14:50] (03CR) 10Eric Gardner: [C: 03+2] "This is great - I wholeheartedly support having a consistent, react-like baseline that the rest of our UI components can start following." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [01:07:21] (03Merged) 10jenkins-bot: Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [01:10:17] (03CR) 10Eric Gardner: [C: 03+2] Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 (owner: 10Matthias Mullie) [01:16:58] (03CR) 10jenkins-bot: Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [02:02:42] (03Merged) 10jenkins-bot: Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 (owner: 10Matthias Mullie) [02:14:12] (03CR) 10jenkins-bot: Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 (owner: 10Matthias Mullie) [02:26:16] (03CR) 10Eric Gardner: [C: 03+2] Convert NewQualifierWidget to ComponentWidget (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [03:18:19] (03Merged) 10jenkins-bot: Convert NewQualifierWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [03:20:10] (03CR) 10Eric Gardner: [C: 03+2] Convert ItemWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525291 (owner: 10Matthias Mullie) [03:24:00] (03CR) 10jenkins-bot: Convert NewQualifierWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [03:44:01] (03PS15) 10Eric Gardner: Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) [03:44:27] (03CR) 10Eric Gardner: Refactor UW Statements Code (037 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [03:46:46] (03CR) 10jerkins-bot: [V: 04-1] Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [04:02:00] (03CR) 10Eric Gardner: "Looks like the tests in Special:JavascriptTest fail because:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [04:08:53] (03Merged) 10jenkins-bot: Convert ItemWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525291 (owner: 10Matthias Mullie) [04:10:23] (03CR) 10Eric Gardner: [C: 03+2] Convert StatementWidget.js to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531505 (owner: 10Matthias Mullie) [04:21:20] (03CR) 10jenkins-bot: Convert ItemWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525291 (owner: 10Matthias Mullie) [05:08:05] (03Merged) 10jenkins-bot: Convert StatementWidget.js to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531505 (owner: 10Matthias Mullie) [05:08:48] (03PS15) 10Eric Gardner: Add page protection message to file page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/530617 (https://phabricator.wikimedia.org/T221732) (owner: 10Anne Tomasevich) [05:09:06] (03PS3) 10Eric Gardner: Tests: Add unit tests for getProtectionMsg [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531696 (https://phabricator.wikimedia.org/T221732) (owner: 10Kosta Harlan) [05:09:14] (03PS3) 10Eric Gardner: Tests: Add test coverage for userCanEdit() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531711 (https://phabricator.wikimedia.org/T221732) (owner: 10Anne Tomasevich) [05:20:05] (03CR) 10jenkins-bot: Convert StatementWidget.js to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531505 (owner: 10Matthias Mullie) [06:33:20] (03CR) 10Matthias Mullie: Convert NewQualifierWidget to ComponentWidget (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [08:19:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531862 (owner: 10L10n-bot) [08:26:56] (03CR) 10Matthias Mullie: "Just some minor feedback; it all seems to work great - will submit follow-up and merge." (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [08:28:56] (03PS16) 10Matthias Mullie: Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [08:32:03] (03CR) 10jerkins-bot: [V: 04-1] Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [08:34:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/531856 (owner: 10L10n-bot) [08:38:33] (03CR) 10jenkins-bot: build: Updating eslint-utils to 1.4.2 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/531864 (owner: 10Libraryupgrader) [08:54:13] (03PS17) 10Matthias Mullie: Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [08:54:22] (03CR) 10Matthias Mullie: Refactor UW Statements Code (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [09:13:45] (03CR) 10jerkins-bot: [V: 04-1] Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [09:21:58] (03PS18) 10Matthias Mullie: Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [09:33:52] (03CR) 10Matthias Mullie: [C: 03+2] "There we go!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [09:40:36] (03Merged) 10jenkins-bot: Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [09:43:03] (03CR) 10jenkins-bot: Refactor UW Statements Code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/529840 (https://phabricator.wikimedia.org/T225102) (owner: 10Eric Gardner) [09:59:12] (03CR) 10Kosta Harlan: [C: 04-1] Tests: Add test coverage for userCanEdit() (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531711 (https://phabricator.wikimedia.org/T221732) (owner: 10Anne Tomasevich) [10:30:37] (03PS4) 10Anne Tomasevich: Tests: Add test coverage for userCanEdit() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531711 (https://phabricator.wikimedia.org/T221732) [10:32:08] (03CR) 10Anne Tomasevich: "> Patch Set 3: Code-Review-1" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531711 (https://phabricator.wikimedia.org/T221732) (owner: 10Anne Tomasevich) [11:12:07] (03CR) 10Kosta Harlan: [C: 03+2] Tests: Add test coverage for userCanEdit() (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531711 (https://phabricator.wikimedia.org/T221732) (owner: 10Anne Tomasevich) [12:19:13] (03PS1) 10Matthias Mullie: Convert LinkNoticeWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531917 [12:19:15] (03PS1) 10Matthias Mullie: Convert Convert QualifierValueInputWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531918 [12:19:18] (03PS1) 10Matthias Mullie: No need to deal with formatvalue caches if they've already been cleaned up [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531919 [12:33:04] (03CR) 10Anne Tomasevich: [C: 03+2] Tests: Add unit tests for getProtectionMsg [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531696 (https://phabricator.wikimedia.org/T221732) (owner: 10Kosta Harlan) [13:03:57] (03CR) 10jerkins-bot: [V: 04-1] Convert Convert QualifierValueInputWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531918 (owner: 10Matthias Mullie) [13:04:10] (03CR) 10jerkins-bot: [V: 04-1] Convert LinkNoticeWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531917 (owner: 10Matthias Mullie) [13:04:13] (03CR) 10Jforrester: [C: 03+2] build: Updating eslint-utils to 1.4.2 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531904 (owner: 10Libraryupgrader) [13:07:29] (03CR) 10jerkins-bot: [V: 04-1] No need to deal with formatvalue caches if they've already been cleaned up [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531919 (owner: 10Matthias Mullie) [13:59:55] (03PS2) 10Matthias Mullie: Convert LinkNoticeWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531917 [14:00:24] (03PS2) 10Matthias Mullie: Convert Convert QualifierValueInputWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531918 [14:35:32] (03CR) 10Matthias Mullie: [C: 04-1] "This one needs a little more work (qunit tests mostly - stubbing out formatValue due to lack of actual API endpoints is getting annoying)," [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531918 (owner: 10Matthias Mullie) [14:41:28] (03CR) 10jerkins-bot: [V: 04-1] Convert LinkNoticeWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531917 (owner: 10Matthias Mullie) [14:44:23] (03CR) 10jerkins-bot: [V: 04-1] Convert Convert QualifierValueInputWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531918 (owner: 10Matthias Mullie) [16:01:05] (03CR) 10jerkins-bot: [V: 04-1] build: Updating eslint-utils to 1.4.2 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531904 (owner: 10Libraryupgrader) [22:07:42] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/531904 (owner: 10Libraryupgrader)