[01:30:07] 10Multimedia, 10MediaViewer, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10Patch-For-Review: Clicking on images takes you to a black screen due to JS error from MediaViewer using mw.Title internals which have changed - https://phabricator.wikimedia.org/T232521 (10Krinkle) 05Open→03Resolved a:03Catrope [08:30:25] (03CR) 10Matthias Mullie: [WIP] Provide an alternative PrefetchingTermLookup for MediaInfo entities (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525794 (https://phabricator.wikimedia.org/T223792) (owner: 10Matthias Mullie) [09:59:41] 10Multimedia, 10MediaViewer, 10MediaWiki-Core-Testing, 10MobileFrontend, and 7 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10awight) [10:00:18] 10Multimedia, 10MediaViewer, 10MediaWiki-Core-Testing, 10MobileFrontend, and 7 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10awight) [10:02:01] 10Multimedia, 10MediaViewer, 10MediaWiki-Core-Testing, 10MobileFrontend, and 7 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10awight) [11:32:13] (03CR) 10Lucas Werkmeister (WMDE): [WIP] Provide an alternative PrefetchingTermLookup for MediaInfo entities (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525794 (https://phabricator.wikimedia.org/T223792) (owner: 10Matthias Mullie) [12:03:53] (03CR) 10Cparle: [C: 03+2] Skip formatValue calls for input types where we don't need it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534158 (owner: 10Matthias Mullie) [12:37:50] 10Multimedia, 10MediaViewer, 10Design, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), and 2 others: Clicking the black frame should close Multimediaviewer - https://phabricator.wikimedia.org/T133900 (10Gilles) @Jdlrobson This recently merged change is likely the cause of {T231895} [13:15:36] (03PS6) 10Matthias Mullie: Provide an alternative PrefetchingTermLookup for MediaInfo entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525794 (https://phabricator.wikimedia.org/T223792) [13:55:01] (03CR) 10Cparle: [C: 03+2] Improve DOM merge logic - nodes with different props are not equal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/533166 (https://phabricator.wikimedia.org/T231225) (owner: 10Matthias Mullie) [14:25:36] (03CR) 10Cparle: [C: 03+2] Skip formatValue calls for input types where we don't need it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534158 (owner: 10Matthias Mullie) [14:26:43] (03CR) 10Cparle: [C: 03+2] Add summary and tags parameters to StatementWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534909 (owner: 10Lucas Werkmeister) [15:09:18] 10Multimedia, 10MediaViewer, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10): Clicking on images takes you to a black screen due to JS error from MediaViewer using mw.Title internals which have changed - https://phabricator.wikimedia.org/T232521 (10Esanders) The patches above have fixed some known uses, but I'm... [15:36:37] (03PS1) 10Anne Tomasevich: Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) [15:37:04] 10Multimedia, 10MediaViewer, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), and 2 others: Multimedia viewer does not open for Minerva desktop images - https://phabricator.wikimedia.org/T227034 (10Masumrezarock100) [16:11:06] (03Merged) 10jenkins-bot: Improve DOM merge logic - nodes with different props are not equal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/533166 (https://phabricator.wikimedia.org/T231225) (owner: 10Matthias Mullie) [16:21:44] (03PS2) 10Anne Tomasevich: Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) [16:46:55] (03CR) 10jenkins-bot: Improve DOM merge logic - nodes with different props are not equal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/533166 (https://phabricator.wikimedia.org/T231225) (owner: 10Matthias Mullie) [17:01:17] 10Multimedia, 10MediaViewer, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), and 2 others: Multimedia viewer does not open for Minerva desktop images - https://phabricator.wikimedia.org/T227034 (10Masumrezarock100) >>! In T227034#5376860, @Jdlrobson wrote: > Works on https://en.wikipedi... [17:02:58] (03Merged) 10jenkins-bot: Skip formatValue calls for input types where we don't need it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534158 (owner: 10Matthias Mullie) [17:03:37] (03CR) 10jerkins-bot: [V: 04-1] Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) (owner: 10Anne Tomasevich) [17:03:56] (03Merged) 10jenkins-bot: Add summary and tags parameters to StatementWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534909 (owner: 10Lucas Werkmeister) [17:07:13] (03CR) 10jenkins-bot: Skip formatValue calls for input types where we don't need it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534158 (owner: 10Matthias Mullie) [17:18:20] (03CR) 10jenkins-bot: Add summary and tags parameters to StatementWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534909 (owner: 10Lucas Werkmeister) [17:30:49] (03PS3) 10Anne Tomasevich: Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) [17:31:28] (03PS4) 10Anne Tomasevich: Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) [17:33:31] 10Multimedia, 10MediaWiki-Uploading, 10UploadWizard: 4 files, that will not upload with uploadwizard (Internal error: Server failed to store temporary file.) for server-side upload - https://phabricator.wikimedia.org/T229249 (10Aklapper) Going through this task and the date of the comments: T228749 and T2289... [18:01:44] (03PS5) 10Anne Tomasevich: Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) [18:02:47] (03PS6) 10Anne Tomasevich: Add links to autocomplete options to enable middle-clicking [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) [18:04:40] (03CR) 10Anne Tomasevich: "Since default behavior of middle click is to open link in a new tab, all that was needed here was changing the `` element wrapping l" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535876 (https://phabricator.wikimedia.org/T224604) (owner: 10Anne Tomasevich) [22:18:44] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Patch-For-Review, and 2 others: XMPReader::parse exceptions - https://phabricator.wikimedia.org/T118799 (10TheDJ) so.... turns out we are missing the XMP data from a significant number of files most likely... ;) [22:19:21] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Patch-For-Review, and 2 others: XMPReader::parse exceptions - https://phabricator.wikimedia.org/T118799 (10TheDJ) [22:19:25] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-Site-requests: Force a refresh of the EXIF metadata of all jpgs in production once new EXIF code lands - https://phabricator.wikimedia.org/T231393 (10TheDJ) [22:22:29] James_F: ^ was a fun one ;) [22:23:33] Oh dear. [22:27:26] took me quite some time to figure out... [22:28:31] nullchars mess with your expectations about what things are diong [22:50:16] Should we make XMPReader tolerate \0 chars as well? [22:50:21] Or just rely on fixing MW itself? [22:56:36] well.. it's a chunk based parser, so we can't use trim for that, as other whitespace inside the xmp might drop off. [22:57:01] if you just feed it a proper string there isnt a problem. [22:57:15] i consider the extraction to have been broken, not the parsing of xmp. [22:58:02] also, i'm not even sure this is in spec... it's just that most languages stop str reading at a \0 [22:58:15] so most languages never notice. php does [23:11:57] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-Site-requests: Force a refresh of the EXIF metadata of all jpgs in production once new EXIF code lands - https://phabricator.wikimedia.org/T231393 (10matmarex) Is this about running the refreshImageMetadata.php script? As of 2017 it was cons... [23:21:38] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-Site-requests: Force a refresh of the EXIF metadata of all jpgs in production once new EXIF code lands - https://phabricator.wikimedia.org/T231393 (10Jdforrester-WMF) Not impossible, "just" needs some code tweaking to use jobs rather than di... [23:30:13] thedj: Fair. Also, boo ^' [23:31:19] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-Site-requests: Force a refresh of the EXIF metadata of all jpgs in production once new EXIF code lands - https://phabricator.wikimedia.org/T231393 (10matmarex) Well, I'm glad someone is planning to work on it :) [23:58:02] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent" - https://phabricator.wikimedia.org/T225197 (10Krinkle)