[00:50:37] (03PS5) 10Eric Gardner: Allow users to see locations of existing coordinates on map [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/562939 (https://phabricator.wikimedia.org/T227116) [00:57:07] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/562939 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [03:12:03] 10Multimedia, 10MediaWiki-extensions-WikibaseRepository, 10StructuredDataOnCommons, 10WikibaseMediaInfo, and 2 others: Creating a Commons gallery page incorrectly states "This entity does not exist." - https://phabricator.wikimedia.org/T227699 (10TerraCodes) Could you link the page its showing that on? Whe... [06:20:32] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563343 (owner: 10Libraryupgrader) [08:46:01] (03PS1) 10Addshore: Adopt namechange BufferingTermLookup -> BufferingTermIndexTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563380 [08:59:01] (03CR) 10Ladsgroup: [C: 03+2] Use new namespace for PrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563227 (https://phabricator.wikimedia.org/T242096) (owner: 10Addshore) [09:02:43] (03CR) 10Ladsgroup: [C: 03+2] Adopt namechange BufferingTermLookup -> BufferingTermIndexTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563380 (owner: 10Addshore) [09:20:10] (03Merged) 10jenkins-bot: Use new namespace for PrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563227 (https://phabricator.wikimedia.org/T242096) (owner: 10Addshore) [11:56:31] (03PS1) 10Addshore: WIP: DNM: wbterms: adopt getPrefetchedAliases for PrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563428 [12:26:00] (03Merged) 10jenkins-bot: Adopt namechange BufferingTermLookup -> BufferingTermIndexTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563380 (owner: 10Addshore) [12:33:45] (03PS6) 10Matthias Mullie: Improved media-specific search [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563106 [12:40:15] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563106 (owner: 10Matthias Mullie) [12:46:17] (03CR) 10jerkins-bot: [V: 04-1] Improved media-specific search [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563106 (owner: 10Matthias Mullie) [12:55:28] (03PS2) 10Addshore: wbterms: adopt getPrefetchedAliases for PrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563428 (https://phabricator.wikimedia.org/T242326) [17:16:53] 10Multimedia, 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Google-Code-in-2019, 10good first task: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Florian) [17:16:59] 10Multimedia, 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Google-Code-in-2019, 10good first task: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Florian) I'll mentor this in GCI :) [17:21:46] 10Multimedia, 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Google-Code-in-2019, 10good first task: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Florian) Imported as https://codein.withgoogle.com/dashboard/tasks/5658834341724160/ [20:35:40] (03CR) 10Brion VIBBER: "darned npm undid the pin for me when I updated, I must be using the cli wrong. :D fixing..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/562383 (owner: 10Brion VIBBER) [20:38:41] (03CR) 10Jforrester: [C: 04-1] "> Patch Set 1:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/562383 (owner: 10Brion VIBBER) [20:39:06] (03PS2) 10Brion VIBBER: Update video.js to 7.7.4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/562383 [20:41:19] (03PS5) 10Brion VIBBER: Transform audio players in video.js mode again [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/553442 (https://phabricator.wikimedia.org/T228339) [20:45:04] (03CR) 10Jforrester: [C: 03+2] Update video.js to 7.7.4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/562383 (owner: 10Brion VIBBER) [20:47:41] (03PS1) 10Anne Tomasevich: Update metadata step UX for clarity [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563578 (https://phabricator.wikimedia.org/T224890) [20:50:13] (03CR) 10jerkins-bot: [V: 04-1] Update metadata step UX for clarity [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563578 (https://phabricator.wikimedia.org/T224890) (owner: 10Anne Tomasevich) [20:59:25] (03CR) 10jerkins-bot: [V: 04-1] Transform audio players in video.js mode again [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/553442 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [21:02:54] (03CR) 10Brion VIBBER: "Test failure are from the crossorigin attribute, I think they're being applied here where they shouldn't be as I think that's meant to be " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/553442 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [21:05:22] (03Merged) 10jenkins-bot: Update video.js to 7.7.4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/562383 (owner: 10Brion VIBBER) [21:09:11] (03PS2) 10Anne Tomasevich: WIP: the logic for enabling the publish button isn't quite there; ideally we'd enable it when the user is on the final step AND there is structured data. This becomes more complicated when the user adds the SD on the final step. Still more to do here... [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563578 (https://phabricator.wikimedia.org/T224890) [21:11:19] (03CR) 10jerkins-bot: [V: 04-1] WIP: the logic for enabling the publish button isn't quite there; ideally we'd enable it when the user is on the final step AND there is structured data. This becomes more complicated when the user adds the SD on the final step. Still more to do here... [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563578 (https://phabricator.wikimedia.org/T224890) (owner: 10Anne Tomasevic [21:32:12] (03PS6) 10Brion VIBBER: Transform audio players in video.js mode again [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/553442 (https://phabricator.wikimedia.org/T228339) [21:34:49] let's see if i've placated the test gods [21:48:34] (03CR) 10jerkins-bot: [V: 04-1] Transform audio players in video.js mode again [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/553442 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [22:29:55] (03PS1) 10Jforrester: build: Fix no-jquery/no-parse-html-literal warnings, move over-rides for Kaltura down [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/563593 [22:42:22] (03CR) 10Brion VIBBER: [C: 03+2] "hooray for silencing awful warnings" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/563593 (owner: 10Jforrester) [23:04:37] (03Merged) 10jenkins-bot: build: Fix no-jquery/no-parse-html-literal warnings, move over-rides for Kaltura down [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/563593 (owner: 10Jforrester) [23:37:39] (03PS1) 10Bartosz Dziewoński: Replace messages removed in MediaWiki core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563608 [23:42:33] (03CR) 10Jforrester: [C: 03+1] Replace messages removed in MediaWiki core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563608 (owner: 10Bartosz Dziewoński) [23:45:49] (03PS1) 10Bartosz Dziewoński: Fix exception when clicking the "Retry failed uploads" button [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563611 [23:54:24] (03PS2) 10Jforrester: build: Updating npm dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/563343 (owner: 10Libraryupgrader)