[10:44:33] (03PS1) 10Cparle: Styling fixes for constraints [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/584565 (https://phabricator.wikimedia.org/T239163) [10:53:26] (03PS2) 10Lucas Werkmeister (WMDE): Move constraints popup to OOUI overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) [10:59:25] (03CR) 10Cparle: [C: 03+2] Move constraints popup to OOUI overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) (owner: 10Lucas Werkmeister (WMDE)) [11:05:10] (03CR) 10jerkins-bot: [V: 04-1] Styling fixes for constraints [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/584565 (https://phabricator.wikimedia.org/T239163) (owner: 10Cparle) [11:20:29] (03CR) 10jerkins-bot: [V: 04-1] Move constraints popup to OOUI overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) (owner: 10Lucas Werkmeister (WMDE)) [11:48:50] (03PS2) 10Cparle: Styling fixes for constraints [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/584565 (https://phabricator.wikimedia.org/T239163) [12:19:42] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] "retry gate-and-submit, probably failed due to T248459" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) (owner: 10Lucas Werkmeister (WMDE)) [12:42:14] (03CR) 10jerkins-bot: [V: 04-1] Move constraints popup to OOUI overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) (owner: 10Lucas Werkmeister (WMDE)) [12:48:13] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] "try again, I guess?" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) (owner: 10Lucas Werkmeister (WMDE)) [13:04:56] (03PS23) 10Matthias Mullie: [DO NOT MERGE] Hacks to test media search improvements on production data [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/565248 [13:09:08] (03Merged) 10jenkins-bot: Move constraints popup to OOUI overlay [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/583992 (https://phabricator.wikimedia.org/T239163) (owner: 10Lucas Werkmeister (WMDE)) [13:30:04] (03PS35) 10Matthias Mullie: Improved media-specific search [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563106 (https://phabricator.wikimedia.org/T216625) [13:46:22] (03CR) 10jerkins-bot: [V: 04-1] Improved media-specific search [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563106 (https://phabricator.wikimedia.org/T216625) (owner: 10Matthias Mullie) [14:27:59] (03PS36) 10Matthias Mullie: Improved media-specific search [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/563106 (https://phabricator.wikimedia.org/T216625) [15:17:59] (03CR) 10Cparle: [C: 04-1] "If I add a qualifier with "somevalue" and then change the property, the disabled textbox becomes enabled which I guess it shouldn't" (037 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/572124 (https://phabricator.wikimedia.org/T239172) (owner: 10Anne Tomasevich) [16:18:53] (03CR) 10Brion VIBBER: [C: 03+2] Use config factory rather than a global [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/583118 (owner: 10Jforrester) [16:29:00] 10Multimedia, 10Analytics, 10Tool-Pageviews: Image files with quotes do not resolve on the mediarequest API - https://phabricator.wikimedia.org/T247333 (10fdans) hellooo @JAllemandou can you put here the gist with the code to get the non-urlencoded chars? [16:29:11] 10Multimedia, 10Analytics, 10Tool-Pageviews: Image files with quotes do not resolve on the mediarequest API - https://phabricator.wikimedia.org/T247333 (10fdans) https://gist.github.com/jobar/f969585562f5c5731c0195cc5c1fb311 [16:29:48] 10Multimedia, 10Analytics, 10Tool-Pageviews: Image files with quotes do not resolve on the mediarequest API - https://phabricator.wikimedia.org/T247333 (10fdans) p:05Triage→03High [16:42:01] (03Merged) 10jenkins-bot: Use config factory rather than a global [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/583118 (owner: 10Jforrester) [16:45:05] one patch merged. ha-ha-ha [17:00:30] (03PS10) 10Brion VIBBER: Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:04:41] (03CR) 10Brion VIBBER: [C: 03+1] "Rebased and fixed a merge conflict from another cleanup patch (I think correctly). Looking ok to folks still?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:11:47] (03CR) 10Krinkle: [C: 04-1] Convert $wgMemc use to WANObjectCache (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:18:37] (03CR) 10Brion VIBBER: [C: 03+1] "oops I broke it. Fixing." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:19:03] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:19:48] (03PS11) 10Brion VIBBER: Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:23:29] and now we play "who catches the remaining errors in the rebase: jenkins or kr inkle?" :D [17:40:20] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [17:46:15] (03CR) 10Jforrester: "> Patch Set 10: Code-Review+1" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [18:04:05] (03CR) 10Brion VIBBER: [C: 03+1] "lemme fix" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [18:54:02] (03PS12) 10Brion VIBBER: Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:17:43] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:38:48] (03PS13) 10Brion VIBBER: Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [20:04:58] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [20:13:48] 10Multimedia, 10MediaViewer: Test if replacing the blur effect with pixelation makes loading feel faster - https://phabricator.wikimedia.org/T71609 (10Gilles) [20:17:12] (03CR) 10Brion VIBBER: "I'm afraid I don't understand what's still failing. I may have missed a line in the log output." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [21:00:30] (03PS14) 10Jforrester: Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [21:00:51] brion: That was a change in CI, now reverted. Should work now. Have bumped extension.json; if it passes, let's C+2. [21:00:58] \o/ [21:01:04] i hope i dun it right [21:01:08] we'll find out soon :D [21:01:10] * James_F too. [21:01:18] In production tomorrow? ;-) [21:01:34] life comes at you fast! [21:02:04] honestly that's the easiest way to test it thanks to its weird edge cases with repo classes ;) [21:02:13] though beta should work the kinks out [21:02:17] *beta cluster [21:05:26] Yeah. [21:42:44] (03CR) 10Jforrester: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [21:55:45] (03PS18) 10Anne Tomasevich: Add somevalue/novalue options for entity datatype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/572124 (https://phabricator.wikimedia.org/T239172) [21:57:14] (03CR) 10Anne Tomasevich: [C: 04-2] "Thanks for all the feedback Cormac! I've made changes for all items except one, which I commented on." (037 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/572124 (https://phabricator.wikimedia.org/T239172) (owner: 10Anne Tomasevich) [22:19:50] (03CR) 10jerkins-bot: [V: 04-1] Add somevalue/novalue options for entity datatype [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/572124 (https://phabricator.wikimedia.org/T239172) (owner: 10Anne Tomasevich) [22:31:51] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/570728 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [22:32:15] oh happy day [22:32:19] merge \o/ [22:32:37] Indeed. [23:20:51] 10Multimedia, 10Commons, 10UploadWizard, 10Notice, and 2 others: Do not put "verified" template on UploadWizard Flicker uploads if user isn't trusted - https://phabricator.wikimedia.org/T100062 (10kaldari) @AlexisJazz - Can this be closed now?