[06:30:42] (03CR) 10Itamar Givon: [C: 03+2] "LGTM, The Only question I have is how these tests didn't fail in CI before this patch, but that's perhaps for another forum" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615483 (https://phabricator.wikimedia.org/T250930) (owner: 10Michael Große) [10:41:35] (03CR) 10Lucas Werkmeister (WMDE): Avoid using $wgWBRepoSettings directly (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615579 (https://phabricator.wikimedia.org/T257447) (owner: 10Ladsgroup) [11:30:33] (03PS9) 10Cparle: Turn on MediaSearch profile for all searches incl NS_FILE [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/613153 (https://phabricator.wikimedia.org/T258172) [11:55:19] (03CR) 10jerkins-bot: [V: 04-1] Turn on MediaSearch profile for all searches incl NS_FILE [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/613153 (https://phabricator.wikimedia.org/T258172) (owner: 10Cparle) [14:24:03] (03CR) 10DCausse: "the query looks good to me" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/613153 (https://phabricator.wikimedia.org/T258172) (owner: 10Cparle) [14:40:52] (03PS2) 10Ladsgroup: Avoid using $wgWBRepoSettings directly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615579 (https://phabricator.wikimedia.org/T257447) [14:40:56] (03CR) 10Ladsgroup: Avoid using $wgWBRepoSettings directly (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615579 (https://phabricator.wikimedia.org/T257447) (owner: 10Ladsgroup) [14:41:56] (03PS10) 10Cparle: Turn on MediaSearch profile for all searches incl NS_FILE [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/613153 (https://phabricator.wikimedia.org/T258172) [14:45:25] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] Avoid using $wgWBRepoSettings directly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615579 (https://phabricator.wikimedia.org/T257447) (owner: 10Ladsgroup) [15:02:25] (03PS11) 10Cparle: Turn on MediaSearch profile for all searches incl NS_FILE [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/613153 (https://phabricator.wikimedia.org/T258172) [15:11:40] (03Merged) 10jenkins-bot: Avoid using $wgWBRepoSettings directly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615579 (https://phabricator.wikimedia.org/T257447) (owner: 10Ladsgroup) [15:50:48] (03PS1) 10Tobias Andersson: LanguageFallbackChain has been renamed. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615787 (https://phabricator.wikimedia.org/T250930) [16:12:05] (03PS1) 10Reedy: T258721 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615771 [16:14:43] (03CR) 10jerkins-bot: [V: 04-1] T258721 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615771 (owner: 10Reedy) [16:15:49] (03CR) 10Tobias Andersson: "Looks like we missed one more rename." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615787 (https://phabricator.wikimedia.org/T250930) (owner: 10Tobias Andersson) [16:17:06] (03CR) 10Tobias Andersson: "This change is ready for review." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615787 (https://phabricator.wikimedia.org/T250930) (owner: 10Tobias Andersson) [16:18:27] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] LanguageFallbackChain has been renamed. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615787 (https://phabricator.wikimedia.org/T250930) (owner: 10Tobias Andersson) [16:24:23] (03PS1) 10Reedy: tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) [16:25:43] (03PS2) 10Reedy: tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) [16:29:41] (03CR) 10Reedy: [C: 03+2] tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) (owner: 10Reedy) [16:32:17] (03CR) 10jerkins-bot: [V: 04-1] tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) (owner: 10Reedy) [16:34:50] (03PS1) 10Reedy: Bump mediawiki/mediawiki-codesniffer to 19.1.0 for PHP 7.3 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615774 [16:35:17] (03PS2) 10Reedy: Bump mediawiki/mediawiki-codesniffer to 19.1.0 for PHP 7.3 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615774 [16:37:13] (03CR) 10jerkins-bot: [V: 04-1] Bump mediawiki/mediawiki-codesniffer to 19.1.0 for PHP 7.3 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615774 (owner: 10Reedy) [16:38:53] (03PS3) 10Reedy: Bump mediawiki/mediawiki-codesniffer to 19.1.0 for PHP 7.3 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615774 [16:41:38] (03CR) 10jerkins-bot: [V: 04-1] Bump mediawiki/mediawiki-codesniffer to 19.1.0 for PHP 7.3 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615774 (owner: 10Reedy) [16:43:08] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Force merging due to cyclic dependancy on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/615773" [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615774 (owner: 10Reedy) [16:43:27] (03PS3) 10Reedy: tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) [16:43:45] (03CR) 10Reedy: [C: 03+2] tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) (owner: 10Reedy) [16:45:34] (03Merged) 10jenkins-bot: LanguageFallbackChain has been renamed. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/615787 (https://phabricator.wikimedia.org/T250930) (owner: 10Tobias Andersson) [16:48:53] (03Merged) 10jenkins-bot: tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615773 (https://phabricator.wikimedia.org/T205957) (owner: 10Reedy) [16:52:46] (03PS2) 10Reedy: T258721 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615771 [16:55:25] (03Abandoned) 10Reedy: T258721 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/615771 (owner: 10Reedy) [21:39:02] (03PS15) 10Eric Gardner: Add QuickView to search results [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618)