[01:12:01] (03CR) 10Anne Tomasevich: "Excellent work wrangling some extremely varied results into a consistent UI! I think this one will need some careful QA once it's in produ" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) (owner: 10Eric Gardner) [01:34:07] (03CR) 10Anne Tomasevich: "Looks nice! Just a few nit-picky things..." (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/614856 (https://phabricator.wikimedia.org/T257696) (owner: 10Eric Gardner) [15:20:31] (03CR) 10Eric Gardner: "One last patchset coming shortly" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) (owner: 10Eric Gardner) [15:28:47] (03PS17) 10Eric Gardner: Add QuickView to search results [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) [16:24:17] (03CR) 10Anne Tomasevich: "Request for one code comment, then I think this is ready to merge!" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) (owner: 10Eric Gardner) [16:29:15] (03PS18) 10Eric Gardner: Add QuickView to search results [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) [16:31:32] (03CR) 10Eric Gardner: Add QuickView to search results (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) (owner: 10Eric Gardner) [16:37:17] (03PS1) 10Saloniig: Fix Typo [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/617172 [16:37:18] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/617172 (owner: 10Saloniig) [16:59:56] (03CR) 10Anne Tomasevich: [C: 03+2] "🎉" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) (owner: 10Eric Gardner) [17:01:56] (03CR) 10Eric Gardner: "Good questions RE: what markup to use. I think a follow-up patch (that also touches the Quickview file) is the best way to address though." (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/614856 (https://phabricator.wikimedia.org/T257696) (owner: 10Eric Gardner) [17:02:03] (03PS8) 10Eric Gardner: Add components for empty state and no results [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/614856 (https://phabricator.wikimedia.org/T257696) [17:15:51] (03CR) 10Anne Tomasevich: Add components for empty state and no results (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/614856 (https://phabricator.wikimedia.org/T257696) (owner: 10Eric Gardner) [17:20:03] (03CR) 10Eric Gardner: Add components for empty state and no results (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/614856 (https://phabricator.wikimedia.org/T257696) (owner: 10Eric Gardner) [17:26:05] (03Merged) 10jenkins-bot: Add QuickView to search results [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/610940 (https://phabricator.wikimedia.org/T258618) (owner: 10Eric Gardner) [17:35:49] (03PS9) 10Eric Gardner: Add components for empty state and no results [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/614856 (https://phabricator.wikimedia.org/T257696) [17:44:18] (03CR) 10Jforrester: [C: 03+2] "Thank you!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/617172 (owner: 10Saloniig) [18:16:36] (03Merged) 10jenkins-bot: Fix Typo [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/617172 (owner: 10Saloniig) [18:36:35] (03PS2) 10Eric Gardner: Add a base Image.vue component with lazy loading & error handling [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/616918 (https://phabricator.wikimedia.org/T258833) [19:04:49] (03CR) 10Eric Gardner: [C: 04-1] Add a base Image.vue component with lazy loading & error handling (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/616918 (https://phabricator.wikimedia.org/T258833) (owner: 10Eric Gardner) [21:07:05] (03PS3) 10Eric Gardner: Add a base Image.vue component with lazy loading & error handling [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/616918 (https://phabricator.wikimedia.org/T258833)