[00:25:28] (03CR) 10Anne Tomasevich: [C: 03+1] "LGTM, events are logging as expected. I can +2 once the schema is finalized/approved!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630681 (https://phabricator.wikimedia.org/T258183) (owner: 10Eric Gardner) [07:31:31] (03CR) 10DCausse: [C: 03+1] Replace naive PHP-based token length statement score correction [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/628301 (https://phabricator.wikimedia.org/T262522) (owner: 10Matthias Mullie) [12:28:13] (03PS3) 10Matthias Mullie: Test entity traversal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622359 (https://phabricator.wikimedia.org/T258055) [12:44:00] (03CR) 10Matthias Mullie: [C: 04-1] Test entity traversal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622359 (https://phabricator.wikimedia.org/T258055) (owner: 10Matthias Mullie) [12:44:12] (03CR) 10Matthias Mullie: [C: 04-2] "Do not merge ATM" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622359 (https://phabricator.wikimedia.org/T258055) (owner: 10Matthias Mullie) [12:48:44] (03CR) 10jerkins-bot: [V: 04-1] Test entity traversal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622359 (https://phabricator.wikimedia.org/T258055) (owner: 10Matthias Mullie) [12:50:48] (03PS3) 10Matthias Mullie: Allow other properties to be searched [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/633978 (https://phabricator.wikimedia.org/T264925) [13:05:47] (03PS4) 10Matthias Mullie: Test entity traversal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622359 (https://phabricator.wikimedia.org/T258055) [13:12:00] (03CR) 10Tobias Andersson: "This change is ready for review." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/634009 (https://phabricator.wikimedia.org/T263435) (owner: 10Tobias Andersson) [13:33:02] (03CR) 10jerkins-bot: [V: 04-1] Test entity traversal [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622359 (https://phabricator.wikimedia.org/T258055) (owner: 10Matthias Mullie) [14:31:50] (03CR) 10Lucas Werkmeister (WMDE): [C: 04-1] "Isn’t this worse than the old version? MediaInfo implements LabelsProvider, and captions are labels, so if I’m not mistaken, previously th" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/634009 (https://phabricator.wikimedia.org/T263435) (owner: 10Tobias Andersson) [16:43:01] (03PS1) 10Bartosz Dziewoński: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) [16:43:35] (03CR) 10Bartosz Dziewoński: "Caused T265560. Follow-up: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/634290" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/631850 (owner: 10Esanders) [16:46:44] (03CR) 10jerkins-bot: [V: 04-1] Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [16:49:23] (03CR) 10Bartosz Dziewoński: "Unrelated test failures like this:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [16:52:10] (03PS1) 10Jforrester: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634252 (https://phabricator.wikimedia.org/T265560) [16:56:31] (03CR) 10jerkins-bot: [V: 04-1] Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634252 (https://phabricator.wikimedia.org/T265560) (owner: 10Jforrester) [16:58:44] (03CR) 10Jforrester: "> Patch Set 1:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [17:04:45] (03CR) 10Bartosz Dziewoński: "Looks like this is T265628" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [17:20:45] (03PS1) 10Jforrester: ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634293 (https://phabricator.wikimedia.org/T265628) [17:21:34] (03PS1) 10Bartosz Dziewoński: Skip ApiFlickrBlacklistTest tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634294 (https://phabricator.wikimedia.org/T265628) [17:22:55] (03CR) 10Jforrester: "Ah. My approach (I4586cd742f1) goes slightly in the 'right' direction, but I've not done the full mocking to provide the expected response" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634294 (https://phabricator.wikimedia.org/T265628) (owner: 10Bartosz Dziewoński) [17:28:39] (03PS2) 10Bartosz Dziewoński: Skip ApiFlickrBlacklistTest tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634294 (https://phabricator.wikimedia.org/T265628) [17:29:18] (03CR) 10Bartosz Dziewoński: "Oh, I just didn't want to dig into this… I'm fine with whatever unbreaks it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634294 (https://phabricator.wikimedia.org/T265628) (owner: 10Bartosz Dziewoński) [17:29:48] (03PS2) 10Jforrester: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [17:30:02] (03CR) 10Bartosz Dziewoński: [C: 03+1] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634293 (https://phabricator.wikimedia.org/T265628) (owner: 10Jforrester) [17:30:10] (03Abandoned) 10Jforrester: Skip ApiFlickrBlacklistTest tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634294 (https://phabricator.wikimedia.org/T265628) (owner: 10Bartosz Dziewoński) [17:32:59] (03CR) 10Bartosz Dziewoński: [C: 03+2] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634293 (https://phabricator.wikimedia.org/T265628) (owner: 10Jforrester) [17:33:07] (03CR) 10Bartosz Dziewoński: [C: 03+1] Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [17:38:29] (03CR) 10Jforrester: [C: 03+2] Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [17:55:52] (03Merged) 10jenkins-bot: ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634293 (https://phabricator.wikimedia.org/T265628) (owner: 10Jforrester) [17:55:54] (03Merged) 10jenkins-bot: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/634290 (https://phabricator.wikimedia.org/T265560) (owner: 10Bartosz Dziewoński) [18:00:03] (03PS1) 10Jforrester: ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634259 (https://phabricator.wikimedia.org/T265628) [18:00:21] (03PS2) 10Jforrester: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634252 (https://phabricator.wikimedia.org/T265560) [18:00:29] (03PS3) 10Jforrester: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634252 (https://phabricator.wikimedia.org/T265560) [18:30:53] (03CR) 10Catrope: [C: 03+2] ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634259 (https://phabricator.wikimedia.org/T265628) (owner: 10Jforrester) [18:31:03] (03CR) 10Catrope: [C: 03+2] Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634252 (https://phabricator.wikimedia.org/T265560) (owner: 10Jforrester) [18:37:09] (03CR) 10Anne Tomasevich: [C: 03+2] Cache the relevant entities used in media search query [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/632203 (https://phabricator.wikimedia.org/T263238) (owner: 10Matthias Mullie) [18:49:43] (03Merged) 10jenkins-bot: ApiFlickrBlacklistTest: Don't try to access HTTP in integration tests [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634259 (https://phabricator.wikimedia.org/T265628) (owner: 10Jforrester) [18:49:46] (03Merged) 10jenkins-bot: Work around LESS calculating `calc()` values wrong [extensions/UploadWizard] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634252 (https://phabricator.wikimedia.org/T265560) (owner: 10Jforrester) [19:06:05] (03CR) 10jerkins-bot: [V: 04-1] Cache the relevant entities used in media search query [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/632203 (https://phabricator.wikimedia.org/T263238) (owner: 10Matthias Mullie) [19:15:43] (03CR) 10Bartosz Dziewoński: "Also, if you're in the mood for boring work (like… converting CSS to LESS), then I'd like to interest you in T265650, which should prevent" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/631850 (owner: 10Esanders) [19:18:40] (03PS7) 10Anne Tomasevich: Add copyable filename to QuickView and CopyTextLayout component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) [19:26:06] (03PS8) 10Anne Tomasevich: Add copyable filename to QuickView and CopyTextLayout component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) [20:34:14] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Yeah, you have to do it like this, we'd done the same in VisualEditor and elsewhere." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/625864 (https://phabricator.wikimedia.org/T262252) (owner: 10Ostrzyciel)