[16:57:32] * greg-g looks around [16:58:32] * YuviPanda looks intently at greg-g looking around [16:58:52] * ^demon|away keeps his eyes to himself [16:59:05] :) [17:01:07] Hello everybody! [17:01:11] hi greg-g! [17:01:14] hello! [17:01:19] Welcome everybody to the old bug reports triage here! Everybody is free to join and help cleaning up and retesting bug reports. See https://www.mediawiki.org/wiki/Bug_management/Triage/20140624 for more info. [17:01:29] So the goal is to triage some bug reports together, be talkative and verbose in what we're doing, so it's transparent and people can learn from each other. [17:01:48] Who's here? Feel free to say Hi [17:02:00] we also document the progress (though not mandatory, feel free to ignore) in http://etherpad.wmflabs.org/pad/p/BugTriage [17:02:13] * MatmaRex lurks [17:02:28] hehe [17:02:39] ....and that Etherpad also has a link to the open bug reports, but I'll paste it here again: https://bugzilla.wikimedia.org/buglist.cgi?bug_id=19731%2C30583%2C30629%2C43694%2C43886%2C38259%2C39470%2C30705%2C30991%2C34511%2C38723%2C39424%2C39443%2C38934%2C&bug_id_type=nowords&f1=priority&list_id=324193&n1=1&o1=changedafter&order=product%2Ccomponent%2Cbug_id&priority=Immediate&priority=Highest&priority=High&product=MediaWiki&product=MediaWiki [17:02:39] %20extensions&query_format=advanced&resolution=---&v1=-17m [17:03:07] or http://ur1.ca/hlh5v for those who hate long urls [17:03:16] I don't obviously. ;) [17:03:29] That is a link to open tickets in Bugzilla for MediaWiki and MediaWiki extensions which have been set to high priority a long time ago (actually, more than 17 months ago) and not changed since then. [17:04:12] Everybody can pick her/his favorite ticket, take a look, try to understand, check it there is still enough info, try to reproduce, or add folks to the CC list who might have expertise in that area and be able to add some useful input [17:04:22] That is the triage part - more is explained in https://www.mediawiki.org/wiki/Bug_management/How_to_triage [17:04:41] greg-g! Let's start? [17:04:53] also, if you're curious if something is still valid or if it should just be closed (either already fixed, or no longer needed), do ask! [17:05:06] let's get those out of the system as much as possible :) [17:05:10] yep, let's go [17:05:25] * andre__ takes a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=32013 [17:05:30] "The XSS filter in IE8/9 breaks certain tools" [17:05:40] I wonder how much we can and want to work around that, [17:05:52] and if it's really a high priority (lots of folks affected, major breakage?) [17:06:08] * greg-g looks at csteipp ;) [17:06:34] looks like that IE behavior broke (breaks?) some tools on the toolserver, that's why it was set to high/highest prio [17:07:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=32013#c14 and https://bugzilla.wikimedia.org/show_bug.cgi?id=32013#c18 seem to be the most relevant recent comments [17:08:06] I really wonder how many Tools are affected by this, and how we could find out. Because that would influence how important this is... [17:08:18] Maybe I'll just add a comment asking exactly that... [17:08:22] I should have stated on the bug: I'd prefer to keep the header, and have the tool be updated (per comment #18) [17:09:04] csteipp, I can copy & paste that for you :P [17:09:24] morning [17:09:53] andre__: sure :) [17:10:08] csteipp: so but that's basically a decision that we won't investigate here on the Wikimedia part so I'll decrease priority. Or does that even mean WONTFIX? [17:10:10] * greg-g waves to Nikerabbit [17:11:12] is it just me or is the etherpad link not owrking? [17:11:28] Nikerabbit, https://etherpad.wikimedia.org/p/BugTriage loads for me [17:11:29] Works for me [17:11:36] andre__: I think lower priority, and anyone is welcome to submit a patch that adds the disabling header, based on a feature flag. WMF sites will most likely not enable that flag. [17:11:44] okay, then you earlier link was wrong ;) [17:11:44] csteipp, oh, that makes sense, thank you! [17:11:51] whoops, sorry [17:11:58] argh, yeah, it was [17:12:01] sorry again [17:12:13] What are we on right now? [17:13:28] parent5446, in general: open tickets in Bugzilla for MediaWiki and MediaWiki extensions which have been set to high priority a long time ago (actually, more than 17 months ago) and not changed since then [17:13:39] so taking a look, try to understand, check it there is still enough info, try to reproduce, or add folks to the CC list who might have expertise in that area and be able to add some useful input [17:13:39] <^demon|away> I marked 18861 fixed. [17:14:06] parent5446: that's the idea today - but obviously priorities sometimes need input from Core development too, so that's why greg-g is also here [17:14:21] ^demon|away: I was just going to say about 18861 [17:14:35] heh, cool [17:14:41] andre__: Ah OK [17:14:52] greg-g: found a ticket of interest already? :) [17:15:14] yep, https://bugzilla.wikimedia.org/show_bug.cgi?id=43506 [17:15:17] just edited it [17:15:52] aud.e made a patch to fix, it didn't get merged and is now abandoned, no activity for a bit, so I reduced prio, reset assignee, and asked for followup from the reporter [17:17:04] (my tactic right now is sorting by assignee, try to remove assignees on bugs that are stalled for other reasons and the person isn't working on it anymore) [17:17:14] greg-g, oh, good idea! [17:17:24] * andre__ looks at JavaScript parser fun with encapsulateSelection in https://bugzilla.wikimedia.org/show_bug.cgi?id=40261 [17:17:45] heh, reporter asks "Is this a bug?" and set high priority him/herself... Hmm, well... :) [17:18:34] * andre__ searches for other Bugzilla tickets mentioning "encapsulateSelection" [17:19:30] hmm. only one other, unrelated [17:21:14] though that other one is browser specific. So I'll lower priority on bug 40261, ask for browser information, and if it's still an issue [17:24:24] * https://bugzilla.wikimedia.org/show_bug.cgi?id=36587 [17:24:25] ** reset assignee, asked him (Gilles) if the prio should be lowered, and pinged a reporter that they were asked a question many months ago [17:25:38] That bug is not a simple fix. Proper fix is probably rewrite chunked upload in its entirety, to not suck [17:27:39] * andre__ looks at accessibility bug report https://bugzilla.wikimedia.org/show_bug.cgi?id=42394 [17:29:16] bawolff: :) [17:29:31] * https://bugzilla.wikimedia.org/show_bug.cgi?id=40920 [17:29:31] ** reset assignee, pinged the patch author and reviewer for feedback (no movement on patch for over a month, needs a rebase) [17:29:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=42355 - I think this can be WONTFIXed, since it makes sense that if you choose a default date/time format that is invalid it will throw an error [17:31:17] I'd personally prefer if it just went to default if invalid, since which settings are valid change with language, but certainly pretty low priority issue [17:31:18] parent5446: agree, maybe the error message was unclear? [17:31:19] parent5446: would you like to propose that in the ticket, or afraid of reporters with forks in front of your house? :P [17:31:37] "we've come for dinner!" [17:31:41] Lol [17:31:49] The error message is pretty clear [17:31:49] andre__: How does "is equal to any of the strings" split matches? ,? [17:31:57] "Global default ... is invalid" [17:32:04] I'll propose it in the bug [17:32:05] oh, yeah it is, I some how missed that [17:32:09] James_F, errrr, more context please? Or more coffee for me? :P [17:32:18] After reading a11y ticket https://bugzilla.wikimedia.org/show_bug.cgi?id=42394 there's not much we can do on our side, so I'll lower priority there [17:32:29] James_F, ah [17:32:34] James_F, no, space [17:32:35] andre__: In a Bugzilla power-search, on of the match options is "is equal to any of the strings" but I can't find documentation. [17:32:50] andre__: Oh. How do you make it find strings with spaces? "Foo bar"? [17:33:21] James_F: I don't think you can search for several strings and at least one of them including a space [17:33:30] * James_F grumbles. [17:33:33] OK, thanks. [17:33:35] James_F, well, you can down there [17:33:38] but not up there [17:34:01] (My /main/ problem is that I can't edit the custom search structure except to add to the end or re-create from scratch.) [17:36:05] James_F, "" Match ALL: Comment | contains all of the strings | abc def ghi | AND | Comment | contains the string | one term with spaces "" ? [17:36:11] or maybe I don't understand the problem :-/ [17:36:31] andre__: Where's that from? [17:37:10] James_F: from my fingers after looking at Bugzilla's Advanced Search in the "Custom Search" section [17:37:20] andre__: Aha. :-) [17:40:22] * https://bugzilla.wikimedia.org/show_bug.cgi?id=12974 [17:40:23] ** poked the nest of a very old bug (a duplicate is a 4 digit bug number) [17:41:37] andre__: https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&list_id=324287&namedcmd=Editing-%2A&remaction=run is the context, FWIW. [17:41:50] andre__: (1k5 bug results search.) [17:42:30] eek [17:43:14] greg-g: That's, roughly, "bugs, tasks, enhancements etc. the Editing team is responsible for fixing, or getting fixed". [17:43:59] James_F, whou, that's a complex one, indeed [17:44:13] James_F: god speed [17:44:22] andre__: It's not cognitively a hard search, but BZ makes it so. ;-) [17:44:51] James_F: you could merge the first three items by "Resolution is equal to ---" [17:45:13] but yeah, apart from that I don't see how to make this easier :( [17:45:26] andre__: Yeah, I changed my mind about what I was searching half-way through using it, and I can't change the search terms after the fact. [17:45:38] yeah, Bugzilla. sigh :-/ [17:46:01] andre__: Soon enough we'll be saying "Yeah, Phabricator, sigh." instead… [17:46:10] oh, definitely! [17:46:20] search is less powerful... [17:48:50] * andre__ looks at https://bugzilla.wikimedia.org/show_bug.cgi?id=42229 (MW 1.20 complains about pcre in replaceExternalLinks() in Parser.php when preg_split() returns false) [17:51:18] * parent5446 rebases https://bugzilla.wikimedia.org/show_bug.cgi?id=43509 and adds reviewers to patch. [17:52:35] andre__: I remember that one [17:52:54] Nikerabbit, hehe [17:53:15] andre__: but haven't encountered that in long time [17:53:20] parent5446: hah, did we do the same one? [17:53:28] :) [17:53:41] tss, tss. ;) [17:53:49] Oh I'm stupid [17:54:00] I thought you were writing about a different bug and we just happened to have the same summary [17:54:06] :) [17:54:54] haha "Allow global renaming of global users " /me moves along [17:55:02] Let me try to write a "Mid-air collision" popup for Etherpad [17:55:51] andre__: one of the worst things about BZ [17:56:11] conflict detection? [17:58:23] it's make it sound like the worst thing in the world if I add a CC while someone else is just commenting (ie: things that aren't actually 'colliding') [17:58:36] scares people away [17:59:16] * greg-g goes to get some food real quick [18:05:08] I wonder what to do with https://bugzilla.wikimedia.org/show_bug.cgi?id=40362 where Krinkle doesn't answer me ;) [18:05:21] probably lowering priority - upgrading from 1.8 to 1.20 doesn't sound common [18:05:29] * andre__ also needs to buy some quick food, back in 5min [18:05:54] wow, 1.8 > 1.20? [18:07:16] andre__: won't fix, they know how to reopen ;) [18:07:55] andre__: We actually get a surprising number of people asking for help on updating from super ancient versions [18:09:03] * bawolff encounters someone on #mediawiki updating from somewhere between 1.5-1.10 probably about once every three months [18:13:59] alright, y'all commented on it (thanks!) so I'll leave it like that [18:17:11] nemo sidetracked me with https://bugzilla.wikimedia.org/show_bug.cgi?id=57732 out of band ;) [18:17:23] Nemo is allowed to do that. :P [18:18:07] I'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=20189#c13 where Thehelpfulone wrote "Bumping to high priority. Currently Oversighters have to undelete a page to be able to easily suppress multiple revisions on that page. This is a major security risk" [18:18:33] andre__: It's certainly a real pain. [18:18:46] * Risker perks up on seeing "Oversighter" [18:19:05] concur that it's a real pain, and it means making the whole thing visible again [18:19:08] Hmm. So high priority is probably realistic, though that would still need somebody to write the code :-/ [18:19:51] * andre__ won't touch it [18:20:03] * James_F nods. [18:23:19] * greg-g is now looking at graphs during deploy window [18:28:23] * andre__ looks at https://bugzilla.wikimedia.org/show_bug.cgi?id=32590 but doesn't get it [18:31:12] andre__: It looks like there's a title record in the database which doesn't meet the current standard for what a valid title is [18:31:29] when that happens mediawiki outputs
  • , which looks like a blank line [18:33:09] * andre__ calls it a day [18:33:17] So, thanks everybody who participated in triaging! [18:33:33] I hope that it was interesting and you had some fun [18:33:33] (and I won't stop you from continuing, but I'm out for today) [18:33:33] See you around! Thanks again! [18:33:34] ah :) [18:34:06] * andre__ really leaving now, bbl [18:35:58] andre__, James_F, Risker: ah, 20189 (checkboxes for revdel). I had forgotten about that. [18:36:10] I did part of that as one of my first contributions to MW [18:36:22] (relatively speaking) [18:36:27] :) thank you, Krenair! [18:36:58] I think it was 14th or something [18:37:16] I should take a look at the rest at some point [18:39:11] Krenair: Ha. :-) [18:42:44] andre__: thanks, btw [19:53:45] csteipp: About discussion on Bug 32013 (IE XSS Filter breaking/Tool author here). Krinkle wants to ditch the tool and write yet another disambiguation gadget/userscript. Not setting the flag allowed IE to create XSS vulnerabilities documented by link [3]. [20:15:30] join/ #wikimedia-staff [20:54:43] andre__: btw: ": [20:54:44] * Buglist down from 64 to 52 tickets [20:54:53] er, bad paste, but yeah [23:02:41] flood is good!!! [23:03:23] flood is good!!! [23:16:47] flood is good [23:18:05] Jtmorgan? [23:18:10] Jpmorgan.