[12:12:41] (PS1) Zfilipin: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/90322 [12:34:47] (PS3) Hashar: wrapper around MediaWiki core phpunit [integration/jenkins] - https://gerrit.wikimedia.org/r/90146 [12:36:06] (CR) Hashar: [C: 2] "Good enough for now, will amend later if need be." [integration/jenkins] - https://gerrit.wikimedia.org/r/90146 (owner: Hashar) [12:36:09] (Merged) jenkins-bot: wrapper around MediaWiki core phpunit [integration/jenkins] - https://gerrit.wikimedia.org/r/90146 (owner: Hashar) [12:42:57] (PS1) Hashar: mw setting injecter was not initially closing PHP tag [integration/jenkins] - https://gerrit.wikimedia.org/r/90325 [12:43:05] (CR) Hashar: [C: 2] mw setting injecter was not initially closing PHP tag [integration/jenkins] - https://gerrit.wikimedia.org/r/90325 (owner: Hashar) [12:43:10] (Merged) jenkins-bot: mw setting injecter was not initially closing PHP tag [integration/jenkins] - https://gerrit.wikimedia.org/r/90325 (owner: Hashar) [12:45:10] hi zeljkof [12:45:29] ho Nikerabbit [12:45:51] zeljkof: would you have time for a question? [12:48:07] Nikerabbit: sure [12:48:16] you can ask without asking can you ask :) [12:48:41] zeljkof: the last scenario of https://gerrit.wikimedia.org/r/88952 [12:49:31] Basically I want to fill 20 text areas in a loop, but they way I did it, it always tries to write to the first extare in the page [12:50:36] Nikerabbit: looking.. [12:54:33] ok, found the problem [12:54:48] will run on my machine and upload a new patchset [12:55:41] zeljkof: you need to set $wgTranslateTestUsers then [12:55:56] how do I do that? [12:56:01] and where should the test run? [12:56:12] oh, I thought you had translate locally [12:56:13] there is no site in feature tags [12:56:36] no, but I can have it if it is in vagrant [12:56:41] nah [12:56:44] you can use these: [12:56:55] export MEDIAWIKI_URL=http://dev.translatewiki.net/wiki/ [12:56:55] export MEDIAWIKI_USER=Kimono [12:57:14] I have password for kimono [12:57:16] it will be on sandbox.transaltewiki.net eventually [12:57:21] if you did not change it [12:57:24] no I haven't [12:57:37] but not yet [12:58:12] I have just checked, translate is not i mediawiki-vagrant [12:58:22] you should ping ori or yuri to get it there [12:58:23] mleb might be [12:58:31] mleb is [12:58:36] is that the same thing? [12:58:36] translate is included in that [12:58:43] (PS1) Hashar: mw-apply-settings: copy settings in dir log, not as a file [integration/jenkins] - https://gerrit.wikimedia.org/r/90327 [12:58:52] (CR) Hashar: [C: 2] mw-apply-settings: copy settings in dir log, not as a file [integration/jenkins] - https://gerrit.wikimedia.org/r/90327 (owner: Hashar) [12:58:55] (Merged) jenkins-bot: mw-apply-settings: copy settings in dir log, not as a file [integration/jenkins] - https://gerrit.wikimedia.org/r/90327 (owner: Hashar) [12:59:25] but for now it is easier to just use dev [12:59:31] because it also needs some data in it [12:59:54] hm [12:59:55] timed out after 5 seconds, waiting for {:class=>"tux-textarea-translation", :tag_name=>"textarea"} to become present [13:00:28] yes that is what I get after the first translation [13:01:39] (PS1) Hashar: mw-apply-settings: make sure log dir exist [integration/jenkins] - https://gerrit.wikimedia.org/r/90329 [13:01:45] (CR) Hashar: [C: 2] mw-apply-settings: make sure log dir exist [integration/jenkins] - https://gerrit.wikimedia.org/r/90329 (owner: Hashar) [13:01:48] (Merged) jenkins-bot: mw-apply-settings: make sure log dir exist [integration/jenkins] - https://gerrit.wikimedia.org/r/90329 (owner: Hashar) [13:01:55] wait, other tests also fail? [13:02:03] or just the last scenario? [13:02:34] zeljkof: other scenarios should pass, though I didn't test them today [13:05:55] somehow I would need to be able to select the next textarea in each step of the loop [13:07:43] Nikerabbit: sure, that is trivial [13:07:56] zeljkof: glad to hear that ;) [13:07:57] I am just having a hard time to enter anything into that text area :) [13:08:02] zeljkof: ou? [13:08:16] does the scenario work for you on dev.translate… ? [13:08:33] I am getting timeouts all the time [13:08:51] zeljkof: I can see it make the first translation, then timeout for the second one because it is still looking for the first textarea which is now hidden [13:09:02] is it timing out for you before that even? [13:09:13] yes [13:09:24] I does not enter anything in the first textarea [13:10:12] I see [13:10:22] I enters the text really quickly, so I missed that [13:10:28] ok, so far so good [13:25:49] hm, you do not actually save the translation :) [13:26:45] oh wait, my mistake, you do [13:32:32] hm, why does Special:SpecialPages open after the scenario? [13:33:05] I see, there is @stash after hook [13:33:25] zeljkof: just to confuse you :( [13:33:32] :) [13:34:23] ok, now I am getting somewhere [13:43:35] (PS1) Hashar: mw-run-phpunit*: make sure we compress mw log files [integration/jenkins] - https://gerrit.wikimedia.org/r/90336 [13:43:45] (CR) Hashar: [C: 2] mw-run-phpunit*: make sure we compress mw log files [integration/jenkins] - https://gerrit.wikimedia.org/r/90336 (owner: Hashar) [13:43:48] (Merged) jenkins-bot: mw-run-phpunit*: make sure we compress mw log files [integration/jenkins] - https://gerrit.wikimedia.org/r/90336 (owner: Hashar) [13:48:06] (PS1) Hashar: ignore gzip errors when compressing log [integration/jenkins] - https://gerrit.wikimedia.org/r/90337 [13:48:13] (CR) Hashar: [C: 2] ignore gzip errors when compressing log [integration/jenkins] - https://gerrit.wikimedia.org/r/90337 (owner: Hashar) [13:48:16] (Merged) jenkins-bot: ignore gzip errors when compressing log [integration/jenkins] - https://gerrit.wikimedia.org/r/90337 (owner: Hashar) [13:50:23] ok, managed to set the second text field [13:50:33] Nikerabbit: now to click the second save button [13:51:21] zeljkof: cool [13:51:31] zeljkof: I bet you are saving me a lot of time trying to figure out how to do it [13:51:40] maybe :) [13:51:51] it is a bit tricky, I thought it would take me a minute [13:51:56] but nothing complicated [13:52:02] you will see the code, it is simple [13:54:21] ok, button works [13:54:26] a few more minutes [14:00:30] (PS1) Hashar: publisher phpunit-junit-2 for mw-apply-settings macro [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90342 [14:00:32] (PS1) Hashar: mw regression jobs now use shell script [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90343 [14:00:50] (CR) jenkins-bot: [V: -1] mw regression jobs now use shell script [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90343 (owner: Hashar) [14:00:52] (CR) Hashar: [C: 2] macro mw-apply-settings [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90341 (owner: Hashar) [14:00:56] (CR) Hashar: [C: 2] publisher phpunit-junit-2 for mw-apply-settings macro [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90342 (owner: Hashar) [14:01:01] (CR) Hashar: [C: 2] mw regression jobs now use shell script [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90343 (owner: Hashar) [14:02:24] (Merged) jenkins-bot: macro mw-apply-settings [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90341 (owner: Hashar) [14:02:26] (Merged) jenkins-bot: publisher phpunit-junit-2 for mw-apply-settings macro [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90342 (owner: Hashar) [14:02:36] that is a bit spammy [14:02:39] (Merged) jenkins-bot: mw regression jobs now use shell script [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90343 (owner: Hashar) [14:02:43] I am not sure whether it is a good idea to keep grrrit-wm there [14:03:59] Nikerabbit: done [14:04:07] see https://gerrit.wikimedia.org/r/#/c/88952 [14:04:12] compare patch set 5 and 6 [14:04:26] I messed up some whitespace, my editor converts tabs to spaces [14:06:02] zeljkof: the last step still fails, right? [14:06:26] Nikerabbit: yes [14:06:31] do you need help with that too? [14:06:55] zeljkof: nope, I would have been worried if it was passing :) [14:06:59] thanks [14:07:12] no problem [14:09:59] zeljkof: nice [14:10:17] Nikerabbit: I did not check if the changes break other tests [14:10:29] but it should be easy to fix, if it does [14:12:41] zeljkof: hm (0..20).each [14:12:47] doesn't that do 21 steps? [14:13:06] or is one of the numbers not inclusive? [14:13:15] oops, sorry, yes, that is probably 21 steps [14:13:56] (0..20).each {|i| p i} [14:14:07] this outputs both 0 and 20 [14:14:11] so yes 21 steps [14:14:12] my mistake [14:14:26] zeljkof: and it still passes? [14:14:38] well, I can test myself [14:14:51] Nikerabbit: you should make it (0..19) [14:14:56] that will be 20 steps [14:19:12] (CR) Zfilipin: "Feel free to make smaller or bigger patch sets, what ever makes sense to you. I prefer smaller patch sets, but that is only personal prefe" [qa/browsertests] - https://gerrit.wikimedia.org/r/87436 (owner: Plavi) [14:25:01] (CR) Zfilipin: "(1 comment)" [qa/browsertests] - https://gerrit.wikimedia.org/r/87436 (owner: Plavi) [14:26:27] (CR) Zfilipin: "(1 comment)" [qa/browsertests] - https://gerrit.wikimedia.org/r/87436 (owner: Plavi) [14:30:48] (PS9) Zfilipin: Created a test for ProveIt gadget [qa/browsertests] - https://gerrit.wikimedia.org/r/87436 (owner: Plavi) [14:33:04] zeljkof: all but one scenario is now passing :) [14:33:12] Nikerabbit: great :) [14:33:32] + on(StashPage).translation_element.when_present.text.should == 'Pupu' [14:34:42] was that a question? [14:35:26] maybe [14:35:33] I think I see text "Pupu" on the screen [14:35:48] but the test complains? [14:35:54] yes [14:35:54] expected: "Pupu" got: "" (using ==) (RSpec::Expectations::ExpectationNotMetError) [14:36:11] can you upload the new code to gerrit, so I could take a look? [14:36:16] (CR) Zfilipin: "Replaced double quotes with single quotes (according to our coding convention)." [qa/browsertests] - https://gerrit.wikimedia.org/r/87436 (owner: Plavi) [14:36:28] zeljkof: yes [14:36:42] https://gerrit.wikimedia.org/r/88952 [14:36:50] Scenario: Can improve own earlier translation [14:38:22] (CR) Zfilipin: [C: 1] "The scenarios run fine on my machine and the code looks good. Chris, Matt, feel free to merge this into master, if you do not see anything" [qa/browsertests] - https://gerrit.wikimedia.org/r/87436 (owner: Plavi) [14:39:29] (PS1) Hashar: properly set $wgDebugLogFile path under Apache [integration/jenkins] - https://gerrit.wikimedia.org/r/90352 [14:39:35] Nikerabbit: just to find a setting in my editor not to convert tabs to spaces… :) [14:39:40] (CR) Hashar: [C: 2] properly set $wgDebugLogFile path under Apache [integration/jenkins] - https://gerrit.wikimedia.org/r/90352 (owner: Hashar) [14:39:51] (Merged) jenkins-bot: properly set $wgDebugLogFile path under Apache [integration/jenkins] - https://gerrit.wikimedia.org/r/90352 (owner: Hashar) [14:40:26] zeljkof: or me finding one not converting spaces to tabs ;) [14:40:45] Nikerabbit: it is your repo, I should make sure not to break whitespace [14:45:19] mm [14:45:19] ok, I think I got it configured [14:51:34] (PS1) Cmcmahon: do not depend on a particular URL in case of redirect [qa/browsertests] - https://gerrit.wikimedia.org/r/90354 [14:55:05] [14:55:12] but the area is really empty [14:55:17] take a look in the firebug [14:55:46] does ULS or something other put the text in front of the text area? [14:55:54] I have to go to a meeting now [14:56:57] zeljkof: weird [14:57:03] ULS should not be involved [14:59:57] Nikerabbit: but I see a keyboard icon when I click the text field [15:06:19] (CR) Zfilipin: [C: 2] do not depend on a particular URL in case of redirect [qa/browsertests] - https://gerrit.wikimedia.org/r/90354 (owner: Cmcmahon) [15:12:24] (PS1) Hashar: apache debug log permission need to be done by Job [integration/jenkins] - https://gerrit.wikimedia.org/r/90355 [15:12:40] (CR) Hashar: [C: 2] apache debug log permission need to be done by Job [integration/jenkins] - https://gerrit.wikimedia.org/r/90355 (owner: Hashar) [15:12:45] (Merged) jenkins-bot: apache debug log permission need to be done by Job [integration/jenkins] - https://gerrit.wikimedia.org/r/90355 (owner: Hashar) [15:18:38] (PS2) Cmcmahon: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/90322 (owner: Zfilipin) [15:18:50] (CR) Cmcmahon: [C: 2] "maintenance" [qa/browsertests] - https://gerrit.wikimedia.org/r/90322 (owner: Zfilipin) [15:36:13] zeljkof: so I can see the text Pupu on my screen, but it is not in the html [15:36:16] is that a problem? [15:36:28] probably [15:50:27] (PS1) Hashar: mw exts now have injected settings + artifacts [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90358 [15:55:52] (PS2) Hashar: mw exts now have injected settings + artifacts [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90358 [16:08:56] Nikerabbit: I am not sure how that could happen [16:09:10] for text to be on the screen but dom inspector does not see it [16:10:00] zeljkof: wtf?! [16:10:24] chrismcmahon: this is the tool [16:10:25] http://stackoverflow.com/questions/11699805/where-is-network-link-conditioner-prefpane-in-osx-mountain-lion-and-xcode-4-4 [16:10:51] Nikerabbit: do you see where the text is in the dom? when you are inspecting the page with a dom inspector? [16:11:50] [19:11:37.234] $( '.tux-textarea-translation' ).val() does give the correct string [16:18:58] Nikerabbit: I have to go now, will take a look later [16:20:35] okay [16:31:30] (CR) Hashar: [C: 2] "deployed" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90358 (owner: Hashar) [16:33:13] (Merged) jenkins-bot: mw exts now have injected settings + artifacts [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90358 (owner: Hashar) [17:44:47] (PS1) Cmcmahon: restore working ULS tests [qa/browsertests] - https://gerrit.wikimedia.org/r/90380 [17:59:46] ? [18:01:10] manybubbles: I see the CirrusSearch tests are disabled on Jenkins, but I am running them locally to get a feel for how they work. [18:01:47] manybubbles: Is there anything specific you want me to look at or tweak for you? I am getting 16 failures when it ran. [18:02:12] rachel99: yikes! are you running against beta? [18:02:24] I haven't run against beta in a while [18:02:35] yes, beta labs. [18:03:04] And my environment is the same one I used to test VisualEditor, so I don't know if there are other specific vars I need to set up [18:04:38] rachel99: REUSE_BROWSER helps for speed, but other than that there isn't anything [18:04:50] I typically run against my dev machine but that doesn't make sense for you :) [18:05:24] let me go rebuild beta's search indecies - it should solve some of the failures. If you email me the list of failures I can take a stab at explaining them. [18:05:44] manybubbles: Ok, that would be great. I will send them to you. [18:26:46] ohai qa channel [18:26:57] oh, no zeljko [18:28:39] chrismcmalunch: question about merging some bugs real quick [19:18:23] hi greg-g just returned [19:20:53] heya [19:21:03] so, https://bugzilla.wikimedia.org/show_bug.cgi?id=51491 and https://bugzilla.wikimedia.org/show_bug.cgi?id=50576, same thing, right? [19:21:17] iow: I think I reported a dupe bug and it's causing confusion (at least for me) ;) [19:21:32] greg-g: looking... [19:22:41] greg-g: I think we can merge those [19:23:02] greg-g: doing that now [19:23:36] cool, thanks [19:26:18] slightly different intent but the end result is the same [19:45:55] greg-g: this is an interesting deploy week on the browsertests front. I don't think I remember another time when we had tests passing for beta labs/master branch but failing in test2wiki waiting for deploy for VisualEditor, MobileFrontend, and I think Platform all at the same time, not to mention the beta SSL thing that's finally getting straightened and one or two other issues. [19:56:18] (PS2) Cmcmahon: Fixed mailing list address [qa/browsertests] - https://gerrit.wikimedia.org/r/90138 (owner: Zfilipin) [19:56:56] (CR) Cmcmahon: [C: 2] "documentation" [qa/browsertests] - https://gerrit.wikimedia.org/r/90138 (owner: Zfilipin) [20:03:15] (PS1) Hashar: gzip --force, to overwrite existing log files [integration/jenkins] - https://gerrit.wikimedia.org/r/90428 [20:04:22] (PS1) Hashar: gzip --force, to overwrite existing log files [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90429 [20:05:30] (CR) Hashar: [C: 2] gzip --force, to overwrite existing log files [integration/jenkins] - https://gerrit.wikimedia.org/r/90428 (owner: Hashar) [20:06:02] (Merged) jenkins-bot: gzip --force, to overwrite existing log files [integration/jenkins] - https://gerrit.wikimedia.org/r/90428 (owner: Hashar) [20:06:19] (PS2) Hashar: gzip --force, to overwrite existing log files [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90429 [20:07:22] (CR) Hashar: [C: 2] gzip --force, to overwrite existing log files [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90429 (owner: Hashar) [20:14:08] (Merged) jenkins-bot: gzip --force, to overwrite existing log files [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/90429 (owner: Hashar) [20:49:30] chrismcmahon: hey :) [20:49:40] chrismcmahon: we eventually have some code coverage generated for mediawiki/core :-D [20:49:47] hi hashar [20:49:57] they have been generated for a few weeks now [20:50:13] I thought they were not generated because php segfault at the very very end [20:50:23] but that is AFTER the HTML has been written [20:50:25] so https://integration.wikimedia.org/cover/mediawiki-core/master/php/ :] [20:50:37] I need to write down some doc about it somewher [20:50:41] and announce it [20:52:38] hashar: that's not much coverage :-) I'll look forward to the reaction. [20:54:34] chrismcmahon: we have a PHPUnit option that requires us to specify which function a test is covering [20:54:48] if nothing is explicitly specified, then PHPUnit discard the coverage report [21:01:39] chrismcmahon: Ispend most of tomorrow writing doc and email. Will get code coverage … covered :] [22:05:52] (PS2) Hashar: mediawiki-release [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/89215 [22:05:54] (PS4) Hashar: tarball experiment [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86160