[00:08:27] <James_F>	 chrismcmahon: Hmm. I was expecting https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/103/ to pass now that wmf22 rolled out to test2. :-(
[00:13:22] <chrismcmahon>	 James_F: so was I.  looking...
[00:13:55] <James_F>	 chrismcmahon: I'm now not able to see the SauceLabs test videos for some reason, so struggling to work out what went wrong.
[00:14:32] <James_F>	 Oh, the bit looking for 've-init-mw-viewPageTarget-toolbar-editNotices-notice' will likely have failed with the new toolbar changes.
[00:14:34] <James_F>	 Hmm.
[00:14:54] <James_F>	 But then why did https://wmf.ci.cloudbees.com/view/r-ve/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/ pass?
[00:15:23] <James_F>	 And also, the changes to the toolbar aren't yet in master, let alone on test2.
[00:17:39] <chrismcmahon>	 James_F: the basic_edit failure is a timeout, 2 cursor failures are interesting, transclusion seems to have not popped a hover icon, link seems to have not navigated all the way to the link text.
[00:18:02] <James_F>	 Hmm.
[00:19:28] <chrismcmahon>	 James_F: I'm out tomorrow, but Zeljko is going to run down any overnight failures with Jeff Hall in the morning.
[00:19:35] * James_F  nods.

[00:20:29] <chrismcmahon>	 James_F: I'll probably poke this a bit more this evening
[00:20:44] <James_F>	 chrismcmahon: Thanks. Will try to investigate myself too.
[01:26:33] <chrismcmahon>	 James_F: gerrit collision.  I'm just trying remove one erroneous space character
[01:26:40] <James_F>	 chrismcmahon: Aha. OK. :-)
[01:29:46] <chrismcmahon>	 James_F: I'm going to +2 that if you don't mind so it will pass in the overnight build
[01:32:11] <James_F>	 chrismcmahon: Sure - have re-added the "[Browser tests]" qualifier and +2'ed.
[01:38:12] <chrismcmahon>	 I *always* forget that part
[01:45:29] * James_F  grins.

[05:28:12] <grrrit-wm>	 (CR) Zfilipin: [C: -1] "If we decide to restore this commit, I would prefer to restore it in ULS repo (with optionally deleting existing tests there)." [qa/browsertests] - https://gerrit.wikimedia.org/r/90380 (owner: Cmcmahon)
[08:01:59] <Nikerabbit>	 morning
[08:20:38] <grrrit-wm>	 (PS1) Hashar: doc.wm.o: migrate index page a standalone default.html [integration/docroot] - https://gerrit.wikimedia.org/r/90503
[08:20:48] <grrrit-wm>	 (CR) Hashar: [C: 2] doc.wm.o: migrate index page a standalone default.html [integration/docroot] - https://gerrit.wikimedia.org/r/90503 (owner: Hashar)
[08:20:50] <grrrit-wm>	 (Merged) jenkins-bot: doc.wm.o: migrate index page a standalone default.html [integration/docroot] - https://gerrit.wikimedia.org/r/90503 (owner: Hashar)
[08:43:38] <zeljkof>	 Nikerabbit: morning
[08:58:17] <grrrit-wm>	 (PS1) Hashar: 'Cover' section listing code coverage reports [integration/docroot] - https://gerrit.wikimedia.org/r/90509
[08:58:32] <grrrit-wm>	 (CR) Hashar: [C: 2] 'Cover' section listing code coverage reports [integration/docroot] - https://gerrit.wikimedia.org/r/90509 (owner: Hashar)
[08:58:34] <grrrit-wm>	 (Merged) jenkins-bot: 'Cover' section listing code coverage reports [integration/docroot] - https://gerrit.wikimedia.org/r/90509 (owner: Hashar)
[09:04:43] <Nikerabbit>	 zeljkof: I don't know how to proceed with the textarea related failure of yesterday
[09:04:53] <zeljkof>	 Nikerabbit: will take a look now
[09:04:58] <zeljkof>	 I need a few minutes to finish something
[09:05:17] <zeljkof>	 Nikerabbit: did you decide when would be a good time for you to pair with me?
[09:10:31] <Nikerabbit>	 zeljkof: I'd like to do it after our daily on some weekday
[09:10:51] <zeljkof>	 monday and wednesday 10am-noon?
[09:11:46] <zeljkof>	 aharoni: the same question for you, did you decide when would be a good time for you to pair with me?
[09:16:29] <Nikerabbit>	 zeljkof: two hours each?
[09:16:40] <Nikerabbit>	 and what timezone?
[09:16:47] <Nikerabbit>	 ;)
[09:16:58] <zeljkof>	 Nikerabbit: what ever you prefer, I think we should pair 2-4 hours weekly, I would suggest 4 hours
[09:17:11] <zeljkof>	 so 4 times 1 hour, 2 times 2 hours...
[09:17:19] <Nikerabbit>	 2x2 sounds good to me
[09:17:27] <zeljkof>	 we are in the same timezone now, right? :) utc+2
[09:17:31] <Nikerabbit>	 umm
[09:17:35] <Nikerabbit>	 it's 12.17 now for me
[09:17:53] <zeljkof>	 oh, then we are not the same time zone
[09:18:00] <zeljkof>	 it is 11:17 here
[09:18:07] <zeljkof>	 are you the same time zone as aharoni
[09:18:08] <zeljkof>	 *
[09:18:10] <zeljkof>	 ?
[09:18:13] <Nikerabbit>	 yes, but...
[09:18:18] <Nikerabbit>	 when do you switch to winter time?
[09:18:28] <zeljkof>	 I have no idea, in a few weeks I think
[09:18:38] <zeljkof>	 I think Google Calendar knows about that stuff
[09:18:44] <zeljkof>	 just create events there and invite me
[09:18:44] <Nikerabbit>	 we will switch in one week
[09:18:48] <Nikerabbit>	 okay
[09:18:52] <zeljkof>	 the calendar will figure it out
[09:19:58] <Nikerabbit>	 if I can figure out the calendar...
[09:20:44] <zeljkof>	 :)
[09:20:49] <zeljkof>	 Should I make the events?
[09:21:47] <Nikerabbit>	 zeljkof: noo I just did
[09:21:55] <Nikerabbit>	 zeljkof: please check
[09:22:04] <zeljkof>	 great, I will check the time and accept
[09:22:14] <zeljkof>	 if there are no conflicts, but there should not be any
[09:23:15] <zeljkof>	 Nikerabbit: accepted
[09:23:18] <zeljkof>	 see you on monday :)
[09:23:34] <zeljkof>	 I am almost finished with my stuff, will take a look at your problem in a minute
[09:26:50] <zeljkof>	 Nikerabbit: done, now taking a look at 88952
[09:43:05] <Nikerabbit>	 zeljkof: can I help?
[09:43:10] <zeljkof>	 Nikerabbit: yes
[09:43:12] <zeljkof>	 :)
[09:43:20] <zeljkof>	 this is what I get when I run all tests
[09:43:24] <zeljkof>	 https://etherpad.wikimedia.org/p/88952
[09:43:55] <Nikerabbit>	 meh!
[09:44:00] <Nikerabbit>	 why is it different for you?
[09:44:42] <Nikerabbit>	 for the modal dialog... my theory is that it hasn't finished saving before continuing to navigate away
[09:44:51] <Nikerabbit>	 but timed out after 5 seconds, waiting for {:class=>"tux-status-translated", :tag_name=>"span"} to become present (Watir::Wait::TimeoutError)
[09:45:08] <Nikerabbit>	 but that check should wait for it... does it need the index handling as well?
[09:45:42] <zeljkof>	 I will take a look
[09:45:54] <zeljkof>	 what is the test that is failing for you?
[09:46:11] <Nikerabbit>	 zeljkof: something like: I can edit existing translation
[09:46:27] <zeljkof>	 Scenario: Can improve own earlier translation
[09:46:45] <Nikerabbit>	 yes
[09:47:55] <zeljkof>	 ok, will work on it now
[09:47:58] <zeljkof>	 still getting: Modal dialog present
[09:48:53] <zeljkof>	 I will update the ether pad when I make progress
[09:49:03] <zeljkof>	 and push to gerrit when I have something to show
[09:49:31] <Nikerabbit>	 mm
[09:49:49] <Nikerabbit>	 which ether pad?
[09:49:54] <zeljkof>	 https://etherpad.wikimedia.org/p/88952
[09:53:43] <zeljkof>	 Nikerabbit: but when I reload page manually, javascript "confirm navigation" popup does appear
[09:53:54] <zeljkof>	 so the popup is really there
[09:54:23] <Nikerabbit>	 yes it is
[09:54:39] <zeljkof>	 ok, so the test should dismiss it then
[09:54:53] <zeljkof>	 and you do not do that anywher
[09:54:56] <zeljkof>	 anywhere
[09:55:00] <zeljkof>	 will take a look how it is done
[09:57:15] <Nikerabbit>	 zeljkof: hold on a second. I think something is broken
[09:59:54] <Nikerabbit>	 zeljkof: yes, I'm so sorry
[10:00:01] <Nikerabbit>	 zeljkof: the tests found out an actual regression
[10:00:04] <zeljkof>	 :)
[10:00:11] <zeljkof>	 even _before_ merged into master
[10:00:13] <Nikerabbit>	 zeljkof: now only one scenario should fail
[10:00:15] <zeljkof>	 wow, good job
[10:00:23] <zeljkof>	 ok, will run the tests again
[10:00:31] <zeljkof>	 you have already fixed it on dev machine?
[10:01:02] <Nikerabbit>	 zeljkof: yes
[10:02:44] <zeljkof>	 great
[10:02:58] <zeljkof>	 take a look at the ether pad, just one test failed for me
[10:03:02] <zeljkof>	 will take a look at the cause now
[10:03:24] <Nikerabbit>	 alert??
[10:03:38] <zeljkof>	 ooops :)
[10:03:49] <zeljkof>	 that was my change, trying to dismiss the alert
[10:03:55] <zeljkof>	 running again
[10:06:48] <Nikerabbit>	 zeljkof: yep, now it looks the same as mine
[10:07:54] <zeljkof>	 updated the pad, now only one error
[10:07:57] <zeljkof>	 looking
[10:07:58] <Nikerabbit>	 the first one looks like the previous test did not run the after(@stash)
[10:08:12] <Nikerabbit>	 yes, that is now the error I'm stuck with
[10:08:58] <Nikerabbit>	 should I try different way to access the contents? Should I modify our javascript to create the text field differently? Is it a bug somewhere?
[10:09:12] <zeljkof>	 Nikerabbit: do not know, loo
[10:09:14] <zeljkof>	 looking
[10:12:30] <zeljkof>	 Nikerabbit: how do you insert text into this textarea?
[10:12:42] <zeljkof>	 since firefox dom inspector sees no text there
[10:12:43] <zeljkof>	 <textarea style="overflow: hidden; word-wrap: break-word; resize: horizontal; height: 68px;" placeholder="Your translation" dir="ltr" class="tux-textarea-translation" lang="en"></textarea>
[10:12:53] <Nikerabbit>	 zeljkof: $( 'textarea' ).val( 'foo' );
[10:13:00] <zeljkof>	 but I can see the text on the screen
[10:13:04] <zeljkof>	 really really strange
[10:14:03] <zeljkof>	 ok, so you just insert text into the first text area?
[10:14:15] <Nikerabbit>	 http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTranslate.git/9d85779b5365e7d24577e24f9eb66d67dc6e969d/resources%2Fjs%2Fext.translate.editor.js#L444
[10:14:16] <zeljkof>	 (not really a js/jquery ninja)
[10:14:33] <Nikerabbit>	 we are creating the textarea on the fly as well
[10:15:09] <zeljkof>	 that should not be the problem
[10:15:35] <zeljkof>	 but for some reason ff dom inspector thinks texarea has not text
[10:15:42] <zeljkof>	 can you reproduce it on your machine too?
[10:16:26] <Nikerabbit>	 zeljkof: when running tests at least
[10:16:52] <zeljkof>	 can you leave the browser open after the test and take a look at the page?
[10:17:04] <zeljkof>	 (you should also disable the after step hook)
[10:17:07] <Nikerabbit>	 in Chrome dom tree the text is also not visible
[10:17:14] <zeljkof>	 so the tests stays on the page
[10:18:06] <Nikerabbit>	 but that seems to be the behavior with all textareas
[10:19:01] <zeljkof>	 but where is the text then?!
[10:19:17] <zeljkof>	 if you enter text into text area, where is it in the dom?
[10:19:44] <zeljkof>	 probably selenium asks for the text of the text area and the browser (like it's dom inspector) says there is no text there
[10:20:39] <Nikerabbit>	 so it is impossible to compare the contents of a textarea?
[10:21:00] <zeljkof>	 everything is possible (almost) :)
[10:21:32] <Nikerabbit>	 Neither Chrome nor Firefox does not show any changes to dom when I alter the contents of an textarea
[10:24:05] <zeljkof>	 yes, just checked that
[10:24:08] <zeljkof>	 strange
[10:24:56] <zeljkof>	 how to check textarea content with query?
[10:25:00] <zeljkof>	 jquery?
[10:25:08] <zeljkof>	 (stupid autocorrect)
[10:26:06] <Nikerabbit>	 um
[10:26:10] <Nikerabbit>	 just with .val()
[10:26:25] <zeljkof>	 $( 'textarea' ).val()
[10:26:32] <zeljkof>	 and it really returns pupu
[10:26:34] <Nikerabbit>	 yeah, that takes the firs ttextarea it finds
[10:26:43] <zeljkof>	 let's try that...
[10:36:42] <zeljkof>	 Nikerabbit: want to hear a funny story? :)
[10:37:22] <zeljkof>	 which attribute do you think this code sets?
[10:37:23] <zeljkof>	 $( 'textarea' ).val( 'foo' );
[10:37:26] <zeljkof>	 text or value?
[10:37:29] <zeljkof>	 :)
[10:40:06] <Nikerabbit>	 zeljkof: um
[10:40:16] <Nikerabbit>	 zeljkof: value in dom speak
[10:40:25] <zeljkof>	 selenium steaks dom :)
[10:40:26] <Nikerabbit>	 zeljkof: but not value as in attribute
[10:40:26] <zeljkof>	 https://gerrit.wikimedia.org/r/#/c/88952/7..8/tests/browser/features/step_definitions/translation_stash_steps.rb
[10:40:34] <zeljkof>	 this was all that needed to be done
[10:40:36] <zeljkof>	 test works fine now
[10:40:55] <Nikerabbit>	 zeljkof: funny
[10:40:59] <zeljkof>	 yes
[10:41:07] <zeljkof>	 I also thought it will set text, not value
[10:41:20] <zeljkof>	 but I am not really familiar with html/dom differences
[10:41:39] <zeljkof>	 anyway, all tests should work now
[10:41:41] <Nikerabbit>	 zeljkof: how about the step on line 29 on that url?
[10:42:10] <Nikerabbit>	 does foo.should == 'foo' work as expected?
[10:42:34] <zeljkof>	 in step 31 of translation_stash_steps.rb?
[10:42:45] <zeljkof>	 it should be
[10:42:45] <Nikerabbit>	 yeah
[10:43:02] <zeljkof>	 on(StashPage).second_translation_element.value.should == ''
[10:43:13] <zeljkof>	 or something like that
[10:43:21] <zeljkof>	 did you test if it breaks?
[10:43:33] <zeljkof>	 meaning if you put anything but empty string there, does the test fail
[10:43:51] <zeljkof>	 "you should never trust a test that you did not see fail" (unknown source)
[10:43:54] <Nikerabbit>	 it does, but I wonder if it fails if there is osmething in the text area
[10:44:18] <zeljkof>	 see my above comment (in quotes)
[10:44:53] <Nikerabbit>	 there are two ways it can be made to fail :)
[10:46:51] <Nikerabbit>	 zeljkof: yes it fails, so it is okay
[10:46:53] <Nikerabbit>	 zeljkof: thanks!
[10:47:16] <Nikerabbit>	 zeljkof: this completes the tests for this story
[10:47:31] <zeljkof>	 great
[10:47:38] <zeljkof>	 should I make the review of the complete commit?
[10:48:15] <Nikerabbit>	 zeljkof: we have Amir tasked for it, but it wont hurt if you catch the issues before that ;)
[10:48:42] <zeljkof>	 sure, will take a look now that I am somewhat familiar with the codee
[10:49:00] <zeljkof>	 prepare for at least -1 :)
[10:49:32] <zeljkof>	 the experience has shown that rarely a commit get +1 in the first look
[11:28:34] <Nikerabbit>	 zeljkof: left some counter questions. will fix the issues after lunch
[11:29:09] <zeljkof>	 will take a look
[11:57:10] <Nikerabbit>	 plop
[12:17:33] <Nikerabbit>	 evening
[12:23:57] <zeljkof>	 plop?
[12:24:04] <zeljkof>	 Nikerabbit: ^
[12:26:17] <Nikerabbit>	 hi zeljkof
[12:26:38] <zeljkof>	 Hi Nikerabbit
[12:27:44] <Nikerabbit>	 zeljkof: can we reach consensus on the remaining questions on the patch? ;)
[12:27:51] <grrrit-wm>	 (PS1) Zfilipin: Moving documenation to mediawiki/selenium repository [qa/browsertests] - https://gerrit.wikimedia.org/r/90534
[12:28:00] <zeljkof>	 just a second, will take a look
[12:30:10] <zeljkof>	 hashar: can the bot ping the channel when there are changes in mediawiki/selenium repo?
[12:30:36] <grrrit-wm>	 (PS2) Zfilipin: Moving documenation to mediawiki/selenium repository [qa/browsertests] - https://gerrit.wikimedia.org/r/90534
[12:33:43] <hashar>	 zeljkof: yup, have to edit the grrrit configuration in labs/tools/grrrit
[12:34:03] <zeljkof>	 hashar: let me take a look, maybe I can make the change
[12:36:04] <zeljkof>	 Nikerabbit: 88952 looks good to me! :)
[12:36:11] <zeljkof>	 I gave it a +1
[12:36:36] <zeljkof>	 I will let somebody else to merge it in
[12:36:37] <hashar>	 zeljkof: template: https://gerrit.wikimedia.org/r/#/c/85653/
[12:36:47] <zeljkof>	 but I do not see Amir in reviewers
[12:36:54] <Nikerabbit>	 zeljkof: thanks, I will ping Amir
[12:37:15] <zeljkof>	 hashar: looks simple enough
[12:37:16] <zeljkof>	 will try
[12:38:32] <hashar>	 it is :-]
[12:38:40] <hashar>	 yuvipanda can merge and deploy
[12:38:43] <hashar>	 not sure who else
[12:38:47] <hashar>	 make sure to add him as a reviewer
[12:45:08] <zeljkof>	 hashar: done
[12:45:10] <zeljkof>	 https://gerrit.wikimedia.org/r/#/c/90537/
[12:45:23] <hashar>	 goood
[12:45:25] <zeljkof>	 added you and yuvipanda to reviewers
[12:47:26] <zeljkof>	 hashar: what needs to happen to mirror a repo on github?
[12:47:51] <hashar>	 no idea :(
[12:48:04] <zeljkof>	 do you know who/where to ask?
[12:48:32] <hashar>	 Chad ^demon
[12:48:39] <hashar>	 but maybe it is documented somewhere on mw.org
[12:56:23] <zeljkof>	 hashar: thanks
[12:56:29] <zeljkof>	 will ping them later
[13:11:58] <zeljkof>	 hashar: found your comment in bugzilla https://bugzilla.wikimedia.org/show_bug.cgi?id=35429#c22 :)
[13:13:50] <zeljkof>	 created a bug
[13:14:01] <zeljkof>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=55874
[13:22:00] <grrrit-wm>	 (CR) Krinkle: [C: 1] mediawiki/conf.d/_join.php minor fix + comment update [integration/jenkins] - https://gerrit.wikimedia.org/r/90114 (owner: Hashar)
[14:04:15] <grrrit-wm>	 (PS1) Cmcmahon: only run on test2 until Bug 54886 resolved [qa/browsertests] - https://gerrit.wikimedia.org/r/90547
[14:05:30] <grrrit-wm>	 (CR) Cmcmahon: "this should turn the beta labs builds green" [qa/browsertests] - https://gerrit.wikimedia.org/r/90547 (owner: Cmcmahon)
[14:24:42] <grrrit-wm>	 (PS13) Hashar: debian-glue macros and jobs [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/71245 (owner: AzaToth)
[14:24:53] <grrrit-wm>	 (CR) Hashar: "rebased" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/71245 (owner: AzaToth)
[14:28:25] <grrrit-wm>	 (PS14) Hashar: debian-glue macros and jobs [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/71245 (owner: AzaToth)
[14:42:37] <grrrit-wm>	 (CR) Zfilipin: [C: 2] only run on test2 until Bug 54886 resolved [qa/browsertests] - https://gerrit.wikimedia.org/r/90547 (owner: Cmcmahon)
[15:51:48] <grrrit-wm>	 (PS1) Zfilipin: WIP Moved config files to mediawiki/selenium repository [qa/browsertests] - https://gerrit.wikimedia.org/r/90559
[15:53:45] <grrrit-wm>	 (PS2) Zfilipin: WIP Moved config files to mediawiki/selenium repository [qa/browsertests] - https://gerrit.wikimedia.org/r/90559