[01:11:23] (CR) Krinkle: "Generated and deployed job 'parsoid-roundtrip-test-check'." [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95475 (owner: GWicke) [02:47:18] chrismcmahon: FYI I'm reorganizing How to run browsertests [10:37:58] (PS1) Hashar: readme: fix MEDIAWIKI_USER blockstyle [qa/browsertests] - https://gerrit.wikimedia.org/r/95590 [10:38:08] (CR) Hashar: [C: 2] readme: fix MEDIAWIKI_USER blockstyle [qa/browsertests] - https://gerrit.wikimedia.org/r/95590 (owner: Hashar) [10:39:07] zeljkof: hello :] [10:39:17] hashar: morning [10:39:33] I finally managed to setup cucumber etc on my laptop :] [10:39:37] and bonjour [10:39:43] great [10:39:44] the ULS ones are failing for me :-( [10:39:48] really? [10:39:54] they are rock solid [10:40:05] are you running them against wmf labs? [10:40:10] or your local mediawiki [10:40:12] ? [10:40:17] local wiki [10:40:30] ULS tests expect a lot of configuration [10:40:35] you should speak with language team [10:40:43] ohhhhh [10:40:46] I have no clue how to configure local wiki so the tests run [10:40:50] configuration of the extension? [10:40:59] I do not know [10:41:04] they make all the config [10:41:08] I just run the tests [10:41:31] for the sake of it, my results are http://noc.wikimedia.org/~hashar/uls-browsertests.html [10:41:49] hashar: well, you do not have firefox installed :) [10:41:59] ... [10:42:07] * hashar tries again with phantomjs [10:42:10] Could not find Firefox binary (os=macosx). Make sure Firefox is installed or set the path manually with Selenium::WebDriver::Firefox::Binary.path= (Selenium::WebDriver::Error::WebDriverError) [10:42:34] did you set browser label environment variable to phantomjs? [10:42:52] na forgot about it sorry :( [10:43:36] by default the tests will run on firefox [10:43:39] yeah that looks better now [10:43:57] language team is probably traveling to india, if you have trouble finding them online [10:44:13] I wanted to confirm they work properly on phantomjs [10:44:18] using master / master branches [10:44:25] hashar: I did not test them on phantomjs [10:44:31] I expect some things to fail [10:44:32] I think the Wiki I setup for jenkins test is badly configured [10:45:16] I did not understand that [10:45:20] sorry [10:45:36] the jenkins job I created to run ULS browser tests has a bunch of failures [10:46:03] they might be due to phantomJS or because of an issue in the Wiki configuration which is setup to run the tests [10:46:14] apparently they are phantomjs related, I got a bunch of issues [10:46:33] try running the tests with firefox [10:46:38] they should be stable with it [10:46:54] and if they fail with phantomjs, we can pair next week to get them running [10:47:01] would be nice [10:47:10] cause I don't think we can use Firefox in headless mode for Jenkins [10:47:15] pairing proved to be the best was forward [10:47:23] hashar: oh yes we can :) [10:47:27] timed out after 5 seconds, waiting for {:text=>"Edit source", :tag_name=>"a"} to become present (Watir::Wait::TimeoutError) [10:47:28] :D [10:47:31] I have already done that [10:47:36] \O/ [10:47:53] the reason I wanted phantomjs is that it is very easy to setup [10:47:56] but we should try getting them up and running with phantomjs anyay [10:48:09] just have to apt-get install phantomjs and then BROWSER_LABEL=phantomjs. [10:48:12] headless firefox should be trivial to set up on linux [10:48:35] might be worth a step by step guide in qa/browsertests.git in README.md [10:48:35] http://watirwebdriver.com/headless/ [10:48:53] yes, we do need to work on the docs [10:48:56] soon... [10:57:08] I should enable phantomjs cache as well [10:57:10] to speed tests [10:58:05] invalid byte sequence in UTF-8 (ArgumentError) [10:58:05] \O/ [10:58:54] (CR) Zfilipin: [C: 2] readme: fix MEDIAWIKI_USER blockstyle [qa/browsertests] - https://gerrit.wikimedia.org/r/95590 (owner: Hashar) [10:59:04] hashar: while I have you here... [10:59:25] I have noticed that different repos have different behaviour at gerrit web site [10:59:48] some repos force you to submit a change, some do not even offer submit as an option [11:00:02] some repos have verified radio buttons, some not... [11:00:09] is that on purpose? [11:03:11] (PS1) Zfilipin: Markdown requires four spaces to properly format a block of text as code [qa/browsertests] - https://gerrit.wikimedia.org/r/95591 [11:08:12] zeljkof: yeah different expectations [11:08:24] for example Jenkins is not allowed to merge changes in operations/* repositories [11:08:46] some repositories don't let people manually verify +2 which can only be done by Jenkins [11:08:48] that is a bit messy [11:08:56] ops is not on my radar anyway [11:08:58] I filled a bug for my phantomjs tests not passing [11:08:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=57099 [11:09:08] with some UTF-8 related stacktrace [11:09:12] and the HTML report generated [11:09:21] I must leave, my daughter is pissing of my wife :/ [11:09:31] hashar: have fun :) [11:09:39] yeah [11:09:40] :( [11:09:44] be back later [12:09:43] hashar: how do I tag commits in gerrit? [12:11:12] hashar: and do you know if there is something like "star" or "bookmark" feature in bugzilla? [12:11:41] adding yourself to cc is probably similar, but I am in way too much bugs in cc, so it is too crowded in cc list :) [12:18:21] zeljkof: git tag [12:18:30] then: git push gerrit --tags [12:18:38] or if your remote is "origin" : git push origin --tags [12:19:08] you can even sign the tag with gpg [12:19:22] hashar: thanks [12:19:30] can I see existing tags in gerrit? [12:19:35] to sign it: git tag -s [12:19:49] you can see them in giblit at git.wikimedia.org [12:19:53] or just "git tag" [12:20:48] hashar: hm, git tag returns nothing [12:20:51] lemme see... [12:21:04] maybe I have to fetch moar from gerrit [12:21:26] yes, git fetch origin did the trick [12:21:31] and git log --simplify-by-decoration --oneline --decorate --graph --all [12:21:33] I usually do just git fetch origin master [12:21:36] gives you a nice graph of branches and tags [12:22:20] git fetch origin --tags [12:22:38] would fetch just the tags, I am pretty sure they are fetched when doing simply git fetch origin [12:23:16] on another subject, I found out an issue with phantomjs, that is related to how the browsers normalize css font-familly [12:23:30] the css has font-familly: 'Autonym',sans-serif" [12:23:55] phantomjs normalize it by removing the single quotes so it yield: Autonym, sans-serif [12:24:03] whereas firefox yield 'Autonym', sans-serif [12:24:53] wow [12:25:02] we have to then fix the test [12:25:15] it does: on(InterlanguagePage).interlang_link_element.style("font-family").should == "'Autonym',sans-serif" [12:26:01] no clue what the style() comes from [12:26:01] hashar: added 0.1.13 tag to the gem [12:26:01] https://git.wikimedia.org/summary/?r=mediawiki/selenium.git [12:26:06] great [12:26:23] * [new tag] 0.1.13 -> 0.1.13 [12:26:49] hashar: unrelated, who should I ask to get commit bit to browsertests and mediawiki-selenium repos on github? [12:27:40] commit bit? [12:28:02] so I can for example close issues on github [12:28:09] like admin [12:28:11] oh my [12:28:16] or whatever github calls it [12:28:48] is https://github.com/wikimedia/qa-browsertests replicated by Gerrit ? [12:28:55] yes [12:29:11] so when a repo is replicated at github, I have no privileges to do stuff on github [12:29:22] what I need to do is close github issues, for example [12:29:34] or we could disable github issue tracker :D [12:29:36] will give you access [12:29:51] I would leave it there, there is no harm [12:30:06] but I would like to be able to close stuff, so it does not look abandoned [12:30:31] the same for https://github.com/wikimedia/mediawiki-selenium [12:33:09] I am trying to add you to the github wikimedia team [12:33:31] this is me [12:33:32] https://github.com/zeljkofilipin [12:34:24] https://github.com/organizations/wikimedia/teams/569423 [12:34:31] you should now be part of the qa team [12:35:22] hashar: great! :) [12:40:51] and the font normalization is filled as https://bugzilla.wikimedia.org/show_bug.cgi?id=57101 [12:41:22] hashar: is there a way to "star" or "bookmark" that bug? [12:41:31] Another one that fails is: Given I am logged in // When I am on a page with interlanguage links // Then the Interlanguage area should use Autonym font [12:41:42] adding myself to cc is not the best way, since I am in cc for a lot of bugs [12:41:49] I am not sure which page it is expecting, but it surely does not exist on my wiki [12:42:07] zeljkof: you could use a tracking bug [12:42:15] and mark all those bugs as being blocked by the tracking bug [12:42:52] example: https://bugzilla.wikimedia.org/showdependencytree.cgi?id=50664&hide_resolved=0 [12:43:10] interesting [12:43:13] let me try [12:43:37] since the two bugs that you have reported is something that I would like to get fixed in the next pairing session with the language team [12:44:16] another way is to add some string in the "Whiteboard" field [12:44:30] that is even better [12:44:31] then you can look for any bugs containing that string there [12:44:39] kind of a freeform keyword [12:44:43] and then create a search that will find them [12:44:49] will try that [12:45:56] example: all bugs mentioning [hardware]  https://bugzilla.mozilla.org/buglist.cgi?resolution=DUPLICATE;resolution=---;status_whiteboard_type=allwordssubstr;query_format=advanced;status_whiteboard=%5Bhardware%5D;component=Other;component=Custom%20Builds;component=Future;product=Release%20Engineering [12:47:30] works https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=pair-programming&sharer_id=16205 [12:53:06] \O/ [12:56:04] the rest of the tests, I have no clue what is wrong [12:56:15] probably assuming some pages already exist [12:56:33] yes [12:56:43] they are not the best of the tests that we have [12:56:51] when do you have the time to pair next week? [12:56:56] monday 10am? [12:58:27] I am not sure whether it is good idea for me to invest time figuring out how the browser tests work :D [12:58:47] gotta play with the VisualEditor ones [13:06:54] of course it requires parsoid grmblbl [13:10:22] hashar: we do not have to go into detail :) [13:10:37] we can just try fixing stuff in general, and I can take care of details [13:11:27] maybe it should be done with i18n team ? [13:11:58] hashar: I am already pairing with them four times a week, 2 hours each session [13:12:13] but they are in india next week, so pairings are off until they return [13:23:15] ahhh [13:23:25] I got VisualEditor and Parsoid running on my box!! [13:23:58] zeljkof: any clue how I can lower the default 5 seconds timeout ? [13:24:17] where? [13:24:26] | Numbering | ## | timed out after 5 seconds, waiting for {:title=>/Edit this page with VisualEditor/, :tag_name=>"a"} to become present (Watir::Wait::TimeoutError) [13:24:54] I am in the middle of something else, it is easy to fix, but you have to dig into ruby code [13:25:04] I think we should pair on this next week :) [13:25:24] yeah probably [13:25:43] and the tests are assuming a bunch of expectations which aren't true :/ [13:25:52] like assuming a "Selenium user" user :D [13:28:58] yes [13:29:04] we still have a long way to go [13:30:09] one more for VisualEditor https://bugzilla.wikimedia.org/show_bug.cgi?id=57103 [13:30:10] browsertests assume User:Selenium_user exist [13:30:14] i will attempt to fix it myself :] [13:30:27] good luck :) [13:36:15] crazy daughter is awake grmblbl [13:36:59] I give up anyway [13:37:13] the tests are making too many assumptions [13:39:41] filled bugs :D [13:39:50] that is good :) [13:39:56] we need moar bugs :) [13:40:00] that is going to take a looong time [14:19:15] hashar: is @bug actually recognised by doxygen? [14:20:08] no clue [14:21:13] okay :D [14:43:02] I am off for the rest of the day might show up later in the evening. [15:25:28] (PS1) Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95616 [15:31:32] (CR) Addshore: [C: -1] "Needs to be changed in zuul-config first as far as I know." [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95616 (owner: Jeroen De Dauw) [15:33:05] (PS1) Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/zuul-config] - https://gerrit.wikimedia.org/r/95617 [15:33:16] (CR) Jeroen De Dauw: "https://gerrit.wikimedia.org/r/95617" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95616 (owner: Jeroen De Dauw) [15:33:59] (Abandoned) Jeroen De Dauw: Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - https://gerrit.wikimedia.org/r/93428 (owner: Jeroen De Dauw) [15:35:30] (Abandoned) Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/zuul-config] - https://gerrit.wikimedia.org/r/95617 (owner: Jeroen De Dauw) [15:35:33] (Restored) Jeroen De Dauw: Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - https://gerrit.wikimedia.org/r/93428 (owner: Jeroen De Dauw) [15:36:11] (CR) Jeroen De Dauw: "Hashar, can you have a look at this? This blocks development." [integration/zuul-config] - https://gerrit.wikimedia.org/r/93428 (owner: Jeroen De Dauw) [16:36:52] (CR) Jhall: [C: 1 V: 1] Markdown requires four spaces to properly format a block of text as code [qa/browsertests] - https://gerrit.wikimedia.org/r/95591 (owner: Zfilipin) [16:37:30] Hi, I'm trying to upload a pic(.jpg) on beta. How do i do it? [16:39:46] Anjana, I ran into the same issue - see this e-mail thread on the QA list: [16:39:48] http://lists.wikimedia.org/pipermail/qa/2013-November/000675.html [16:40:16] You should be able to find the upload wizard on the Commons site: [16:40:18] http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard [16:40:34] I did that. How do i export the variable? :) [16:41:19] What platform are you using (Mac, Linux, Windows)? [16:42:15] win [16:42:59] I don't use Windows much, but I believe you'll need to export the environment variable value from a DOS (command) prompt [16:43:06] I believe the syntax is: [16:43:41] set MEDIAWIKI_URL= [16:44:13] I'm not a Windows expert, so you might want to do a Google search on the best way to set environment variables for your version of Windows [16:44:20] Thanks Jeff. Shall try it [19:05:23] (PS1) Addshore: Add job for SideBarMenu [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95653 [19:09:20] (PS1) Addshore: Add zuul trigger for SideBarMenu [integration/zuul-config] - https://gerrit.wikimedia.org/r/95654 [19:17:34] (CR) Addshore: "It appears tests will / should fail unless https://gerrit.wikimedia.org/r/#/c/95655/ is merged" [integration/zuul-config] - https://gerrit.wikimedia.org/r/95654 (owner: Addshore) [20:10:28] (PS1) Addshore: Remove duplicate AnitSpoof extension entry [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95660 [21:10:09] (CR) Zfilipin: "Jeff, for future reference, you should never change values in "Verified" section when reviewing a commit. I am not sure why the section is" [qa/browsertests] - https://gerrit.wikimedia.org/r/95591 (owner: Zfilipin) [21:14:27] (CR) Jhall: Markdown requires four spaces to properly format a block of text as code [qa/browsertests] - https://gerrit.wikimedia.org/r/95591 (owner: Zfilipin) [21:23:56] (PS2) Hashar: Remove duplicate AnitSpoof extension entry [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95660 (owner: Addshore) [21:24:03] (CR) Hashar: [C: 2] Remove duplicate AntiSpoof extension entry [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95660 (owner: Addshore) [21:24:36] (Merged) jenkins-bot: Remove duplicate AntiSpoof extension entry [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95660 (owner: Addshore) [21:27:05] (PS2) Hashar: Add job for SideBarMenu [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95653 (owner: Addshore) [21:27:20] (CR) Hashar: [C: 2] Add job for SideBarMenu [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95653 (owner: Addshore) [21:27:55] (Merged) jenkins-bot: Add job for SideBarMenu [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95653 (owner: Addshore) [21:29:53] (CR) Hashar: "Jobs deployed:" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95653 (owner: Addshore) [21:32:21] (CR) Hashar: "I guess we want to wait for "upstream" to merge the changes you submitted." [integration/zuul-config] - https://gerrit.wikimedia.org/r/95654 (owner: Addshore) [21:52:15] (PS2) Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95616 [21:52:17] (PS2) Jeroen De Dauw: Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - https://gerrit.wikimedia.org/r/93428 [21:53:16] (PS3) Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/95616 [22:09:20] I am tru=ying to upload a picture (.jpg) to beta. I don't see an icon or an option in the pull-down menu for this. I also tried uploading the picture to commons and then tried accessing it from beta. no luck. Can anyone help, pls? [22:10:04] I have also set the MEDIAWIKI_URL env variable. [22:27:09] Anjana, I'm seeing the same problem with images added via commons.wikimedia.beta.wmflabs.org not being available for insertion in articles on en.wikipedia.beta.wmflabs.org [22:27:47] Although it seems to work fine in production, so I think it might be an environmental issue with the beta.wmflabs test environment [22:29:18] Some key folks are out of the office today, but I can try to learn more next week to see if this is a bug or just an environmental issue [22:53:44] jeff, so is this a reported bug on beta? [22:57:45] anana, I don't think so, I just entered https://bugzilla.wikimedia.org/show_bug.cgi?id=57117 [22:58:31] Ok. Thanks! [22:59:20] that's just one piece of it, Special:UploadWizard is messed up on commons-beta, and I'm not sure whether en-beta supports accessing commons or commons-beta as JeffHall reports [23:11:09] Is there an option to upload images directly on beta? [23:13:36] d'oh, en-beta is configured so commons: links to production commons. [23:14:00] but I think [[File:A nice picture.jpg]] will locate a file on commons-beta [23:17:10] anjana you can upload at http://en.wikipedia.beta.wmflabs.org/wiki/Special:Upload or http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard [23:17:38] or http://commons.wikimedia.beta.wmflabs.org/wiki/Special:Upload [23:18:07] Thanks spage. Shall try it. [23:38:25] page, [[File:A nice picture.jpg]] din't work. I was able to upload a image via http://en.wikipedia.beta.wmflabs.org/wiki/Special:Upload. Now, my question is: I am on my homepage on beta which has a lot of text, I want to insert a image or a thumbnail. [23:38:48] How do i do it? [23:40:57] what i mean is , how do i embed a image or a thumbnail amidst the text on the page. [23:41:06] JeffHall, anjana File:Foo.jpg links find images from commons-beta OK for me, see http://en.wikipedia.beta.wmflabs.org/wiki/User:Spage_beta#commons-beta_link [23:42:33] anjana, just [[File:Some name.jpg]], see http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Spage_beta&action=edit [23:43:50] as for thumbnailing and captions, the (somewhat WTF? ☺) syntax is explained at https://www.mediawiki.org/wiki/Help:Images [23:47:51] anjana, are you User:Ranganu ? I was giving the wikitext syntax. It looks like you used VisualEditor to enter [[File:A nice picture.jpg]], so http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Ranganu&action=edit shows VE put this in tag so that it *wouldn't* work. [23:48:13] I was just about to tell you that :) [23:49:26] yes I am user:ranganu [23:49:38] and i am using VE [23:50:29] you can insert images with VisualEditor using toolbar More > Media , though it seems there are all kinds of bugs trying to locate [[A nice picture]]. Have fun filing them [23:50:35] :) [23:51:23] Thanks for your time, page.... [23:51:45] call me 'S', it really is my name. Are you working for WMF? [23:53:05] that's the problem with VisualEditor, we have 11 years of history explaining how to do things in wikitext, it'll all have to be prefaced with "ARE YOU USING VisualEditor?" [23:53:15] What doe 'S' stand for? Nope, I just trying to contribute to WMF as a volunteer... [23:55:15] I understand...I am very new here. don't know where to start...And obviously, I am kind of getting frustrated trying to figure out things...There is a ton of info here and don't know where to look :). Will keep trying. [23:57:45] S is my name, honest. I'm sorry I added to your frustration, my fault. Bugs: media browser doesn't filter sensibly, insert picture, clicking near picture and typing inserts in wrong location...