[00:03:55] JeffHall: links interface busted in FF: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/lastCompletedBuild/testReport/ Chrome looks OK [00:04:24] JeffHall: guessing you can repro that on beta labs [00:05:28] chrismcmahon: I tried reproing that manually via beta labs just now, and it seems to work fine - will also try it running the automated test locally [00:07:57] JeffHall: I repro'd on FF. clicking Link icon without touching anything else, nothing happened. on Chrome, first word is highlighted and Link UI appears [00:08:25] chrismcmahon: Yeah, something is wrong testing links via Firefox - I'll look into that more tomorrow. Luckily we're not deploying any of these changes to production this week! [00:09:05] JeffHall: want me to file the BZ for that then? I think this is a new issue. [00:09:30] chrismcmahon: Sure, that would be great if you can log the BZ ticket [03:05:49] Yippee, build fixed! [03:05:50] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #484: FIXED in 4 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/484/ [03:06:15] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #447: FAILURE in 4 min 27 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/447/ [03:10:21] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #314: FAILURE in 4 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/314/ [03:10:44] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #425: FAILURE in 4 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/425/ [03:25:05] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #496: FAILURE in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/496/ [03:45:11] Yippee, build fixed! [03:45:11] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #311: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/311/ [04:08:31] Yippee, build fixed! [04:08:32] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #379: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/379/ [04:25:49] Yippee, build fixed! [04:25:49] Project browsertests-test2.wikipedia.org-linux-chrome build #745: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/745/ [04:44:38] Yippee, build fixed! [04:44:38] Project browsertests-test2.wikipedia.org-linux-firefox build #719: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/719/ [04:49:56] Yippee, build fixed! [04:49:57] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #302: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/302/ [06:06:15] Project Translate-sandbox.translatewiki.net-linux-firefox build #73: FAILURE in 4 sec: https://wmf.ci.cloudbees.com/job/Translate-sandbox.translatewiki.net-linux-firefox/73/ [06:06:17] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #81: FAILURE in 1.4 sec: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/81/ [06:06:34] Project VisualEditor-test2.wikipedia.org-linux-firefox build #178: FAILURE in 3.4 sec: https://wmf.ci.cloudbees.com/job/VisualEditor-test2.wikipedia.org-linux-firefox/178/ [06:36:32] https://wmf.ci.cloudbees.com/view/r-uls/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/lastBuild/console is this issue known? [08:39:23] hi zeljkof [08:39:57] hashar: mayankmadan_ [08:40:00] sorry :) [08:40:04] hi mayankmadan_ [08:40:37] I speak to hashar too much, my IRC client thinks I want to ping him when I type "h" :) [08:40:48] hello [08:41:13] hashar: good morning, sorry about the ping, my mistake [08:42:09] mayankmadan_: do you have a question? [08:42:43] zeljkof, is there anything wrong with this page? https://www.mediawiki.org/wiki/Browser_testing/setup_instructions [08:42:48] if you have time [08:43:10] you are a part of Google code-in? [08:43:19] yep [08:43:49] mayankmadan_: since you are our first ever code-in student, I have all the time in the world :) [08:43:57] but I have a meeting in 15 minutes [08:44:04] let me see the page [08:44:08] thanks [08:44:41] mayankmadan_: the page looks good to me [08:44:45] great [08:45:10] do I have to close the ticket at code-in site? [08:45:24] zeljkof, can you close the task then? http://www.google-melange.com/gci/task/view/google/gci2013/5781683647283200 [08:45:40] https://wmf.ci.cloudbees.com/view/r-uls/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/lastBuild/console is this issue known? [08:46:00] mayankmadan_: sure, in 5-10 minutes [08:46:05] Nikerabbit: let me see... [08:46:12] okey doke [08:46:23] Nikerabbit: uh oh [08:47:25] it's all our tests failing with the same error btw [08:47:30] prolly others too [08:48:35] zeljkof: would you get time to review my browser tests tag for ULS ? [08:49:01] I would like to trigger the browser tests from Gerrit by the end of this week :D [08:50:35] wait everybody! there is only one of me :) [08:50:46] Nikerabbit: I will take a look at the failures with Amir today [08:51:18] hashar: your commits are high on my todo list, I will try to take a look today, but it will be merged by the end of the week for sure [08:55:17] mayankmadan_: ok, closing the code-in ticket in a minute or two [08:55:38] if you are looking for more documentation tickets, I will be more than happy to create a few more [08:59:08] zeljkof: it is not that much about the commit though, but more about how the scenario are tagged :D [08:59:33] the idea is to identify any tests which are not going to pass on a freshly installed wiki. [09:06:53] zeljkof, can you close the task if everything is ok? i was kinda in a hurry. But if you are busy then no problem [09:07:13] mayankmadan: closing it right now [09:07:19] thanks [09:07:33] closed [09:07:44] if you are looking for more documentation tasks, let me know [09:07:56] I would be glad to create a few more, we do need help [09:10:53] zeljkof, i wouldnt mind some more :) [09:11:11] but are there any coding tasks from you? [09:12:50] of course! :) [09:13:14] I am in a meeting for the next two hours, I will create a few tasks, both documentation and coding after the meeting [09:13:56] great [09:55:41] Yippee, build fixed! [09:55:42] Project Translate-sandbox.translatewiki.net-linux-firefox build #74: FIXED in 4 min 6 sec: https://wmf.ci.cloudbees.com/job/Translate-sandbox.translatewiki.net-linux-firefox/74/ [09:57:03] Yippee, build fixed! [09:57:03] Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #71: FIXED in 1 min 21 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/71/ [10:05:42] Yippee, build fixed! [10:05:43] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #82: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/82/ [10:17:26] (CR) Amire80: [C: 2] Added links to Jenkins jobs [selenium] - https://gerrit.wikimedia.org/r/96023 (owner: Zfilipin) [10:17:30] (Merged) jenkins-bot: Added links to Jenkins jobs [selenium] - https://gerrit.wikimedia.org/r/96023 (owner: Zfilipin) [10:34:47] hashar: do you know why this page has "edit links" at the bottom-left http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page [10:34:50] but this page does not [10:34:55] http://en.wikipedia.beta.wmflabs.org/wiki/Boleyn_family [10:35:06] css [10:35:17] what about it? [10:35:18] ahh [10:35:26] no I have no idea [10:35:29] :) [10:35:35] should I ask wikidata people? [10:35:54] yup definitely [10:36:29] that might be related to a user permission which we dont have onbeta [10:39:33] hashar: can you take a look at wikidata channel [10:39:43] I got the reply there, but I do not understand what they mean [10:53:50] zeljkof, this task doesnt make any sense [10:53:52] http://www.google-melange.com/gci/task/view/google/gci2013/5814239499386880 [10:53:58] the page doesnt exist now [10:54:10] yes, sorry [10:54:16] we have deleted the page and forgot to delete the task [11:29:36] zeljkof, what about the tasks that you were about to add? [11:29:56] mayankmadan: I have just finished with the meeting, still writing meeting notes [11:30:12] okay [11:30:15] as soon as I am done with that I will add a few more documentation and coding tasks [11:30:18] no problem :) [11:30:32] I did not find a way to delete that obsolete task [11:30:54] I will probably reuse the task, just change the title and text to something else [11:31:18] hmm [11:31:38] Nikerabbit: looks like the failure that you have noticed earlier today is a cloud bees problem, [11:36:37] it is fixed now [11:43:21] zeljkof: oki [11:43:31] zeljkof: will someone trigger reruns of tets or should we just wait? [11:47:12] (PS1) Hashar: tweak phpunit-junit macros [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97725 [11:47:15] (PS1) Hashar: phpunit job + wikimedia/wikimania-scholarships [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97726 [11:47:23] (CR) Hashar: [C: 2] tweak phpunit-junit macros [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97725 (owner: Hashar) [11:47:30] (CR) Hashar: [C: 2] phpunit job + wikimedia/wikimania-scholarships [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97726 (owner: Hashar) [11:48:07] (Merged) jenkins-bot: tweak phpunit-junit macros [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97725 (owner: Hashar) [11:48:22] (Merged) jenkins-bot: phpunit job + wikimedia/wikimania-scholarships [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97726 (owner: Hashar) [11:52:19] (PS1) Hashar: triggers for wikimedia/wikimania-scholarships [integration/zuul-config] - https://gerrit.wikimedia.org/r/97727 [11:53:05] (CR) Hashar: [C: 2] triggers for wikimedia/wikimania-scholarships [integration/zuul-config] - https://gerrit.wikimedia.org/r/97727 (owner: Hashar) [11:53:14] (Merged) jenkins-bot: triggers for wikimedia/wikimania-scholarships [integration/zuul-config] - https://gerrit.wikimedia.org/r/97727 (owner: Hashar) [11:59:54] (PS1) Hashar: phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97729 [12:00:41] (PS2) Hashar: phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97729 [12:00:50] (CR) Hashar: [C: 2] phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97729 (owner: Hashar) [12:01:15] (Merged) jenkins-bot: phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97729 (owner: Hashar) [12:12:37] Nikerabbit: I have already rerun the tests [12:52:57] zeljkof, are you free now? [12:53:11] mayankmadan: I am for the next 5 minutes :( [12:53:15] then I have another meeting [12:53:29] I did not have the time to add more tasks, if that is what you wanted to ask [12:53:36] zeljkof, so you are like a super busy person :) [12:53:45] I promise I will do my best to add more tasks after this meeting [12:53:55] mayankmadan: not usually, but today is crazy :) [13:35:08] (Abandoned) Hashar: pipelines.test: Change from Verified+2 to Verified+1 [integration/zuul-config] - https://gerrit.wikimedia.org/r/61720 (owner: Krinkle) [13:37:46] (Abandoned) Hashar: experimental breadcrumb display [integration/docroot] - https://gerrit.wikimedia.org/r/68343 (owner: Hashar) [13:38:04] (Abandoned) Hashar: experimental HTML console publishing [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/74424 (owner: Hashar) [13:38:11] (Abandoned) Hashar: publish-console.py script [integration/jenkins] - https://gerrit.wikimedia.org/r/75637 (owner: Hashar) [13:40:37] (PS2) Hashar: Actually trigger mwext-MobileFrontend-phpcs-HEAD . [integration/zuul-config] - https://gerrit.wikimedia.org/r/94239 (owner: JanZerebecki) [13:40:53] (CR) Hashar: [C: 2] "sorry , I have been long to visit this change." [integration/zuul-config] - https://gerrit.wikimedia.org/r/94239 (owner: JanZerebecki) [13:40:59] (Merged) jenkins-bot: Actually trigger mwext-MobileFrontend-phpcs-HEAD . [integration/zuul-config] - https://gerrit.wikimedia.org/r/94239 (owner: JanZerebecki) [13:44:28] (CR) Hashar: "deployed" [integration/zuul-config] - https://gerrit.wikimedia.org/r/94239 (owner: JanZerebecki) [13:46:03] (PS4) Hashar: Only run linting and not tests [integration/zuul-config] - https://gerrit.wikimedia.org/r/97061 (owner: Jeroen De Dauw) [13:47:09] (CR) Hashar: [C: 2] "That is a pity, makes the WMF Jenkins useless so you might as well disable all jobs." [integration/zuul-config] - https://gerrit.wikimedia.org/r/97061 (owner: Jeroen De Dauw) [13:49:00] (Merged) jenkins-bot: Only run linting and not tests [integration/zuul-config] - https://gerrit.wikimedia.org/r/97061 (owner: Jeroen De Dauw) [14:00:15] mayankmadan: are you here? [14:01:48] (CR) Hashar: "deployed" [integration/zuul-config] - https://gerrit.wikimedia.org/r/97061 (owner: Jeroen De Dauw) [14:05:45] zeljkof: so what about my proposed Selenium tag "specific-settings" ? To flag out tests which are expecting something more than a fresh wiki ? :] [14:06:11] hashar: sounds good to me [14:06:28] did anybody else comment (Chris, Jeff...)? [14:09:04] hashar: alone or in addition to default-settings? [14:10:22] Nikerabbit: default-settings was my original plan :D [14:10:30] wanted to white list the changes that would pass on a fresh wiki [14:10:42] then I thought it would be better to blacklist list the one requiring a specific setup [14:18:11] zeljkof, yep [14:18:34] mayankmadan: do you have a minute to chat here? [14:18:43] yep [14:18:44] I would like to know what tasks are you interested in [14:19:15] to start, my name is Željko, I live in Zagreb (Croatia) and I work as a software tester for Wikimedia Foundation [14:19:45] we have a lot of tasks related to testing/QA [14:19:56] two main groups are documentation and code [14:20:05] are you more interested in documentation or code? [14:20:11] both [14:20:14] (and feel free to introduce yourself) [14:20:20] great [14:20:25] do you know ruby? [14:20:32] or would you like to learn ruby? :) [14:20:33] my name is Mayank Madan, from india [14:20:41] i dont know ruby at all [14:20:48] but ive been meaning to learn it :) [14:20:52] ok, great [14:21:00] I have a few easy tasks just for you [14:21:09] beginner ruby? [14:21:12] yes [14:21:16] just to get you feet wet [14:21:23] how old are you? [14:21:35] I know you are in high school, just curious [14:21:43] feel free not to answer [14:22:18] back to code, I would like us to follow ruby style conventions [14:22:22] this is a good guide [14:22:22] https://github.com/styleguide/ruby [14:22:30] I have a couple of tasks in mind [14:22:43] they could take you a few days each to complete [14:22:46] zeljkof, im 16 [14:23:20] how much time did it take you to do the first task? (moving setup to a separate age) [14:23:32] 20 mins [14:23:32] \ [14:23:43] ok, that is pretty short, right? :) [14:23:55] better than nothing :D [14:24:06] I was told the tasks should be big enough to take at least a few hours to complete [14:24:25] hashar: the first task is a way to get them interested :) [14:24:44] mayankmadan: are you interested in tasks that will take you a few hours to complete? [14:24:53] yes [14:25:10] mayankmadan: ok [14:25:16] two tasks that I had in mind [14:25:47] take a look at "Strings" section of guide [14:25:51] https://github.com/styleguide/ruby [14:26:04] most of our code base is violating this [14:26:08] "Prefer string interpolation instead of string concatenation" [14:26:27] zeljkof, first i wanted to ask, how will be these 2 tasks weighed in final evaluation? [14:26:29] so the first task would be to find all double quotes in ruby files in about 10 repositories [14:26:47] mayankmadan: I have no idea how the tasks are wighted [14:27:03] this is the first time I participate in the google code-in [14:27:18] but this two ones will be more complicated than the first one [14:27:31] i really wanna be a grand prize winner so i need to make sure that i do a lot of tasks and some of them needs to be good coding tasks too :) [14:27:57] and I have more complicated tasks in mind, if you finish the two introductory ones [14:28:05] mayankmadan: I like the spirit! :) [14:28:16] there is another thing [14:28:24] we do have a lot of things that needs to be done, and there is a lot of code to be written [14:28:28] go ahead [14:28:49] i dont know anything about ruby. i am good at php js python but not ruby [14:29:06] no problem, you will pick up enough ruby [14:29:17] im gonna do it!!! [14:29:54] if you want more php/js/python tasks, you will have to look elsewhere [14:29:54] if you want to learn ruby, stay tuned :) [14:30:07] i want to learn ruby!!! [14:30:19] but i will need help from you guys too :) [14:30:32] mayankmadan: I promise to teach you everything I know, if you want to learn :) [14:30:49] thank you [14:31:04] ok, the second task I had in mind [14:31:17] if you look at "Naming" section of the guidelines [14:31:20] https://github.com/styleguide/ruby [14:31:31] I have noticed that we violate this one [14:31:33] Use snake_case for methods and variables. [14:31:37] in at least one repository [14:31:58] so the task would be to replace all camelCase methods with snake_case [14:32:11] okey doke [14:32:14] ok [14:32:24] I will enter the tasks in melange and you can get started [14:32:32] when they are finished, we can move forward [14:32:34] both the tasks? [14:32:44] I think you can take just one at a time, right? [14:32:50] yes [14:33:05] so as soon as the first one is finished I promise to close the task as soon as possible [14:33:07] can you add just 1 now so that i can get the next one too? [14:33:11] wait, phone [14:33:24] no problem, that is an option too [14:37:56] mayankmadan: sorry, family emergency, have to do something, will be back in 30 or so minutes and I will add the task to the code-in site [14:38:03] when it is done I will add another one [14:38:08] no problem [14:38:46] Nikerabbit: I am dropping the @default-settings tag from the ULS browser tests [14:38:58] feel free [14:39:08] Nikerabbit: blacklisting the one requiring a specific wiki sounds better, this way the test will always be run on fresh wiki [14:39:40] Nikerabbit: I tend to dislike that tag name but could not find out something better :/ [14:40:40] @needs-custom-setup ;D [14:40:50] yeah good idea [14:46:44] (PS12) Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 [14:46:56] (CR) Hashar: "rebased" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 (owner: Hashar) [14:48:54] (PS13) Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 [14:49:19] (CR) Hashar: "+ MobileFrontend" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 (owner: Hashar) [14:49:42] (PS14) Hashar: browsertests for some extensions [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 [14:50:01] (CR) Hashar: [C: 2] "lets unleash them. deployed!" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 (owner: Hashar) [14:50:23] (Merged) jenkins-bot: browsertests for some extensions [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86868 (owner: Hashar) [14:51:24] Nikerabbit: and now I am adding mwext-browsertests-UniversalLanguageSelector-phantomjs to the list of job triggered in Zuul [14:53:10] ok [14:54:42] (PS1) Hashar: ULS browsertests on check pipeline [integration/zuul-config] - https://gerrit.wikimedia.org/r/97741 [14:55:34] (CR) Hashar: [C: 2] "deploying" [integration/zuul-config] - https://gerrit.wikimedia.org/r/97741 (owner: Hashar) [14:55:44] (Merged) jenkins-bot: ULS browsertests on check pipeline [integration/zuul-config] - https://gerrit.wikimedia.org/r/97741 (owner: Hashar) [15:37:08] zeljkof, you are back :) [15:37:25] mayankmadan: yes, starting to work on the task [15:37:28] was having a look at ruby syntax [15:37:39] how to you like it? [15:38:51] its nice [15:41:04] I will add a basic task to melange site, and link to the bugzilla [15:41:13] and add all details to bugzilla [15:41:29] I will post the link here when it is created [15:41:34] so you can claim the task [15:41:44] and get the data in bugzilla as I write it [15:55:34] JeffHall: would you like to be one of the google code-in mentors? [15:55:57] chrismcmahon and I are already mentors, but we could use some help [15:56:03] Sure - I'm interested, but not really sure what's involved [15:56:06] it would not take a lot of your time [15:56:22] OK, sounds good to me! [15:56:27] all you need to do is review task that students do [15:56:38] and optionally, create new tasks for studens [15:56:43] students, that is [15:57:16] OK - I did some review for mayankmadan yesterday, so I can definitely do that for other students as well [15:58:05] JeffHall: great, I have asked what you need to do [15:58:40] JeffHall: Quim will let you know what you need to do [16:00:22] zeljkof: Yep, Quim just talked to me, so I'm getting setup now [16:00:30] JeffHall: great [16:00:36] I am writing new tasks [16:03:13] please ping me when the task is created :) [16:07:05] here it is [16:07:14] https://www.google-melange.com/gci/task/view/google/gci2013/5896231096156160 [16:08:10] zeljkof, the page is inactive :( org admin has to approve it [16:08:21] mayankmadan: I will ping them [16:09:52] approved! :) [16:09:59] claimed it :) [16:10:03] I will add more data to the bug after lunch [16:10:06] back in 30 minutes [16:10:30] wait [16:10:44] zeljkof, which git repo do i clone? [16:10:46] I am adding data to the bug as I write this :) [16:10:52] take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=57597 [16:10:59] there is 10 or so repos in the list [16:12:06] * zeljkof is out to lunch [16:12:51] there is no list [16:13:09] zeljkof, ^ [16:13:29] or anyone who can help as zeljkof is gone [16:13:40] JeffHall :^^ [16:19:05] chrismcmahon, ^^ [16:20:19] mayankmadan: read the bug carefully please [16:20:35] chrismcmahon, i cannot find the list in the given url [16:21:47] mayankmadan: do you see where it says "list of repositories"? [16:21:58] chrismcmahon, in the link section there are 9 repos but the task said 10 [16:22:19] yes [16:23:13] mayankmadan: the 10th is mediawiki/selenium itself I believe [16:23:19] ok [16:23:40] so do i change all the single quotes including the ones that are in require statements? [16:25:45] mayankmadan: do you have an account it gerrit? you'll have to be able to submit patches http://www.mediawiki.org/wiki/Developer_access [16:25:54] yes i do [16:26:00] chrismcmahon, ^^^ [16:26:04] mayankmadan: OK [16:26:24] so do i change all the single quotes including the ones that are in require statements? [16:30:21] mayankmadan: what does the style guide say? [16:31:20] Yippee, build fixed! [16:31:21] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #186: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/186/ [16:33:59] mayankmadan: did you get the list of repos? [16:34:06] yep [16:34:15] great [16:34:20] do you have any questions? [16:34:31] all you have to do is clone all repos, 10 or so of them [16:34:51] and replace all double quotes with single quotes in .rb and .feature files [16:34:55] are you free for sometime? [16:35:06] yes, I have 25 minutes now until the next meeting [16:35:26] cause i wont be able to reply for about 10 mins(having dinner) [16:35:35] sure, I will be here [16:35:49] I will probably be able to answer short questions during the meeting too [16:45:34] zeljkof, do i have to change all the single quotes to double or just including require, if etc [16:45:53] and how do i test out the scripts after making changes? [16:45:56] mayankmadan: change all single to double [16:46:09] and I will change back the ones that need to be single [16:46:15] ok [16:46:21] do you have gerrit account? [16:46:26] yes [16:46:29] meaning: did you clone from gerrit? [16:46:31] ok, great [16:46:48] zeljkof, how do i test out the scripts after making changes? [16:46:55] do you know how to push changes back to gerrit? [16:47:05] by git review [16:47:14] great, do you have git-review installed? [16:47:24] which OS do you use? windows, mac, linux? [16:47:58] yes [16:48:01] i use linux [16:48:14] ubuntu 13.04 [16:48:31] ok, great [16:48:44] I will be back in a minute, this IRC client is behaving [16:48:47] will try another one [16:50:01] I am back [16:51:14] mayankmadan: do you know how to add me as a reviewer once you push the commit to gerrit? [16:51:21] yes [16:51:31] mayankmadan: wow, you know everything! :) [16:51:50] ok, ping me if you have any questions, I will be online for the next hour or two [16:52:25] zeljkof, how do i test scripts after making changes to them? [16:52:43] mayankmadan: it depends on the repository [16:52:56] the simplest check is to run ruby linter [16:53:08] do you have everything set up to run browser tests? [16:53:39] i dont even have ruby [16:53:41] zeljkof, ^ [16:53:45] :) [16:53:54] ok, you have to follow the advice from the page you have created :) [16:54:05] and if you find something wrong there, please do update the page [16:56:40] mayankmadan: anyway, just push the change to gerrit, I can test it on my machine [16:56:45] okay [16:56:56] and I can let you know how to test it on your machine when you make all the changes [16:57:13] the code in gerrit can be changed, so feel free to push there [16:58:09] zeljkof, are all the problems with concatenation fixed? [17:00:22] mayankmadan: what do you mean by that? [17:00:47] is that a general question, or something related to replacing quotes? [17:00:59] Prefer string interpolation instead of string concatenation: [17:01:10] mayankmadan: we have a few of those too [17:01:14] in first section of Strings in styleguide [17:01:20] in wikidata repo [17:02:16] chrismcmahon: I noticed that even the Chrome jobs for VisualEditor failed in their last CloudBees run: https://wmf.ci.cloudbees.com/view/r-ve/ [17:02:30] zeljkof, getting this error while installing ruby [17:02:33] chrismcmahon: Is it OK if I kick those jobs off manually to try and trouble-shoot them? [17:02:49] JeffHall: one sec... [17:02:55] JeffHall: yes, you can start all jenkins jobs you want :) [17:03:01] zeljkof, specifically while this step: rvm install ruby-2.0.0-p247 [17:03:07] mayankmadan: can you paste the error here? [17:03:25] sorry forgot to paste it :) [17:03:28] http://etherpad.wikimedia.org/p/mayankmadan [17:03:31] https://dpaste.de/K5Rj [17:03:32] paste here [17:03:39] zeljkof, ^^ [17:03:40] ok, that is good [17:04:07] mayankmadan: uh oh [17:04:16] did you read the log file? [17:04:24] from the error message? [17:04:34] JeffHall: I guess. https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/163/console shows the msg. "/use-ruby: line 1: syntax error near unexpected token `<'" [17:06:09] zeljkof, https://dpaste.de/Nf8c [17:06:19] i think the repository in the last is not added [17:06:48] chrismcmahon: Yeah, that error seems environmental to me, so want to see if it will repeat on a re-run of the same jobs [17:07:00] mayankmadan: ok, can you install ruby via apt-get? [17:07:06] JeffHall: go for it [17:07:08] (are you on ubuntu?) [17:07:20] yep im on ubuntu [17:07:57] do you have rvm installed? [17:08:02] yes [17:08:04] maybe you can install different ruby version? [17:08:40] which version? [17:09:34]