chrismcmahon: It appears to be a timing issue - if I modify the relevant step with a brute-force sleep, everything comes up roses: [17:52:19] When(/^I click Review your changes$/) do [17:52:19] sleep 5 [17:52:19] on(VisualEditorPage).review_changes_element.when_present.click [17:52:19] end [17:53:22] chrismcmahon: Yep, I do have that review_changes element in iframe-index-1, so I'm pretty sure I have your latest code [17:54:49] chrismcmahon: It seems that I just have a fast machine, and Selenium is looking for page elements faster than the browser is loading them [17:56:42] chrismcmahon: I'll try adding wait_until behavior in place of my "sleep" [17:57:09] JeffHall: so the sleep actually dtrt then? [17:59:03] Yeah, adding a simple sleep in the relevant test fixes it, and jsut to prove it, I removed that one-line sleep statement, re-ran the test with Chrome, and the "Element is not clickable at point…" is mocking me again [18:02:37] JeffHall: it is MAC OS X 10.8.5 [18:03:39] ryasmeen: OK, thanks - just wanted to know if your machine was already updated to Mavericks (OSX 10.9) - you and I have the same version of Mac OS, so that's good! [18:10:39] (CR) Zfilipin: "@Hashar: if you are talking about comments I made in env.rb[1], Ruby did not complain because it is valid Ruby code. :) But, I find it con" [selenium] - https://gerrit.wikimedia.org/r/97756 (owner: Mayankmadan) [18:17:10] hi zeljkof [18:17:19] hi mayankmadan_ [18:17:39] can i have another task? [18:17:42] sure [18:17:51] nothing on the list looks interesting to you? [18:18:01] I saw that a few tasks is already taken [18:18:08] yep [18:18:11] I have a few good ones in mind [18:18:16] let me think for a second [18:18:27] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #428: FAILURE in 4 min 24 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/428/ [18:20:47] mayankmadan_: I think this would be a good task for you [18:20:48] https://www.google-melange.com/gci/task/view/google/gci2013/5888156557639680 [18:20:58] since you have already worked on the documentation [18:21:27] but if you prefer a coding task I have a few in mind [18:21:38] zeljkof, i was thinking to do it after i have done another coding task [18:21:45] is there anything left for you in the previous task? [18:22:03] yes [18:22:06] just saw it [18:22:11] the last time I checked there was just a couple of small things left to finish everything [18:22:37] I have closed the task at google site so you can move to the next one, because what is left was really details [18:22:58] ill do that now [18:23:04] https://gerrit.wikimedia.org/r/#/c/97781/ [18:23:04] please do [18:23:12] there are no inline comments [18:23:12] I will create a few more new tasks [18:23:42] mayankmadan_: you have to expand "patch set 1" [18:23:44] the comments are there [18:23:59] by default only the last patch set is expanded, in this case patch set 2 [18:24:10] so you do not see the comments that I have left for patch set 1 [18:24:29] i fixed all the problems that were in patch set 1 [18:24:30] no, wait [18:24:44] really, I have left a couple of comments, but they are not visible [18:24:48] let me see... [18:25:12] found it! :) [18:25:13] https://gerrit.wikimedia.org/r/#/c/97781/1..2/tests/browser/features/support/pages/main_page.rb [18:25:18] here are comments [18:25:38] I am not sure why it is not visible from the commit page [18:29:09] zeljkof, there is no file named main_page.rb in UniversalLanguageSelector that i changed [18:30:38] zeljkof, https://gerrit.wikimedia.org/r/#/c/97781/2/tests/browser/features/support/pages/main_page.rb [18:30:44] it says no differences [18:32:34] let me see... [18:33:45] I see [18:34:02] when you did the rebase, you have pulled this file into the repository [18:34:04] https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/tests/browser/features/support/pages/main_page.rb [18:34:12] and it has a few single qoutes [18:34:14] chrismcmahon: After some tinkering on my MacBook, I've discovered that I can get VE browser tests to work with Chrome only where I use explicit "sleep" statements - "wait_until" statements will not do the trick [18:34:38] mayankmadan_: do you see the file in the repository (on your machine)? [18:34:47] chrismcmahon: Going to do some searching in StacKOverflow to see if anyone else has encountered this same issue... [18:35:12] JeffHall: that is somewhat bizarre [18:40:21] zeljkof, yes i do [18:40:48] mayankmadan_: please change single quotes to double and that is all [18:40:54] that needs to be done [18:47:35] zeljkof, done [18:47:46] mayankmadan_: great [18:47:57] I think there were three things left to do, did you do them all? [18:48:09] I mean three commits [18:48:49] there were 2 commits left [18:48:53] im onto the last one [18:49:02] mayankmadan_: great [18:49:06] let me know when you are done [18:54:12] zeljkof, done [18:54:27] mayankmadan_: great, let me take a look [18:56:58] mayankmadan_: this still has one small thing to fix https://gerrit.wikimedia.org/r/#/c/97761/ [18:57:03] manybubbles: are you here? [18:57:10] here [18:57:22] great [18:57:28] could you answer this question? https://gerrit.wikimedia.org/r/#/c/97761/4/tests/browser/features/full_text.feature [18:57:32] please :) [18:57:48] so we could finally close this task for mayankmadan_ [18:57:57] I think that is the only thing left [18:58:18] answer was sitting as a draft:( [18:58:27] manybubbles: :) [18:58:30] I'd left it 20 minutes ago but not published it [18:58:34] zeljkof, the task is already closed [18:58:52] mayankmadan_: I know, I mean so you have actually finished all the work [18:58:59] and so you could move on to another task [18:58:59] oh [18:59:38] you were about to publish a task [19:00:08] mayankmadan_: yes, I have something in mind, but I have to ask other people how to do it [19:00:19] just a second to check your code [19:04:05] mayankmadan_: this looks good https://gerrit.wikimedia.org/r/#/c/97842/ [19:05:40] yippee [19:06:13] there are a couple of small changes that need to made here: https://gerrit.wikimedia.org/r/#/c/97761/ [19:06:16] in patch set 4 [19:06:31] I am reviewing the other commit that you have just pushed [19:13:14] mayankmadan_: this is what I had in mind for a coding task [19:13:15] http://lists.wikimedia.org/pipermail/wikitech-l/2013-November/073270.html [19:13:24] but I do not know really what needs to be tested [19:13:33] so I have to wait for somebody to let me know [19:13:40] and I have more ideas [19:14:13] zeljkof, btw just fixed the errors [19:14:50] looking at the code... [19:15:20] mayankmadan_: do you have open source experience? or coding experience in general? [19:15:43] some with kde [19:16:00] mayankmadan_: you are pretty fast with the tools we use :) [19:16:06] I am impressed [19:16:43] thanks :D [19:18:45] manybubbles: mayankmadan_ this looks good to me https://gerrit.wikimedia.org/r/#/c/97761/ [19:19:03] manybubbles: please take a look and feel free to merge it if you have no complaints [19:19:29] mayankmadan_: checking the last commit [19:20:16] mayankmadan_: does this look interesting to you? http://lists.wikimedia.org/pipermail/wikitech-l/2013-November/073270.html [19:20:45] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #384: FAILURE in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/384/ [19:20:56] if yes, I can create a draft task, you can start working on it, and if we get some comments in the next day or two, we can agree to accept or reject them [19:21:45] and if that project is interested in selenium tests, new tests could be new tasks [19:21:56] there is no need to put everything into one task [19:22:00] what do you say? [19:22:44] i say lets do it [19:22:53] mayankmadan_: deal! [19:23:12] I will +1 the last commit in a minute and create the task in the next 5-10 minutes [19:23:34] you can start working on the first test, and if the project is interested in tests, we can make new tasks for new tests [19:23:53] the first task will be to create a few basic tests, just to see if it is doable or not [19:24:15] ill be back in 5 mins [19:24:18] and if you prove it is doable, then the sky is the limit [19:26:26] mayankmadan_: as far as I am concerned double quotes task is finished! :) [19:26:27] hey, I'm asking in #wikimedia-operations about config changes to fix beta labs ( https://gerrit.wikimedia.org/r/#/c/97933/ ) but hashar & Reedy aren't around. Do people mind if fixes for beta labs accumulate in mediawiki-config ? [19:26:31] let's start with the pdf task [19:31:36] zeljkof, i need to try some tests right? [19:32:55] mayankmadan_: I am working on the task description right now [19:33:02] okay dokay [19:33:18] did you read my blog posts' [19:33:19] ? [19:33:33] or watch videos that Chris and I have created? [19:33:57] you will learn a lot by reading articles from my web site: http://filipin.eu/ [19:34:13] something to keep you occupied while I work on the task [19:34:15] :) [19:34:45] which videos? [19:35:27] zeljkof, ^ [19:36:06] read the last few blog posts at my blog [19:36:35] there are embedded youtube videos [19:43:53] * zeljkof is back in 20 minutes [20:30:27] Yippee, build fixed! [20:30:28] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #305: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/305/ [20:43:49] zeljkof, you are finally bacl :) [20:44:08] mayankmadan_: yes, sorry, had family stuff to take care of [20:44:16] I will create the task right now [20:44:16] no problem [20:44:23] wait [20:44:35] first explain me the task please [20:44:37] did you get familiar with selenium and cucumber and friends [20:44:46] i kinda took a nap :) its really late here [20:45:14] ok, so the task is to create a test for "export html page to pdf" feature [20:45:30] you would click a link on a page that would create a pdf [20:45:54] a script should create a simple article on a mediawiki site [20:46:01] then export the article to pdf [20:46:09] and check if everything got exported [20:46:20] title, text, images, links... [20:46:33] the task would be about a day or two work [20:46:49] so not too much, but enough to be a good task [20:46:53] the time needed is not important [20:47:01] hallo [20:47:03] but i dont know how to create tests [20:47:10] and if the team doing the export feature is interested in tests, then we could create more tests [20:47:24] mayankmadan_: that is what you are here for, right? to learn :) [20:47:28] GEOFBOT: hi [20:47:32] hey [20:47:36] zeljkof, yep [20:47:36] i have jenkins [20:47:37] GEOFBOT: do you have a question? [20:47:39] on cloudbee [20:47:49] building a python program over and over again [20:47:56] GEOFBOT: oh, you are the other code-in student? [20:47:58] how would i get it to have email notifications for success? [20:48:00] yeah [20:48:20] GEOFBOT: just a second, I have finish something, will reply in a minute [20:48:25] ok [20:48:40] mayankmadan_: do you have any further questions? I will make sure to provide enough data so you can start [20:49:07] zeljkof, will you help me in learning to write tests? [20:49:21] mayankmadan_: that is what I do! :) [20:49:37] thank you very much [20:49:57] mayankmadan_: I spend a lot of time teaching people how to write tests [20:50:17] GEOFBOT: is you Jenkins instance public? can you provide a link? [20:50:52] zeljkof: im not sure if its public [20:50:55] but here is a link [20:50:56] https://geofbot.ci.cloudbees.com/job/test/ [20:51:45] GEOFBOT: it is not public :) [20:51:53] GEOFBOT: just a second, will let you know [20:52:08] GEOFBOT: by the way, where are you from? (I am from Croatia) [20:53:23] zeljkof: us eastern coast [20:53:41] GEOFBOT: I was recently in Boston, had a great time [20:55:02] GEOFBOT: so, to send e-mail notifications in jenkins... [20:57:20] GEOFBOT: assuming you have created a free-style software project [20:58:07] yes [20:58:14] if you go to configure job page [20:58:24] at the bottom there will be post-build actions section [20:59:01] add e-mail notification section [20:59:14] add recipients [20:59:38] (your e-mail) [20:59:50] and after every failed build you will get e-mail notification [21:00:04] GEOFBOT: does that answer your question? [21:01:54] yes, thanks [21:02:00] so should i just make the program break on purpose? [21:02:09] so it will send emails [21:04:57] zeljkof, whenever you are ready [21:05:33] GEOFBOT: yes, that should be the next step [21:05:46] when you receive e-mails, then you can start changing them [21:06:11] im using a github repository [21:06:14] mayankmadan_: sorry, I have a ton of distractions, I will create the task now [21:06:19] i changed the code on purpose [21:06:22] and i will see what happens [21:06:31] GEOFBOT: great, can you post the link to the bug in bugzilla? [21:06:46] and also feel free to post link to the jenkins instance [21:06:59] zeljkof: https://bugzilla.wikimedia.org/show_bug.cgi?id=55824 [21:07:13] Yippee, build fixed! [21:07:14] Project Flow-en.wikipedia.beta.wmflabs.org-linux-chrome build #74: FIXED in 1 min 52 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-chrome/74/ [21:07:55] zeljkof: one last thing [21:08:05] how do you get jenkins to get the latest verison of code from github [21:08:19] oh wait [21:08:23] nevermind, it picked it up [21:13:41] GEOFBOT: yes, it should just pick the latest coce [21:13:42] code [21:13:47] im not sure [21:13:53] if its working the way i twant it to. [21:14:00] if i make a syntax error, it still passes [21:14:13] please add links to your code and jenkins to the bug [21:14:35] GEOFBOT: you can always see the code that jenkins has [21:14:37] go to the job [21:14:54] and then click workspace on the left hand side [21:15:03] and you will see the files that jenkins has [21:16:52] chrismcmahon: I borrowed a Linux loaner from the IT folks, and Chrome tests that were failing for me on Mac OS work like a charm in the new environment [21:17:26] chrismcmahon: Will talk to RobLa to see if I can trade my MacBook in for a Linux machine - too much time wasted trying to get things working under MacOS! [21:17:35] JeffHall: that is bizarre. zeljkof is the Mac fan around here, that *should* work [21:18:04] JeffHall: yes, I am always saying to chrismcmahon he should get a "real" machine :) [21:18:12] JeffHall: OIT has a closet full of old Linux laptops, have two [21:18:56] zeljkof: how do i make a jenkins job public? [21:19:04] Yeah, it's weird, I've been using Mac OS for years and never run into anything like this before. But I'd rather spend my time developing tests than trouble-shooting my local environment! [21:19:21] GEOFBOT: I think you have to sign up for cloudbees open source account [21:19:22] zeljkof, what does the tests do? [21:19:34] GEOFBOT: probably too much trouble [21:19:43] mayankmadan_: I did not understand that [21:19:57] mayankmadan_: I am writing the task as I write this :) [21:24:45] zeljkof: that's ok, i can try [21:28:13] mayankmadan_: I have created the task https://www.google-melange.com/gci/task/view/google/gci2013/6466458871660544 [21:28:17] but it is not approved yet [21:28:23] I will ask the admins to approve it [21:28:40] okay dokay [21:30:18] zeljkof, claimed! [21:30:34] mayankmadan_: it is approved already :) [21:30:56] yes and i claimed it too [21:31:23] mayankmadan_: great [21:31:25] yesseth! [21:31:28] first jenkins fail [21:31:59] mayankmadan_, GEOFBOT: I will go to sleep soon, if you have any questions, ask now, or in the bug reports, or at QA mailing list [21:31:59] zeljkof, is it possible that we start working on this tomorrow? its 3:00AM here and i am feeling sleepy [21:32:03] zeljkof: can you view the job yet? [21:32:04] https://geofbot.ci.cloudbees.com/view/All/job/test/ [21:32:15] mayankmadan_: get some sleep! now! :) [21:32:33] mayankmadan_: you have 5 days, there is no rush [21:32:36] GEOFBOT: let me see [21:32:47] good night everybody [21:32:56] zeljkof, thanks for you cooperation :) [21:33:09] mayankmadan_: good night [21:34:49] zeljkof: can you view the jenkins job pages [21:34:51] https://geofbot.ci.cloudbees.com/view/All/job/test/ [21:35:19] GEOFBOT: no, but you can create an account for me there [21:35:39] use this e-mail zfilipin@wikimedia.org [21:35:50] so I will be able to log in [21:39:07] zeljkof likes spam :-) [21:39:37] chrismcmahon: gmail has solved spam problem :) [21:40:20] chrismcmahon: to quote John C. Dvorak: "I get NO SPAM!" [21:40:31] heh [21:41:00] i nthink you're added now [21:48:20] GEOFBOT: let me see... [21:48:43] GEOFBOT: for future reference, you have to mention my nick if you want me to see the message [21:48:54] I usually do not have IRC client visible [21:48:59] sorry [21:49:00] ok [21:49:04] I take a look when it pings me [21:49:28] GEOFBOT: no problem, but if you do not mention me, you might wait a long time for an answer :) [21:52:45] GEOFBOT: I am in! :) [21:53:06] hey zeljkof, i'm Leo who claimed the gci task [21:53:25] NameLess-exe: hi Leo and welcome! :) [21:53:50] GEOFBOT: feel free to add me to e-mail notifications, so I can see how they look like [21:53:55] zeljkof: ok [21:53:58] thanks. [21:54:01] zeljkof: i triede adding the changes first [21:54:01] NameLess-exe: do you have any questions? [21:54:12] not yet ;), i'm make a start on the project now, just woke up... [21:54:15] GEOFBOT: I forgot, did you have a question? [21:54:23] zeljkof: not yet... [21:54:35] NameLess-exe: it is 11pm here, I will probably go to bed soon :) [21:54:53] GEOFBOT, NameLess-exe: feel free to ask questions here, but I might be sleeping [21:54:54] yeah, we're 12 hours apart atm [21:55:11] also you can ask at the bugzilla bug, and at QA mailing list [21:55:23] ok, cool [21:55:25] NameLess-exe: where are you? (I am in Croatia) [21:55:31] new zealand [21:55:44] utc+13 [21:55:52] NameLess-exe: wow, that is probably as far from me as possible :) [21:56:07] yeah [21:56:14] zeljkof: one last question, how do you set custom messages [21:56:22] zeljkof: like, with html and what not [21:56:46] GEOFBOT: well, that is the task that you have to figure out :) [21:56:51] GEOFBOT: I really do not know [21:57:07] but there is a jenkins plugin (link is in bugzilla bug) that you should install [21:57:20] and it will probably give you options on how to format e-mail notifications [22:03:29] Yippee, build fixed! [22:03:30] Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #29: FIXED in 35 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/29/ [22:06:40] zeljkof: looks like the easiest way [22:06:51] is to get jenkins to generate an html report [22:06:54] when building [22:07:00] and then use that report [22:07:01] GEOFBOT: go for it! :) [22:07:02] as an emai [22:07:08] http://stackoverflow.com/questions/16315604/how-to-include-content-of-the-html-file-to-template-of-the-jenkins-email-ext [22:11:05] JeffHall: have you met Tomasz Finc yet? [22:11:19] chrismcmahon: Yes, I have [22:11:29] chrismcmahon: did you create a mediawiki user for mobile? [22:11:42] chrismcmahon: I have just found that task in my todo list :( [22:12:27] chrismcmahon: No, have not created a mediawiki user for mobile. Have not heard of that task before [22:12:31] zeljkof: I did not. I actually set the Selenium_newuser password to the same as Selenium_user. That solves the problem for the Mobile tests. I think you can WONTFIX the issue. [22:13:30] JeffHall: that is something chrismcmahon and I talked about last week [22:13:46] chrismcmahon: it is not in bugzilla yet, just my todo list, I will delete it then [22:15:23] JeffHall: if you have a chance to chat with Tomasz maybe today, the Mobile folks are looking for a bit of help doing e.g. post-deploy validation, you and ryasmeen would be in a good position to help out if you don't mind. [22:16:36] chrismcmahon: I think Tomasz left about 15 mins ago for the holiday break, but I can talk to him when he's back on the scene [22:17:23] JeffHall: ah, too bad. I just got an email from him about it. Later I suppose. [22:33:04] chrismcmahon: I will be happy to do that,I am working from hone today.I will communicate with him when he is online today [22:40:54] zeljkof: i tried using email-ext's default script to generate an html report [22:40:56] did you get it? [22:41:31] GEOFBOT: let me check [22:43:59] GEOFBOT: the last e-mail I got from your jenkins was 33 minutes ago [22:44:07] and it did not look nice :) [22:44:20] hmmm [22:44:33] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #168: FAILURE in 39 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/168/ [22:45:38] zeljkof: sending another one [22:45:51] GEOFBOT: did you get the e-mail? [22:46:08] yes [22:51:05] GEOFBOT: I got the e-mail! :) [22:51:13] it is way nicer that in used to be [22:51:37] but check the bug page, a few people have left comments on how to e-mail notification should look like [22:51:47] let me know if you have questions [23:02:49] zeljkof: that is teh default script for email-ext plugin [23:02:51] we can modify it [23:02:54] to our own ideas [23:03:10] looks good for the first iteration [23:32:01] Yippee, build fixed! [23:32:02] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-10 build #5: FIXED in 3 min 29 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-10/5/ [23:35:11] Yippee, build fixed! [23:35:12] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-9 build #4: FIXED in 3 min 10 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-9/4/ [23:52:15] good night everybody