[01:50:06] good evening [03:09:58] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #320: FAILURE in 4 min 14 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/320/ [03:10:11] Yippee, build fixed! [03:10:11] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #431: FIXED in 4 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/431/ [04:48:42] Yippee, build fixed! [04:48:43] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #308: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/308/ [05:39:30] Yippee, build fixed! [05:39:30] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-8 build #7: FIXED in 2 min 47 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-8/7/ [06:38:13] Yippee, build fixed! [06:38:13] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #158: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/158/ [08:02:31] Hi zeljkof [08:19:57] hi zeljkof [08:20:07] hi mayankmadan_ [08:20:58] zeljkof, did you have a look at the mail that i sent you? [08:21:27] mayankmadan: I saw it but did not have the time to read it yet [08:21:44] is there a reason you did not send it to qa list? [08:22:04] I am not the only one that can help you, there are more people at qa list [08:22:29] so could you please send it to qa list, and I will reply there [08:22:32] deal? [08:22:34] okey dokey [08:22:54] deal [08:23:47] zeljkof, do you have some time now? [08:24:07] mayankmadan: I am free all day [08:24:18] I have stuff to do, but if you need help, I can help you [08:24:45] i was having problems running rubymine [08:24:49] can you help me with that? [08:24:58] sure [08:25:02] what is the problem [08:26:32] zeljkof, i have pasted the error on etherpad [08:26:40] http://etherpad.wikimedia.org/p/mayankmadan [08:29:50] hm [08:30:23] it said No valid license found [08:30:33] but you should not need a license for the first 30 days [08:30:46] exactly [08:30:54] I have ubuntu virtual machine, I will try it there and let you know [08:31:11] in the meantime, you can use this editor, if you do not already have a favorite one [08:31:39] http://www.sublimetext.com/3 [08:31:50] i am already using sublimetext 2 [08:31:52] :) [08:32:00] why not 3? :) [08:32:18] i dont know :) i downloaded it quite a while back [08:32:44] and btw i wrote a test that would go on a random page and convert the file to pdf and then download it :) [08:32:50] could you also please send e-mail to qa mailing list about rubymine not working, and please include the error message? [08:32:58] great [08:33:11] I need a few minutes to scan my mail to find your e-mail [08:34:01] i now think that i know how tests works. the pages folder contains all the possible pages and their elements which could be used in the tests right? [08:34:46] mayankmadan: yes [08:34:56] great [08:46:15] mayankmadan: sorry, I have forgot I have a meeting at 10 [08:46:21] I have to go now [08:46:26] I should be back in an hour or so [08:46:49] okay [10:27:39] (PS1) Hashar: basic layout for labs [integration/zuul-config] (labs) - https://gerrit.wikimedia.org/r/98157 [10:27:47] (CR) jenkins-bot: [V: -1] basic layout for labs [integration/zuul-config] (labs) - https://gerrit.wikimedia.org/r/98157 (owner: Hashar) [10:28:50] (CR) Hashar: [C: 2 V: 2] basic layout for labs [integration/zuul-config] (labs) - https://gerrit.wikimedia.org/r/98157 (owner: Hashar) [11:26:14] zeljkof: welcome back [11:26:22] mayankmadan: hi [11:26:47] lets get the task finished if you have time [11:27:10] mayankmadan: let's go! :) [11:27:33] did you get a chance to test out that script that i sent? [11:27:41] it was working fine for me [11:27:52] but in case there are any changes that you want? [11:28:27] mayankmadan: sorry, I was offline [11:28:36] can you push the code to gerrit? [11:29:14] but is that whats needed? [11:29:28] we comment all code at gerrit [11:29:30] a sscript that would go to a random page and download pdf for that page? [11:29:41] zeljkof, ^ [11:29:44] you can always update the commit at gerrit [11:29:54] the first step is to push it to gerrit [11:30:07] should it be in a new file or in pdf.feature? [11:30:22] mayankmadan: let me see the pdf.feature file... [11:31:04] yes, it should probably go to pdf.feature file [11:31:21] then let me edit the code [11:31:26] and steps to pdf_steps.rb [11:31:50] you can even push the current code to gerrit, and then edit the comit [11:43:47] mayankmadan: if you have pushed the commit to gerrit, remember to add me as a reviewer [11:43:55] almost done [11:44:03] otherwise it does not show on my dashboard [11:44:08] no rush, just a reminder [11:46:04] zeljkof, how do i remove outstanding commits? [11:46:25] I do not know what you mean [11:46:40] it shows this as outstanding commit. 986b4c3 Prefer double-quoted strings in Ruby code [11:46:46] if i type yes [11:46:49] can you show me the git log? [11:46:58] or the git review output (to the pad) [11:47:40] zeljkof, posted [11:47:42] http://etherpad.wikimedia.org/p/mayankmadan [11:47:58] the first part is the error from rubymine [11:48:03] then there is git log [11:49:00] you can delete rubymine output, since it is at dpaste site [11:49:16] i do not see the error message [11:49:17] zeljkof, ill do [11:50:48] (PS1) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [11:50:54] zeljkof, nevermind [11:51:13] i ran git reset HEAD^ twice [11:51:26] then ran git stash and then used git review [11:54:09] zeljkof, done, added you to the reviewer list [11:55:52] mayankmadan: ok, looking [11:58:27] mayankmadan: while you are waiting, could you please work on this? https://gerrit.wikimedia.org/r/#/c/97842/ [11:58:38] Tobi asked if you can make one final change [11:58:47] and I think that is the last one for the previous task [11:59:30] not related, people at QA list are suggesting changes that you should make to the wiki page that you have created [11:59:55] feel free to improve the page according to suggestions, but as far as I am concerned you do not have to [12:00:14] your task was to move the date to the separate page and you have completed the task [12:00:29] further improvements are welcome, but completely optional [12:00:31] i will try my best to improve the information on that page [12:00:43] did you see the suggestions at qa list? [12:00:47] no [12:01:05] and do keep in mind, working on the page is welcome, but optional, you have finished the task [12:01:17] do you receive e-mail notifications from the list? [12:01:31] yes i do [12:02:18] if you search for "GCI Task" at this page http://lists.wikimedia.org/pipermail/qa/2013-November/thread.html [12:02:30] you will find your post and all replies [12:03:21] i think this is the last post in the thread [12:03:21] http://lists.wikimedia.org/pipermail/qa/2013-November/000770.html [12:04:29] just saw them [12:05:23] ok, back to the current task [12:05:44] there is a small whitespace fix you should do [12:06:28] (CR) Zfilipin: [C: -1] "Please fix whitespace." (3 comments) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [12:06:40] I have added comments [12:07:02] let me know when you are done with https://gerrit.wikimedia.org/r/#/c/98160/ and https://gerrit.wikimedia.org/r/#/c/97842/ [12:10:54] im first fixing the problems with older patches [12:11:43] mayankmadan: great [12:20:17] (PS2) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [12:20:19] zeljkof, both done [12:20:37] great, looking... [12:20:52] (I was working on testing rubymine on linux, will know if that works soon) [12:27:25] mayankmadan: unfortunately, the last change you made to 97842 now breaks something, you will have to make another change [12:28:32] zeljkof, how? [12:28:40] I am just making the comment [12:31:20] how is 98160? [12:32:33] done with 97842, let's see the other one [12:32:59] mayankmadan: and by the way, do not feel discouraged with all -1 reviews [12:33:04] you are doing a good job [12:33:28] but since you are new, every commit needs a few iterations before it is ready to be merged into master branch [12:34:28] okay [12:37:14] zeljkof, fixed 97842 [12:37:45] I do not see the new commit [12:38:59] now? [12:41:10] I can see it [12:43:00] +1 from me :) [12:43:05] yeah [12:43:20] will review pdf commit now [12:43:30] okay [12:43:56] hm, gerrit is not working for me at the moment [12:43:58] just a minute [12:48:17] ok [12:48:25] so, you have made a few mistakes [12:48:30] let me find some docs [12:48:50] please read this [12:48:51] https://github.com/cucumber/cucumber/wiki/Given-When-Then [12:48:56] let me know when you are done [12:49:02] I will have a few questions [12:54:02] zeljkof, i have read it and i have made some changes in the file [12:56:21] great, will take a look [12:56:21] for future reference, when ever possilbe, I will not let you know what to do [12:56:37] I will ask try to let you figure out what needs to be done [12:56:46] but if you ever get stuck on something, let me know [12:57:05] (PS3) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [12:57:19] sometimes the challenge can be too hard for the moment [12:57:32] zeljkof, okay will keep that in mind [13:01:20] ok, improvement [13:01:25] but still a way to go :) [13:01:42] is your internet better now? can we try screen sharing? [13:01:46] or audio? [13:02:10] or we could pair in the etherpad [13:02:32] do you have the time to pair on this test now? [13:02:35] yes we can [13:02:41] using hangouts right? [13:02:53] yes, hangout is good [13:03:01] I will create the event and invite you [13:03:07] thanks [13:05:07] you should get the invitation via gmail [13:05:39] let me know if you can not join the hangout [13:38:01] (CR) Zfilipin: [C: -1] Added a test for downloading pdf from a random page (3 comments) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [14:17:55] hello zeljkof [14:18:15] i couldn't figure out how to upload custom scripts to jenkins on cloudbees [14:18:19] so i set up my own instance [14:18:27] and also set up a mail server on that computer [14:18:30] to send notifications [14:18:36] but for some reason all the emails are garbled [14:18:52] the html is being interpreted as plaintext or something [14:21:25] GEOFBOT: just a minute, I am in a meeting with mayankmadan [14:32:42] zeljkof, ill be back in about 2 hrs [14:32:58] GEOFBOT: I am here now [14:33:25] hai [14:33:31] GEOFBOT: I have noticed that I am receiving strange e-mail messages :) [14:33:42] for some reason the email thing-a-ma-jig interprets html as being plaintext [14:33:46] and a load of crap comes up [14:33:54] what you needed to upload to cloudbees? [14:34:06] what kind of custom script? a plugin? [14:34:13] i was trying to find a way to upload custom jelly scripts for email-ext to cloudbees [14:34:19] but i couldn't find a way [14:34:31] so i decided to make my own jenkins instance [14:34:36] on a local machine [14:34:40] GEOFBOT: ok, I have no clue what you are talking about :) [14:34:55] I am not famililiar with email-ext [14:35:23] i think the problem is my jenkins is not configed right [14:35:27] so it sends html as plaintext [14:35:38] it is hard to debug that [14:35:49] could you try setting it up at cloudbees? [14:36:02] that way both of us can log in and see what is going on [14:36:22] is there any way to upload things to cloudbees [14:36:29] yes [14:36:34] but what you need? [14:36:51] did you post cloudbees url to the bug report? [14:36:55] not yet [14:37:00] please do [14:37:05] I will log in and take a look [14:40:09] zeljkof: done [14:40:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=55824 [14:41:39] a possible solution? [14:41:40] http://stackoverflow.com/questions/11332956/how-can-i-write-a-jenkins-email-ext-template-to-display-test-results-like-the-st [14:41:57] GEOFBOT: looking.... [14:48:01] ok, I am looking at plugin documentation, it says the plugin can change notification subject and body [14:48:07] let's try something simple [14:48:18] did you manage to change the subject? [14:51:04] GEOFBOT: ^ [14:55:14] hmmm [14:55:16] lemme try [15:02:12] zeljkof: RUN GOOO GET TO DA EMAIL [15:02:13] jk [15:02:19] yes, i got the subject to change [15:02:52] ok [15:02:56] step one done [15:03:04] did you manage to change anything in the body? [15:03:29] not yet [15:03:42] i don't know how to edit a jelly script [15:03:51] what is a jelly script? :) [15:04:04] where did you change the subject? [15:04:07] can you send me the link? [15:04:42] https://geofbot.ci.cloudbees.com/job/test/configure [15:04:48] if you scroll all the way down [15:05:03] there is a place where you can edit the subject for custom email notfis [15:05:58] ok [15:06:05] but the body needs to be changed by the script [15:07:57] but where is the script located? [15:08:33] according to the documentation [15:08:37] it is located at $JENKINS_HOME\email-templates [15:08:43] how would i access that folder [15:08:54] zeljkof: ^ [15:09:04] GEOFBOT: let me see [15:09:35] this page says [15:09:36] https://geofbot.ci.cloudbees.com/configure [15:09:42] Home directory /home/geofbot/hudson_home [15:14:05] is there a way to ftp there? [15:14:25] zeljkof: so i could upload a custom script [15:15:14] there is a way to upload files [15:15:19] but not sure about ftp [15:15:33] you can contact their support asking how to do it [15:16:59] zeljkof: how do you upload files [15:17:07] I do not :) [15:17:09] take a look at this [15:17:10] https://geofbot.ci.cloudbees.com/job/mail/2/console [15:17:15] I have to go now, will be back soon [15:17:18] * zeljkof is out to lunch [15:17:38] bai [15:40:02] zeljkof, im back [15:40:13] mayankmadan, GEOFBOT: I am back too :) [15:40:31] mayankmadan: 97842 is merged into master! :) [15:40:51] yipee [15:40:59] mayankmadan: push pdf test to gerrit too [15:42:30] (PS4) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [15:42:33] just did [15:42:34] hashar: let me know if you can pair today [15:42:41] mayankmadan: great, let me take a look [15:42:46] zeljkof: oh man sorry :/ [15:42:59] zeljkof: eventually got swamped with Zuul / Jenkins on labs :( [15:43:01] hashar: no problem, we can pair next week if today is too late [15:43:09] lost the last 2 hours or so figuring out some ssh connection issue [15:43:21] zeljkof: monday morning ? [15:43:26] will be at home so we can video [15:44:03] I have meeting 10-12 [15:44:07] 12:30? [15:44:17] or 9-10? [15:44:38] 12:30 is no good, another meeting :( [15:45:00] hashar: 12:30 or tuesday, or 14:00 on monday [15:45:04] or 9-10 any day next week [15:46:04] zeljkof: 9:30 on tuesday ? [15:46:31] hashar: I have 10-12 meetings with language team monday-thursday [15:46:42] I can pair until 10, then I have to go [15:47:02] so we can pair 9:30-10:00 every day next week, as far as I am concerned :) [15:48:58] zeljkof, im a lil confused. how do i further proceed? any hints [15:49:05] (CR) Zfilipin: [C: 1] Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [15:49:20] mayankmadan: +1 for 98160! :) [15:49:28] thank you [15:50:21] now, the next step is to write a test that will create a page with just some text and see if the text appears in the pdf [15:50:38] can you write just the cucumber file and push it to gerrit? [15:50:55] when that is done I will let you know how to proceed [15:52:39] zeljkof: not sure half hour is enough though [15:52:58] hashar: but 30 minutes every day... :) [15:53:05] we can get something done in 30 minutes [15:53:20] and then have the rest of the day to finish what we have started [15:53:48] GEOFBOT: ping me when you get back [15:54:25] zeljkof: I can't really spend that much time on browser tests though :D [15:54:40] 30 minutes a day, or the rest of the day? :) [15:55:00] both :] [15:55:19] we can pair 1-2-3 days for 30 minutes, it does not have to be every day [15:55:44] zeljkof, what is aftv5_page? [15:55:57] mayankmadan: a page :) [15:56:09] what do you want to know? [15:56:18] what is aftv5? [15:56:26] aftv5 stands for article feedback tool version 5 [15:56:41] a feature [15:56:44] like pdf export [15:56:45] or login [15:59:55] zeljkof, what does step do in ruby? [16:00:55] "step" is a cucumber term [16:01:00] in ruby it is ruby file [16:01:30] every "given/when/then/and" line in feature file is a step [16:01:59] when cucumber executes a step, it finds the ruby code in step file and executes it [16:02:07] does that answer the question? [16:06:40] yep [16:10:51] zeljkof, can i use a scenario in step? [16:11:10] mayankmadan: what do you mean? [16:11:19] nothing [16:11:21] can you call all steps from a scenario in a step file? [16:12:09] exactly [16:12:29] no, buy you can call all steps from a scenario [16:12:33] go to the pad [16:12:41] http://etherpad.wikimedia.org/p/mayankmadan [16:15:10] if for example, from line 27 you want to call steps 8 and 9 [16:15:58] you can do it like lines 28 and 29 [16:16:12] clear? [16:16:28] you can not call a scenario, but you can call it's steps [16:16:40] and if you need to call the same steps over and over [16:16:59] now you can call 'I call the entire "Check for Download as PDF link" scenario' step from another step [16:17:02] makes sense? [16:19:03] kinda does [16:19:13] what is confusing you? [16:19:20] it is like calling functions/methods [16:19:30] you can not call a class, but you can call a method [16:20:13] zeljkof, what was the environment variable that sets test2 as mediawiki url? [16:20:34] export MEDIAWIKI_URL=http://test2.wikipedia.org/wiki/ [16:21:16] zeljkof, i got it what you were saying about calling all steps from scenario. that same thing was in my mind too :) [16:21:38] great :) [16:23:51] mayankmadan: I have just tested firefox [16:24:04] and pdf file that it downloads gets rendered as html page! :) [16:24:10] that makes your job way easier [16:24:16] will test with chrome now [16:24:31] zeljkof, i have made the script that will create a page with some text and download it as pdf [16:24:41] great, push to gerrit [16:27:38] zeljkof, actually i havent :) there is a problem im trying to figure out [16:27:55] mayankmadan: just write the feature file and push it [16:28:09] when we agree on the feature file we will proceed to the next step [16:32:03] (PS5) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [16:32:03] zeljkof, pushed [16:35:09] (CR) Zfilipin: [C: -1] Added a test for downloading pdf from a random page (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [16:35:13] added a comment [16:36:17] wait, one more comment [16:36:34] (CR) Zfilipin: Added a test for downloading pdf from a random page (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [16:36:49] there is no "then" steps? [16:36:54] where do you check the file? [16:37:04] then step will eventually be there [16:37:26] i dont think you can create a page without logging in :) [16:37:47] mayankmadan: you can, try [16:38:08] you have to write the feature file first [16:38:16] when you are done with it, then continue with the implementation [16:38:35] why didn't you write the entire feature file first? [16:38:50] you were working on implementation of steps? [16:38:55] because i wanted to try what i have written [16:39:00] no no :) [16:39:05] write the feature file first [16:39:07] then run it [16:39:24] copy/paste the steps that cucumber suggested to steps file [16:39:30] and then implement the steps one by one [16:49:53] (PS6) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [16:50:00] zeljkof, pushed to gerrit [16:50:07] mayankmadan: looking [16:52:36] (CR) Zfilipin: [C: -1] Added a test for downloading pdf from a random page (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [16:52:40] good work [16:53:01] simple change (see comment) and you are ready for implementation [16:53:09] zeljkof, arent the lines setup? [16:53:16] depends [16:53:32] cause page creation is tested in page.feature and i have already tested downloading pdf's [16:53:37] for this scenario it is important that you have a page with some text, right? [16:54:01] but this scenario tests if the text on the page and in the pdf are the same [16:54:26] I think that creating a page, adding text and downloading the file are the actions, not setup [16:54:30] but I could be wrong [16:54:50] if you think they are setup, leave the feature file as is [16:55:07] in pdf.rb i have used http://etherpad.wikimedia.org/p/mayankmadan [16:55:21] for I have created a page [16:55:34] mayankmadan: great [16:55:35] zeljkof, ^ it seems to be working fine [16:55:50] I will have to go soon, when you finish this if you need more to do, create a test that checks page title [16:55:50] but its only valid for test2 [16:56:01] it is important that it works at test2 now [16:56:05] we will think about other sites later [16:56:21] zeljkof, so for this task i just need to test for some simple text on page? [16:56:34] mayankmadan: yes, as simple as you like [16:56:35] im not saying that its easy but just confirming [16:56:39] just "text" is fine [16:56:52] or and other simple word or sentence [16:57:25] Download as pdf element is only in RandomPage class [16:57:33] zeljkof, ^ [16:57:48] mayankmadan: feel free to move/copy it somewhere else if you need to [16:58:01] just make it work now, we will make it beautiful later [16:58:21] move/copy what? [16:58:49] the element you have mentioned [16:59:32] ok [16:59:49]