[03:09:50] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #322: FAILURE in 4 min 21 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/322/ [03:10:03] Yippee, build fixed! [03:10:04] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #433: FIXED in 4 min 24 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/433/ [03:42:44] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #389: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/389/ [03:43:42] Yippee, build fixed! [03:43:43] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #319: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/319/ [04:30:53] good night to whoever is still listening [04:47:53] Yippee, build fixed! [04:47:54] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #310: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/310/ [05:35:48] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-7 build #8: FAILURE in 2 min 47 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-7/8/ [05:38:25] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-8 build #9: FAILURE in 2 min 36 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-8/9/ [05:45:27] Yippee, build fixed! [05:45:27] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #88: FIXED in 2 min 26 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/88/ [06:01:27] Yippee, build fixed! [06:01:28] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #101: FIXED in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/101/ [06:35:32] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #160: FAILURE in 14 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/160/ [09:53:46] (CR) Mayankmadan: Added a test for downloading pdf from a random page (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [09:59:02] can anyone help me with https://gerrit.wikimedia.org/r/98160 [12:41:08] (PS1) Merlijn van Deen: Add Python 3.3 syntax checker [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98275 [14:05:54] (PS8) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [14:14:24] hi GEOFBOT [14:17:24] hai [14:31:22] (CR) Zfilipin: Added a test for downloading pdf from a random page (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [14:37:16] zeljkof: i added a "started by" thing to the email notificaiton [14:42:55] GEOFBOT: great [14:43:07] feel free to attach the email to the bug report [14:43:14] or forward it to me, so I can attach it [14:43:38] a few people are interested in the task you are doing, I would like for them to be able to see the progress [15:02:01] zeljkof: forwarded [15:02:51] hi zeljkof [15:04:22] zeljkof, checkout the latest patchset [15:05:53] zeljkof, online? [15:08:41] zeljkof, sorry i disconnected. i didnt receive any of your messages if you sent any [15:37:00] zeljkof, ? [15:37:28] mayankmadan: sorry, I was logged in on another machine, did you ask anything? [15:38:52] zeljkof, did you have a look at patchset 8 [15:38:59] it is working perfectly [15:39:41] no, sorry, did not have the time [15:39:42] the test passes and i have failed it too by changing the string in DownloadedPDFPage [15:39:55] I am working on a private project today [15:40:11] i can take a look later today, I have to finish something now [15:40:29] did you write the tests for checking title and image? [15:40:48] no :) [15:40:49] I took a quick look earlier today and code for page with text looked good [15:40:51] ok, great [15:41:04] please continue with writing tests for checking title and image [15:41:07] ok [15:41:14] I think when that is done, this task can be closed [15:41:24] zeljkof, at about what time will you be free? any estimate? [15:41:27] and I promise I will take a look at the code later today [15:41:37] in about 3 hours from now [15:41:42] ok [15:41:55] sorry, I work on a private project on Saturdays, [15:42:03] no problem [15:42:04] but I will have some time later today [15:42:17] if the code is good I will close the task and create a new one [15:42:32] will ping you back after 3-3.5 hrs [15:42:40] ok [15:42:50] if there is more work needed to be done, I will leave a comment [15:42:58] anyway, you will have something to do over the weekend [15:52:31] zeljkof, By title do you mean like a title of the page or heading inside a page? [15:52:43] mayankmadan: the title of the page [15:52:50] ok [15:53:00] and yes, optionally, if you create the title inside a page, that could be checked too [15:53:47] zeljkof, just to be clear, these will be 2 tasks right? [15:53:58] mayankmadan: what will be 2 tasks? [15:54:02] pdf tests? [15:54:05] yes [15:54:12] tasks on melange [15:54:20] there can be as many tasks on melange about pdf tests as you like :) [15:54:46] the first task should cover the basics, checking text, title, image, optionally something else [15:54:59] when that is done, we can create more complex pages and check them [15:55:10] more complex pages will be task 2 on melange [15:55:31] when that is done, we can create really complex pages, and check them, (task 3 on melange) [15:55:44] and we can create even more tasks, when you are done [15:55:54] each one covering more and more complex tests [15:56:14] and each task will be made so it takes you a few days (2-3) to complete [15:56:28] so the tasks should not be too simple, but also not too complicated [15:56:30] sounds good? [15:56:50] i thought you will close the task after i have completed the simple text check [15:56:58] yes, I wil [15:57:02] yes, I will [15:57:04] ok [15:57:13] this task is just about having a few basic tests for pdf [15:57:21] okay [15:57:30] title, text, image, I am not sure if the bug says something else [15:57:43] then when this task is closed, I will create a new task and a new bug [15:58:05] the next task could involve more complex pages, or maybe another browser, like chrome or phantomjs [15:58:18] hmm [15:58:25] I have plenty of ideas, if you want to work with us :) [15:58:48] you do have some quick documentation tasks too right? [15:58:55] and I promise that I will do my best to create tasks that will take you about 2-3 days to complete [15:59:08] mayankmadan: there will be documentation tasks too [15:59:19] but not as simple as the first one you had :) [15:59:26] also 2-3 days of work [15:59:41] not of a couple of hours? [15:59:42] but since you are now pretty much familiar with our tools, it could take you even less time [16:00:10] mayankmadan: as far as I understood the rules, the task should be big enough so it takes a few days for student to complete [16:00:17] but maybe I misunderstood the rules [16:00:28] how are you graded, when they decide who wins? [16:00:43] but the number of solved tasks? or by the complexity of the tasks? or both? [16:01:05] I assume you want to close a lot of tasks, but also that tasks should not be trivial, right? [16:01:11] the first 5 students are selected as the grand prize finalists then they see the no of tasks and how much coomplicated were the task [16:01:59] i want to do both to some extent i.e some easy quick tasks and some hard ones which take some time [16:02:03] mayankmadan: ok, we can create a few simple and a few more complex tasks, so you have both the number of tasks and complexity [16:02:11] sounds good? [16:02:15] yep [16:02:17] thanks [16:02:29] I think the first task was too simple, right? just moving text to another page [16:02:35] but it was a good first task [16:02:36] yeah [16:02:50] next documentation task should be at least a few hours of work [16:02:57] nice [16:02:58] but it does not have to be a few days [16:03:27] I promise I will do my best to help you (and every other student) to become a winner [16:03:40] thats nice to hear [16:03:56] and it is completely up to you (and other students) how much time and effort you want to put in [16:04:25] I want to be fair to every student and give everybody the same chance [16:04:39] and I am open to making some tasks easier and some harder [16:04:50] so students can choose which one they prefer [16:24:27] zeljkof, where are the @browser and @random_string variables defined? [16:25:20] I think in env.rb [16:25:30] features/support/env.rb [16:25:31] no they arent [16:25:43] oh no, they are defined in gems [16:25:54] @random string is in mediawiki-selenium gem [16:26:00] and @browser in page-object get [16:26:02] gem [16:26:09] ruby gems are ruby packages [16:26:14] and we use a few of those [16:26:21] some of them define variables that we later use [16:37:41] zeljkof, @random_string is outputting nothing? any help if you are free? [16:37:59] terminal output or it did not happen :) [16:38:05] paste what you have tried to the pad [16:40:53] zeljkof, pasted [16:42:00] sorry i added quotes twice [16:42:08] that was a mistake i just noticed [16:42:20] take a look how I changed line 7 at the pad [16:42:20] but random string still isnt outputting anything [16:42:23] try it like that [16:42:34] i did at first [16:42:41] did not help? [16:42:42] but that doesnt work either [16:42:53] sorry, can not debug that right now [16:43:02] push the code to gerrit [16:43:06] I will take a look later [16:43:09] no problem [16:43:17] if you are stuck here, write feature files for title and image [16:43:28] and push all that to gerrit so I can take a look later [16:43:28] zeljkof, i am writing for title [16:43:32] great [16:43:37] i am writing for title [16:56:44] @random_string works perfectly in page_steps.rb [17:00:34] where it does not work? [17:01:04] i have tried it in irb and it surely doesnt work in DownloadedPDFPage.rb [17:01:08] oh, I see in the page [17:01:10] right [17:01:13] I know how to fix it [17:01:17] and it didnt work in irb as well [17:01:18] take a look at the pad [17:02:54] can you paste to the pad where you call title element? or is it in gerrit? [17:03:28] zeljkof, pasted at the end of the pad [17:03:47] I know how to fix it [17:04:36] take a look at the pad [17:04:43] that should fix the problem [17:04:45] is the @random_string only available to step definitions? [17:04:48] yes [17:04:52] ok [17:04:53] not in the pages [17:05:03] next time give me a hint so i can solve myself :) [17:05:21] sorry, working on something else, did not think :) [17:05:28] no problem [17:05:30] and this would be hard to hint :) [17:05:38] true [17:40:11] zeljkof, ping me when you are absolutely free [17:41:24] mayankmadan: sorry, I have to go in a minute [17:41:37] will you be back today? [17:42:15] zeljkof, ^ [17:43:22] yes, in 3 hours or so [17:43:46] ok ill ping you then if im online [17:44:25] ok [17:44:33] if you have questions, upload code to gerrit [17:44:39] and leave comments where you have questions [17:44:46] okay [17:44:53] remember to paste terminal output [17:45:01] either to comments or to the pad [17:46:13] (PS9) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [17:47:43] (CR) Mayankmadan: Added a test for downloading pdf from a random page (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [18:09:39] Yippee, build fixed! [18:09:39] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #323: FIXED in 4 min 17 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/323/ [18:13:40] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #434: FAILURE in 4 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/434/ [18:42:11] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #320: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/320/ [18:54:23] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #390: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/390/ [19:34:07] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #311: FAILURE in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/311/ [19:41:12] zeljkof, free? [20:13:46] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #592: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/592/ [20:23:20] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-9 build #10: FAILURE in 2 min 13 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-9/10/ [20:24:46] zeljkof, online? [20:27:29] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #89: FAILURE in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/89/ [20:34:29] mayankmadan: I am back [20:35:08] great [20:35:35] zeljkof, did you have a look at the patch? [20:36:33] mayankmadan: not yet, just got online [20:36:44] mayankmadan: will do now [20:45:42] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #102: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/102/ [20:51:59] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #195: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/195/ [20:54:32] zeljkof, still online? [20:54:42] mayankmadan: yes, reviewing coce [20:54:44] code [20:54:51] will post my comments in a minute [21:14:54] mayankmadan: ok, solved the problem [21:15:00] posting comment now [21:15:45] great [21:17:01] (CR) Zfilipin: [C: -1] Added a test for downloading pdf from a random page (4 comments) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [21:18:00] zeljkof, why does it work the other way? [21:18:08] mayankmadan: long story :) [21:18:20] do not have enough time now to go into detail [21:18:31] we should have a pairing session on monday [21:18:39] yep that would be great [21:18:40] here in via hangout [21:18:46] great [21:18:50] here _or_ via hangout [21:18:59] have to go back to the other project I am working on [21:19:02] hangout is better [21:19:07] will you close the task today? [21:19:26] if you write the remaining tests :) [21:19:37] wasn't there another test or two that needed to be done? [21:19:42] remaining meaning the image test? [21:20:37] yes, I was just looking at the bug [21:20:46] add test for cheching the image, and the task is done [21:21:13] and if you like this pdf tests, I can create a new task for more tests [21:21:26] if you would like to move to docs or another tests, let me know [21:21:35] first some quick documentation ones [21:23:02] morning [21:23:22] zeljkof, still getting the same error [21:23:39] Nikerabbit: morning? :) [21:23:59] mayankmadan: please update the patch set and paste terminal output [21:25:04] Yippee, build fixed! [21:25:05] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #161: FIXED in 13 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/161/ [21:25:21] zeljkof, posted the error to pad [21:26:12] mayankmadan: please also update the commit, so I can see if you made all required changes [21:26:43] (PS10) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [21:26:47] updated [21:27:41] mayankmadan: and the error is not the same, it is different now :) [21:28:18] zeljkof, its still unable to locate the element [21:28:35] mayankmadan: yes, but the error is different :) details matter [21:28:39] looking [21:32:15] mayankmadan_, mayankmadan: stupid me :) [21:32:24] posting how to fix the problem [21:32:50] btw i figured out why you used textlayer class [21:33:00] just used inspect element on the title in pdf [21:33:23] mayankmadan: great [21:33:27] and now I have a puzzle :) [21:33:39] you know enough to figure out why the test is failing :) [21:33:51] but since it is late for you, I will give you a hint [21:34:02] you have to wait for an element to appear [21:34:06] do you know what to do? :) [21:34:09] yep [21:34:22] ok, let me know if you get stuck [21:37:36] zeljkof, didnt i need to add when_present? [21:37:58] yes [21:38:01] do you know where? [21:38:42] when im checking for text inside title_element? [21:39:38] zeljkof, ^ [21:39:47] yes [21:39:50] try it [21:39:54] that didnt work [21:40:32] wait [21:41:35] zeljkof, it worked :) i forgot to save the file first [21:41:47] saving the file is your friend! :) [21:42:42] zeljkof, i have committed that [21:42:46] (PS11) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [21:43:18] zeljkof, any hints on how to post an image with test script? [21:44:00] take a look if we already have a test for creating images [21:44:11] already did. you dont [21:44:16] *we dont :) [21:45:20] zeljkof, ^ [21:45:35] then you will have to create one [21:45:50] isnt that too much for 1 task :) [21:46:10] it should be as easy as adding a string to a page [21:46:19] find a page with an image [21:46:21] really? how? [21:46:31] on mediawiki.org or any wikipedia [21:46:42] click "edit source" and find how the image is added [21:47:11] and when you create the page, instead of adding a string to the page, just add the string that embeds the image [21:47:14] got it? [21:47:20] yep [21:47:36] great [21:47:42] I will be online for 1 more hour [21:47:46] ping me if you get stuck [21:52:21] zeljkof, the image should be on test2 server right? [21:52:36] mayankmadan: the image can be anywhere [21:52:49] just find an article on test2 with an image [21:52:54] that is the easiest way [21:53:02] or google for how to add image to mediawiki article [21:59:41] zeljkof, converting a page with image is going to take a lot of time [21:59:53] even with a small image? [22:00:16] no the browser was stuck [22:00:39] try another time [22:00:43] or with another image [22:00:47] it worked [22:02:14] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #174: FAILURE in 40 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/174/ [22:02:37] mayankmadan: see, it was easier that you thought :) [22:02:46] yep [22:03:23] hi zeljkof [22:03:31] GEOFBOT: hi [22:03:41] so my target [22:03:46] is to imitate the jenkins job page? [22:04:16] like https://wmf.ci.cloudbees.com/view/r-ve/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/164/ [22:04:57] zeljkof, if i am using the same image every time, i can use its url in the page file right? [22:05:01] GEOFBOT: yes, the e-mail should looks similar to that [22:05:21] mayankmadan: yes, for now you can hard code the url [22:05:34] do i need to include the git revision id [22:05:34] zeljkof, what is hard code? [22:05:39] mayankmadan: :) [22:06:00] what? :) [22:06:16] mayankmadan: for example, having an url to an image in code [22:06:29] usually things like that are a sign of bad code [22:06:38] google it :) [22:08:47] zeljkof, i committed it [22:08:52] (PS12) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [22:09:00] the latest patchset checks everything [22:09:08] mayankmadan: let me see [22:09:47] zeljkof, if its ok then the task is done, right? [22:10:00] mayankmadan: yes [22:10:12] I have a few small things you should change [22:10:22] but a few minutes of work [22:10:25] okay [22:12:10] zeljkof: groovy is a strange language [22:12:17] esp. embedded in html 0_o [22:12:38] GEOFBOT: I have no clue about groovy :) [22:13:02] I'm hacking together bits and pieces from other code to get it to work [22:13:15] copy-paste programming = bad [22:13:28] once i got a newsletter from a programming site [22:13:34] condemning copy-paste programming [22:13:37] i felt guilty :( [22:13:41] lol [22:14:34] (CR) Zfilipin: [C: -1] Added a test for downloading pdf from a random page (4 comments) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [22:15:03] GEOFBOT: just make it work, we will make it beautiful later :) [22:15:22] mayankmadan: posted my comments, you have done a good job! :) [22:15:27] zeljkof, its an a tag instead of img tag [22:15:32] zeljkof: a way to fetch git commit id [22:15:32] cause its a link to the file [22:15:43] https://groups.google.com/forum/#!topic/jenkinsci-users/2gDOsMoFhvc [22:15:48] mayankmadan: the image is not in the pdf? [22:15:52] or in the page? [22:16:04] GEOFBOT: I did not understand the question [22:16:25] zeljkof: i was showing you a link i found [22:16:27] zeljkof, it is there(both), mediawiki adds image this way only [22:16:31] that described a way to fetch the git commit id [22:16:39] so i can make it closer to the actual webpage [22:16:46] GEOFBOT: oh, great, sorry, I am doing something completely different now [22:16:55] lol ok [22:17:02] zeljkof, i used this [[Image:Glucose.PNG|200px|thumb|right|This is a sugar molecule. Carbon atoms are made blue, oxygen atoms are made red and hydrogen atoms are made white to show the difference. In reality atoms do not have a color.]] [22:17:20] mayankmadan: can you send me link to the page with the image, so I could take a look? [22:17:39] mayankmadan: if there is a problem with images, we can check for a link, that is also an options [22:17:41] option [22:17:44] it shows a thumbnail of the image and zeljkof https://test2.wikipedia.org/wiki/Molecule [22:19:36] zeljkof: i might have to unclaim the task for now, been very busy recently :( [22:19:49] zeljkof, done [22:19:55] now it should be good to go [22:20:07] NameLess-exe: no problem, come back when you have the time [22:20:14] yeah, cool [22:20:23] Random question: Which is better, nano, vi, or emacs? [22:20:50] GEOFBOT: that is like asking which religion is better :) [22:21:05] mayankmadan: what is done? :) sorry, too many threads [22:21:24] lol [22:21:28] i am a newb, so i use nano [22:21:35] because it is more beginner-friendly [22:21:45] all the controls conveniently at the bottom [22:22:01] (PS13) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [22:22:10] zeljkof, the pdf test patch is updated [22:22:19] zeljkof, i think it should be good to go [22:22:46] mayankmadan: let me see [22:23:04] GEOFBOT: when I am in terminal, I use nano too :) [22:23:22] but I prefer gui, so I use sublime text 3 or rubymine when there [22:32:36] (CR) Zfilipin: [C: -1] "$ bundle exec cucumber features/pdf.feature" [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [22:32:45] mayankmadan: you have made a small mistake [22:34:05] zeljkof, now its definitely done [22:34:09] (PS14) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [22:34:15] mayankmadan: let's see :) [22:40:15] (CR) Zfilipin: [C: -1] "$ bundle exec cucumber features/pdf.feature" [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [22:40:30] mayankmadan: the test fails for me [22:40:34] tried it two times [22:41:51] zeljkof, passes for me [22:42:12] zeljkof: do i need to include the "Started 4 days 4 hr ago Took 26 min on psuedonode" part? [22:44:23] (PS15) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [22:44:24] zeljkof, how about now? [22:44:39] zeljkof, i have increased the timeout time to 30 seconds [22:46:02] mayankmadan: let me try [22:46:26] GEOFBOT: I think it is important to say which test failed [22:46:32] everything else is optional [22:50:35] mayankmadan: still fails for me, debugging [22:50:46] zeljkof, damn [22:50:48] anyway, I will close the task today, you have done a good you [22:50:51] job [22:51:02] thank you very very much :) [22:51:20] we can fix the failure next week, I want you to be able to work on the next task over the weekend :) [22:51:35] zeljkof, thanks [22:51:46] zeljkof, are you gonna create it now? [22:53:45]