[00:40:10] (CR) Addshore: [C: -1] Remove now incomplete dependency lists for some projects (2 comments) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97065 (owner: Jeroen De Dauw) [03:09:42] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #326: FAILURE in 4 min 19 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/326/ [04:40:50] Yippee, build fixed! [04:40:50] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #571: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/571/ [05:01:59] Yippee, build fixed! [05:01:59] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #575: FIXED in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/575/ [05:06:11] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #595: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/595/ [05:20:01] Yippee, build fixed! [05:20:02] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #92: FIXED in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/92/ [06:24:40] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #164: FAILURE in 19 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/164/ [06:32:04] (PS3) Jeroen De Dauw: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97065 [06:32:10] (CR) Jeroen De Dauw: Remove now incomplete dependency lists for some projects (1 comment) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97065 (owner: Jeroen De Dauw) [07:00:44] Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome build #177: FAILURE in 42 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/177/ [07:56:17] hi zeljkof [08:11:53] mayankmadan_: good morning! :) (or afternoon) [08:12:21] morning for you afternoon for me [08:13:01] zeljkof, in the bug report for this task http://www.google-melange.com/gci/task/view/google/gci2013/5851412575551488 [08:13:05] are you on a winter break or something? or do you go to school? [08:13:29] zeljkof, winter breaks will start soon but i have exams from 6th [08:13:43] so preparatory holidays [08:14:23] mayankmadan_: did you finish the task? [08:15:14] zeljkof, in the bug report you have given an example from visual_editor_steps.rb which is no longer in the repo [08:15:28] so i replaced that example with an example from login_steps.rb [08:15:34] rest is i guess complete [08:15:43] mayankmadan_: I think Jeff created the task, let me see [08:16:00] mayankmadan_: great, I will take a look now [08:16:10] do you see anything that you would like to work on next on the list? [08:17:37] let me see [08:18:14] zeljkof, any info on this task http://www.google-melange.com/gci/task/view/google/gci2013/5854732451053568 [08:19:01] mayankmadan_: what do you want to know about that? [08:19:18] http headers? [08:19:27] do you know what that is? [08:20:10] zeljkof, not exactly [08:20:43] good morning [08:20:51] hashar: morning! :) [08:21:13] zeljkof, did you get my message? [08:21:20] zeljkof: ended up a bit sick thursday sorry [08:21:26] mayankmadan_: which one? [08:21:32] hashar: no problem [08:21:34] zeljkof, not exactly [08:21:40] zeljkof: and friday was mostly quiet hacking. Wanna video call this morning ? [08:21:43] let me know if you would like to pair this week [08:21:47] else i will commute to mycoworking place [08:21:57] hashar: want to pair now? [08:22:08] hashar: or later this week? [08:22:17] lets do it now [08:22:31] you had some questions iirc, better to have some answers right now :D [08:23:10] hashar: ok, I need 5-10 minutes to close code-in task for mayankmadan_ so he can claim another taks [08:23:21] good [08:28:45] mayankmadan_: closed the task, feel free to pick another one! [08:29:26] zeljkof, arent you going to tell me about http headers? [08:29:53] mayankmadan_: I have a meeting with hashar now so I can not type a lot [08:30:01] zeljkof, no problem [08:30:03] you should google http headers [08:30:08] and read about it [08:30:13] this, for example [08:30:13] ill ping you after couple of hours [08:30:22] https://en.wikipedia.org/wiki/List_of_HTTP_header_fields [08:31:05] mayankmadan_: you could also work on this https://www.google-melange.com/gci/task/view/google/gci2013/5888156557639680 [08:31:23] zeljkof, i was just looking at that :) [08:31:54] mayankmadan_: great [08:32:09] hashar: I will create google calendar event and invite you there [08:32:37] zeljkof: or just paste me the hangout link :) [08:32:45] hashar: that too :) [08:33:29] hashar: https://plus.google.com/hangouts/_/calendar/emZpbGlwaW5Ad2lraW1lZGlhLm9yZw.j5g8u9mls00bmsrml5eh6d6oac?authuser=1 [08:39:43] zeljkof: https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder [08:39:44] for later :D [08:41:36] zeljkof: git clone -o gerrit ssh://review.openstack.org:29418/openstack-infra/jenkins-job-builder.git [08:43:01] zeljkof: git clone ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder.git [08:48:28] zeljkof: git clone ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config.git [09:02:01] comutting to coworking plae [09:02:02] ce [09:02:04] grrm [09:02:16] commute time to co-working place. [09:16:13] zeljkof, zeljkof_ any other tasks related to tests? [09:17:36] mayankmadan__: in a meeting with Nikerabbit [09:17:51] mayankmadan__: you can create more pdf tests [09:17:57] for more complicated pages [09:18:15] that have ordered lists, unordered lists, links... [09:18:22] you can start with the task now, I [09:18:30] I will create it on melange in 2 hours or so [09:46:31] Yippee, build fixed! [09:46:32] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #165: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/165/ [09:55:56] (PS4) Hashar: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97065 (owner: Jeroen De Dauw) [09:57:16] (CR) Hashar: [C: 2] "amended commit summary to list out jobs being updated." [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97065 (owner: Jeroen De Dauw) [09:57:58] (Merged) jenkins-bot: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/97065 (owner: Jeroen De Dauw) [10:20:55] (PS1) Hashar: mediawik-core-release: run phpunit tests [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98492 [10:39:20] (PS2) Hashar: mediawik-core-release: run phpunit tests [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98492 [11:07:36] Nikerabbit: did you push the commit to gerrit? [11:09:44] zeljkof, are you busy? [11:13:13] mayankmadan__: no [11:13:21] did you start working on pdf tests? [11:13:28] yep [11:13:53] ok, great, I will create the task right now, so you can claim it [11:16:37] zeljkof: oops I think I forgot [11:17:17] it is now [11:17:31] Nikerabbit: thanks [11:28:28] mayankmadan__: I have created the task [11:28:29] https://www.google-melange.com/gci/task/view/google/gci2013/5884931574071296 [11:28:33] I will update the bug report [11:29:33] zeljkof, done [11:30:09] zeljkof, done means claimed :) [11:30:09] mayankmadan__: assigned [11:30:25] zeljkof, i had a question [11:30:55] should match /foo/ [11:31:10] it will look in the given element for the string "foo" right? [11:32:16] yes [11:33:45] zeljkof, another question [11:33:57] zeljkof, on the pad [11:34:07] I am in a another meeting, will be available in an hour [11:34:12] okay np [11:50:52] (CR) Hashar: [C: 2] "updated mediawiki-core-release" [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98492 (owner: Hashar) [11:51:09] (Abandoned) Hashar: tarball experiment [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/86160 (owner: Hashar) [11:51:46] (Merged) jenkins-bot: mediawik-core-release: run phpunit tests [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98492 (owner: Hashar) [11:52:16] (Abandoned) Hashar: tie to ruby 1.9.3 [qa/browsertests] - https://gerrit.wikimedia.org/r/85813 (owner: Hashar) [12:00:51] zeljkof, busy? [12:01:34] mayankmadan__: still in the meeting [12:01:41] 30 more minutes or so [12:01:58] ok [12:14:33] (Abandoned) Hashar: (WIP) jenkins-build-parse.py (WIP) [integration/jenkins] - https://gerrit.wikimedia.org/r/75906 (owner: Hashar) [12:26:57] zeljkof, ping me when you are free? [12:27:01] *. [12:27:12] mayankmadan__: will be in 5-10 minutes [12:33:41] (PS1) Hashar: wikimedia-wikimania-scholarships-jslint now voting [integration/zuul-config] - https://gerrit.wikimedia.org/r/98501 [12:33:49] (CR) Hashar: [C: 2] wikimedia-wikimania-scholarships-jslint now voting [integration/zuul-config] - https://gerrit.wikimedia.org/r/98501 (owner: Hashar) [12:34:06] (Merged) jenkins-bot: wikimedia-wikimania-scholarships-jslint now voting [integration/zuul-config] - https://gerrit.wikimedia.org/r/98501 (owner: Hashar) [12:39:39] mayankmadan__: I am free now [12:40:01] zeljkof, i had a question [12:40:03] on the pad [12:40:13] looking [12:40:14] in the function title_element [12:41:04] i do not see the question [12:41:07] zeljkof, now at the bottom of the pad [12:41:34] zeljkof, you told me to define title_element that way [12:41:41] ok [12:41:59] can you explain why you have wrote .div at the end of line 34 [12:42:35] I see [12:42:59] zeljkof, i dont understand the use of second .div [12:43:00] that should actually be somewhat different [12:43:16] read this page [12:43:16] https://github.com/cheezy/page-object/issues/113 [12:45:15] take a look at lines 38-41 [12:45:26] they do the same thing, but using a different API [12:45:32] you should use that api [12:45:47] in short, to explain line 34 [12:45:55] @browser points to a browser [12:46:13] div(class: "textLayer") finds a div element with that class on the page [12:46:31] and the last div finds the first div that is child div of div(class: "textLayer") [12:46:45] and lines 38-41 do the same [12:46:54] is it more clear now? [12:46:59] * zeljkof is back in 10 minutes [12:47:14] zeljkof, yes but what if i want to find another div in the parent div [12:59:21] mayankmadan__: let me see [12:59:27] do you have example page? [12:59:58] zeljkof, http://test2.wikipedia.org/w/index.php?title=Special:Book&bookcmd=download&collection_id=f635463bc9b444eb&writer=rl&return_to=0.40190231181249836 [13:00:58] mayankmadan__: link opens blank page for me [13:01:10] will create pdf page myself [13:01:21] the 1,2 and the text is in seperate div [13:01:49] wait [13:03:19] zeljkof, how about this [13:03:21] http://test2.wikipedia.org/w/index.php?title=Special:Book&bookcmd=download&collection_id=5c45128306e1ce2e&writer=rl&return_to=0.31311671804038477 [13:03:30] great, that one works [13:03:46] so, the question is how to check the first and the second line? [13:03:53] kind of [13:04:55] zeljkof, the numbers and the text are in different div's [13:05:02] *div(s) [13:11:19] (PS1) Hashar: phase out /srv/slave-scripts [integration/jenkins] - https://gerrit.wikimedia.org/r/98509 [13:11:38] (CR) Hashar: [C: 2] phase out /srv/slave-scripts [integration/jenkins] - https://gerrit.wikimedia.org/r/98509 (owner: Hashar) [13:11:42] (Merged) jenkins-bot: phase out /srv/slave-scripts [integration/jenkins] - https://gerrit.wikimedia.org/r/98509 (owner: Hashar) [13:11:51] mayankmadan__: looking [13:12:44] found it [13:13:15] found what? [13:14:54] mayankmadan__: take a look at the pad [13:14:59] does that answer your question [13:17:10] zeljkof, is there a way to include all the div(s) inside a parent [13:20:37] what do you mean? [13:21:02] zeljkof, if i do page.parent_element.div(text: "This is the second line") [13:21:18] it will only be the div that has the given text [13:21:26] ok [13:21:33] and you want any div? [13:21:42] but what if i want all the div(s) under textLayer class [13:23:12] mayankmadan__: take a look at lines 48-50 of the pad [13:23:19] does that answer your question? [13:23:35] yep [13:27:32] great [13:27:47] I have no more meetings today, so if you have questions, ping me [13:27:54] great [13:32:21] zeljkof, cant i use match method for div collection? [13:32:34] mayankmadan__: you can try :) [13:32:37] but it will fail [13:32:41] yes it did [13:32:41] what do you want to do? [13:33:11] i wanted to search for the whole list [13:33:40] (PS1) Hashar: phase out /srv/slave-scripts [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98513 [13:35:20] mayankmadan__: what do you mean? [13:35:24] (CR) Hashar: [C: 2] phase out /srv/slave-scripts [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98513 (owner: Hashar) [13:35:43] (Merged) jenkins-bot: phase out /srv/slave-scripts [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98513 (owner: Hashar) [13:35:54] zeljkof, searching for the list on pdf page using match function [13:37:11] can you upload the code that you have so far to gerrit? [13:38:55] just a second [13:48:46] (PS16) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [13:48:56] zeljkof, uploaded [13:50:05] mayankmadan__: looking [13:57:46] mayankmadan__: why are you creating an ordered list with two lines? [13:57:54] one line should be enough [13:58:06] just 1? [13:58:21] mayankmadan__: a list is a list even with just one item L) [13:58:22] :) [13:58:27] make it as simple as possible [13:59:05] you just want to check if things that are in the wiki page appear in the pdf [13:59:48] okay [14:02:28] mayankmadan__: did you have another question? [14:02:35] not yet [14:02:36] or did I answer all your questions? [14:02:38] ok, great [14:02:43] ping me when you get stuck [14:02:43] nice [14:02:48] okey dokey [14:02:55] remember that you need to make the tests as simple as possible [14:03:10] we just want to check if what we added to the page ended in the pdf [14:03:28] for this task add anything you can think of to the page, and check if it ends in the pdf [14:03:38] links, lists, images [14:03:41] ... [14:04:00] there should not be a lot of stuff to do, I would have to check [14:04:09] also headlines, different sizes [14:04:23] but after you get the code to check one thing, checking for anything is easy, right? [14:28:26] zeljkof, im done with ordered lists [14:28:35] mayankmadan__: great [14:28:48] do you know what to do next? [14:29:28] unordered list? [14:29:35] sounds good to me :) [14:40:38] (PS17) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [14:47:41] Yippee, build fixed! [14:47:42] Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox build #39: FIXED in 42 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-firefox/39/ [14:58:49] zeljkof, done with unordered lists too [14:59:03] mayankmadan__: excellent [14:59:09] you can continue with links next [14:59:19] zeljkof, what should i do next? [15:00:02] I would suggest adding a link to the page and checking if it appears in the pdf [15:00:06] sounds good? [15:00:27] zeljkof, does the link needs to change in every test? [15:00:44] mayankmadan__: no, for now you can hard-code everything [15:39:40] * zeljkof is out to lunch [15:43:01] zeljkof, links doesnt work in the pdf file [15:44:40] zeljkof, the link comes in the references [15:44:57] the test passes although because of it being in references [16:06:43] zeljkof, links doesnt work in the pdf file [16:06:44] zeljkof, the link comes in the references [16:06:44] the test passes although because of it being in references [16:07:29] mayankmadan_: :) [16:07:37] I did not really understand the problem [16:08:08] zeljkof, can you open this http://test2.wikipedia.org/w/index.php?title=Special:Book&bookcmd=download&collection_id=17491eac8713a1c0&writer=rl&return_to=0.7836022111849398 [16:08:45] yes [16:09:22] zeljkof, the string Wikipedia Text doesnt have a hyperlink [16:09:40] the link is mentioned in references. is it how it is supposed to be? [16:11:16] mayankmadan_: I have no idea :) I am not familiar with pdf feature at all [16:11:27] let's assume that this is how it should be [16:11:32] ok [16:11:50] for now just check if the link text appears at the page, and if the link url appears in references [16:11:52] makes sense? [16:12:07] its done [16:12:13] thats how i did it [16:12:25] mayankmadan_: excellent, you are reading my mind :) [16:12:32] :) [16:15:58] zeljkof: I think we probably need both Testing and QA categories. I'm sure there is a lot of overlap though, I don't think there is any harm to have both. [16:19:59] hi James_F are you back in SF now? [16:20:28] chrismcmahon: when should we use qa, when testing? [16:20:34] that is the question [16:22:04] zeljkof: I'm sure we'll use both a lot, but I'd put QA on things that have to do with development process in particular, of which testing is a part, yes? [16:22:30] chrismcmahon: Hey. Yes. [16:22:34] chrismcmahon: what I want to figure out is which set of page we should recommend to new people to read [16:22:55] I would like to have as little pages as possible tagged with a tag [16:22:59] be it qa or testing [16:23:12] but when something is tagged qa or testing, new people should read it [16:23:14] zeljkof: how about a tag "New to QA" then? [16:23:17] something like that [16:23:30] zeljkof: the more tags we have, the better [16:23:34] chrismcmahon: yes, that was another idea I had [16:23:53] qa basics, new to qa, qa getting started... [16:24:05] is there a way to show intersection of categories? [16:24:11] qa+getting started? [16:24:22] James_F: this smells like a blocker to me, wondered if you'd care to raise the importance: https://bugzilla.wikimedia.org/show_bug.cgi?id=57568 (and welcome back!) [16:24:24] I did a bit of research on that but looks like it is not possible [16:24:44] zeljkof: it should be possible with CirrusSearch [16:25:20] chrismcmahon: interesting [16:25:54] chrismcmahon: Eurgh. Fun. [16:28:08] zeljkof, now what? [16:28:16] what is left? :) [16:28:16] is it enough for this task [16:28:31] ^ [16:28:41] manybubbles: is it possible to do a boolean search for category on mw.o e.g. "category:QA or category:testing", "category:QA and category:testing", something like that? [16:28:47] can you investigate what mediawiki page can consist of? [16:29:01] mayankmadan_: ^ [16:29:13] chrismcmahon: incategory:QA is a filter [16:29:15] zeljkof, okay but is it enough for this task? :) [16:29:25] mayankmadan_: if you have covered all basic elements, then I think the task is done [16:29:32] so you can do a boolean search if by that you mean "restrict to pages in both these categories" [16:29:55] mayankmadan_: I think the scope of this task is to cover all basic elements [16:30:00] but not "incategory:QA AND NOT incategory:Blah OR (incategory:fish AND incategory:clams) [16:30:30] but that syntax (baring maybe the parenthesis) does work for normal text [16:30:44] manybubbles zeljkof "incategory:QA, testing" seems to dtrt [16:31:02] (PS18) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [16:31:16] manybubbles zeljkof at least that seems to handle the OR condition [16:31:18] (CR) jenkins-bot: [V: -1] Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [16:31:34] dtrt? [16:31:58] do the right thing [16:32:03] ah [16:32:13] huh, I doubt cirrus will do the right thing with that then [16:32:41] zeljkof im getting an error because of "�" [16:32:56] but this is how bullets are shown [16:33:01] mayankmadan_: moar details or it did not happen :) [16:33:20] mayankmadan_: I will have to go soon, please ping chrismcmahon with questions [16:33:39] brb [16:33:39] chrismcmahon: mayankmadan_ is our code-in student, he is working on his 5th task (I think) [16:34:05] zeljkof, 11th for mediawiki 5th for qa [16:34:16] zeljkof, https://dpaste.de/vvzW [16:34:26] manybubbles: if I want to point new people to pages that are both in QA and New_contributors category, is there a way to do it on mediawiki.org? [16:34:41] hi mayankmadan_ I'll be right back myself [16:34:45] zeljkof: one moment [16:34:51] mayankmadan_: please push changes to gerrit [16:34:58] mayankmadan_: so we can take a look [16:35:05] zeljkof, pushed [16:35:10] already pushed [16:35:10] mayankmadan_: great [16:35:27] zeljkof, the jenkins bot gave it a -1 [16:35:29] zeljkof: https://www.mediawiki.org/w/index.php?search=incategory%3AQA+incategory%3ANew_contributors&title=Special%3ASearch [16:35:35] mayankmadan_: great, I will have to go soon, finishing something, please ping chrismcmahonbrb [16:35:49] mayankmadan_: the jenkins bot is a fickle beast sometimes [16:35:55] manybubbles: beautiful :) [16:36:00] manybubbles: thanks [16:46:22] (CR) Zfilipin: "Chris, Jeff, please merge this into master if you do not have any complains." [selenium] - https://gerrit.wikimedia.org/r/97756 (owner: Mayankmadan) [16:46:43] (CR) Zfilipin: "Chris, Jeff, please merge this into master if you do not have any complains." [qa/browsertests] - https://gerrit.wikimedia.org/r/97849 (owner: Mayankmadan) [16:54:09] chrismcmahon, any help [16:57:53] chrismcmahon, jenkins is giving me this error https://dpaste.de/vvzW [16:58:16] because of "�" [16:58:42] but this is how unordered lists are processed [16:59:44] mayankmadan_: I think it is because of page.text_layer_element.div(text: "•") [17:00:15] yes because of the "�" in that [17:00:47] • • • • • • • • [17:01:34] ? [17:05:56] chrismcmahon, i dont get it :) [17:06:12] mayankmadan_: I'm not sure, let me try something here... [17:18:39] mayankmadan_: where is your test intended to run? [17:19:20] chrismcmahon, https://gerrit.wikimedia.org/r/98160 [17:20:43] mayankmadan_: against what test environment does this test run? [17:23:04] test environment? [17:23:20] chrismcmahon, ^ [17:25:44] mayankmadan_: what happens when you run this test? [17:26:33] it passes. it doesnt fail [17:27:20] chrismcmahon, ^ [17:27:24] mayankmadan_: and what is the URL of the host where it runs? [17:28:02] test2.wikipedia.org [17:28:45] ok [17:32:24] mayankmadan_: does it work when you run it in the Chrome browser? [17:32:35] chrismcmahon, it works in firefox [17:32:43] cause it renders the pdf page as html [17:33:46] mayankmadan_: seems this test will only work in Firefox [17:33:54] yes [17:34:07] zeljko said it was fine [17:34:27] chrismcmahon, and not just this, all the tests in the pdf.feature [17:44:47] mayankmadan_: does this make sense to you? http://stackoverflow.com/questions/1739836/invalid-multibyte-char-us-ascii-with-rails-and-ruby-1-9 [17:47:13] (PS19) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [17:47:17] chrismcmahon, how about now? [17:47:17] (CR) jenkins-bot: [V: -1] Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan) [17:47:23] aww [17:48:00] chrismcmahon, still getting the same error from jenkins [17:48:17] chrismcmahon, even after adding this # encoding: utf-8 [17:49:41] mayankmadan_: it still thinks it is not utf-8, error is 'invalid multibyte char (US-ASCII)' [17:49:55] yep [17:50:10] chrismcmahon, the link you sent had this solution [17:50:45] mayankmadan_: I know. does it change if you put the encoding line at the top of the file? [17:52:19] (PS20) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [17:52:52] chrismcmahon, well it worked this time [17:53:06] chrismcmahon, what difference does it make if it is on top of other comments? [17:54:02] mayankmadan_: the Ruby parser reads from top to bottom. I'm still not sure that's a great way to identify page elements, but at least it gets us down the road. [17:54:49] chrismcmahon, can you close the task now? [18:00:46] chrismcmahon, http://www.google-melange.com/gci/task/view/google/gci2013/5884931574071296 [18:07:37] mayankmadan_: there is still a whitespace issue, can you see the tabs at https://gerrit.wikimedia.org/r/#/c/98160/20/features/support/pages/DownloadedPDFPage.rb ? [18:12:16] chrismcmahon, will fix that in a minute [18:13:42] (PS21) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [18:13:44] chrismcmahon, how about now? [18:14:07] Yippee, build fixed! [18:14:08] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #327: FIXED in 4 min 36 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/327/ [18:33:20] chrismcmahon, how about now? [18:34:59] mayankmadan: is there some procedural reason that you need the task to be marked completed? [18:35:58] mayankmadan: there are some reasons I don't want to merge this code yet, and Zeljko didn't tell me what he had in mind for this. [18:37:16] chrismcmahon, dont merge the code, i have been working with the same gerrit review request for the previous task as well [18:37:48] chrismcmahon, and he completed the task. [18:38:12] i wanted this tasked to be marked complete just because i wanted to get on with another one [18:38:19] mayankmadan: OK [18:41:11] thanks chrismcmahon [18:41:14] :) [18:42:20] thanks mayankmadan [18:53:54] chrismcmahon, this is an easy and a quick one [18:53:55] http://www.google-melange.com/gci/task/view/google/gci2013/5848183833886720 [18:54:01] i wanted to do this [19:10:19] (PS1) Mayankmadan: Merging the readme files of other repositories with this one. [selenium] - https://gerrit.wikimedia.org/r/98577 [19:10:46] chrismcmahon, i have already added the review request for the changes in readme file of mediawiki-selenium repository [19:19:10]