[03:10:44] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #510: FAILURE in 9 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/510/ [03:40:09] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #517: FAILURE in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/517/ [03:43:15] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #496: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/496/ [04:38:47] Yippee, build fixed! [04:38:48] Project browsertests-test2.wikipedia.org-linux-chrome build #765: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/765/ [04:51:49] Yippee, build fixed! [04:51:50] Project browsertests-test2.wikipedia.org-linux-firefox build #740: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/740/ [05:03:49] Yippee, build fixed! [05:03:49] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #322: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/322/ [05:34:23] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #603: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/603/ [06:06:47] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #115: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/115/ [12:28:12] hi zeljkof [12:28:22] mayankmadan: hi [12:28:26] long time no see! :) [12:29:05] yeah :) i had on olympiad on 5th and my school exam on 6th [12:29:10] now its on 9th [12:29:35] so ill be able to work on the task in about 4hrs [12:29:40] will you be online then? [12:30:03] I should be online for the next 3-4 hours [12:30:22] so I will probably have to go when you are free :) [12:30:35] but chris and jeff should be here at that time [12:30:43] okay [15:03:38] hi zelkof [15:03:40] im back [15:03:46] you online? [15:12:18] hi mayankmadan :) [15:12:29] you are lucky I have randomly checked irc [15:12:53] you have a typo in my nick, so my irc client did not notify me [15:13:16] oops [15:13:45] so do you have some time? [15:14:13] zeljkof, ^ [15:14:19] mayankmadan: sure [15:14:23] great [15:14:29] so lets get started on the task :) [15:15:42] mayankmadan: sure [15:15:46] do you have any questions? [15:18:43] zeljkof, how do i check the browser argument in @browser [15:19:01] I do not understand the question [15:19:17] zeljkof, do i check the browser by request.env['HTTP_USER_AGENT']? [15:19:33] noooo :) [15:19:40] why? [15:20:22] because there is a better way :) [15:20:34] what? [15:23:40] zeljkof, ^ [15:26:57] ? [15:37:50] mayankmadan: sorry, had to step away for a minute [15:37:52] I am back [15:38:16] np [15:38:56] zeljkof, now whats the better way? [15:39:05] just a second [15:41:55] (PS1) Hashar: operations-puppet-pep8 no more uses submodules [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/99663 [15:42:16] (CR) Hashar: [C: 2] operations-puppet-pep8 no more uses submodules [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/99663 (owner: Hashar) [15:42:39] mayankmadan: @browser.name [15:42:43] should return browser name [15:42:51] anywere in steps file [15:43:13] (Merged) jenkins-bot: operations-puppet-pep8 no more uses submodules [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/99663 (owner: Hashar) [15:43:30] mayankmadan: do you already have some code that needs to know which browser is used? [15:43:41] if so, push it to gerrit so I can take a look [15:44:01] not yet [15:44:08] ok [15:44:15] if you get stuck, let me know [15:44:20] I will be online for an hour or so [15:44:31] zeljkof, i have to install the pdf-reader gem [15:44:35] and chrismcmahon and Jeff should be online soon too [15:44:37] how do i push it to gerrit [15:45:04] you have to add it to the gemfile [15:45:38] add a new line to gemfile [15:45:39] like this [15:45:40] https://github.com/wikimedia/qa-browsertests/blob/master/Gemfile#L6 [15:45:49] and then from command line run [15:45:51] bundle update [15:46:02] that will install the gem and update gemfile.lock [15:46:18] and you can push changed gemfile and gemfile.lock then to gerrit [15:46:21] got it? [15:46:32] gemfile.lock too? [15:46:50] lock file get's updated automatically, after running bundle update [15:46:59] and yes, push the changes from both files to gerrit [15:47:24] okay [15:48:43] ping me if you get stuck [15:48:57] okey dokey artichokey [16:12:14] zeljkof, fixed the deprecated warning error [16:12:23] mayankmadan: great [16:13:11] (PS22) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [16:13:14] uploaded to gerrit [16:17:37] zeljkof, should i just assume the file is downloaded in user's download folder? [16:18:05] mayankmadan: yes, just make it work on your machine [16:21:39] zeljkof, i was thinking instead of checking if the browser is chrome how about the test that run only runs on chrome? [16:21:49] sounds good to me! :) [16:22:02] zeljkof, any help on that? :) [16:22:13] I am in a meeting with chrismcmahon [16:22:20] oh [16:22:24] then no problem [16:22:25] just create a new feature file that will work with chrome only [16:22:31] we will merge them later [16:22:39] just make one small test that works on chrome [16:22:42] for start [16:33:51] zeljkof, is there a list of env variables that i can export? [16:34:32] JeffHall, ^ [16:35:06] mayankamadan: Yes, I believe that's in the README file - hold on a sec and I'll paste a link [16:36:40] mayankmadan: They are listed here: https://github.com/wikimedia/mediawiki-selenium [16:37:24] JeffHall, There is no list [16:37:41] but never mind [16:37:59] just found what i was looking for [16:38:19] mayankmadan: The env variables are listed in the "export" commands in that README file - just scroll through the page and you'll see them all [16:41:45] JeffHall, shouldnt this work if i put it in the steps file? ENV["BROWSER_LABEL"]="chrome" [16:43:21] mayankmadan: No, I don't believe that will work - the "ENV" syntax just allows you to read the value of an environment variable [16:43:33] okay [16:43:53] mayankmadan: Are you editing a steps definition file? [16:43:59] yep [16:44:03] pdf_steps.rb [16:44:26] JeffHall, checked out from https://gerrit.wikimedia.org/r/#/c/98160/ [16:44:39] trying to implement the tests for chrome [16:45:20] mayankmadan: There is probably a more elegant way to do it, but as a quick solution you can simply issue a system "export" command from your steps definition Ruby file [16:46:01] how? [16:46:36] mayankmadan: The syntax is simply: system('xxxxxxx') [16:46:45] oh [16:46:58] mayankmadan: Where your shell command is inserted in place of the xxxxxx [16:47:15] got it [16:53:01] JeffHall, shouldnt system("export BROWSER_LABEL=chrome") work? [16:54:38] mayankmadan: Yes, your syntax looks correct to me, but now I think on it, I believe the browser choice is being set higher up in the stack (before your steps definition file is run) [16:54:51] mayankmadan: Probably in env.rb - let me look.... [16:58:50] mayankmadan: I have to go now, JeffHall and chrismcmahon can help you with anything :) [16:59:05] mayankmadan: Yeah, the browser selection is being set at the level of the mediawiki-selenium Rubygem, so the choice is already made before your steps definition file is run [16:59:50] mayankmadan: Can you just export the BROWSER_LABEL at the system level in the usual way for now, and we can add a tag later indicating that your test only works for Chrome? [17:00:25] okay [17:04:49] Project UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-phantomjs build #1: FAILURE in 31 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-en.wikipedia.beta.wmflabs.org-linux-phantomjs/1/ [17:11:08] JeffHall, any ideas why i cannot use chrome browser in tests? [17:11:15] the scenario fails if i use chrome [17:11:27] it doesnt give any errors, just says that it failed [17:11:35] mayankmadan: Do you have the chromedriver installed on your machine? [17:11:47] :) [17:11:49] forgot that [17:12:08] mayankmadan: http://code.google.com/p/selenium/wiki/ChromeDriver [17:13:38] JeffHall, it wont work with chromium, will it? [17:14:38] mayankmadan: I have never tried using Chromium myself, so I'm not sure (maybe someone else on this channel will know the answer...) [17:48:01] JeffHall, do i need to restart my computer after installing chromedriver [17:48:39] mayankmadan: No, but make sure that it is in your PATH (try the 'which chromedriver' command) [17:49:02] JeffHall, it outputs nothing [17:49:17] i copied the chromedriver to /usr/bin [17:49:47] and btw i have installed google chrome too [17:50:09] mayankmadan: Yeah, so chromedriver is not in your PATH - you can export that environment variable value manually or add an equivalent command to your shell profile file [17:54:50] JeffHall, finally i got it working [17:55:02] mayankmadan: Great! [18:06:11] Yippee, build fixed! [18:06:11] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #511: FIXED in 3 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/511/ [18:06:29] Yippee, build fixed! [18:06:30] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #469: FIXED in 4 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/469/ [18:10:38] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #335: FAILURE in 4 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/335/ [18:24:21] JeffHall, Im lagging behind in the task listin gci :( [18:25:15] mayankmadan: I believe we can extend the task deadline - let me check on that real quick [18:25:54] i need to complete this task as quickly as possible [18:26:10] Thomas Lam has already done 10 and i am on just 12 [18:26:31] mayankmadan: We can extend the deadline for the task if you want - just let me know if you want me to do that [18:27:22] JeffHall, i cant install gem open url [18:27:45] Yippee, build fixed! [18:27:46] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #497: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/497/ [18:28:44] mayankmadan: Is it the "open-uri" gem you're trying to install? That's part of the Ruby core, so you don't have to install it separately [18:29:28] JeffHall, http://rubygems.org/gems/openurl [18:31:04] mayankmadan: Hmmm… I can install that gem without a problem - what errors are you getting? [18:31:26] JeffHall, Could not find gem 'open-url (>= 0) x86-mingw32' in the gems available on this [18:31:26] machine. [18:32:03] mayankmadan: Do you have a Windows machine? [18:32:08] nope [18:32:16] ubuntu 13.04 [18:32:37] JeffHall, ^ [18:32:37] mayankmadan: What command are you using to try and install the gem? [18:33:25] JeffHall, i wrote gem 'open-url' in GemFile and ran bundle update [18:34:04] Try it without the dash: gem 'openurl' [18:34:25] mayankmadan: ^ [18:49:46] JeffHall, A little help? [18:49:52] if you are free [18:50:11] mayankmadan: Sure, I'm here [18:51:04] JeffHall, are you familiar with pdf-reader gem? [18:51:33] mayankmadan: No, I have not used that specific gem before [18:52:00] JeffHall, but still can you try to explain to me how it works? :) [18:52:59] mayankmadan: Sure, I can take a look at the documentation. Are you having a specific problem with it? [18:53:21] JeffHall, I just dont get how to extract page elements using it [18:55:15] mayankmadan: I assume you're trying to use the walk() method in that gem? [18:55:33] JeffHall, why wont file = open(@browser.url) work in pdf_steps.rb? [18:56:10] mayankmadan: I'll have to grab that code from Gerrit - give me a few minutes [18:56:16] wait [18:56:22] JeffHall, i havent pushed it yet [18:57:17] mayankmadan: OK, let me know when you push the code [18:58:32] (PS23) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [18:58:36] JeffHall, pushed [18:58:45] https://gerrit.wikimedia.org/r/98160 [18:58:56] mayankmadan: OK, thanks. I'll take a look [19:12:39] JeffHall, what does walk method do? [19:13:06] JeffHall, and why do i have to require 'open-uri' and 'pdf-reader' to make them work? [19:15:01] mayankmadan: Now that I'm looking at your test, I don't think you will need to use the walk() method - wasn't sure what the test was supposed to do before I looked at the code! [19:15:47] mayankmadan: 'open-uri' and 'pdf-reader' would just be used to grab the PDF document and verify that it is in fact a PDF (and not some other file format) [19:16:04] JeffHall, but why do i need to require the open-uri and pdf-reader in the pdf_steps.rb to make them work? [19:16:12] to use methods from them? [19:18:23] mayankmadan: Yes, exactly, when you require those gems, you then have access to their methods [19:25:59] mayankmadan: I think if you add the following two lines to env.rb, you should be in business: [19:26:15] require 'open-uri' [19:26:16] require 'pdf-reader' [19:26:44] mayankmadan: That at least gets the file grabbing and PDF reading working for me locally [19:34:58] JeffHall, I am able to get the text of page by text method [19:44:34] (PS1) Hashar: drop labels hasPhpUnit & hasPhpcs (unneeded now) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/99712 [19:45:00] (CR) Hashar: [C: 2] drop labels hasPhpUnit & hasPhpcs (unneeded now) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/99712 (owner: Hashar) [19:45:22] (Merged) jenkins-bot: drop labels hasPhpUnit & hasPhpcs (unneeded now) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/99712 (owner: Hashar) [19:49:38] JeffHall_lunch, The test is working perfectly :) [20:03:39] (CR) Hashar: "Some bits can be enhanced (see inline diff)." (2 comments) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/98275 (owner: Merlijn van Deen) [20:11:11] mayankmadan: Great! [20:24:20] JeffHall, im getting this error while running git review [20:24:21] https://dpaste.de/nBYk [20:26:16] mayankmadan: Can you try the "git rebase --continue" command? [20:28:43] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #323: FAILURE in 45 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/323/ [20:29:51] (PS24) Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 [20:30:02] JeffHall, finally [20:30:12] is the task considered complete? [20:30:55] mayankmadan: Just give me a few minutes to check the updated code, and then I think we can consider the task complete :) [20:31:03] great [20:40:34] mayankmadan: Can you mark the Google Code-in task "ready for review"? http://www.google-melange.com/gci/task/view/google/gci2013/5799508969521152 [20:40:40] oh yeah [20:41:09] JeffHall, marked complete [20:42:41] mayankmadan: Great! The test is returning some minor errors on this end, but it looks great overall! I'll mark the task complete. Thanks for all of your hard work on this! [20:43:27] JeffHall, what are the errors [20:43:36] and ofcourse thanks for working with me [20:43:45] and cooperating with me [20:44:59] mayankmadan: Here are the errors I got just from a quick run, they may be issues with my local environment (haven't had time to verify that): [20:45:07] mayankmadan: https://dpaste.de/Yo48 [20:50:12] JeffHall, wanted to work on this http://www.google-melange.com/gci/task/view/google/gci2013/5837412055908352 [20:51:01] mayankmadan: OK, I can assign that task to you [20:51:30] JeffHall, and is this task even valid anymore cause in the bug report Tomislav Plavcic says that these tests will be abandoned [20:52:35] mayankmadan: Hmmm…. not sure. Let me check on that [20:55:22] mayankmadan: It should be a valid task - the issue with the expanding/collapsing sidebar sections has been resolved at en.wikipedia.beta.wmflabs.org [20:55:34] okay [20:58:32] JeffHall, is there a particular file which has test for this page or do i need to create a new one? [21:00:01] mayankmadan: Probably best to create a new feature file, since I don't believe there's one already [21:01:05] JeffHall, should this be for test2 or beta.wmflabs? [21:01:57] mayankmadan: As far as I know, those sidebar features should be testable in both of those environments [21:02:57] JeffHall, Its totally different [21:03:29] in test2, print/export is already expanded whereas in beta.wmflabs its not [21:03:52] mayankmadan: OK, well just focus on en.wikipedia.beta.wmflabs.org for now [21:03:59] ok [21:25:29] JeffHall, How do i make sure if an element does not exist? [21:25:37] is there something like should !exist ? [21:27:04] mayankmadan: I assume you're talking about RSpec matchers in a step definitions file? [21:27:15] JeffHall, maybe :) [21:28:59] mayankmadan: There's some good documentation on RSpec matcher syntax here: https://www.relishapp.com/rspec/rspec-expectations/v/2-14/docs/built-in-matchers/be-matchers [21:30:25] mayankmadan: So you probably want something like " page.