[03:24:00] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #525: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/525/
[03:26:37] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #504: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/504/
[04:41:23] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #330: FAILURE in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/330/
[07:18:21] <wmf-selenium-bot>	 Yippee, build fixed!
[07:18:22] <wmf-selenium-bot>	 Project VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #205: FIXED in 48 min: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/205/
[09:28:16] <Nikerabbit>	 hi zeljkof
[09:30:11] <zeljkof>	 hi Nikerabbit
[09:30:17] <zeljkof>	 I am in a meeting with Amir
[09:30:29] <Nikerabbit>	 zeljkof: are you going to merge the uls phantomjs commit?
[09:30:41] <zeljkof>	 Nikerabbit: not yet
[09:31:00] <Nikerabbit>	 zeljkof: just fixed sandbox and updated it to new code, should make many of the tests pass
[09:31:39] <zeljkof>	 for some reason this is not working
[09:31:40] <zeljkof>	 https://wmf.ci.cloudbees.com/view/free-style/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs/
[09:33:29] <grrrit-wm>	 (CR) Zfilipin: [C: -1] "Do not merge until this is green:" [qa/browsertests] - https://gerrit.wikimedia.org/r/100382 (owner: Zfilipin)
[09:33:45] <grrrit-wm>	 (CR) Zfilipin: [C: -1] "Do not merge until this is green:" [selenium] - https://gerrit.wikimedia.org/r/100381 (owner: Zfilipin)
[09:42:50] <Nikerabbit>	 zeljkof: it looks like the setting does not get saved, hard to say whether it is bug in uls for in the test
[09:43:16] <zeljkof>	 Nikerabbit: which setting?
[09:44:03] <Nikerabbit>	 zeljkof: input method setting
[09:44:07] <Nikerabbit>	 zeljkof: font setting does get saved
[09:44:17] <zeljkof>	 Nikerabbit: I have no clue what you are talking about :)
[09:44:23] <zeljkof>	 a commit?
[09:45:19] <Nikerabbit>	 zeljkof: the test you linked
[09:45:24] <wmf-selenium-bot>	 Yippee, build fixed!
[09:45:25] <wmf-selenium-bot>	 Project UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #102: FIXED in 1 min 25 sec: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/102/
[09:45:48] <zeljkof>	 Nikerabbit: the problem there is that tests are running at sauce, and not using phantomjs?
[09:45:56] <zeljkof>	 where did you see an error with fonts?
[09:46:15] <zeljkof>	 this is one error
[09:46:15] <zeljkof>	 https://wmf.ci.cloudbees.com/view/free-style/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs/lastCompletedBuild/testReport/(root)/Font%20selection/Font_selector_appears/
[09:46:23] <zeljkof>	 and the error message is
[09:46:24] <zeljkof>	 Unable to pick a platform for the provided browser (RuntimeError)
[09:46:52] <Nikerabbit>	 maybe I was looking at something else
[09:47:00] <zeljkof>	 Nikerabbit: could be
[09:47:36] <Nikerabbit>	 zeljkof: yeah sorry, was looking at the firefox version
[09:47:58] <zeljkof>	 Nikerabbit: yes, that one should be pretty much green
[10:10:06] <Nikerabbit>	 https://saucelabs.com/jobs/09801d149f634aaebb13874b074dc169 why is the  browser not going to full screen size?
[10:23:33] <aharoni>	 zeljkof: hi, i'm back
[10:23:51] <zeljkof>	 ok, will get to the hangout in a minute
[10:23:55] <Nikerabbit>	 sigh
[10:24:10] <zeljkof>	 Nikerabbit: what's up? :)
[10:24:14] <Nikerabbit>	 of course there must be on test failing in every job
[10:24:20] <Nikerabbit>	 https://wmf.ci.cloudbees.com/view/r-tr/job/Translate-sandbox.translatewiki.net-linux-firefox/
[10:24:28] <Nikerabbit>	 https://wmf.ci.cloudbees.com/view/r-tw/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/
[10:24:40] <zeljkof>	 flaky tests! fun! :)
[10:25:18] <Nikerabbit>	 going to do other stuff now, feel free to have a look at those or whatever you are planning to do, sandbox should work properly now for tests
[10:43:01] <Nikerabbit>	 465
[10:49:36] <aharoni>	 Nikerabbit: hi.
[10:49:47] <aharoni>	 should the sandbox tests run on sandbox or on dev?
[10:56:18] <Nikerabbit>	 aharoni: never on dev
[11:04:40] <grrrit-wm>	 (CR) Zfilipin: [C: -1] "There is still one deprecation warning left." [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan)
[11:13:54] <grrrit-wm>	 (CR) Zfilipin: Added a test for downloading pdf from a random page (5 comments) [qa/browsertests] - https://gerrit.wikimedia.org/r/98160 (owner: Mayankmadan)
[15:12:23] <grrrit-wm>	 (Abandoned) Zfilipin: Released gem version 0.1.14 [selenium] - https://gerrit.wikimedia.org/r/100381 (owner: Zfilipin)
[15:12:44] <grrrit-wm>	 (Abandoned) Zfilipin: Updated Ruby gems [qa/browsertests] - https://gerrit.wikimedia.org/r/100382 (owner: Zfilipin)
[15:13:56] <grrrit-wm>	 (PS2) Zfilipin: Make it possible to run tests on Cloudbees using PhantomJS [selenium] - https://gerrit.wikimedia.org/r/100375
[15:44:15] <chrismcmahon>	 another IE test fails because login is flaky.  I'll fix that in the browsertests right now, actually
[16:01:27] <grrrit-wm>	 (PS1) Cmcmahon: interim update until login method is shared among repos [qa/browsertests] - https://gerrit.wikimedia.org/r/100579
[16:02:41] <grrrit-wm>	 (CR) Cmcmahon: "I made this change to the Mobile repo some time ago and it did improve the situation with false failures due to login failing" [qa/browsertests] - https://gerrit.wikimedia.org/r/100579 (owner: Cmcmahon)
[16:22:20] <grrrit-wm>	 (CR) Jhall: [C: 1] interim update until login method is shared among repos [qa/browsertests] - https://gerrit.wikimedia.org/r/100579 (owner: Cmcmahon)
[16:29:17] <grrrit-wm>	 (PS1) Hashar: mwconf: $wg settings for djvu [integration/jenkins] - https://gerrit.wikimedia.org/r/100582
[16:29:27] <grrrit-wm>	 (CR) Hashar: [C: 2] mwconf: $wg settings for djvu [integration/jenkins] - https://gerrit.wikimedia.org/r/100582 (owner: Hashar)
[16:29:30] <grrrit-wm>	 (Merged) jenkins-bot: mwconf: $wg settings for djvu [integration/jenkins] - https://gerrit.wikimedia.org/r/100582 (owner: Hashar)
[16:39:51] <grrrit-wm>	 (PS1) Hashar: mwconf: wgDjvuToXml -> wgDjvuToXML [integration/jenkins] - https://gerrit.wikimedia.org/r/100583
[16:39:59] <grrrit-wm>	 (CR) Hashar: [C: 2] mwconf: wgDjvuToXml -> wgDjvuToXML [integration/jenkins] - https://gerrit.wikimedia.org/r/100583 (owner: Hashar)
[16:40:02] <grrrit-wm>	 (Merged) jenkins-bot: mwconf: wgDjvuToXml -> wgDjvuToXML [integration/jenkins] - https://gerrit.wikimedia.org/r/100583 (owner: Hashar)
[16:43:56] <grrrit-wm>	 (PS1) Cmcmahon: preference no longer exists per Bug 52809 [qa/browsertests] - https://gerrit.wikimedia.org/r/100584
[16:57:38] <chrismcmahon>	 JeffHall: you have +2 rights on the repo here, yes?  https://gerrit.wikimedia.org/r/#/c/100579/ https://gerrit.wikimedia.org/r/#/c/100584/  You can go ahead and merge stuff if it looks reasonable to you.  I'd like to merge those two in the next hour for the daily builds.
[16:58:27] <JeffHall>	 chrismcmahon: Sure, I can do the +2.  Is there an additional step for the merge itself?  I don't believe I've actually done a merge before
[16:58:45] <chrismcmahon>	 JeffHall: oh, that's right.
[16:59:32] <chrismcmahon>	  JeffHall in gerrit when you click Review you need to add the +2 under Code-review and not under Verified
[17:00:00] <chrismcmahon>	 JeffHall:  once the +2 is in gerrit then the Jenkins bot picks it up and merges it
[17:00:31] <JeffHall>	 chrismcmahon: OK, will do that now
[17:00:49] <chrismcmahon>	 JeffHall:  awesome thanks
[17:01:25] <grrrit-wm>	 (CR) Jhall: [C: 2] preference no longer exists per Bug 52809 [qa/browsertests] - https://gerrit.wikimedia.org/r/100584 (owner: Cmcmahon)
[17:02:55] <grrrit-wm>	 (Merged) jenkins-bot: preference no longer exists per Bug 52809 [qa/browsertests] - https://gerrit.wikimedia.org/r/100584 (owner: Cmcmahon)
[17:06:16] <grrrit-wm>	 (CR) Jhall: [C: 2] interim update until login method is shared among repos [qa/browsertests] - https://gerrit.wikimedia.org/r/100579 (owner: Cmcmahon)
[17:06:20] <grrrit-wm>	 (PS2) Cmcmahon: interim update until login method is shared among repos [qa/browsertests] - https://gerrit.wikimedia.org/r/100579
[17:08:35] <grrrit-wm>	 (CR) Jhall: [C: 2] interim update until login method is shared among repos [qa/browsertests] - https://gerrit.wikimedia.org/r/100579 (owner: Cmcmahon)
[17:09:55] <grrrit-wm>	 (Merged) jenkins-bot: interim update until login method is shared among repos [qa/browsertests] - https://gerrit.wikimedia.org/r/100579 (owner: Cmcmahon)
[17:31:45] <vandrew_>	 zeljkof: yes
[17:31:54] <zeljkof>	 vandrew_: great :)
[17:32:04] <zeljkof>	 this channel is more focused on testing
[17:32:09] <zeljkof>	 and has less traffic
[17:32:26] <zeljkof>	 and you can find Tobi_WMDE, chrismcmahon and JeffHall here (other code-in mentors)
[17:32:44] <zeljkof>	 (we started to chat in #wikimedia-dev, but it is pretty busy)
[17:32:49] <vandrew_>	 that's good
[17:33:49] <vandrew_>	 zeljkof: where should I put the *_spec.rb ?
[17:34:12] <zeljkof>	 do you see where the rest of the _spec.rb files are? :)
[17:34:42] <vandrew_>	 step definition
[17:34:43] <zeljkof>	 oh, wait, what _spec.rb files?
[17:35:05] <zeljkof>	 ok, in short, please push the code you have so far to gerrit, what ever you have
[17:35:14] <zeljkof>	 it will be easier to ask and answer questions there
[17:35:17] <vandrew_>	 ok
[17:36:58] <zeljkof>	 vandrew_: do not forget to add all four of us mentors as reviewers to the commit, once it is in gerrit
[17:37:08] <zeljkof>	 vandrew_: let me know if you do not know how to do that
[17:41:19] <vandrew_>	 zeljkof: https://gerrit.wikimedia.org/r/#/c/100591/
[17:42:51] <zeljkof>	 vandrew_: looking
[17:45:42] <zeljkof>	 vandrew_: I left a couple of comments
[17:45:56] <zeljkof>	 please do not take my -1 review personally, it is about code, not you :)
[17:46:32] <zeljkof>	 vandrew_: are you familiar with cucumber?
[17:49:18] <vandrew_>	 zeljkof: not too familiar, but I test the behavior on this page http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page
[17:49:41] <zeljkof>	 vandrew_: do you know how to run a feature file?
[17:50:35] <vandrew_>	 zeljkof: using gem
[17:51:00] <zeljkof>	 :)
[17:51:35] <zeljkof>	 Tobi_WMDE, chrismcmahon, JeffHall: can one of you help vandrew_ ? I am about to leave (it is almost 7pm here)
[17:52:05] <Tobi_WMDE>	 zeljkof: I can look into it tomorrow
[17:52:16] <Tobi_WMDE>	 about to leave as well & we're having deployment
[17:53:03] <JeffHall>	 zeljkof, vandrew_ sure I can try to help out, although I have a meeting starting in a few minutes, but should be around most of the day after that
[17:53:20] <zeljkof>	 JeffHall: great, thanks
[17:54:36] <JeffHall>	 vandrew_: If you have any questions, let me know and I'll respond as quickly as I can :)
[17:54:56] <vandrew_>	 JeffHall: sure thing
[17:55:23] <chrismcmahon>	 vandrew_: neither JeffHall nor I are very familiar with the wikidata tests, but we'll do what we can.
[17:55:46] <zeljkof>	 chrismcmahon, JeffHall: the task is to convert existing rspec tests to cucumber
[17:56:03] <zeljkof>	 it should be easy to do, since the code is already there
[17:57:55] <vandrew_>	 chrismcmahon: where do I implement the definition steps ?
[18:03:35] <chrismcmahon>	 vandrew_:  you might take a look at an example like this:  https://gerrit.wikimedia.org/r/#/c/99260/
[18:04:05] <vandrew_>	 chrismcmahon: that is more than I could've asked for, thanks
[18:05:31] <chrismcmahon>	 vandrew_: that is a test that I wrote recently that I think is simple enough to make a good example, but powerful enough to also be a good test
[18:05:55] <chrismcmahon>	 vandrew_: if you see anything there that does not make sense, feel free to ask in the channel here
[18:07:17] <vandrew_>	 chrismcmahon: flow_steps.rb most of the code if from the old test yes ?
[18:09:27] <chrismcmahon>	 vandrew_: probably so.   the idea is that the /step_definitions/*_steps.rb file has all of the actions, while the /support/pages/*_page.rb file defines all of the elements that the actions will use
[18:10:10] <chrismcmahon>	 vandrew_: and you will want to read about page_object if you have not already https://github.com/cheezy/page-object/wiki/Elements
[18:10:38] <chrismcmahon>	 https://github.com/cheezy/page-object/wiki
[18:13:22] <grrrit-wm>	 (PS3) Zfilipin: WIP Make it possible to run tests on Cloudbees using PhantomJS [selenium] - https://gerrit.wikimedia.org/r/100375
[18:14:35] <grrrit-wm>	 (PS4) Zfilipin: WIP Make it possible to run tests on Cloudbees using PhantomJS [selenium] - https://gerrit.wikimedia.org/r/100375
[18:17:38] <vandrew_>	 chrismcmahon: can I create .feature code from the *_spec.rb ?
[18:18:44] <wmf-selenium-bot>	 Yippee, build fixed!
[18:18:44] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #454: FIXED in 4 min 44 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/454/
[18:19:47] <chrismcmahon>	 vandrew_:  I think so, the .feature file should contain the Given/When/Then statements that Cucumber needs
[18:23:32] <zeljkof>	 vandrew_: you should probably take a look at this: http://filipin.eu/browser-automation-workshop/
[18:36:29] <wmf-selenium-bot>	 Yippee, build fixed!
[18:36:29] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #505: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/505/
[18:45:27] <vandrew_>	 chrismcmahon: I saw in that video that they are using rubyminer, should I use it too ?
[18:50:28] <JeffHall>	 vandrew_: Many of us do use RubyMine, and you can download a 30-day trial version from http://www.jetbrains.com/ruby/download/index.html
[18:51:00] <JeffHall>	 vandrew_: RubyMine is not required, but it does have some nice features for working with Cucumber tests
[18:56:32] <vandrew_>	 JeffHall: how does the old tests help me if the *_spec.rb file code is generated by the .feature file which I have to write ?
[18:58:00] <JeffHall>	 vandrew_: When you first run a new feature file (with no matching steps file), Cucumber will tell you what steps need to be created, and it will give you some stub code to get started
[18:58:41] <JeffHall>	 vandrew_: Looking at the existing feature and steps files for browser tests can give you can idea of the correct syntax, etc
[18:59:09] <vandrew_>	 JeffHall: can I match the feature file with the old *_spec.rb file ?
[18:59:54] <JeffHall>	 vandraw_: I will have to look at that a bit more - what is the Bugzilla ticket number that you are working on?
[19:00:21] <vandrew_>	 here https://bugzilla.wikimedia.org/show_bug.cgi?id=57844
[19:08:29] <JeffHall>	 vandrew_: Yes, it seems that you should be able to take the "steps" from an existing *_spec.rb file, move those into Gherkin syntax in a new *.feature file, then run Cucumber against that feature file to generate the stub code for the steps file
[19:12:18] <vandrew_>	 JeffHall: I should be able to do this in RubyMine yep?
[19:12:59] <JeffHall>	 vandrew_: Yes, you can use either a regular old text editor, but RubyMine will probably be an easier way to go :)
[21:18:32] <wmf-selenium-bot>	 Yippee, build fixed!
[21:18:33] <wmf-selenium-bot>	 Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #113: FIXED in 3 min 9 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/113/
[21:32:54] <wmf-selenium-bot>	 Yippee, build fixed!
[21:32:54] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #125: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/125/
[22:28:41] <grrrit-wm>	 (PS1) Cmcmahon: login still failing occasionally in IEs [qa/browsertests] - https://gerrit.wikimedia.org/r/100694
[22:30:54] <grrrit-wm>	 (CR) Cmcmahon: "for example: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/340/testReport/juni" [qa/browsertests] - https://gerrit.wikimedia.org/r/100694 (owner: Cmcmahon)
[23:10:45] <grrrit-wm>	 (PS1) Krinkle: Make mwext-Scribunto-jslint voting [integration/zuul-config] - https://gerrit.wikimedia.org/r/100712
[23:11:41] <grrrit-wm>	 (CR) Krinkle: [C: 1] Make mwext-Scribunto-jslint voting [integration/zuul-config] - https://gerrit.wikimedia.org/r/100712 (owner: Krinkle)
[23:14:04] <grrrit-wm>	 (CR) Krinkle: [C: -1] "Don't merge before I283fda1409b1e76db." [integration/zuul-config] - https://gerrit.wikimedia.org/r/100712 (owner: Krinkle)