[00:03:04] Yippee, build fixed! [00:03:05] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #527: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/527/ [00:23:56] (CR) Jhall: [C: 2] login still failing occasionally in IEs [qa/browsertests] - https://gerrit.wikimedia.org/r/100694 (owner: Cmcmahon) [00:25:15] (Merged) jenkins-bot: login still failing occasionally in IEs [qa/browsertests] - https://gerrit.wikimedia.org/r/100694 (owner: Cmcmahon) [00:26:25] JeffHall: thanks for the +2, I hope it helps. I think the login button changed a little while ago, it has a slight animation now when the cursor touches it that I think is throwing off the click() [00:27:15] chrismcmahon: Yeah, I couldn't verify that change locally with Internet Explorer itself, but it makes sense to me [03:46:20] Yippee, build fixed! [03:46:20] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #341: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/341/ [04:54:44] Yippee, build fixed! [04:54:45] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #332: FIXED in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/332/ [05:49:54] Project Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-10 build #32: FAILURE in 6 min 37 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-10/32/ [06:10:26] Project Flow-en.wikipedia.beta.wmflabs.org-linux-firefox build #114: FAILURE in 5 min 42 sec: https://wmf.ci.cloudbees.com/job/Flow-en.wikipedia.beta.wmflabs.org-linux-firefox/114/ [06:23:25] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome build #126: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/126/ [09:01:33] zeljkof: morning [09:01:51] Nikerabbit: moog? mooge? :) [09:02:51] zeljkof: uga? [09:21:07] (CR) Zfilipin: [C: 2] Add Translate-meta.wikimedia.org-linux-firefox [selenium] - https://gerrit.wikimedia.org/r/99054 (owner: Nikerabbit) [09:21:09] (Merged) jenkins-bot: Add Translate-meta.wikimedia.org-linux-firefox [selenium] - https://gerrit.wikimedia.org/r/99054 (owner: Nikerabbit) [10:05:45] Project UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #186: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/186/ [10:13:29] Yippee, build fixed! [10:13:30] Project TwnMainPage-sandbox.translatewiki.net-linux-firefox build #115: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/TwnMainPage-sandbox.translatewiki.net-linux-firefox/115/ [14:30:19] (PS1) Siebrand: Enable voting phpcs-strict-HEAD for LocalisationUpdate [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100785 [14:30:25] (CR) jenkins-bot: [V: -1] Enable voting phpcs-strict-HEAD for LocalisationUpdate [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100785 (owner: Siebrand) [14:32:15] (CR) Siebrand: "Am I missing something? Please let me know what else needs doing." [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100785 (owner: Siebrand) [14:32:45] zeljkof: I got this error when using cucumber [14:32:49] /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- minitest/unit (LoadError) [14:33:00] vandrew: hi! :) [14:33:09] did you upload the file that causes the error to gerrit? [14:36:59] zeljkof: I used cucumber on an already made .feature file, should I set up anything specific for it to work ? [14:37:21] I used gem install sinatra and gem install cucumber [14:37:30] vandrew: [14:37:54] vandrew: ok, let's use this pad for colaboration: http://etherpad.wikimedia.org/p/vandrew [14:38:13] you can just type there, no registration needed, but keep in mind that the pad is public [14:38:27] can you paste the output of your command line to the pad? [14:39:21] yes [14:39:27] hi zeljkof [14:39:40] Nikerabbit: could you please merge this? https://gerrit.wikimedia.org/r/#/c/100384/ [14:39:56] hi mayankmadan! :) long time no see [14:40:07] zeljkof, been superbusy in exams [14:40:18] mayankmadan: got good grades? :) [14:40:37] zeljkof, mostly good except chem :) [14:40:54] mayankmadan: great :) [14:40:54] im here just for today :) for completing the task that i have claimed [14:41:04] mayankmadan: great, one more time [14:41:11] zeljkof: I'm learning the basic functions of cucumber [14:41:12] then i will return on 16th dec [14:41:18] I've paste the code I am working on [14:41:29] mayankmadan: there is also a few commits that you need to do to finish old tasks, did you see my comments in gerrit? [14:41:45] vandrew: excellent [14:41:48] zeljkof, i will now [14:42:20] mayankmadan: great, I should be online for a few more hours, so feel free to ask if you have questions [14:42:28] okey doke [14:42:52] vandrew: ok, what is the problem with the feature? [14:43:28] (PS5) Zfilipin: WIP Make it possible to run tests on Cloudbees using PhantomJS [selenium] - https://gerrit.wikimedia.org/r/100375 [14:43:44] when I use cucumber *.feature in terminal I get the follwoing errors, which I'll past thee [14:44:09] (CR) Zfilipin: "The first job on cloudbees: https://wmf.ci.cloudbees.com/view/fs/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.o" [selenium] - https://gerrit.wikimedia.org/r/100375 (owner: Zfilipin) [14:44:44] zeljkof, how does the wait_until() function worK? [14:45:06] mayankmadan: see this page http://watirwebdriver.com/waiting/ [14:46:37] vandrew: ok, did you follow these instructions? https://www.mediawiki.org/wiki/Browser_testing/Setup_instructions [14:47:02] vandrew: are you on mac or linux? [14:47:13] linux [14:47:18] vandrew: ubuntu? [14:47:26] fedora [14:47:43] did you do this?* https://www.mediawiki.org/wiki/Browser_testing/Setup_instructions#Ruby_on_Linux [14:48:16] zeljkof: yes, I have installed ruby [14:48:41] but should I use gem update --system in the folder I am working or something ? [14:54:38] vandrew: yes [14:54:45] you should follow _all_ instructions :) [14:54:58] did you install ruby via rvm? or via yum? [14:55:34] yum [14:55:48] zeljkof, is there a way to make the test wait for about 5 seconds? [14:55:50] vandrew: and what did the instructions say? :) [14:56:01] vandrew: but ruby via yum should be fine [14:56:27] vandrew: does gem update --system work then? (that is optional anyway) [14:57:02] vandrew: more important is the next lines, gem install bundler, and then bundle install [14:57:07] vandrew: did you do those? [14:57:18] vandrew: that two lines will install all required ruby software [14:57:28] gem update --system gives some errors [14:57:31] mayankmadan: yes, but why exactly 5? [14:57:41] vandrew: ok, that is optional, just skip it [14:57:50] vandrew: but make sure to run the next two commands [14:58:06] vandrew: you might need to add sudo in front, since you have installed ruby via yum? [14:58:07] zeljkof, not exactly 5 :) [14:58:30] mayankmadan: what are you trying to do? code or it did not happen :) [14:58:30] never mind [14:58:39] i can use wait until [14:58:53] mayankmadan: yes, that is the better way [15:00:19] vandrew: feel free to paste any error messages to the pad, if you get stuck [15:00:46] zeljkof: I've posted the error I got when using gem install bundler [15:01:02] bundler seems to have installed [15:02:03] vandrew: can you paste terminal output? [15:02:37] vandrew: what did you do to get that error message? [15:03:01] sudo gem install bundler [15:03:37] I've used gem install json_pure and I'll see if it works [15:04:37] vandrew: you might need ruby dev tools [15:04:41] vandrew: something similar to https://github.com/watir/watirbook/blob/master/installation/ubuntu.md#selenium-webdriver [15:09:20] zeljkof, is there a prob with syntax here? http://etherpad.wikimedia.org/p/mayankmadan [15:09:55] zeljkof: I got it work, with the gem install json_pure [15:09:59] working* [15:10:18] vandrew: great, but bundle install should do the job :/ [15:10:25] mayankmadan_: looking... [15:11:26] mayankmadan_: but line 1 makes no sense :) [15:11:37] zeljkof, why? [15:11:56] i have to use wait_while_present for an item to disappear [15:11:59] if you are waiting until something is present (visible+enabled), and then you say it should not be visible [15:12:24] mayankmadan_: I see [15:12:31] mayankmadan_: then my code is wrong, let me check [15:12:40] zeljkof, this is from watirwebdriver.com/waiting [15:12:41] object.wait_while_present:; where you just wait until something disappears [15:13:11] zeljkof, it says wait_while_present is used to wait until something disappears [15:13:13] mayankmadan_: yes, that is it, then your code is good [15:13:22] mayankmadan_: is there a problem? [15:13:24] but it doesnt work [15:13:39] mayankmadan_: error message(s) or it did not happen! :) [15:13:40] zeljkof, undefined method `visible?' for nil:NilClass (NoMethodError) [15:13:45] :) [15:14:04] mayankmadan_: got it [15:14:10] so, the problem is that this code [15:14:19] on(RandomPage).community_portal_element.wait_while_present [15:14:29] returns nil [15:14:36] not to get into a lot of detail, nil is nothing [15:15:01] and then you call method "visible?" on nil (nothing) and ruby complains [15:15:07] will post an idea to the pad [15:16:13] mayankmadan_: try it :) [15:16:22] zeljkof, buy how? [15:16:32] how will it work? [15:16:57] it will work, since the first line just waits that the element disappears, but it returns nil so we can not chain another method call to the end of it [15:17:19] zeljkof, yes [15:17:28] just saw line 6 [15:17:42] i skipped it when i first read it [15:17:43] the second line actually creates a new object, and the object knows how to handle method called visible? [15:17:59] mayankmadan_: you have learned a new trick today [15:18:05] yep [15:18:06] thanks [15:18:19] vandrew: stuff works now? or are you still stuck? [15:18:53] zeljkof: when I use bundle install it says Bundler::GemfileNotFound [15:19:31] vandrew: looks like bundler is not installed :( [15:19:36] can you install rvm? [15:19:40] zeljkof: but cucumber is working [15:20:07] vandrew: ok, if stuff works now, then you do not have to install rvm [15:20:19] zeljkof, looks like wait_while_present is deprecated [15:20:24] any other alternative [15:20:32] mayankmadan_: nooooooo :) [15:20:46] mayankmadan_: post the error message, and I will explain [15:22:54] zeljkof, its on the pad [15:23:20] mayankmadan_: ok, time for another short lesson :) [15:25:15] zeljkof, im back [15:25:53] mayankmadan: ok, another short lesson [15:26:08] wait_* methods are part of watir api [15:26:20] and deprecation warning you got is from page-object gem [15:26:37] not to get into a lot of detail, but there is a simple way to get rid of the warning [15:26:45] actually, two ways [15:27:14] #1 page.some_element.element.wait_* [15:27:33] (you have to add ".element" before ".wait_*") [15:27:42] #2 use page-object waiting API! :) [15:27:43] ok [15:27:51] #whats 2nd [15:27:59] https://github.com/cheezy/page-object/wiki/Ajax-Calls [15:28:23] you get to pick, I have no preference, except I prefer not to see deprecation warnings :) [15:28:38] mayankmadan: questions? [15:31:14] zeljkof: ok now that everything is set up I am working on the delete_item.feature [15:31:33] vandrew: great, ping me if you have any questions, I should be online for a few more hours [15:31:34] not really [15:32:14] vandrew, mayankmadan: if you have questions, and I am not around, Tobi_WMDE is probably still around, and chris and jeff should arrive soon [15:32:25] zeljkof: can I make from the old *_spec.rb files .feature one ? [15:32:27] okey doke [15:32:33] so I can edit the feature pages if problems arrive ? [15:32:56] vandrew: I did not understand the question? [15:33:18] you can do anything you want, push the code to gerrit and we will let you know if you got it wrong [15:33:33] and you can also post code snippets to the pad, so I can answer here [15:33:38] ok [15:34:00] vandrew: it is hard for me to talk about code without having code samples in front of me :) [15:34:16] vandrew: so, "show me the code or it did not happen" :) [15:35:28] zeljkof, how about i upload changes to older review request on gerrit after doing the current task? [15:35:41] zeljkof: here should something like that work ? [15:37:11] mayankmadan: I am fine with any order of events, as far as everything is eventually completed :) [15:37:19] okay [15:37:22] vandrew: the code in the pad looks fine [15:37:27] zeljkof: I also see that when I run the .feature file I get the steps yes ? [15:37:40] can I do the reverse ? run the old step file and get a feature file ? [15:37:54] but you do not need a background if there is only one scenario in the feature file [15:38:21] vandrew: yes, when you run the feature file you get the skeleton steps [15:38:36] vandrew: and no, you can not run the step files and get the feature file :) [15:38:48] vandrew: additionally, what you have is spec file, not step file [15:39:29] current tests are written in rspec (http://rspec.info/) and your task is to move the tests to cucumber (http://cukes.info/) [15:39:39] rspec and cucumber and two related, but separate tools [15:39:48] vandrew: did I answer the question? [15:39:52] yes [15:40:19] vandrew: great [15:40:27] take a look at the pad, I made a suggestion [15:40:32] zeljkof: and one last thing regarding the code, I'll post it on the pad [15:40:38] vandrew: sure [15:41:15] vandrew: did you watch this video? http://filipin.eu/browser-automation-workshop/ [15:41:35] vandrew: ok, I see the question [15:41:52] and I see the confusion [15:42:08] so, cucumber feature files are a communication tool [15:42:18] yes I saw that video [15:42:28] it took me some time [15:42:37] only almost plain english goes there [15:42:40] (into feature files) [15:42:48] all the code goes to step files [15:42:57] vandrew: does that answer the question? [15:43:23] so I can use just plain english ? [15:43:28] vandrew: if you are stuck, and you can do screen sharing, we can pair for 30-60 minutes, so I can get you introduced [15:43:51] vandrew: yes, in feature files (take a look at existing ones) you use something similar to plain english [15:43:57] but it is structured [15:44:06] still reads like normal english, but follows some rules [15:44:57] vandrew: do you know what to do next? or are you stuck? [15:46:06] zeljkof: I'm a little confused, should I write: And item UI is not empty ? [15:46:20] vandrew: sounds good to me! :) [15:46:40] zeljkof: I'll finish the delete_item and share the code with you [15:46:46] so, feature file explains what needs to happen, you do not have to think about implementation there [15:46:56] vandrew: sounds like a plan [15:56:00] zeljkof: done, what do you think ? [15:56:56] vandrew: let me see... the code is in gerrit? [15:57:04] or in the pad? [15:57:07] pad [15:57:14] ok, looking [15:57:56] vandrew: the feature file looks good to me! (will comment a couple of minor things there) [15:58:33] now I got the step definiton code [15:58:50] vandrew: ok, generated by cucumber? [15:58:54] zeljkof: yes [15:58:58] do you know where to paste it? [15:59:09] in step_definition folder [15:59:36] vandrew: do you know how to name the folder? [15:59:45] err, how to name the file [16:00:11] yep, delete_item_steps.rb [16:00:17] vandrew: excellen [16:00:19] excellent [16:00:35] let me know if you get stuck implementing the steps [16:02:18] JeffHall, chrismcmahon: could you please take a look at this and merge it if you have no complaints? https://gerrit.wikimedia.org/r/#/c/100384/ [16:02:29] Nikerabbit ^ [16:02:31] hi zeljkof [16:02:34] looking [16:02:39] chrismcmahon: great, thanks [16:02:57] zeljkof: OK, will do [16:03:06] JeffHall: thanks! [16:03:58] zeljkof: that should do it, merged [16:04:16] chrismcmahon: thanks! let me test it right now [16:04:23] zeljkof: just btw, I updated the gems for MobileFrontend the other day to use chunky_png [16:04:51] chrismcmahon: saw that, I think I have merged it (or it was merged already, not sure) [16:05:12] chrismcmahon, JeffHall: take a look at these two jobs [16:05:13] https://wmf.ci.cloudbees.com/view/fs/ [16:05:19] both of them run the same tests [16:05:37] one of them using firefox on sauce, the other one phantomjs on cloudbees [16:05:42] the other one is twice as fast [16:06:47] zeljkof: Excellent! This is a great direction to be moving in, since at least on the Visual Editor team, devs are also using PhantomJS for some of their testing [16:07:15] JeffHall: phantomjs is limited, but really useful, we should at least do some testing with it [16:07:29] zeljkof, the task is done, just need to upload the patch to gerrit [16:07:40] mayankmadan: great! :) [16:07:47] ping me when I need to review it [16:11:48] (PS1) Mayankmadan: Adding tests for collapsing and expanding sidebar sections [qa/browsertests] - https://gerrit.wikimedia.org/r/100795 [16:11:51] zeljkof, done, uploaded to gerrit [16:12:06] mayankmadan: great, looking [16:17:35] zeljkof: I added the _steps.rb content to the pad [16:17:54] vandrew: just a minute, reviewing code that mayankmadan pushed to gerrit [16:20:22] (CR) Zfilipin: [C: -1] "please see inline comments" (2 comments) [qa/browsertests] - https://gerrit.wikimedia.org/r/100795 (owner: Mayankmadan) [16:20:59] mayankmadan: I left a couple of comments, let me know if you have any questions, you did really good job so far! :) (only a couple of things to do are left) [16:21:03] vandrew: looking [16:21:24] ahhhhhh Could not find profile: 'ciwmf' [16:21:26] I am doomed :D [16:21:34] hashar: where is that? [16:21:39] VisualEditor :-] [16:21:48] I am working on a job that install MediaWiki + VE + Parsoid daemon [16:21:52] and run the cucumber tests against it [16:21:55] hashar: I promise to move config folder to the gem soon(tm) [16:22:02] takes 2:30 minutes just to setup everything hehe [16:22:12] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=56085 [16:22:18] na it is ok, just have to send the profile [16:28:50] vandrew: what do you get when you run the feature file now? [16:29:05] I can guess, but I want to see how you report it :) [16:29:12] zeljkof, languages section is not present on every page [16:29:23] should i do it just for main page? [16:29:31] zeljkof: check the pad [16:36:35] looking... [16:37:04] mayankmadan: can you send me link to the page/pages where it does not appear? [16:37:20] mayankmadan: and yes, feel free to use main page instead of random page then [16:37:41] vandrew: ok, so cucumber does not see that you have implemented the steps? [16:38:04] zeljkof: I think so [16:38:07] can you post the entire output, including the command that caused the output? [16:38:14] zeljkof, those random pages which are moved or doesnt have text [16:38:17] vandrew: did you save the file? :) [16:38:25] i am going to use main page [16:38:28] zeljkof: yes [16:38:52] mayankmadan: yes, then use the main page for all tests, or just language one, as you like [16:39:10] zeljkof, just for the language one will be better [16:39:26] mayankmadan: agreed [16:39:55] vandrew: I do not understand the output, you get all that when you run "cucumber delete_item.feature"? [16:40:04] zeljkof: yes [16:40:24] can you post output of this: pwd [16:41:01] yes [16:41:08] vandrew: got it :) [16:41:17] you have to be in tests/browser [16:41:24] not tests/browser/features [16:41:29] so just: cd .. [16:41:33] and run cucumber again [16:41:41] and use bundle install on this page [16:41:42] yes ? [16:41:47] zeljkof: https://integration.wikimedia.org/ci/job/visualeditor-doitall/12/console [16:41:56] first ever run of browser tests with VE / Parsoid [16:42:01] which are going to fail :-D [16:42:23] vandrew: if I understood you, yes, bundle install should be run from tests/browser too [16:42:45] hashar: progress! :) [16:42:58] yeah I need to inject some more configuration [16:44:04] zeljkof: all okay? [16:44:07] vandrew: cucumber works now? [16:44:17] zeljkof: still installing some things [16:44:21] Nikerabbit: phantomjs is still messing with me :( [16:44:26] (PS1) Hashar: make browsertest runner a macro [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100798 [16:44:32] (CR) jenkins-bot: [V: -1] make browsertest runner a macro [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100798 (owner: Hashar) [16:44:33] I'll ping you when it is done [16:44:39] vandrew: great [16:44:56] Nikerabbit: https://wmf.ci.cloudbees.com/job/free-style-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-phantomjs/23/console [16:45:04] Nikerabbit: which: no phantomjs in ... [16:45:09] Nikerabbit: grrrrr.... [16:47:53] zeljkof, isnt there a given i am at main page? [16:48:02] or shall i define it? [16:48:15] i couldnt get rubymine working so cant check [16:48:15] mayankmadan: it should already be there [16:48:32] mayankmadan: you should contact rubymine support, they will know what to do [16:48:45] mayankmadan: you should grep the repo, the step should be there [16:48:51] search for MainPage [16:49:06] bah 10 minutes :( [16:49:06] 00:10:18.901 Finished: FAILURE [16:50:14] zeljkof, There is no step [16:50:31] mayankmadan: create it then, we need it anyway [16:50:36] okay [16:50:50] hashar: did you see speed improvement? https://wmf.ci.cloudbees.com/view/fs/ [16:50:54] zeljkof: I have posted the output I got [16:50:59] in the pad [16:51:07] hashar: the same tests in firefox+sauce and phantomjs+cloudbees [16:51:31] hashar: sauce 16 minutes, phantomjs 8 minutes [16:51:37] vandrew: looking [16:52:23] eh, Flow is messing with me today. Se is not finding some elements [16:52:25] vandrew: what do you get for this: bundle [16:52:39] vandrew: or: which bundle [16:53:17] added the output [16:53:34] vandrew: ok, now run the tests like this [16:54:18] vandrew: bundle exec cucumber features/feature_name.feature [16:54:30] (and replace feature_name.feature with the actual file name) [16:54:39] ok [16:54:46] vandrew: paste the output to the pad [16:55:01] zeljkof: yeah phantomjs has little overhead compared to firefox/sauce [16:55:27] zeljkof: if we used a matrix job, the phantomjs could be a touchstone build, aka if it fails, the other browsers are not triggered at all [16:55:45] hashar: exactly [16:55:58] hashar: and we could even run it in parallel, making it even faster [16:56:12] yup [16:56:16] done [16:56:18] gotta finish up Parsoid/Ve test first hehe [16:56:53] (PS1) Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100800 [16:56:57] (CR) jenkins-bot: [V: -1] (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100800 (owner: Hashar) [16:57:03] vandrew: hm, strange error message, let me run the tests on my machine [16:57:17] vandrew: can you push the code you have so far to gerrit, so I could grab it and run locally? [16:57:56] zeljkof: yep, just a second [17:01:03] zeljkof: done https://gerrit.wikimedia.org/r/#/c/100591/ I think I forgot to add git add . and it doesn't show the steps file [17:01:26] vandrew: do you know how to amend the commit? [17:01:31] vandrew: steps file is really not there [17:02:35] git commit -a --amend [17:02:38] git review -R [17:02:53] vandrew: yes, please then add the steps file and push it to gerrit [17:06:07] zeljkof, im having a problem with languages section [17:06:22] mayankmadan: what is the problem? [17:06:57] zeljkof, i have pasted the code on the pad [17:07:45] it says that the simple English element doesnt disappear even after 30 sec [17:07:45] mayankmadan: what is the problem? deprecation warning? [17:07:54] but it clearly is not visisble [17:07:58] *visible [17:08:10] zeljkof, ^^^ [17:08:16] mayankmadan: the error message does not say that [17:08:26] are you sure you have pasted the correct error message? [17:08:29] (PS2) Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100800 [17:08:36] zeljkof, its not the error message [17:08:45] its the code on the sidebar_steps.rb [17:08:53] (CR) jenkins-bot: [V: -1] (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100800 (owner: Hashar) [17:09:06] zeljkof, now i have pasted the error [17:09:59] mayankmadan: can you push the code to gerrit, so I can try it on my machine?* [17:10:55] zeljkof: this time worked [17:11:09] vandrew: problem solved itself! :) perfect [17:11:19] vandrew: ping me if you get stuck [17:11:39] zeljkof: oh now, I was speakin about the commit [17:12:04] vandrew: I see :) looking at the code [17:12:06] (PS2) Mayankmadan: Adding tests for collapsing and expanding sidebar sections [qa/browsertests] - https://gerrit.wikimedia.org/r/100795 [17:12:14] zeljkof, pushed [17:12:36] mayankmadan: just a second, looking at code that vandrew pushed [17:14:04] zeljkof: but there isn't any config.yml in /confi it is config.yml.sample [17:14:22] (PS3) Hashar: (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100800 [17:14:26] (CR) jenkins-bot: [V: -1] (WIP) (WIP) visualeditor-doitall (WIP) (WIP) [integration/jenkins-job-builder-config] - https://gerrit.wikimedia.org/r/100800 (owner: Hashar) [17:14:47] out for today *wave* [17:15:19] vandrew: you have solved the problem! :) [17:15:32] you have to copy the config.yml.sample file and rename it to config.yml [17:15:40] that is the solution, thanks for the reminder [17:15:55] vandrew: let me know if you get any further errors [17:15:59] mayankmadan: looking [17:24:58] mayankmadan: the problem is that there are two elements with text simple english on the page :) [17:25:26] but there is only one element with _title_ simple english :) [17:25:32] do you know how to make the change? [17:25:37] no :) [17:26:46] a(:simple_english, title: "Simple English") [17:26:51] oh [17:26:56] (CR) Zfilipin: Adding tests for collapsing and expanding sidebar sections (1 comment) [qa/browsertests] - https://gerrit.wikimedia.org/r/100795 (owner: Mayankmadan) [17:27:06]